[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443512132 Thanks @hellonico !! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443467638 @hellonico I was able to change the base in the PR, but I think you will need to rebase your commits against master to make it all clean :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443467475 @hellonico - Can you change the PR to be against master ? Right now it against 1.3.0 - thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443444577 I kicked off the Jenkins CI again - when it passes this is good to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443387755 Thanks @hellonico so much for your contribution! I'll take a closer look tomorrow. Don't worry about the failure on the Travis side, there have been some issues with it lately. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
