[GitHub] haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for Avg Pooling

2018-07-01 Thread GitBox 
haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for 
Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#issuecomment-401637354
 
 
   `test_2d_pooling('max')` the test is failing at max pooling, which does not 
even hit my code paths.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for Avg Pooling

2018-06-16 Thread GitBox 
haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for 
Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#issuecomment-397850554
 
 
   @TaoLv All previous tests were still performed even with those changes. If I 
do separate the tests, wouldn't it be a bit confusing if the tests for 
```count_include_pad=True``` and ```count_include_pad=False``` are in 2 
different unit tests?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for Avg Pooling

2018-06-12 Thread GitBox 
haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for 
Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#issuecomment-396691275
 
 
   @piiswrong Is this PR good to be merged?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for Avg Pooling

2018-06-05 Thread GitBox 
haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for 
Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#issuecomment-394867817
 
 
   @szha


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for Avg Pooling

2018-06-05 Thread GitBox 
haojin2 commented on issue #11021: [MXNET-380] count_include_pad argument for 
Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#issuecomment-394866016
 
 
   @piiswrong Addressed all the reviews so far, please take another look when 
you’ve got time, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services