[GitHub] iblis17 commented on issue #9677: Refactor operators and add MKLDNN
iblis17 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-368280425 @marcoabreu About the reason of hosting Julia code in another repository, Julia's package manager is built on top of git, and it requires some specific structure in the cloned dir. For example, we have `MXNet.jl`, we cloned it as `MXNet` and it should have following dir structure: ``` MXNet/ # the pkg name |- src/ ||- MXNet.jl # this file is the pkg entry point, should be named as same as pkg name ||- other.jl ... etc |- test/ ||- runtests.jl # test cases entry point ``` Since git cannot checkout a subdir as svn does, the only choice is to put Julia binding as a single repo. > and thus not part of our PR validation chain? I tried to ping developer several times on both GitHub and Slack, but did not get progress. See: - https://github.com/apache/incubator-mxnet/pull/8727 - https://github.com/apache/incubator-mxnet/pull/8175 I finished the patch already, but I do not have any permission to trigger new Jenkins script via PR (https://github.com/apache/incubator-mxnet/pull/8175#issuecomment-336340005). I beg for help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iblis17 commented on issue #9677: Refactor operators and add MKLDNN
iblis17 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-368280425 @marcoabreu About the reason of hosting Julia code in another repository, Julia's package manager is built on top of git, and it requires some specific structure in the cloned dir. For example, we have `MXNet.jl`, we cloned it as `MXNet` and it should have following dir structure: ``` MXNet/ # the pkg name |- src/ ||- MXNet.jl # this file is the pkg entry point, should named as same as pkg name ||- other.jl ... etc |- test/ ||- runtests.jl # test cases entry point ``` Since git cannot checkout a subdir as svn does, the only choice is to put Julia binding as a single repo. > and thus not part of our PR validation chain? I tried to ping developer several times on both GitHub and Slack, but did not get progress. See: - https://github.com/apache/incubator-mxnet/pull/8727 - https://github.com/apache/incubator-mxnet/pull/8175 I finished the patch already, but I do not have any permission to trigger new Jenkins script via PR (https://github.com/apache/incubator-mxnet/pull/8175#issuecomment-336340005). I beg for help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iblis17 commented on issue #9677: Refactor operators and add MKLDNN
iblis17 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-368280425 @marcoabreu About the reason of hosting Julia code in another repository, Julia's package manager is built on top of git, and it requires some specific structure in the cloned dir. For example, we have `MXNet.jl`, we cloned it as `MXNet` and it should have following dir structure: ``` MXNet/ # the pkg name |- src/ ||- MXNet.jl # this file is the pkg entry point, should named as same as pkg name ||- other.jl ... etc |- test/ ||- runtests.jl # test cases entry point ``` Due to git cannot checkout a subdir as svn does, the only choice is to put Julia binding as a single repo. > and thus not part of our PR validation chain? I tried to ping developer several times on both GitHub and Slack, but did not get progress. See: - https://github.com/apache/incubator-mxnet/pull/8727 - https://github.com/apache/incubator-mxnet/pull/8175 I finished the patch already, but I do not have any permission to trigger new Jenkins script via PR (https://github.com/apache/incubator-mxnet/pull/8175#issuecomment-336340005). I beg for help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iblis17 commented on issue #9677: Refactor operators and add MKLDNN
iblis17 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-368280425 @marcoabreu About the reason of hosting Julia code in another repository, Julia's package manager is built on top of git, and it requires some specific structure in the cloned dir. For example, we have `MXNet.jl`, we cloned it as `MXNet` and it should have following dir structure: ``` MXNet/ # the pkg name |- src/ ||- MXNet.jl # this file is the pkg entry point, should named as same as pkg name ||- other.jl ... etc |- test/ ||- runtests.jl # test cases entry point ``` Due the git cannot checkout a subdir as svn does, the only choice is to put Julia binding as a single repo. > and thus not part of our PR validation chain? I tried to ping developer several times on both GitHub and Slack, but did not get progress. See: - https://github.com/apache/incubator-mxnet/pull/8727 - https://github.com/apache/incubator-mxnet/pull/8175 I finished the patch already, but I do not have any permission to trigger new Jenkins script via PR (https://github.com/apache/incubator-mxnet/pull/8175#issuecomment-336340005). I beg for help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iblis17 commented on issue #9677: Refactor operators and add MKLDNN
iblis17 commented on issue #9677: Refactor operators and add MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-368242469
I built the python one.
```python
In [6]: mx.sym.Convolution(attr={'a': 42})
```
and got similar error message.
This PR prevent user from attaching arbirary attr dictionary.
Is this change intended?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] iblis17 commented on issue #9677: Refactor operators and add MKLDNN
iblis17 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-368241751 I did bisect. This patch caused MXNet.jl testing failure. (Ref https://travis-ci.org/dmlc/MXNet.jl/jobs/345129890#L1486) The failed case here: https://github.com/dmlc/MXNet.jl/blob/4038704f1f8bd733bc2aab5205068dddbbf122a2/test/unittest/symbolic-node.jl#L140 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
