[GitHub] marcoabreu commented on a change in pull request #10075: Fix CMake build issue with MKL.

2018-03-12 Thread GitBox 
marcoabreu commented on a change in pull request #10075: Fix CMake build issue 
with MKL.
URL: https://github.com/apache/incubator-mxnet/pull/10075#discussion_r173946287
 
 

 ##
 File path: ci/docker/runtime_functions.sh
 ##
 @@ -278,8 +278,6 @@ build_ubuntu_gpu_cmake() {
 cmake \
 -DUSE_CUDA=1   \
 -DUSE_CUDNN=1  \
--DUSE_MKLML_MKL=0  \
--DUSE_MKLDNN=0 \
 
 Review comment:
   This case is handled by build_ubuntu_gpu_cmake_mkldnn. The idea here is to 
create a variety of environments and different build configurations. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcoabreu commented on a change in pull request #10075: Fix CMake build issue with MKL.

2018-03-12 Thread GitBox 
marcoabreu commented on a change in pull request #10075: Fix CMake build issue 
with MKL.
URL: https://github.com/apache/incubator-mxnet/pull/10075#discussion_r173887637
 
 

 ##
 File path: ci/docker/runtime_functions.sh
 ##
 @@ -278,8 +278,6 @@ build_ubuntu_gpu_cmake() {
 cmake \
 -DUSE_CUDA=1   \
 -DUSE_CUDNN=1  \
--DUSE_MKLML_MKL=0  \
--DUSE_MKLDNN=0 \
 
 Review comment:
   I think this one was to explicitely test without MKLDNN.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services