[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3
marcoabreu commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r174286591 ## File path: tests/ci_build/deploy/ci_deploy_doc.sh ## @@ -0,0 +1,35 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# +# Execute command outside a docker container +# +# Usage: ci_deploy_doc.sh +# +# PR_ID: the PR number +# +# BUILD_ID: the current build ID for the specified PR +# + +# TODO szha@: installation of awscli here should be removed once slave hosts have them during Review comment: This is already implemented in the test environment and just waits for redeployment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3
marcoabreu commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r172245084 ## File path: tests/ci_build/deploy/aws ## @@ -0,0 +1,29 @@ +#!/usr/bin/env python Review comment: This file has no type (.py) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3
marcoabreu commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r171434356 ## File path: tests/ci_build/deploy/ci_deploy_doc.sh ## @@ -0,0 +1,30 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# +# Execute command within a docker container Review comment: "outside a docker container". AWS CLI is not available in docker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3
marcoabreu commented on a change in pull request #9928: host doc on s3
URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r171426098
##
File path: Jenkinsfile
##
@@ -692,6 +692,7 @@ try {
init_git()
sh "make clean"
sh "make docs"
+sh tests/ci_build/deploy/ci_deploy_doc.sh ${env.BRANCH_NAME}
${env.CHANGE_ID}
Review comment:
Add quotation marks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3
marcoabreu commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r171382625 ## File path: tests/ci_build/deploy/ci_deploy_doc.sh ## @@ -0,0 +1,30 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# +# Execute command within a docker container +# +# Usage: ci_deploy_doc.sh +# +# PR_ID: the PR number +# +# BUILD_ID: the current build ID for the specified PR +# +aws s3 sync --delete docs/_build/html/ s3://mxnet-ci-doc/$1/$2 --acl public-read \ Review comment: "acl public-read". Could a PR modify this flag in order to enable public-write? Could be problematic. Would it rather be possible to set permissions on a bucket-level that bubble down to every object? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
