[GitHub] marcoabreu commented on issue #13702: Add maven wrapper to scala project.

2019-01-24 Thread GitBox
marcoabreu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-457428060
 
 
   We had it in the past and were asked to remove it.
   
   If there is an alternative to a binary file - which is the case according to 
your link - I'm also in favour to not have them checked in at all as otherwise 
users will have to manually download them and we have to manually remove them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #13702: Add maven wrapper to scala project.

2019-01-24 Thread GitBox
marcoabreu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-457425770
 
 
   Open LEGAL ticket: https://issues.apache.org/jira/browse/LEGAL-288


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #13702: Add maven wrapper to scala project.

2019-01-24 Thread GitBox
marcoabreu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-457425651
 
 
   Original source: 
https://lists.apache.org/thread.html/2bf07a377cac35d4940f0fbf7f647f46a38d2845e5dbb3c650f367d7@%3Cgeneral.incubator.apache.org%3E


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #13702: Add maven wrapper to scala project.

2019-01-24 Thread GitBox
marcoabreu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-457425427
 
 
   Ah, that's an excellent alternative then :)
   
   There you go: 
https://lists.apache.org/thread.html/d409819b554745937103b60d36ad3f5b2b1300fe8ae826fb0e665f7f@%3Cdev.mxnet.apache.org%3E


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #13702: Add maven wrapper to scala project.

2019-01-24 Thread GitBox
marcoabreu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-457334457
 
 
   Thanks @lanking520 , that's a great idea. We have been advised by out 
mentors in the past to specifically remove the maven wrapper binary, but it 
might be good to bring it up again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #13702: Add maven wrapper to scala project.

2018-12-21 Thread GitBox
marcoabreu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-449388751
 
 
   I don't understand how that link is relevant. The Apache release guidelines 
forbid binaries in source releases


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services