[GitHub] marcoabreu commented on issue #9841: Update versions of python dependencies
marcoabreu commented on issue #9841: Update versions of python dependencies URL: https://github.com/apache/incubator-mxnet/pull/9841#issuecomment-377386670 LGTM, but it has to be rebased and modified in order to match the new directory layout This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9841: Update versions of python dependencies
marcoabreu commented on issue #9841: Update versions of python dependencies URL: https://github.com/apache/incubator-mxnet/pull/9841#issuecomment-369089102 LGTM. I have retriggered CI This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9841: Update versions of python dependencies
marcoabreu commented on issue #9841: Update versions of python dependencies URL: https://github.com/apache/incubator-mxnet/pull/9841#issuecomment-367424552 Yes, it would be good to have the same version in CI as in setup.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9841: Update versions of python dependencies
marcoabreu commented on issue #9841: Update versions of python dependencies URL: https://github.com/apache/incubator-mxnet/pull/9841#issuecomment-367249633 Sheng, as far as I am aware, we're not using python/setup.py in CI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9841: Update versions of python dependencies
marcoabreu commented on issue #9841: Update versions of python dependencies URL: https://github.com/apache/incubator-mxnet/pull/9841#issuecomment-367249328 Please also pin the same versions in https://github.com/apache/incubator-mxnet/blob/master/tests/ci_build/install/ubuntu_install_python.sh#L29 to provide a consistent behaviour. It seems like this problem slipped through because we are testing on the latest numpy version but expecting users to install a different one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
