[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-369555038 Thanks a lot everybody! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367872237 Would it be possible to create a test that introduces a delay or uses a for-loop in order to force this race condition? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367872237 Would it be possible to create a test that introduces a delay in order to force this race condition? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367866215 I'm afraid I still don't really understand. I see that you have re-enabled this test, but unfortunately I'm lacking deep technical knowledge of the underlying operations, so would you mind explaining me how this re-enabled test would have caught this failure? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367865250 We don't need fixed seeds since #9791 has been merged. Just make sure that the with_seed decorator is properly applied. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367850610 But would this re-enabled test have caught this error? Please explain how we're preventing this problem from reoccurring. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services