[GitHub] marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer
marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#issuecomment-368543664 Ah, TemporaryFile actually returns you a filehandle. That's why open fails - the file is already opened and the handled is stored in tmp. Please don't forget the with-statement. See https://stackoverflow.com/a/23212515/2393787 for details This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer
marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#issuecomment-368542312 Please see https://stackoverflow.com/a/15590253/2393787 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer
marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#issuecomment-368543664 Ah, TemporaryFile actually returns you a filehandle. That's why open fails - the file is already opened and the handled is stored in tmp. Please don't forget the with-statement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer
marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#issuecomment-368542312 Please see https://stackoverflow.com/a/15590253/2393787 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer
marcoabreu commented on issue #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#issuecomment-368487451 Thanks a lot for addressing my comments in such a timely manner! One minor change and then we're good to go :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #9883: added function for loading content of nd_array files
marcoabreu commented on issue #9883: added function for loading content of nd_array files URL: https://github.com/apache/incubator-mxnet/pull/9883#issuecomment-368341672 Exactly, usually we test the C Backend in python. I'm not familiar with the Cpp package, but maybe that could be another place to test your modifications. In the end there has to be some type of Interface that exposes this function to the interfaces, right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
