[GitHub] nehaljwani commented on issue #9273: Enhancements to the build mechanism

2018-01-02 Thread GitBox
nehaljwani commented on issue #9273: Enhancements to the build mechanism
URL: https://github.com/apache/incubator-mxnet/pull/9273#issuecomment-354845606
 
 
   Why would it break the build for people using mklml? I have just added an 
extra check to see if USE_MKLML is true or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nehaljwani commented on issue #9273: Enhancements to the build mechanism

2018-01-01 Thread GitBox
nehaljwani commented on issue #9273: Enhancements to the build mechanism
URL: https://github.com/apache/incubator-mxnet/pull/9273#issuecomment-354709583
 
 
   @szha I had checked out 1.0.0 and tried building mxnet with the following:
   ```
   export MKLROOT=""
   make -j${CPU_COUNT} \
 AR="$AR" \
 CC="$CC" \
 CXX="$CXX" \
 USE_CUDA=0 \
 USE_CUDNN=0 \
 USE_OPENCV=1 \
 USE_LAPACK=1 \
 USE_BLAS=mkl \
 USE_STATIC_MKL=NONE \
 USE_INTEL_PATH=NONE \
 USE_MKL2017=1 \
 USE_PROFILER=1 \
 USE_CPP_PACKAGE=1 \
 USE_SIGNAL_HANDLER=1 \
 ADD_CFLAGS="$CFLAGS" \
 ADD_LDFLAGS="$LDFLAGS" \
 USE_OPENMP=1 \
 USE_JEMALLOC=1 \
 VERBOSE=1
   ```
   
   - The if block in the `Makefile` for `USE_MKL2017` assumed that I was using 
`MKL_ML` and added `MKL_ML` specific linker flags, which failed at the linking 
stage.
   - Since I used `MKLROOT` instead of `HOME_MKL`, the if block in 
prepare_mkl.sh passed an empty argument to `mkdir`
   - I wanted to use a more recent version (5.0.1) of `JEMALLOC` than what my 
system package manager provided,  but the Makefile didn't allow me to do so. It 
only attempts a specific list of locations.
   - I was using a cross compiler which shipped it's own ar utility, which I 
wanted to use, rather than the one installed in the system.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services