[GitHub] pengzhao-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-11 Thread GitBox
pengzhao-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP 
Test
URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-380624774
 
 
   ping @nihui


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pengzhao-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-03 Thread GitBox
pengzhao-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP 
Test
URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-378445769
 
 
   @marcoabreu @cjolivier01  @zheng-da I think the conclusion (based on 
@xinyu-intel 's analysis) is latest MKL-DNN fixed the problem but the GPU 
results of `exe1` are not correct.  Could anyone look into GPU side?
   
   @marcoabreu Regarding MKL-DNN, there's release version we can use. But the 
MXNET development progress is very fast so more new features (or bugfix) are 
needed. Thus, I think it's OK to select the master branch (based on a commit 
id). Each CI in MKL-DNN is fully verified and tested.
   https://github.com/intel/mkl-dnn/releases
   
   BTW, as we see enabling all test cases would be a great practice to improve 
the quality.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pengzhao-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-02 Thread GitBox
pengzhao-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP 
Test
URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-378090765
 
 
   @zheng-da will double check. The tests in python2/3 MKLDNN-CPU passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services