[GitHub] sxjscience commented on a change in pull request #8779: [Image] add random lighting
sxjscience commented on a change in pull request #8779: [Image] add random lighting URL: https://github.com/apache/incubator-mxnet/pull/8779#discussion_r152695670 ## File path: python/mxnet/gluon/data/vision/transforms.py ## @@ -151,3 +151,23 @@ def __init__(self, max_brightness=0, max_contrast=0, max_saturation=0, max_hue=0 def hybrid_forward(self, F, x): return F.image.random_color_jitter(x, *self._args) + + +class AdjustLighting(HybridBlock): +def __init__(self, alpha_rgb=(0.0, 0.0, 0.0), eigval=(55.46, 4.794, 1.148), Review comment: It's (alpha_r, alpha_g, alpha_b) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sxjscience commented on a change in pull request #8779: [Image] add random lighting
sxjscience commented on a change in pull request #8779: [Image] add random lighting URL: https://github.com/apache/incubator-mxnet/pull/8779#discussion_r152695298 ## File path: python/mxnet/gluon/data/vision/transforms.py ## @@ -151,3 +151,23 @@ def __init__(self, max_brightness=0, max_contrast=0, max_saturation=0, max_hue=0 def hybrid_forward(self, F, x): return F.image.random_color_jitter(x, *self._args) + + +class AdjustLighting(HybridBlock): Review comment: OK. Then I will directly call the operator in the testing code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
