[mynewt-site] branch asf-site updated (3ac9775 -> 8c35b5d)
This is an automated email from the ASF dual-hosted git repository. aditi pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git. from 3ac9775 Merge pull request #303 from runtime-bot/asf-site add 22c30e6 asf-site update Tue Aug 15 01:39:49 UTC 2017 new 8c35b5d Merge pull request #305 from runtime-bot/asf-site The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: events/index.html| 38 ++ latest/events/index.html | 38 ++ latest/sitemap.xml | 32 sitemap.xml | 32 v0_9_0/sitemap.xml | 22 +++--- v1_0_0/sitemap.xml | 30 +++--- 6 files changed, 110 insertions(+), 82 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] aditihilbert closed pull request #305: automated asf-site build
aditihilbert closed pull request #305: automated asf-site build URL: https://github.com/apache/mynewt-site/pull/305 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aditihilbert closed pull request #304: Updated the upcoming events
aditihilbert closed pull request #304: Updated the upcoming events URL: https://github.com/apache/mynewt-site/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-site] 01/01: Merge pull request #304 from aditihilbert/master
This is an automated email from the ASF dual-hosted git repository. aditi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit 37ac7795ef39f115fc5d9890abe2c985f120324e Merge: e3a2ecb 4b3bac4 Author: aditihilbertAuthorDate: Mon Aug 14 18:24:40 2017 -0700 Merge pull request #304 from aditihilbert/master Updated the upcoming events mkdocs.yml | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[GitHub] aditihilbert opened a new pull request #304: Updated the upcoming events
aditihilbert opened a new pull request #304: Updated the upcoming events URL: https://github.com/apache/mynewt-site/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-newtmgr] 02/03: nmxact - Fix typo in Iotivity rsp chr UUID.
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git commit 09a3fc37422db8c83f59b0f41ea9c10d997a03f8 Author: Christopher CollinsAuthorDate: Mon Aug 14 17:24:25 2017 -0700 nmxact - Fix typo in Iotivity rsp chr UUID. --- nmxact/bledefs/bledefs.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nmxact/bledefs/bledefs.go b/nmxact/bledefs/bledefs.go index 6b31ca2..e6bb5b9 100644 --- a/nmxact/bledefs/bledefs.go +++ b/nmxact/bledefs/bledefs.go @@ -35,7 +35,7 @@ const CccdUuid = 0x2902 const IotivitySvcUuid = "ade3d529-c784-4f63-a987-eb69f70ee816" const IotivityReqChrUuid = "ad7b334f-4637-4b86-90b6-9d787f03d218" -const IotivityRspChrUuid = "ad7b334f-4637-4b86-90b6-9d787f03d218" +const IotivityRspChrUuid = "e9241982-4580-42c4-8831-95048216b256" const UnauthSvcUuid = "0c08c213-98ed-4e43-a499-7e1137c39567" const UnauthReqChrUuid = "69b8a928-2ab2-487b-923e-54ce53a18bc1" -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-newtmgr] branch master updated (5674cdd -> 13304eb)
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git. from 5674cdd newtmgr - Remove OS-specific vendored packages. new f99d087 nmxact - write BLE command should listen for ack. new 09a3fc3 nmxact - Fix typo in Iotivity rsp chr UUID. new 13304eb newtmgr - revendor The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: newtmgr/Godeps/Godeps.json | 72 +++--- .../newtmgr/nmxact/bledefs/bledefs.go | 2 +- .../newtmgr/nmxact/nmble/ble_act.go| 4 +- .../newtmgr/nmxact/udp/udp_oic_sesn.go | 28 - nmxact/bledefs/bledefs.go | 2 +- nmxact/nmble/ble_act.go| 4 +- 6 files changed, 67 insertions(+), 45 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[mynewt-newtmgr] 03/03: newtmgr - revendor
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git commit 13304ebf64b2c57d54430230efcaffca3ec2fa0d Author: Christopher CollinsAuthorDate: Fri Aug 11 11:58:41 2017 -0700 newtmgr - revendor --- newtmgr/Godeps/Godeps.json | 72 +++--- .../newtmgr/nmxact/bledefs/bledefs.go | 2 +- .../newtmgr/nmxact/nmble/ble_act.go| 4 +- .../newtmgr/nmxact/udp/udp_oic_sesn.go | 28 - 4 files changed, 65 insertions(+), 41 deletions(-) diff --git a/newtmgr/Godeps/Godeps.json b/newtmgr/Godeps/Godeps.json index ce5ab65..d109d71 100644 --- a/newtmgr/Godeps/Godeps.json +++ b/newtmgr/Godeps/Godeps.json @@ -107,93 +107,93 @@ }, { "ImportPath": "mynewt.apache.org/newt/util", - "Comment": "mynewt_1_0_1_tag-26-gd70e83c", - "Rev": "d70e83caba3debbd8eff933308d619fe67c51dce" + "Comment": "mynewt_1_0_1_tag-31-gf041162", + "Rev": "f0411626b4e579bdf6815553d6d1aea661389aea" }, { "ImportPath": "mynewt.apache.org/newt/util/unixchild", - "Comment": "mynewt_1_0_1_tag-26-gd70e83c", - "Rev": "d70e83caba3debbd8eff933308d619fe67c51dce" + "Comment": "mynewt_1_0_1_tag-31-gf041162", + "Rev": "f0411626b4e579bdf6815553d6d1aea661389aea" }, { "ImportPath": "mynewt.apache.org/newt/viper", - "Comment": "mynewt_1_0_1_tag-26-gd70e83c", - "Rev": "d70e83caba3debbd8eff933308d619fe67c51dce" + "Comment": "mynewt_1_0_1_tag-31-gf041162", + "Rev": "f0411626b4e579bdf6815553d6d1aea661389aea" }, { "ImportPath": "mynewt.apache.org/newt/yaml", - "Comment": "mynewt_1_0_1_tag-26-gd70e83c", - "Rev": "d70e83caba3debbd8eff933308d619fe67c51dce" + "Comment": "mynewt_1_0_1_tag-31-gf041162", + "Rev": "f0411626b4e579bdf6815553d6d1aea661389aea" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/adv", - "Comment": "mynewt_1_1_0_tag-31-gf0af75a", - "Rev": "f0af75a43db81b781f26f3ef05d7c81322ec5a44" + "Comment": "mynewt_1_1_0_tag-36-ge1167f6", + "Rev": "e1167f696197169b49b4dfba4bc38d67502051de" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/bledefs", - "Comment": "mynewt_1_1_0_tag-31-gf0af75a", - "Rev": "f0af75a43db81b781f26f3ef05d7c81322ec5a44" + "Comment": "mynewt_1_1_0_tag-36-ge1167f6", + "Rev": "e1167f696197169b49b4dfba4bc38d67502051de" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/mgmt", - "Comment": "mynewt_1_1_0_tag-31-gf0af75a", - "Rev": "f0af75a43db81b781f26f3ef05d7c81322ec5a44" + "Comment": "mynewt_1_1_0_tag-36-ge1167f6", + "Rev": "e1167f696197169b49b4dfba4bc38d67502051de" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/nmble", - "Comment": "mynewt_1_1_0_tag-31-gf0af75a", - "Rev": "f0af75a43db81b781f26f3ef05d7c81322ec5a44" + "Comment": "mynewt_1_1_0_tag-36-ge1167f6", + "Rev": "e1167f696197169b49b4dfba4bc38d67502051de" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/nmp", - "Comment": "mynewt_1_1_0_tag-31-gf0af75a", - "Rev": "f0af75a43db81b781f26f3ef05d7c81322ec5a44" + "Comment": "mynewt_1_1_0_tag-36-ge1167f6", + "Rev": "e1167f696197169b49b4dfba4bc38d67502051de" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/nmserial", - "Comment": "mynewt_1_1_0_tag-31-gf0af75a", - "Rev": "f0af75a43db81b781f26f3ef05d7c81322ec5a44" + "Comment": "mynewt_1_1_0_tag-36-ge1167f6", + "Rev": "e1167f696197169b49b4dfba4bc38d67502051de" }, { "ImportPath": "mynewt.apache.org/newtmgr/nmxact/nmxutil", - "Comment":
[GitHub] ccollins476ad commented on issue #88: [RFC] Add option to generate CMakeLists.txt file for a target
ccollins476ad commented on issue #88: [RFC] Add option to generate CMakeLists.txt file for a target URL: https://github.com/apache/mynewt-newt/pull/88#issuecomment-322291173 Overall, it looks good to me. However, I have a few comments. A lot of these are pretty minor, so you can use your own discretion when deciding whether to make any changes. 1. Writing `CMakeLists.txt` to the project directory concerns me just a little bit, for a few reasons: a. It "pollutes" the project directory with a generated file. Aside from this file, newt writes all its files to the `bin` directory. b. It limits the user to one target at a time. Other commands, e.g., `build`, allow multiple target names to be specified for a single invocation. When automating builds, it is useful to be able to specify multiple targets or `all`. I am not sure how people would end up using cmake with newt, so the above concern may be invalid. If this feature is intended for manual use only, then the current implementation might be perfect. 2. The help text for `target cmake` looks a bit off: `Cmake all the variables for the target specified by .` 3. The `CMakeTargetWrite()` and `CMakeBuildPackageWrite()` functions should use `StatusMessage()` to display text rather than `fmt.Printf()`. That way, the user can silence the output if desired. I would use a verbosity of `util.VERBOSITY_DEFAULT` here. 4. The above two functions print `Generating code for `. That seems slightly inaccurate since no code is generated. I'm afraid I don't have any suggestions here :). 5. `cmake.go` redefines the compiler types. Would it be better to just use the original definitions in the `toolchain` package (e.g., `toolchain.COMPILER_TYPE_C`)? 6. In `CMakeTargetGenerate()`: ``` CmakeFileHandle, _ := os.Create(CmakeListsPath()) ``` It seems dangerous to ignore the error here. I suggest checking the error and returning `ChildNewtError(err)` on failure. It is important to wrap the original error with `ChildNewtError()` in case the calling code needs to know the specific file system error that caused the problem. 7. In `CMakeTargetGenerate()`: ``` targetBuilder, err := NewTargetBuilder(target) if err != nil { return util.NewNewtError(err.Error()) } ``` `NewTargetBuilder()` already returns a NewtError, so this code can just return `err` unadorned. By returning the original error, you preserve the stack trace. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #487 from wes3/wes_coverity
This is an automated email from the ASF dual-hosted git repository. wes3 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit b9a658fd1478b209967a90e98aa5a5cfe7df77fb Merge: 887f885 f6a9bb5 Author: wes3AuthorDate: Mon Aug 14 07:43:42 2017 -0700 Merge pull request #487 from wes3/wes_coverity Coverity fixes hw/mcu/nordic/nrf51xxx/src/hal_flash.c | 2 +- hw/mcu/nordic/nrf51xxx/src/hal_i2c.c | 8 hw/mcu/nordic/nrf51xxx/src/hal_timer.c | 1 + hw/mcu/nordic/nrf52xxx/src/hal_flash.c | 2 +- hw/mcu/nordic/nrf52xxx/src/hal_i2c.c | 8 hw/mcu/nordic/nrf52xxx/src/hal_timer.c | 1 + 6 files changed, 12 insertions(+), 10 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] branch master updated (887f885 -> b9a658f)
This is an automated email from the ASF dual-hosted git repository. wes3 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 887f885 Merge pull request #474 from IMGJulian/pic32 add 1497a78 nordic/hal_flash: Fix coverity issue 174090 add 80255f4 nordic/hal_flash: Fix for coverity issue 174066 add 5eada4d mcu/nordic/hal_i2c: fix coverity issue 174082 add f6a9bb5 mcu/nordic/hal_timer: fix coverity issue 174078 new b9a658f Merge pull request #487 from wes3/wes_coverity The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: hw/mcu/nordic/nrf51xxx/src/hal_flash.c | 2 +- hw/mcu/nordic/nrf51xxx/src/hal_i2c.c | 8 hw/mcu/nordic/nrf51xxx/src/hal_timer.c | 1 + hw/mcu/nordic/nrf52xxx/src/hal_flash.c | 2 +- hw/mcu/nordic/nrf52xxx/src/hal_i2c.c | 8 hw/mcu/nordic/nrf52xxx/src/hal_timer.c | 1 + 6 files changed, 12 insertions(+), 10 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] michal-narajowski opened a new pull request #88: [RFC] Add option to generate CMakeLists.txt file for a target
michal-narajowski opened a new pull request #88: [RFC] Add option to generate CMakeLists.txt file for a target URL: https://github.com/apache/mynewt-newt/pull/88 This PR adds a command to generate CMakeLists.txt file for a target. The file is placed in project root directory. Usage: newt target cmake This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] 01/01: Merge pull request #474 from IMGJulian/pic32
This is an automated email from the ASF dual-hosted git repository. julian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 887f885d306d83bc10c9fc89ee4c1ab6e73e63f1 Merge: 6e776c3 7d08103 Author: IMGJulianAuthorDate: Mon Aug 14 09:27:23 2017 +0100 Merge pull request #474 from IMGJulian/pic32 PIC32: Fix stack align kernel/os/include/os/arch/pic32/os/os_arch.h | 5 +++-- kernel/os/src/arch/pic32/os_arch_pic32.c | 6 -- 2 files changed, 7 insertions(+), 4 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@mynewt.apache.org" .
[mynewt-core] branch master updated (6e776c3 -> 887f885)
This is an automated email from the ASF dual-hosted git repository. julian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 6e776c3 Merge pull request #488 from ccollins476ad/rm-start-events add 7d08103 PIC32: fix stack align new 887f885 Merge pull request #474 from IMGJulian/pic32 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: kernel/os/include/os/arch/pic32/os/os_arch.h | 5 +++-- kernel/os/src/arch/pic32/os_arch_pic32.c | 6 -- 2 files changed, 7 insertions(+), 4 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@mynewt.apache.org"'].
[GitHub] IMGJulian closed pull request #474: PIC32: Fix stack align
IMGJulian closed pull request #474: PIC32: Fix stack align URL: https://github.com/apache/mynewt-core/pull/474 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services