[GitHub] [mynewt-core] nkaje commented on issue #2239: dialog_da1469x: enhance otp and serial loader tools.

2020-03-20 Thread GitBox
nkaje commented on issue #2239: dialog_da1469x: enhance otp and serial loader 
tools.
URL: https://github.com/apache/mynewt-core/pull/2239#issuecomment-601887699
 
 
   Logs from OpenOCD based system
   ```
   ./da1469x_serial_new.py load -u /dev/ttymxc4 -r ./reset_ocd.sh 
   Triggering SWD reset...
   warning: No executable has been specified and target does not support
   determining executable automatically.  Try using the "file" command.
   0x16011b16 in ?? ()
   adapter speed: 1000 kHz
   target halted due to debug-request, current mode: Thread 
   xPSR: 0xf900 pc: 0x228c msp: 0x2004
   b'\x02'
   Detected serial boot protocol
   Loading application to RAM
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] nkaje edited a comment on issue #2239: dialog_da1469x: enhance otp and serial loader tools.

2020-03-20 Thread GitBox
nkaje edited a comment on issue #2239: dialog_da1469x: enhance otp and serial 
loader tools.
URL: https://github.com/apache/mynewt-core/pull/2239#issuecomment-601887699
 
 
   Logs from OpenOCD based system
   ```
   ./da1469x_serial.py load -u /dev/ttymxc4 -r ./reset_ocd.sh image.elf.bin
   Triggering SWD reset...
   warning: No executable has been specified and target does not support
   determining executable automatically.  Try using the "file" command.
   0x16011b16 in ?? ()
   adapter speed: 1000 kHz
   target halted due to debug-request, current mode: Thread 
   xPSR: 0xf900 pc: 0x228c msp: 0x2004
   b'\x02'
   Detected serial boot protocol
   Loading application to RAM
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] nkaje edited a comment on issue #2239: dialog_da1469x: enhance otp and serial loader tools.

2020-03-20 Thread GitBox
nkaje edited a comment on issue #2239: dialog_da1469x: enhance otp and serial 
loader tools.
URL: https://github.com/apache/mynewt-core/pull/2239#issuecomment-601887699
 
 
   Logs from OpenOCD based system
   ```
   ./da1469x_serial.py load -u /dev/ttymxc4 -r ./reset_ocd.sh 
   Triggering SWD reset...
   warning: No executable has been specified and target does not support
   determining executable automatically.  Try using the "file" command.
   0x16011b16 in ?? ()
   adapter speed: 1000 kHz
   target halted due to debug-request, current mode: Thread 
   xPSR: 0xf900 pc: 0x228c msp: 0x2004
   b'\x02'
   Detected serial boot protocol
   Loading application to RAM
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2245: STM32 Allow reboot to bootloader

2020-03-20 Thread GitBox
apache-mynewt-bot removed a comment on issue #2245: STM32 Allow reboot to 
bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601770523
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/stm32_bootloader.c
   
   
   ```diff
   @@ -1,4 +1,3 @@
   -
#include 
#include 
#include 
   @@ -22,5 +21,5 @@
system_memory_reset_handler = (void (*)(void))(system_memory[1]);
system_memory_reset_handler();

   -while(1) ;
   +while (1);
}
   ```
   
   
   
    hw/mcu/stm/stm32f1xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -34,10 +34,10 @@
defined(STM32F103x6) || defined(STM32F103xB) || defined(STM32F103xE)
#define STM32_SYSTEM_MEMORY 0x1000
#elif defined(STM32F105xC) || \
   -  defined(STM32F107xC)
   +defined(STM32F107xC)
#define STM32_SYSTEM_MEMORY 0x1FFFB000
#elif defined(STM32F101xG) || \
   -  defined(STM32F103xG)
   +defined(STM32F103xG)
#define STM32_SYSTEM_MEMORY 0x1FFFE000
#endif

   ```
   
   
   
    hw/mcu/stm/stm32f4xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -31,7 +31,7 @@
defined(STM32F407xx) || \
defined(STM32F410Cx) || defined(STM32F410Rx) || defined(STM32F410Tx) || 
\
defined(STM32F411xE) || \
   -defined(STM32F412Cx) || defined(STM32F412Rx)  || defined(STM32F412Vx) 
|| defined(STM32F412Zx) || \
   +defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) || 
defined(STM32F412Zx) || \
defined(STM32F415xx) || \
defined(STM32F417xx) || \
defined(STM32F427xx) || \
   ```
   
   
   
    hw/mcu/stm/stm32l0xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -26,7 +26,8 @@

#define SVC_IRQ_NUMBER SVC_IRQn

   -#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || 
defined(STM32L010xB) || defined(STM32L011xx) || \
   +#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || 
defined(STM32L010xB) || \
   +defined(STM32L011xx) || \
defined(STM32L021xx) || \
defined(STM32L031xx) || \
defined(STM32L041xx) || \
   @@ -37,18 +38,18 @@
#define STM32_SYSTEM_MEMORY 0x1FF0
#endif

   -/*
   +/*
 * Defines for naming GPIOs.
 */
   -#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
   -#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
   -#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
   -#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
   -#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
   -#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
   -#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
   -#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
   -#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
   +#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
   +#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
   +#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
   +#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
   +#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
   +#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
   +#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
   +#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
   +#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))

#ifdef __cplusplus
}
   ```
   
   
   
    hw/mcu/stm/stm32l1xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -33,7 +33,8 @@
defined(STM32L151xD) || defined(STM32L151xDX) || defined(STM32L151xE) 
|| \
defined(STM32L152xB) || defined(STM32L152xBA) || defined(STM32L152xC) 
|| defined(STM32L152xCA) || \
defined(STM32L152xD) || defined(STM32L152xDX) || defined(STM32L152xE) 
|| \
   -defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) 
|| defined(STM32L162xDX) || defined(STM32L162xE)
   +defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) 
|| defined(STM32L162xDX) || \
   +defined(STM32L162xE)
#define STM32_SYSTEM_MEMORY 0x1FF0
#endif

   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601779251
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601771237
 
 
   
   
   
   ## RAT Report (2020-03-20 15:49:17)
   
   ## New files with unknown licenses
   
   * https://github.com/apache/mynewt-core/blob/94a2f8887d996417d2cf6183cea2df399c32bc32/hw/mcu/stm/stm32_common/src/stm32_bootloader.c;>hw/mcu/stm/stm32_common/src/stm32_bootloader.c
   
   ## 1 new files were excluded from check (.rat-excludes)
   
   
 Detailed analysis
   
   ## New files in this PR
   
   | License | File |
   |-|--|
   | ?  | https://github.com/apache/mynewt-core/blob/94a2f8887d996417d2cf6183cea2df399c32bc32/hw/mcu/stm/stm32_common/src/stm32_bootloader.c;>hw/mcu/stm/stm32_common/src/stm32_bootloader.c
 |
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-601770523
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/stm32_bootloader.c
   
   
   ```diff
   @@ -1,4 +1,3 @@
   -
#include 
#include 
#include 
   @@ -22,5 +21,5 @@
system_memory_reset_handler = (void (*)(void))(system_memory[1]);
system_memory_reset_handler();

   -while(1) ;
   +while (1);
}
   ```
   
   
   
    hw/mcu/stm/stm32f1xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -34,10 +34,10 @@
defined(STM32F103x6) || defined(STM32F103xB) || defined(STM32F103xE)
#define STM32_SYSTEM_MEMORY 0x1000
#elif defined(STM32F105xC) || \
   -  defined(STM32F107xC)
   +defined(STM32F107xC)
#define STM32_SYSTEM_MEMORY 0x1FFFB000
#elif defined(STM32F101xG) || \
   -  defined(STM32F103xG)
   +defined(STM32F103xG)
#define STM32_SYSTEM_MEMORY 0x1FFFE000
#endif

   ```
   
   
   
    hw/mcu/stm/stm32f4xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -31,7 +31,7 @@
defined(STM32F407xx) || \
defined(STM32F410Cx) || defined(STM32F410Rx) || defined(STM32F410Tx) || 
\
defined(STM32F411xE) || \
   -defined(STM32F412Cx) || defined(STM32F412Rx)  || defined(STM32F412Vx) 
|| defined(STM32F412Zx) || \
   +defined(STM32F412Cx) || defined(STM32F412Rx) || defined(STM32F412Vx) || 
defined(STM32F412Zx) || \
defined(STM32F415xx) || \
defined(STM32F417xx) || \
defined(STM32F427xx) || \
   ```
   
   
   
    hw/mcu/stm/stm32l0xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -26,7 +26,8 @@

#define SVC_IRQ_NUMBER SVC_IRQn

   -#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || 
defined(STM32L010xB) || defined(STM32L011xx) || \
   +#if defined(STM32L010x4) || defined(STM32L010x6) || defined(STM32L010x8) || 
defined(STM32L010xB) || \
   +defined(STM32L011xx) || \
defined(STM32L021xx) || \
defined(STM32L031xx) || \
defined(STM32L041xx) || \
   @@ -37,18 +38,18 @@
#define STM32_SYSTEM_MEMORY 0x1FF0
#endif

   -/*
   +/*
 * Defines for naming GPIOs.
 */
   -#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
   -#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
   -#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
   -#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
   -#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
   -#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
   -#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
   -#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
   -#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))
   +#define MCU_GPIO_PORTA(pin) ((0 * 16) + (pin))
   +#define MCU_GPIO_PORTB(pin) ((1 * 16) + (pin))
   +#define MCU_GPIO_PORTC(pin) ((2 * 16) + (pin))
   +#define MCU_GPIO_PORTD(pin) ((3 * 16) + (pin))
   +#define MCU_GPIO_PORTE(pin) ((4 * 16) + (pin))
   +#define MCU_GPIO_PORTF(pin) ((5 * 16) + (pin))
   +#define MCU_GPIO_PORTG(pin) ((6 * 16) + (pin))
   +#define MCU_GPIO_PORTH(pin) ((7 * 16) + (pin))
   +#define MCU_GPIO_PORTI(pin) ((8 * 16) + (pin))

#ifdef __cplusplus
}
   ```
   
   
   
    hw/mcu/stm/stm32l1xx/include/mcu/mcu.h
   
   
   ```diff
   @@ -33,7 +33,8 @@
defined(STM32L151xD) || defined(STM32L151xDX) || defined(STM32L151xE) 
|| \
defined(STM32L152xB) || defined(STM32L152xBA) || defined(STM32L152xC) 
|| defined(STM32L152xCA) || \
defined(STM32L152xD) || defined(STM32L152xDX) || defined(STM32L152xE) 
|| \
   -defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) 
|| defined(STM32L162xDX) || defined(STM32L162xE)
   +defined(STM32L162xC) || defined(STM32L162xCA) || defined(STM32L162xD) 
|| defined(STM32L162xDX) || \
   +defined(STM32L162xE)
#define STM32_SYSTEM_MEMORY 0x1FF0
#endif

   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] kasjer opened a new pull request #2245: STM32 Allow reboot to bootloader

2020-03-20 Thread GitBox
kasjer opened a new pull request #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245
 
 
   STM32 MCUs have embedded bootloader that can be activated on reset when BOOT 
pin(s) are in certain state.
   This change allows to start bootloader from application that is running from 
flash, so bootloader can be activated even if BOOT pins are soldered to boot 
system from flash.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-20 Thread GitBox
apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-601619928
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-601703747
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar edited a comment on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-20 Thread GitBox
prasad-alatkar edited a comment on issue #777: nimble/host: Clear master and 
slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-601681014
 
 
   @sjanc @rymanluk @ccollins476ad  PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar commented on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-20 Thread GitBox
prasad-alatkar commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-601681014
 
 
   @sjanc @rymanluk @christ PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #778: apps: scanner added

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #778: apps: scanner added
URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-601669692
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #778: apps: scanner added

2020-03-20 Thread GitBox
apache-mynewt-bot removed a comment on issue #778: apps: scanner added
URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-601668068
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/scanner/src/main.c
   
   
   ```diff
   @@ -47,7 +47,7 @@
scan_event(struct ble_gap_event *event, void *arg)
{
switch (event->type) {
   -/* advertising report has been received during discovery procedure */   
   +/* advertising report has been received during discovery procedure */
case BLE_GAP_EVENT_DISC:
MODLOG_DFLT(INFO, "Advertising report was received! Contents:\n");
MODLOG_DFLT(INFO, " event type: %u\n",event->disc.event_type);
   @@ -87,7 +87,7 @@
{
/* Generate a non-resolvable private address. */
ble_app_set_addr();
   -
   +
/* begin scanning */
scan();
}
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #778: apps: scanner added

2020-03-20 Thread GitBox
apache-mynewt-bot removed a comment on issue #778: apps: scanner added
URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-601665874
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/scanner/src/main.c
   
   
   ```diff
   @@ -28,7 +28,7 @@
/* scan_event() calls scan(), so forward declaration is required */
static void scan();

   -static void 
   +static void
ble_app_set_addr(void)
{
ble_addr_t addr;
   @@ -46,8 +46,8 @@
static int
scan_event(struct ble_gap_event *event, void *arg)
{
   -switch (event->type){
   -/* advertising report has been received during discovery procedure */   
   +switch (event->type) {
   +/* advertising report has been received during discovery procedure */
case BLE_GAP_EVENT_DISC:
MODLOG_DFLT(INFO, "Advertising report was received! Contents:\n");
MODLOG_DFLT(INFO, " event type: %u\n",event->disc.event_type);
   @@ -78,16 +78,16 @@
/* set scan parameters */
const struct ble_gap_disc_params scan_params = {500, 16, 0, 0, 1, 0};
/* performs discovery procedure; value of own_addr_type is hard-coded,
   -because NRPA is used */
   +   because NRPA is used */
ble_gap_disc(BLE_OWN_ADDR_RANDOM, 1000, _params,scan_event, NULL);
}

   -static void 
   +static void
on_sync(void)
{
/* Generate a non-resolvable private address. */
ble_app_set_addr();
   -
   +
/* begin scanning */
scan();
}
   @@ -98,7 +98,8 @@
console_printf("Resetting state; reason=%d\n", reason);
}

   -int main(int argc, char **argv)
   +int
   +main(int argc, char **argv)
{
/* Initialize all packages. */
sysinit();
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #778: apps: scanner added

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #778: apps: scanner added
URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-601668068
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/scanner/src/main.c
   
   
   ```diff
   @@ -47,7 +47,7 @@
scan_event(struct ble_gap_event *event, void *arg)
{
switch (event->type) {
   -/* advertising report has been received during discovery procedure */   
   +/* advertising report has been received during discovery procedure */
case BLE_GAP_EVENT_DISC:
MODLOG_DFLT(INFO, "Advertising report was received! Contents:\n");
MODLOG_DFLT(INFO, " event type: %u\n",event->disc.event_type);
   @@ -87,7 +87,7 @@
{
/* Generate a non-resolvable private address. */
ble_app_set_addr();
   -
   +
/* begin scanning */
scan();
}
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #778: apps: scanner added

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #778: apps: scanner added
URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-601665874
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/scanner/src/main.c
   
   
   ```diff
   @@ -28,7 +28,7 @@
/* scan_event() calls scan(), so forward declaration is required */
static void scan();

   -static void 
   +static void
ble_app_set_addr(void)
{
ble_addr_t addr;
   @@ -46,8 +46,8 @@
static int
scan_event(struct ble_gap_event *event, void *arg)
{
   -switch (event->type){
   -/* advertising report has been received during discovery procedure */   
   +switch (event->type) {
   +/* advertising report has been received during discovery procedure */
case BLE_GAP_EVENT_DISC:
MODLOG_DFLT(INFO, "Advertising report was received! Contents:\n");
MODLOG_DFLT(INFO, " event type: %u\n",event->disc.event_type);
   @@ -78,16 +78,16 @@
/* set scan parameters */
const struct ble_gap_disc_params scan_params = {500, 16, 0, 0, 1, 0};
/* performs discovery procedure; value of own_addr_type is hard-coded,
   -because NRPA is used */
   +   because NRPA is used */
ble_gap_disc(BLE_OWN_ADDR_RANDOM, 1000, _params,scan_event, NULL);
}

   -static void 
   +static void
on_sync(void)
{
/* Generate a non-resolvable private address. */
ble_app_set_addr();
   -
   +
/* begin scanning */
scan();
}
   @@ -98,7 +98,8 @@
console_printf("Resetting state; reason=%d\n", reason);
}

   -int main(int argc, char **argv)
   +int
   +main(int argc, char **argv)
{
/* Initialize all packages. */
sysinit();
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] Reynevan94 opened a new pull request #778: apps: scanner added

2020-03-20 Thread GitBox
Reynevan94 opened a new pull request #778: apps: scanner added
URL: https://github.com/apache/mynewt-nimble/pull/778
 
 
   Basic scanner app discovering advertising devices and printing advertising 
report data to serial port.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-mcumgr] branch master updated: zephyr: board nrf51_pca10028 renamed to nrf51dk_nrf51422

2020-03-20 Thread utzig
This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git


The following commit(s) were added to refs/heads/master by this push:
 new 34e93fb  zephyr: board nrf51_pca10028 renamed to nrf51dk_nrf51422
34e93fb is described below

commit 34e93fb95216d58048d9a5789b40c39c1cce6307
Author: Andrzej Puzdrowski 
AuthorDate: Tue Mar 17 17:48:13 2020 +0100

zephyr: board nrf51_pca10028 renamed to nrf51dk_nrf51422

Name of the board is changing in the zephyr-rtos:
zephyrproject-rtos/zephyr#23447

This patch aligns the board name used which is required for suppression
of build warnings.

Signed-off-by: Andrzej Puzdrowski 
---
 samples/smp_svr/zephyr/sample.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/smp_svr/zephyr/sample.yaml 
b/samples/smp_svr/zephyr/sample.yaml
index 0bde1d8..2dc9a3c 100644
--- a/samples/smp_svr/zephyr/sample.yaml
+++ b/samples/smp_svr/zephyr/sample.yaml
@@ -7,6 +7,6 @@ common:
 tests:
   sample.mcumg.smp_svr.nrf51:
 extra_args: CONF_FILE="prj_tiny.conf"
-platform_whitelist: nrf51_pca10028
+platform_whitelist: nrf51dk_nrf51422
   sample.mcumg.smp_svr.nrf52:
 platform_whitelist: nrf52_pca10040 nrf52840_pca10056



[GitHub] [mynewt-mcumgr] utzig merged pull request #73: zephyr: board nrf51_pca10028 renamed to nrf51dk_nrf51422

2020-03-20 Thread GitBox
utzig merged pull request #73: zephyr: board nrf51_pca10028 renamed to 
nrf51dk_nrf51422
URL: https://github.com/apache/mynewt-mcumgr/pull/73
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-mcumgr] nvlsianpu commented on issue #73: zephyr: board nrf51_pca10028 renamed to nrf51dk_nrf51422

2020-03-20 Thread GitBox
nvlsianpu commented on issue #73: zephyr: board nrf51_pca10028 renamed to 
nrf51dk_nrf51422
URL: https://github.com/apache/mynewt-mcumgr/pull/73#issuecomment-601645474
 
 
   @utzig This can be merged. The sample in the zephyr tree is upgraded in 
similar way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-20 Thread GitBox
apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-601619928
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar opened a new pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-20 Thread GitBox
prasad-alatkar opened a new pull request #777: nimble/host: Clear master and 
slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777
 
 
   Added `ble_gap_reset_master_slave_states` to clear advertising and discovery 
states when `ble_hs_reset` is called.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar opened a new issue #776: NimBLE Host: Advertisement and Scanning state should reset when `ble_hs_reset` is called

2020-03-20 Thread GitBox
prasad-alatkar opened a new issue #776: NimBLE Host: Advertisement and Scanning 
state should reset when `ble_hs_reset` is called
URL: https://github.com/apache/mynewt-nimble/issues/776
 
 
   If NimBLE host stack resets because of some controller issue, it should 
clear the advertising and scanning states.
   
   **Brief scenario:**

   Currently I am running into scenario, wherein `bleprph` gets DISCONNECT 
event and followed by host reset (`ble_hs_reset`). Now in `DISCONNECT` event, 
we start advertisement successfully (`bleprph_adv`). Once `ble_hs_reset` is 
called it resets host and again starts advertisement in host sync callback 
(`bleprph_on_sync`). Here we face failure to start advertisement with error 
code `BLE_HS_EALREADY`. It is happening because in `ble_gap_adv_validate`, this 
check fails --> `if (ble_gap_slave[0].op != BLE_GAP_OP_NULL)`. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services