[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #917: Mesh build fix
KKopyscinski commented on pull request #917: URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781863772 @sjanc I checked it again and CDB is off by default; this fixes issue when CDB is on. Could you change commit title? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski removed a comment on pull request #918: nimble/ll: Add restriction when enabling periodic advertising
KKopyscinski removed a comment on pull request #918: URL: https://github.com/apache/mynewt-nimble/pull/918#issuecomment-781861951 @sjanc I checked it again and CDB is off by default; this fixes issue when CDB is on. Could you change commit title? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #918: nimble/ll: Add restriction when enabling periodic advertising
KKopyscinski commented on pull request #918: URL: https://github.com/apache/mynewt-nimble/pull/918#issuecomment-781861951 @sjanc I checked it again and CDB is off by default; this fixes issue when CDB is on. Could you change commit title? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2491: Fix Kinetis HASH driver with small length buffers
apache-mynewt-bot commented on pull request #2491: URL: https://github.com/apache/mynewt-core/pull/2491#issuecomment-781709724 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2491: Fix Kinetis HASH driver with small length buffers
apache-mynewt-bot removed a comment on pull request #2491: URL: https://github.com/apache/mynewt-core/pull/2491#issuecomment-781708644 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/hash/hash_kinetis/src/hash_kinetis.c ```diff @@ -72,7 +72,7 @@ static int kinetis_hash_update(struct hash_dev *hash, void *ctx, uint16_t algo, -const void *inbuf, uint32_t inlen) +const void *inbuf, uint32_t inlen) { uint32_t i; uint32_t remain; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2490: hw: driver: crypto: Mbed TLS alt improvements
apache-mynewt-bot commented on pull request #2490: URL: https://github.com/apache/mynewt-core/pull/2490#issuecomment-781709233 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2490: hw: driver: crypto: Mbed TLS alt improvements
apache-mynewt-bot removed a comment on pull request #2490: URL: https://github.com/apache/mynewt-core/pull/2490#issuecomment-781647817 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/crypto/include/crypto/aes_alt.h ```diff @@ -39,14 +39,14 @@ void mbedtls_aes_init(mbedtls_aes_context *ctx); void mbedtls_aes_free(mbedtls_aes_context *ctx); int mbedtls_aes_setkey_enc(mbedtls_aes_context *ctx, const unsigned char *key, -unsigned int keybits); + unsigned int keybits); int mbedtls_aes_setkey_dec(mbedtls_aes_context *ctx, const unsigned char *key, -unsigned int keybits); + unsigned int keybits); int mbedtls_aes_crypt_ecb(mbedtls_aes_context *ctx, int mode, -const unsigned char input[16], unsigned char output[16]); + const unsigned char input[16], unsigned char output[16]); int mbedtls_aes_crypt_cbc(mbedtls_aes_context *ctx, int mode, -size_t length, unsigned char iv[16], const unsigned char *input, -unsigned char *output); + size_t length, unsigned char iv[16], const unsigned char *input, + unsigned char *output); #ifdef __cplusplus } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2491: Fix Kinetis HASH driver with small length buffers
apache-mynewt-bot commented on pull request #2491: URL: https://github.com/apache/mynewt-core/pull/2491#issuecomment-781708644 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/hash/hash_kinetis/src/hash_kinetis.c ```diff @@ -72,7 +72,7 @@ static int kinetis_hash_update(struct hash_dev *hash, void *ctx, uint16_t algo, -const void *inbuf, uint32_t inlen) +const void *inbuf, uint32_t inlen) { uint32_t i; uint32_t remain; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig opened a new pull request #2491: Fix Kinetis HASH driver with small length buffers
utzig opened a new pull request #2491: URL: https://github.com/apache/mynewt-core/pull/2491 * apps: hash_test: add small varlen inputs test - Add a new test that hashes multiple small variable length strings into a digest, where each string is smaller than SHA-256 block length. * hw: drivers: hash_kinetis: fix small buffer hashing - Hashing a message with multiple blocks of length<=64 (SHA-256 block length) was broken due to proper usage of the mmCAU padding. This commit fixes the handling of the pad data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2490: hw: driver: crypto: Mbed TLS alt improvements
apache-mynewt-bot commented on pull request #2490: URL: https://github.com/apache/mynewt-core/pull/2490#issuecomment-781647817 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/crypto/include/crypto/aes_alt.h ```diff @@ -39,14 +39,14 @@ void mbedtls_aes_init(mbedtls_aes_context *ctx); void mbedtls_aes_free(mbedtls_aes_context *ctx); int mbedtls_aes_setkey_enc(mbedtls_aes_context *ctx, const unsigned char *key, -unsigned int keybits); + unsigned int keybits); int mbedtls_aes_setkey_dec(mbedtls_aes_context *ctx, const unsigned char *key, -unsigned int keybits); + unsigned int keybits); int mbedtls_aes_crypt_ecb(mbedtls_aes_context *ctx, int mode, -const unsigned char input[16], unsigned char output[16]); + const unsigned char input[16], unsigned char output[16]); int mbedtls_aes_crypt_cbc(mbedtls_aes_context *ctx, int mode, -size_t length, unsigned char iv[16], const unsigned char *input, -unsigned char *output); + size_t length, unsigned char iv[16], const unsigned char *input, + unsigned char *output); #ifdef __cplusplus } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig opened a new pull request #2490: hw: driver: crypto: Mbed TLS alt improvements
utzig opened a new pull request #2490: URL: https://github.com/apache/mynewt-core/pull/2490 * Export `mbedtls_aes_setkey_dec` * Correctly handle encryption/decryption in ECB mode * Add CBC alt implementation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated (2db79a9 -> 203ee58)
This is an automated email from the ASF dual-hosted git repository. mlaz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 2db79a9 bsp/nordic_pca10095: Set nrf5340 as default transport new 97e80fc mcu/nxp/kinetis: Change hal_os_tick to be run by SysTick. new 10ea526 bsp/frdm-k82f: Update clock_config.c new b262a45 bsp/frdm-k82f: Set better defaults on FOPT for quicker boot from internal flash. new efeede5 bsp/frdm-kxxf: Allow reading Core and peripheral registers while debugging. new 203ee58 Merge pull request #2487 from mlaz/k8xf_support The 9918 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .style_ignored_dirs| 5 +- hw/bsp/frdm-k64f/frdm-k64_debug.sh | 1 + hw/bsp/frdm-k82f/frdm-k82_debug.sh | 1 + .../src/arch/cortex_m4/startup_MK82F25615.S| 2 +- hw/bsp/frdm-k82f/src/clock_config.c| 252 +++-- hw/bsp/frdm-k82f/src/clock_config.h| 16 +- hw/mcu/nxp/kinetis/src/hal_os_tick.c | 53 ++--- 7 files changed, 170 insertions(+), 160 deletions(-)
[GitHub] [mynewt-core] mlaz merged pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
mlaz merged pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] sjanc merged pull request #2489: bsp/nordic_pca10095: Set nrf5340 as default transport
sjanc merged pull request #2489: URL: https://github.com/apache/mynewt-core/pull/2489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: bsp/nordic_pca10095: Set nrf5340 as default transport
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 2db79a9 bsp/nordic_pca10095: Set nrf5340 as default transport 2db79a9 is described below commit 2db79a96fc778656cab544f2c9d6e617e6936972 Author: Szymon Janc AuthorDate: Thu Feb 18 16:45:07 2021 +0100 bsp/nordic_pca10095: Set nrf5340 as default transport --- hw/bsp/nordic_pca10095/syscfg.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/bsp/nordic_pca10095/syscfg.yml b/hw/bsp/nordic_pca10095/syscfg.yml index 95280be..e1a61cc 100644 --- a/hw/bsp/nordic_pca10095/syscfg.yml +++ b/hw/bsp/nordic_pca10095/syscfg.yml @@ -57,3 +57,5 @@ syscfg.vals: # Always use non-blocking API SPI_HAL_USE_NOBLOCK: 1 + +BLE_HCI_TRANSPORT: nrf5340
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2489: bsp/nordic_pca10095: Set nrf5340 as default transport
apache-mynewt-bot commented on pull request #2489: URL: https://github.com/apache/mynewt-core/pull/2489#issuecomment-781439227 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] sjanc opened a new pull request #2489: bsp/nordic_pca10095: Set nrf5340 as default transport
sjanc opened a new pull request #2489: URL: https://github.com/apache/mynewt-core/pull/2489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] mlaz commented on pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
mlaz commented on pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#issuecomment-781427227 All fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
apache-mynewt-bot commented on pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#issuecomment-781426360 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
apache-mynewt-bot removed a comment on pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#issuecomment-781414929 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/bsp/frdm-k82f/src/clock_config.c ```diff @@ -32,13 +32,13 @@ /* clang-format off */ /* TEXT BELOW IS USED AS SETTING FOR TOOLS * -!!GlobalInfo -product: Clocks v5.0 -processor: MK82FN256xxx15 -package_id: MK82FN256VDC15 -mcu_data: ksdk2_0 -processor_version: 5.0.0 -board: FRDM-K82F + !!GlobalInfo + product: Clocks v5.0 + processor: MK82FN256xxx15 + package_id: MK82FN256VDC15 + mcu_data: ksdk2_0 + processor_version: 5.0.0 + board: FRDM-K82F * BE CAREFUL MODIFYING THIS COMMENT - IT IS YAML SETTINGS FOR TOOLS **/ /* clang-format on */ @@ -90,103 +92,98 @@ **/ /* clang-format off */ /* TEXT BELOW IS USED AS SETTING FOR TOOLS * -!!Configuration -name: BOARD_BootClockHSRUN -outputs: -- {id: Bus_clock.outFreq, value: 75 MHz} -- {id: Core_clock.outFreq, value: 150 MHz, locked: true, accuracy: '0.001'} -- {id: Flash_clock.outFreq, value: 25 MHz} -- {id: FlexBus_clock.outFreq, value: 75 MHz} -- {id: LPO_clock.outFreq, value: 1 kHz} -- {id: MCGFFCLK.outFreq, value: 375 kHz} -- {id: MCGIRCLK.outFreq, value: 32.768 kHz} -- {id: MCGPLLCLK.outFreq, value: 150 MHz} -- {id: MCGPLLCLK2X.outFreq, value: 300 MHz} -- {id: OSCERCLK.outFreq, value: 12 MHz} -- {id: OSCERCLK_UNDIV.outFreq, value: 12 MHz} -- {id: PLLFLLCLK.outFreq, value: 150 MHz} -- {id: System_clock.outFreq, value: 150 MHz} -settings: -- {id: MCGMode, value: PEE} -- {id: powerMode, value: HSRUN} -- {id: MCG.FCRDIV.scale, value: '1'} -- {id: MCG.FRDIV.scale, value: '32'} -- {id: MCG.IREFS.sel, value: MCG.FRDIV} -- {id: MCG.PLLS.sel, value: MCG.PLL_DIV2} -- {id: MCG.VDIV.scale, value: '25'} -- {id: MCG_C1_IRCLKEN_CFG, value: Enabled} -- {id: MCG_C2_OSC_MODE_CFG, value: ModeOscLowPower} -- {id: MCG_C2_RANGE0_CFG, value: Very_high} -- {id: MCG_C2_RANGE0_FRDIV_CFG, value: Very_high} -- {id: OSC_CR_ERCLKEN_CFG, value: Enabled} -- {id: OSC_CR_ERCLKEN_UNDIV_CFG, value: Enabled} -- {id: RTC_CR_OSCE_CFG, value: Enabled} -- {id: RTC_CR_OSC_CAP_LOAD_CFG, value: SC10PF} -- {id: SIM.EMVSIMSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.LPUARTSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.OSC32KSEL.sel, value: RTC.RTC32KCLK} -- {id: SIM.OUTDIV2.scale, value: '2'} -- {id: SIM.OUTDIV4.scale, value: '6'} -- {id: SIM.PLLFLLSEL.sel, value: MCG.MCGPLLCLK} -- {id: SIM.RTCCLKOUTSEL.sel, value: RTC.RTC32KCLK} -- {id: SIM.TPMSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.USBFRAC.scale, value: '1', locked: true} -- {id: SIM.USBSRCSEL.sel, value: SIM.USBDIV} -sources: -- {id: OSC.OSC.outFreq, value: 12 MHz, enabled: true} + !!Configuration + name: BOARD_BootClockHSRUN + outputs: + - {id: Bus_clock.outFreq, value: 75 MHz} + - {id: Core_clock.outFreq, value: 150 MHz, locked: true, accuracy: '0.001'} + - {id: Flash_clock.outFreq, value: 25 MHz} + - {id: FlexBus_clock.outFreq, value: 75 MHz} + - {id: LPO_clock.outFreq, value: 1 kHz} + - {id: MCGFFCLK.outFreq, value: 375 kHz} + - {id: MCGIRCLK.outFreq, value: 32.768 kHz} + - {id: MCGPLLCLK.outFreq, value: 150 MHz} + - {id: MCGPLLCLK2X.outFreq, value: 300 MHz} + - {id: OSCERCLK.outFreq, value: 12 MHz} + - {id: OSCERCLK_UNDIV.outFreq, value: 12 MHz} + - {id: PLLFLLCLK.outFreq, value: 150 MHz} + - {id: System_clock.outFreq, value: 150 MHz} + settings: + - {id: MCGMode, value: PEE} + - {id: powerMode, value: HSRUN} + - {id: MCG.FCRDIV.scale, value: '1'} + - {id: MCG.FRDIV.scale, value: '32'} + - {id: MCG.IREFS.sel, value: MCG.FRDIV} + - {id: MCG.PLLS.sel, value: MCG.PLL_DIV2} + - {id: MCG.VDIV.scale, value: '25'} + - {id: MCG_C1_IRCLKEN_CFG, value: Enabled} + - {id: MCG_C2_OSC_MODE_CFG, value: ModeOscLowPower} + - {id: MCG_C2_RANGE0_CFG, value: Very_high} + - {id: MCG_C2_RANGE0_FRDIV_CFG, value: Very_high} + - {id: OSC_CR_ERCLKEN_CFG, value: Enabled} + - {id: OSC_CR_ERCLKEN_UNDIV_CFG, value: Enabled} + - {id: RTC_CR_OSCE_CFG, value: Enabled} + - {id: RTC_CR_OSC_CAP_LOAD_CFG, value: SC10PF} + - {id: SIM.EMVSIMSRCSEL.sel, value: OSC.OSCERCLK} + - {id: SIM.LPUARTSRCSEL.sel, value: OSC.OSCERCLK} + - {id: SIM.OSC32KSEL.sel, value: RTC.RTC32KCLK} + - {id: SIM.OUTDIV2.scale, value: '2'} + - {id: SIM.OUTDIV4.scale, value: '6'} + - {id: SIM.PLLFLLSEL.sel, value: MCG.MCGPLLCLK}
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
apache-mynewt-bot commented on pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#issuecomment-781414929 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/bsp/frdm-k82f/src/clock_config.c ```diff @@ -32,13 +32,13 @@ /* clang-format off */ /* TEXT BELOW IS USED AS SETTING FOR TOOLS * -!!GlobalInfo -product: Clocks v5.0 -processor: MK82FN256xxx15 -package_id: MK82FN256VDC15 -mcu_data: ksdk2_0 -processor_version: 5.0.0 -board: FRDM-K82F + !!GlobalInfo + product: Clocks v5.0 + processor: MK82FN256xxx15 + package_id: MK82FN256VDC15 + mcu_data: ksdk2_0 + processor_version: 5.0.0 + board: FRDM-K82F * BE CAREFUL MODIFYING THIS COMMENT - IT IS YAML SETTINGS FOR TOOLS **/ /* clang-format on */ @@ -90,103 +92,98 @@ **/ /* clang-format off */ /* TEXT BELOW IS USED AS SETTING FOR TOOLS * -!!Configuration -name: BOARD_BootClockHSRUN -outputs: -- {id: Bus_clock.outFreq, value: 75 MHz} -- {id: Core_clock.outFreq, value: 150 MHz, locked: true, accuracy: '0.001'} -- {id: Flash_clock.outFreq, value: 25 MHz} -- {id: FlexBus_clock.outFreq, value: 75 MHz} -- {id: LPO_clock.outFreq, value: 1 kHz} -- {id: MCGFFCLK.outFreq, value: 375 kHz} -- {id: MCGIRCLK.outFreq, value: 32.768 kHz} -- {id: MCGPLLCLK.outFreq, value: 150 MHz} -- {id: MCGPLLCLK2X.outFreq, value: 300 MHz} -- {id: OSCERCLK.outFreq, value: 12 MHz} -- {id: OSCERCLK_UNDIV.outFreq, value: 12 MHz} -- {id: PLLFLLCLK.outFreq, value: 150 MHz} -- {id: System_clock.outFreq, value: 150 MHz} -settings: -- {id: MCGMode, value: PEE} -- {id: powerMode, value: HSRUN} -- {id: MCG.FCRDIV.scale, value: '1'} -- {id: MCG.FRDIV.scale, value: '32'} -- {id: MCG.IREFS.sel, value: MCG.FRDIV} -- {id: MCG.PLLS.sel, value: MCG.PLL_DIV2} -- {id: MCG.VDIV.scale, value: '25'} -- {id: MCG_C1_IRCLKEN_CFG, value: Enabled} -- {id: MCG_C2_OSC_MODE_CFG, value: ModeOscLowPower} -- {id: MCG_C2_RANGE0_CFG, value: Very_high} -- {id: MCG_C2_RANGE0_FRDIV_CFG, value: Very_high} -- {id: OSC_CR_ERCLKEN_CFG, value: Enabled} -- {id: OSC_CR_ERCLKEN_UNDIV_CFG, value: Enabled} -- {id: RTC_CR_OSCE_CFG, value: Enabled} -- {id: RTC_CR_OSC_CAP_LOAD_CFG, value: SC10PF} -- {id: SIM.EMVSIMSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.LPUARTSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.OSC32KSEL.sel, value: RTC.RTC32KCLK} -- {id: SIM.OUTDIV2.scale, value: '2'} -- {id: SIM.OUTDIV4.scale, value: '6'} -- {id: SIM.PLLFLLSEL.sel, value: MCG.MCGPLLCLK} -- {id: SIM.RTCCLKOUTSEL.sel, value: RTC.RTC32KCLK} -- {id: SIM.TPMSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.USBFRAC.scale, value: '1', locked: true} -- {id: SIM.USBSRCSEL.sel, value: SIM.USBDIV} -sources: -- {id: OSC.OSC.outFreq, value: 12 MHz, enabled: true} + !!Configuration + name: BOARD_BootClockHSRUN + outputs: + - {id: Bus_clock.outFreq, value: 75 MHz} + - {id: Core_clock.outFreq, value: 150 MHz, locked: true, accuracy: '0.001'} + - {id: Flash_clock.outFreq, value: 25 MHz} + - {id: FlexBus_clock.outFreq, value: 75 MHz} + - {id: LPO_clock.outFreq, value: 1 kHz} + - {id: MCGFFCLK.outFreq, value: 375 kHz} + - {id: MCGIRCLK.outFreq, value: 32.768 kHz} + - {id: MCGPLLCLK.outFreq, value: 150 MHz} + - {id: MCGPLLCLK2X.outFreq, value: 300 MHz} + - {id: OSCERCLK.outFreq, value: 12 MHz} + - {id: OSCERCLK_UNDIV.outFreq, value: 12 MHz} + - {id: PLLFLLCLK.outFreq, value: 150 MHz} + - {id: System_clock.outFreq, value: 150 MHz} + settings: + - {id: MCGMode, value: PEE} + - {id: powerMode, value: HSRUN} + - {id: MCG.FCRDIV.scale, value: '1'} + - {id: MCG.FRDIV.scale, value: '32'} + - {id: MCG.IREFS.sel, value: MCG.FRDIV} + - {id: MCG.PLLS.sel, value: MCG.PLL_DIV2} + - {id: MCG.VDIV.scale, value: '25'} + - {id: MCG_C1_IRCLKEN_CFG, value: Enabled} + - {id: MCG_C2_OSC_MODE_CFG, value: ModeOscLowPower} + - {id: MCG_C2_RANGE0_CFG, value: Very_high} + - {id: MCG_C2_RANGE0_FRDIV_CFG, value: Very_high} + - {id: OSC_CR_ERCLKEN_CFG, value: Enabled} + - {id: OSC_CR_ERCLKEN_UNDIV_CFG, value: Enabled} + - {id: RTC_CR_OSCE_CFG, value: Enabled} + - {id: RTC_CR_OSC_CAP_LOAD_CFG, value: SC10PF} + - {id: SIM.EMVSIMSRCSEL.sel, value: OSC.OSCERCLK} + - {id: SIM.LPUARTSRCSEL.sel, value: OSC.OSCERCLK} + - {id: SIM.OSC32KSEL.sel, value: RTC.RTC32KCLK} + - {id: SIM.OUTDIV2.scale, value: '2'} + - {id: SIM.OUTDIV4.scale, value: '6'} + - {id: SIM.PLLFLLSEL.sel, value: MCG.MCGPLLCLK} + -
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
apache-mynewt-bot removed a comment on pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#issuecomment-781002548 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/bsp/frdm-k82f/src/clock_config.c ```diff @@ -32,13 +32,13 @@ /* clang-format off */ /* TEXT BELOW IS USED AS SETTING FOR TOOLS * -!!GlobalInfo -product: Clocks v5.0 -processor: MK82FN256xxx15 -package_id: MK82FN256VDC15 -mcu_data: ksdk2_0 -processor_version: 5.0.0 -board: FRDM-K82F + !!GlobalInfo + product: Clocks v5.0 + processor: MK82FN256xxx15 + package_id: MK82FN256VDC15 + mcu_data: ksdk2_0 + processor_version: 5.0.0 + board: FRDM-K82F * BE CAREFUL MODIFYING THIS COMMENT - IT IS YAML SETTINGS FOR TOOLS **/ /* clang-format on */ @@ -90,103 +92,98 @@ **/ /* clang-format off */ /* TEXT BELOW IS USED AS SETTING FOR TOOLS * -!!Configuration -name: BOARD_BootClockHSRUN -outputs: -- {id: Bus_clock.outFreq, value: 75 MHz} -- {id: Core_clock.outFreq, value: 150 MHz, locked: true, accuracy: '0.001'} -- {id: Flash_clock.outFreq, value: 25 MHz} -- {id: FlexBus_clock.outFreq, value: 75 MHz} -- {id: LPO_clock.outFreq, value: 1 kHz} -- {id: MCGFFCLK.outFreq, value: 375 kHz} -- {id: MCGIRCLK.outFreq, value: 32.768 kHz} -- {id: MCGPLLCLK.outFreq, value: 150 MHz} -- {id: MCGPLLCLK2X.outFreq, value: 300 MHz} -- {id: OSCERCLK.outFreq, value: 12 MHz} -- {id: OSCERCLK_UNDIV.outFreq, value: 12 MHz} -- {id: PLLFLLCLK.outFreq, value: 150 MHz} -- {id: System_clock.outFreq, value: 150 MHz} -settings: -- {id: MCGMode, value: PEE} -- {id: powerMode, value: HSRUN} -- {id: MCG.FCRDIV.scale, value: '1'} -- {id: MCG.FRDIV.scale, value: '32'} -- {id: MCG.IREFS.sel, value: MCG.FRDIV} -- {id: MCG.PLLS.sel, value: MCG.PLL_DIV2} -- {id: MCG.VDIV.scale, value: '25'} -- {id: MCG_C1_IRCLKEN_CFG, value: Enabled} -- {id: MCG_C2_OSC_MODE_CFG, value: ModeOscLowPower} -- {id: MCG_C2_RANGE0_CFG, value: Very_high} -- {id: MCG_C2_RANGE0_FRDIV_CFG, value: Very_high} -- {id: OSC_CR_ERCLKEN_CFG, value: Enabled} -- {id: OSC_CR_ERCLKEN_UNDIV_CFG, value: Enabled} -- {id: RTC_CR_OSCE_CFG, value: Enabled} -- {id: RTC_CR_OSC_CAP_LOAD_CFG, value: SC10PF} -- {id: SIM.EMVSIMSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.LPUARTSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.OSC32KSEL.sel, value: RTC.RTC32KCLK} -- {id: SIM.OUTDIV2.scale, value: '2'} -- {id: SIM.OUTDIV4.scale, value: '6'} -- {id: SIM.PLLFLLSEL.sel, value: MCG.MCGPLLCLK} -- {id: SIM.RTCCLKOUTSEL.sel, value: RTC.RTC32KCLK} -- {id: SIM.TPMSRCSEL.sel, value: OSC.OSCERCLK} -- {id: SIM.USBFRAC.scale, value: '1', locked: true} -- {id: SIM.USBSRCSEL.sel, value: SIM.USBDIV} -sources: -- {id: OSC.OSC.outFreq, value: 12 MHz, enabled: true} + !!Configuration + name: BOARD_BootClockHSRUN + outputs: + - {id: Bus_clock.outFreq, value: 75 MHz} + - {id: Core_clock.outFreq, value: 150 MHz, locked: true, accuracy: '0.001'} + - {id: Flash_clock.outFreq, value: 25 MHz} + - {id: FlexBus_clock.outFreq, value: 75 MHz} + - {id: LPO_clock.outFreq, value: 1 kHz} + - {id: MCGFFCLK.outFreq, value: 375 kHz} + - {id: MCGIRCLK.outFreq, value: 32.768 kHz} + - {id: MCGPLLCLK.outFreq, value: 150 MHz} + - {id: MCGPLLCLK2X.outFreq, value: 300 MHz} + - {id: OSCERCLK.outFreq, value: 12 MHz} + - {id: OSCERCLK_UNDIV.outFreq, value: 12 MHz} + - {id: PLLFLLCLK.outFreq, value: 150 MHz} + - {id: System_clock.outFreq, value: 150 MHz} + settings: + - {id: MCGMode, value: PEE} + - {id: powerMode, value: HSRUN} + - {id: MCG.FCRDIV.scale, value: '1'} + - {id: MCG.FRDIV.scale, value: '32'} + - {id: MCG.IREFS.sel, value: MCG.FRDIV} + - {id: MCG.PLLS.sel, value: MCG.PLL_DIV2} + - {id: MCG.VDIV.scale, value: '25'} + - {id: MCG_C1_IRCLKEN_CFG, value: Enabled} + - {id: MCG_C2_OSC_MODE_CFG, value: ModeOscLowPower} + - {id: MCG_C2_RANGE0_CFG, value: Very_high} + - {id: MCG_C2_RANGE0_FRDIV_CFG, value: Very_high} + - {id: OSC_CR_ERCLKEN_CFG, value: Enabled} + - {id: OSC_CR_ERCLKEN_UNDIV_CFG, value: Enabled} + - {id: RTC_CR_OSCE_CFG, value: Enabled} + - {id: RTC_CR_OSC_CAP_LOAD_CFG, value: SC10PF} + - {id: SIM.EMVSIMSRCSEL.sel, value: OSC.OSCERCLK} + - {id: SIM.LPUARTSRCSEL.sel, value: OSC.OSCERCLK} + - {id: SIM.OSC32KSEL.sel, value: RTC.RTC32KCLK} + - {id: SIM.OUTDIV2.scale, value: '2'} + - {id: SIM.OUTDIV4.scale, value: '6'} + - {id: SIM.PLLFLLSEL.sel, value: MCG.MCGPLLCLK}
[GitHub] [mynewt-core] mlaz commented on a change in pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
mlaz commented on a change in pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#discussion_r578500447 ## File path: hw/bsp/frdm-k82f/src/arch/cortex_m4/startup_MK82F25615.S ## @@ -272,7 +272,7 @@ __isr_vector: .long 0x .long 0x .long 0x -.long 0xFFFE +.long 0x3DFE Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #918: nimble/ll: Add restriction when enabling periodic advertising
apache-mynewt-bot commented on pull request #918: URL: https://github.com/apache/mynewt-nimble/pull/918#issuecomment-781409860 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #918: nimble/ll: Add restriction when enabling periodic advertising
apache-mynewt-bot removed a comment on pull request #918: URL: https://github.com/apache/mynewt-nimble/pull/918#issuecomment-781406465 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #918: nimble/ll: Add restriction when enabling periodic advertising
apache-mynewt-bot commented on pull request #918: URL: https://github.com/apache/mynewt-nimble/pull/918#issuecomment-781406465 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc opened a new pull request #918: nimble/ll: Add restriction when enabling periodic advertising
sjanc opened a new pull request #918: URL: https://github.com/apache/mynewt-nimble/pull/918 Periodic advertising requires extended advertising to be enabled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] mlaz commented on a change in pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
mlaz commented on a change in pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#discussion_r578485462 ## File path: hw/bsp/frdm-k82f/src/arch/cortex_m4/startup_MK82F25615.S ## @@ -272,7 +272,7 @@ __isr_vector: .long 0x .long 0x .long 0x -.long 0xFFFE +.long 0x3DFE Review comment: Yes, you are right, I misread the doc. That is what I intended to do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #917: Mesh build fix
apache-mynewt-bot commented on pull request #917: URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781390945 ## Style check fail: Payload was too large This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #917: Mesh build fix
apache-mynewt-bot removed a comment on pull request #917: URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781354720 ## Style check fail: Payload was too large This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-nimble] 03/03: apps: add roles to config sample apps had default config, but we can minimize their size by disabling unused roles.
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit a3c7ec4ef5bad515e53393a4a15b2b29123f617c Author: Krzysztof Kopyściński AuthorDate: Tue Feb 16 08:18:58 2021 +0100 apps: add roles to config sample apps had default config, but we can minimize their size by disabling unused roles. --- apps/advertiser/syscfg.yml | 23 +++ apps/central/syscfg.yml| 23 +++ apps/peripheral/syscfg.yml | 23 +++ apps/scanner/syscfg.yml| 23 +++ 4 files changed, 92 insertions(+) diff --git a/apps/advertiser/syscfg.yml b/apps/advertiser/syscfg.yml new file mode 100644 index 000..963839f --- /dev/null +++ b/apps/advertiser/syscfg.yml @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +syscfg.vals: +BLE_ROLE_BROADCASTER: 1 +BLE_ROLE_CENTRAL: 0 +BLE_ROLE_OBSERVER: 0 +BLE_ROLE_PERIPHERAL: 0 diff --git a/apps/central/syscfg.yml b/apps/central/syscfg.yml new file mode 100644 index 000..1e24f90 --- /dev/null +++ b/apps/central/syscfg.yml @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +syscfg.vals: +BLE_ROLE_BROADCASTER: 0 +BLE_ROLE_CENTRAL: 1 +BLE_ROLE_OBSERVER: 1 +BLE_ROLE_PERIPHERAL: 0 diff --git a/apps/peripheral/syscfg.yml b/apps/peripheral/syscfg.yml new file mode 100644 index 000..dd02ee6 --- /dev/null +++ b/apps/peripheral/syscfg.yml @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +syscfg.vals: +BLE_ROLE_BROADCASTER: 1 +BLE_ROLE_CENTRAL: 0 +BLE_ROLE_OBSERVER: 0 +BLE_ROLE_PERIPHERAL: 1 diff --git a/apps/scanner/syscfg.yml b/apps/scanner/syscfg.yml new file mode 100644 index 000..a926575 --- /dev/null +++ b/apps/scanner/syscfg.yml @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +syscfg.vals: +BLE_RO
[GitHub] [mynewt-nimble] KKopyscinski merged pull request #913: Optimize host size
KKopyscinski merged pull request #913: URL: https://github.com/apache/mynewt-nimble/pull/913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-nimble] branch master updated (0aa3fe6 -> a3c7ec4)
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from 0aa3fe6 porting: fix typo in CROSS_COMPILE new 3a9d1d8 host/ble_gap.c: optimize code Not all function bodies or methods must compile always. Added preprocessor directives to exclude such code fragments if not required, depending on roles/features. new 43c759d nimble/host: Compile ATT, GATT, L2CAP and SM files if NIMBLE_BLE_CONNECT ATT, GATT, L2CAP and SM are used only when connection is established, there's no need to compile them otherwise. new a3c7ec4 apps: add roles to config sample apps had default config, but we can minimize their size by disabling unused roles. The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: {nimble/host/util => apps/advertiser}/syscfg.yml | 8 +- {nimble/host/util => apps/central}/syscfg.yml| 8 +- {nimble/host/util => apps/peripheral}/syscfg.yml | 8 +- {nimble/host/util => apps/scanner}/syscfg.yml| 8 +- nimble/host/services/gap/src/ble_svc_gap.c | 6 + nimble/host/src/ble_att.c| 3 + nimble/host/src/ble_att_clt.c| 3 + nimble/host/src/ble_att_cmd.c| 3 + nimble/host/src/ble_att_svr.c| 3 + nimble/host/src/ble_gap.c| 135 --- nimble/host/src/ble_gattc.c | 3 + nimble/host/src/ble_gatts_lcl.c | 2 + nimble/host/src/ble_hs.c | 25 +++-- nimble/host/src/ble_hs_hci_evt.c | 36 -- nimble/host/src/ble_l2cap.c | 3 + nimble/host/src/ble_l2cap_coc.c | 2 +- nimble/host/src/ble_l2cap_sig.c | 3 + nimble/host/src/ble_l2cap_sig_cmd.c | 3 + nimble/host/src/ble_sm.c | 3 + nimble/host/src/ble_sm_alg.c | 2 + nimble/host/src/ble_sm_cmd.c | 3 + nimble/host/src/ble_sm_lgcy.c| 2 + nimble/host/src/ble_sm_sc.c | 2 + 23 files changed, 236 insertions(+), 38 deletions(-) copy {nimble/host/util => apps/advertiser}/syscfg.yml (86%) copy {nimble/host/util => apps/central}/syscfg.yml (86%) copy {nimble/host/util => apps/peripheral}/syscfg.yml (86%) copy {nimble/host/util => apps/scanner}/syscfg.yml (86%)
[mynewt-nimble] 02/03: nimble/host: Compile ATT, GATT, L2CAP and SM files if NIMBLE_BLE_CONNECT ATT, GATT, L2CAP and SM are used only when connection is established, there's no need to compile them o
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 43c759de4ed821738483ad335ac52027e0f037b7 Author: Krzysztof Kopyściński AuthorDate: Mon Feb 15 14:51:00 2021 +0100 nimble/host: Compile ATT, GATT, L2CAP and SM files if NIMBLE_BLE_CONNECT ATT, GATT, L2CAP and SM are used only when connection is established, there's no need to compile them otherwise. --- nimble/host/services/gap/src/ble_svc_gap.c | 6 + nimble/host/src/ble_att.c | 3 +++ nimble/host/src/ble_att_clt.c | 3 +++ nimble/host/src/ble_att_cmd.c | 3 +++ nimble/host/src/ble_att_svr.c | 3 +++ nimble/host/src/ble_gattc.c| 3 +++ nimble/host/src/ble_gatts_lcl.c| 2 ++ nimble/host/src/ble_hs.c | 25 +++-- nimble/host/src/ble_hs_hci_evt.c | 36 -- nimble/host/src/ble_l2cap.c| 3 +++ nimble/host/src/ble_l2cap_coc.c| 2 +- nimble/host/src/ble_l2cap_sig.c| 3 +++ nimble/host/src/ble_l2cap_sig_cmd.c| 3 +++ nimble/host/src/ble_sm.c | 3 +++ nimble/host/src/ble_sm_alg.c | 2 ++ nimble/host/src/ble_sm_cmd.c | 3 +++ nimble/host/src/ble_sm_lgcy.c | 2 ++ nimble/host/src/ble_sm_sc.c| 2 ++ 18 files changed, 92 insertions(+), 15 deletions(-) diff --git a/nimble/host/services/gap/src/ble_svc_gap.c b/nimble/host/services/gap/src/ble_svc_gap.c index e79b2b8..0775a41 100644 --- a/nimble/host/services/gap/src/ble_svc_gap.c +++ b/nimble/host/services/gap/src/ble_svc_gap.c @@ -41,6 +41,7 @@ static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] = MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME); static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE); +#if NIMBLE_BLE_CONNECT static int ble_svc_gap_access(uint16_t conn_handle, uint16_t attr_handle, struct ble_gatt_access_ctxt *ctxt, void *arg); @@ -239,6 +240,7 @@ ble_svc_gap_access(uint16_t conn_handle, uint16_t attr_handle, return BLE_ATT_ERR_UNLIKELY; } } +#endif const char * ble_svc_gap_device_name(void) @@ -285,14 +287,18 @@ ble_svc_gap_set_chr_changed_cb(ble_svc_gap_chr_changed_fn *cb) void ble_svc_gap_init(void) { +#if NIMBLE_BLE_CONNECT int rc; +#endif /* Ensure this function only gets called by sysinit. */ SYSINIT_ASSERT_ACTIVE(); +#if NIMBLE_BLE_CONNECT rc = ble_gatts_count_cfg(ble_svc_gap_defs); SYSINIT_PANIC_ASSERT(rc == 0); rc = ble_gatts_add_svcs(ble_svc_gap_defs); SYSINIT_PANIC_ASSERT(rc == 0); +#endif } diff --git a/nimble/host/src/ble_att.c b/nimble/host/src/ble_att.c index cc7a1f1..8aab7f9 100644 --- a/nimble/host/src/ble_att.c +++ b/nimble/host/src/ble_att.c @@ -21,6 +21,7 @@ #include #include "ble_hs_priv.h" +#if NIMBLE_BLE_CONNECT static uint16_t ble_att_preferred_mtu_val; /** Dispatch table for incoming ATT requests. Sorted by op code. */ @@ -587,3 +588,5 @@ ble_att_init(void) return 0; } + +#endif diff --git a/nimble/host/src/ble_att_clt.c b/nimble/host/src/ble_att_clt.c index 09fc9ea..1a76297 100644 --- a/nimble/host/src/ble_att_clt.c +++ b/nimble/host/src/ble_att_clt.c @@ -26,6 +26,7 @@ #include "host/ble_uuid.h" #include "ble_hs_priv.h" +#if NIMBLE_BLE_CONNECT /* * $error response * */ @@ -954,3 +955,5 @@ ble_att_clt_rx_indicate(uint16_t conn_handle, struct os_mbuf **rxom) ble_gattc_rx_indicate_rsp(conn_handle); return 0; } + +#endif diff --git a/nimble/host/src/ble_att_cmd.c b/nimble/host/src/ble_att_cmd.c index 81b070f..e719235 100644 --- a/nimble/host/src/ble_att_cmd.c +++ b/nimble/host/src/ble_att_cmd.c @@ -26,6 +26,7 @@ #include "host/ble_uuid.h" #include "ble_hs_priv.h" +#if NIMBLE_BLE_CONNECT void * ble_att_cmd_prepare(uint8_t opcode, size_t len, struct os_mbuf *txom) { @@ -634,3 +635,5 @@ ble_att_indicate_rsp_write(void *payload, int len) ble_att_init_write(BLE_ATT_OP_INDICATE_RSP, payload, BLE_ATT_INDICATE_RSP_SZ, len); } + +#endif diff --git a/nimble/host/src/ble_att_svr.c b/nimble/host/src/ble_att_svr.c index be61e4b..0cfbc7d 100644 --- a/nimble/host/src/ble_att_svr.c +++ b/nimble/host/src/ble_att_svr.c @@ -25,6 +25,7 @@ #include "host/ble_uuid.h" #include "ble_hs_priv.h" +#if NIMBLE_BLE_CONNECT /** * ATT server - Attribute Protocol * @@ -2727,3 +2728,5 @@ ble_att_svr_init(void) return 0; } + +#endif diff --git a/nimble/host/src/ble_gattc.c b/nimble/host/src/ble_gattc.c index a6e114c..d1036ff 100644 --- a/nimble/host/src/ble_gatt
[mynewt-nimble] 01/03: host/ble_gap.c: optimize code Not all function bodies or methods must compile always. Added preprocessor directives to exclude such code fragments if not required, depending on
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 3a9d1d85977a8be91cd8e93a138785e3521291b0 Author: Krzysztof Kopyściński AuthorDate: Fri Feb 12 14:33:07 2021 +0100 host/ble_gap.c: optimize code Not all function bodies or methods must compile always. Added preprocessor directives to exclude such code fragments if not required, depending on roles/features. --- nimble/host/src/ble_gap.c | 135 -- 1 file changed, 120 insertions(+), 15 deletions(-) diff --git a/nimble/host/src/ble_gap.c b/nimble/host/src/ble_gap.c index bbedc31..45747ff 100644 --- a/nimble/host/src/ble_gap.c +++ b/nimble/host/src/ble_gap.c @@ -225,7 +225,9 @@ ble_gap_update_entry_remove(uint16_t conn_handle); static int ble_gap_adv_enable_tx(int enable); #endif +#if NIMBLE_BLE_CONNECT static int ble_gap_conn_cancel_tx(void); +#endif #if NIMBLE_BLE_SCAN && !MYNEWT_VAL(BLE_EXT_ADV) static int ble_gap_disc_enable_tx(int enable, int filter_duplicates); @@ -387,6 +389,7 @@ ble_gap_log_adv(uint8_t own_addr_type, const ble_addr_t *direct_addr, * $snapshot * */ +#if NIMBLE_BLE_CONNECT static void ble_gap_fill_conn_desc(struct ble_hs_conn *conn, struct ble_gap_conn_desc *desc) @@ -443,10 +446,12 @@ ble_gap_find_snapshot(uint16_t handle, struct ble_gap_snapshot *snap) return 0; } } +#endif int ble_gap_conn_find(uint16_t handle, struct ble_gap_conn_desc *out_desc) { +#if NIMBLE_BLE_CONNECT struct ble_hs_conn *conn; ble_hs_lock(); @@ -463,12 +468,16 @@ ble_gap_conn_find(uint16_t handle, struct ble_gap_conn_desc *out_desc) } else { return 0; } +#else +return BLE_HS_ENOTSUP; +#endif } int ble_gap_conn_find_by_addr(const ble_addr_t *addr, struct ble_gap_conn_desc *out_desc) { +#if NIMBLE_BLE_CONNECT struct ble_hs_conn *conn; ble_hs_lock(); @@ -485,8 +494,12 @@ ble_gap_conn_find_by_addr(const ble_addr_t *addr, } return 0; +#else +return BLE_HS_ENOTSUP; +#endif } +#if NIMBLE_BLE_CONNECT static int ble_gap_extract_conn_cb(uint16_t conn_handle, ble_gap_event_fn **out_cb, void **out_cb_arg) @@ -514,16 +527,22 @@ ble_gap_extract_conn_cb(uint16_t conn_handle, return 0; } } +#endif int ble_gap_set_priv_mode(const ble_addr_t *peer_addr, uint8_t priv_mode) { +#if NIMBLE_BLE_CONNECT return ble_hs_pvcy_set_mode(peer_addr, priv_mode); +#else +return BLE_HS_ENOTSUP; +#endif } int ble_gap_read_le_phy(uint16_t conn_handle, uint8_t *tx_phy, uint8_t *rx_phy) { +#if NIMBLE_BLE_CONNECT struct ble_hci_le_rd_phy_cp cmd; struct ble_hci_le_rd_phy_rp rsp; struct ble_hs_conn *conn; @@ -554,11 +573,15 @@ ble_gap_read_le_phy(uint16_t conn_handle, uint8_t *tx_phy, uint8_t *rx_phy) *rx_phy = rsp.rx_phy; return 0; +#else +return BLE_HS_ENOTSUP; +#endif } int ble_gap_set_prefered_default_le_phy(uint8_t tx_phys_mask, uint8_t rx_phys_mask) { +#if NIMBLE_BLE_CONNECT struct ble_hci_le_set_default_phy_cp cmd; if (tx_phys_mask > (BLE_HCI_LE_PHY_1M_PREF_MASK | @@ -590,12 +613,16 @@ ble_gap_set_prefered_default_le_phy(uint8_t tx_phys_mask, uint8_t rx_phys_mask) return ble_hs_hci_cmd_tx(BLE_HCI_OP(BLE_HCI_OGF_LE, BLE_HCI_OCF_LE_SET_DEFAULT_PHY), &cmd, sizeof(cmd), NULL, 0); +#else +return BLE_HS_ENOTSUP; +#endif } int ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask, uint8_t rx_phys_mask, uint16_t phy_opts) { +#if NIMBLE_BLE_CONNECT struct ble_hci_le_set_phy_cp cmd; struct ble_hs_conn *conn; @@ -642,6 +669,9 @@ ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask, return ble_hs_hci_cmd_tx(BLE_HCI_OP(BLE_HCI_OGF_LE, BLE_HCI_OCF_LE_SET_PHY), &cmd, sizeof(cmd), NULL, 0); +#else +return BLE_HS_ENOTSUP; +#endif } /* @@ -673,7 +703,7 @@ ble_gap_call_event_cb(struct ble_gap_event *event, return rc; } - +#if NIMBLE_BLE_CONNECT static int ble_gap_call_conn_event_cb(struct ble_gap_event *event, uint16_t conn_handle) { @@ -693,28 +723,32 @@ ble_gap_call_conn_event_cb(struct ble_gap_event *event, uint16_t conn_handle) return 0; } +#endif static bool ble_gap_is_preempted(void) { +#if NIMBLE_BLE_ADVERTISE int i; - +#endif BLE_HS_DBG_ASSERT(ble_hs_locked_by_cur_task()); +#if MYNEWT_VAL(BLE_ROLE_CENTRAL) || MYNEWT_VAL(BLE_ROLE_OBSERVER) if (ble_gap_master.preempted_op != BLE_GAP_OP_NULL) {
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #115: Support for software update to Direct-XIP built applications
de-nordic commented on pull request #115: URL: https://github.com/apache/mynewt-mcumgr/pull/115#issuecomment-781358369 @mlaz , @nvlsianpu , @utzig Can you take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #917: Mesh build fix
KKopyscinski commented on pull request #917: URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781356479 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #114: img_mgmt: Use IMG_MGMT_BOOT_CURR_SLOT as current running slot ID
de-nordic commented on pull request #114: URL: https://github.com/apache/mynewt-mcumgr/pull/114#issuecomment-781355406 @mlaz , @nvlsianpu , @utzig Can you take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #917: Mesh build fix
apache-mynewt-bot commented on pull request #917: URL: https://github.com/apache/mynewt-nimble/pull/917#issuecomment-781354720 ## Style check fail: Payload was too large This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc opened a new pull request #917: Mesh build fix
sjanc opened a new pull request #917: URL: https://github.com/apache/mynewt-nimble/pull/917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #115: Support for software update to Direct-XIP built applications
de-nordic opened a new pull request #115: URL: https://github.com/apache/mynewt-mcumgr/pull/115 Depends on https://github.com/apache/mynewt-mcumgr/pull/114 The PR contains two PRs that 1) Add automatic selection of running application slot at compile time 2) Remove restrictions on uploading applications to "pending" slots for Direct-XIP applications This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig commented on a change in pull request #2487: [KINETIS] Multiple fixes: boot, systick and debug.
utzig commented on a change in pull request #2487: URL: https://github.com/apache/mynewt-core/pull/2487#discussion_r578398620 ## File path: hw/bsp/frdm-k82f/src/arch/cortex_m4/startup_MK82F25615.S ## @@ -272,7 +272,7 @@ __isr_vector: .long 0x .long 0x .long 0x -.long 0xFFFE +.long 0x3DFE Review comment: If you are setting `BOOTSRC_SEL` to internal flash shouldn't `BOOTPIN_OPT` be 1 to select `BOOTSRC_SEL`, in other words `0x3FFE`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #114: img_mgmt: Use IMG_MGMT_BOOT_CURR_SLOT as current running slot ID
de-nordic opened a new pull request #114: URL: https://github.com/apache/mynewt-mcumgr/pull/114 The commit changes function img_mgmt_state_flasg functions to use IMG_MGMT_BOOT_CURR_SLOT in comparisons as a currently running slot number instead of previously hard-coded 0. The change allows to correctly identify active partition when application is running from different slot than 0. Signed-off-by: Dominik Ermel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated (306f546 -> 3b59629)
This is an automated email from the ASF dual-hosted git repository. jerzy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 306f546 bsp/nordic_pca10095_net: set nrf5340 as default transport Net core app should use IPC transport by default , as it's used to communicate with app running on net core. new 5dce508 hw/mcu/dialog: Synchronize DCDC handling between cores new 3b59629 drivers/da1469x_charger: Keep DCDC off when VBUS is on The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c | 13 + hw/mcu/dialog/da1469x/src/da1469x_prail.c | 11 +++ 2 files changed, 24 insertions(+)
[mynewt-core] 01/02: hw/mcu/dialog: Synchronize DCDC handling between cores
This is an automated email from the ASF dual-hosted git repository. jerzy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 5dce508a1f60f233a3c97b838543814b76da96a2 Author: Jerzy Kasenberg AuthorDate: Tue Feb 16 16:08:31 2021 +0100 hw/mcu/dialog: Synchronize DCDC handling between cores When DCDC is turned off by M33 set shared memory accordingly so DCDC is not turned on by CMAC. --- hw/mcu/dialog/da1469x/src/da1469x_prail.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/mcu/dialog/da1469x/src/da1469x_prail.c b/hw/mcu/dialog/da1469x/src/da1469x_prail.c index 319bb7a..0ea9d1b 100644 --- a/hw/mcu/dialog/da1469x/src/da1469x_prail.c +++ b/hw/mcu/dialog/da1469x/src/da1469x_prail.c @@ -24,6 +24,9 @@ #include "mcu/da1469x_hal.h" #include "mcu/da1469x_prail.h" #include "mcu/da1469x_retreg.h" +#if MYNEWT_VAL_CHOICE(BLE_HCI_TRANSPORT, dialog_cmac) +#include "cmac_driver/cmac_shared.h" +#endif #include "os/util.h" #define POWER_CTRL_REG_SET(_field, _val) \ @@ -176,6 +179,10 @@ da1469x_prail_dcdc_restore(void) if (CRG_TOP->ANA_STATUS_REG & CRG_TOP_ANA_STATUS_REG_COMP_VBAT_HIGH_Msk) { da1469x_retreg_restore(g_mcu_dcdc_config, ARRAY_SIZE(g_mcu_dcdc_config)); DCDC->DCDC_CTRL1_REG |= DCDC_DCDC_CTRL1_REG_DCDC_ENABLE_Msk; +#if MYNEWT_VAL_CHOICE(BLE_HCI_TRANSPORT, dialog_cmac) +/* Enable turning DCDC on from CMAC core. */ +g_cmac_shared_data->dcdc.enabled = 1; +#endif } } #endif @@ -183,6 +190,10 @@ da1469x_prail_dcdc_restore(void) void da1469x_prail_dcdc_disable(void) { +#if MYNEWT_VAL_CHOICE(BLE_HCI_TRANSPORT, dialog_cmac) +/* Prevent CMAC from turning DCDC on. */ +g_cmac_shared_data->dcdc.enabled = 0; +#endif DCDC->DCDC_CTRL1_REG &= ~DCDC_DCDC_CTRL1_REG_DCDC_ENABLE_Msk; }
[GitHub] [mynewt-core] kasjer merged pull request #2481: da1469x disable dcdc when vbus is present
kasjer merged pull request #2481: URL: https://github.com/apache/mynewt-core/pull/2481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] 02/02: drivers/da1469x_charger: Keep DCDC off when VBUS is on
This is an automated email from the ASF dual-hosted git repository. jerzy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 3b5962962b2c3a52084aaca1cf760b296465a882 Author: Jerzy Kasenberg AuthorDate: Tue Feb 16 16:12:04 2021 +0100 drivers/da1469x_charger: Keep DCDC off when VBUS is on When VBUS is present turn DCDC off, this will allow to increase charge current when battery is not full. It will also keep battery from partially discharging when its full. --- hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c b/hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c index 3107b2a..e1d7b64 100644 --- a/hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c +++ b/hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c @@ -27,6 +27,7 @@ #include #if MYNEWT_VAL(DA1469X_CHARGER_USE_CHARGE_CONTROL) #include +#include #endif int @@ -127,6 +128,18 @@ static void da1469x_vbus_state_changed_event_cb(struct os_event *ev) { assert(ev); +#if MYNEWT_VAL(MCU_DCDC_ENABLE) +/* + * If VBUS is present turn off DCDC so charging current is higher. + * When devices is fully charged as long as VBUS is present battery will + * no be used to power DCDC so it will not deplete. + */ +if ((CRG_TOP->ANA_STATUS_REG & CRG_TOP_ANA_STATUS_REG_VBUS_AVAILABLE_Msk) != 0) { +da1469x_prail_dcdc_disable(); +} else { +da1469x_prail_dcdc_restore(); +} +#endif NVIC_SetPendingIRQ(CHARGER_STATE_IRQn); }
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #913: Optimize host size
KKopyscinski commented on pull request #913: URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-781287605 Code size improvement : | app | size before - FLASH | size before - RAM | size after - FLASH | size after - RAM | delta (FLASH) | delta (RAM) | | --- | --- | --- | --- | --- | --- | ---| | advertiser | 27961 | 3507 | 9111 | 1265 | 18850 | 2242 | | scanner | 42284 | 4171 | 10579 | 2014 | 31705 | 2133 | | blecent | 48557 | 4319 | 48453 | 4319 | 104 | 0 | | bleperph | 45596 | 4552 | 45392 | 4552 | 204 | 0 | This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: bsp/nordic_pca10095_net: set nrf5340 as default transport Net core app should use IPC transport by default , as it's used to communicate with app running on net co
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 306f546 bsp/nordic_pca10095_net: set nrf5340 as default transport Net core app should use IPC transport by default , as it's used to communicate with app running on net core. 306f546 is described below commit 306f546a44df35bd88f4ac9fa450046384bdc30d Author: Krzysztof Kopyściński AuthorDate: Thu Feb 18 10:07:40 2021 +0100 bsp/nordic_pca10095_net: set nrf5340 as default transport Net core app should use IPC transport by default , as it's used to communicate with app running on net core. --- hw/bsp/nordic_pca10095_net/syscfg.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/bsp/nordic_pca10095_net/syscfg.yml b/hw/bsp/nordic_pca10095_net/syscfg.yml index 4ec621e..1952147 100644 --- a/hw/bsp/nordic_pca10095_net/syscfg.yml +++ b/hw/bsp/nordic_pca10095_net/syscfg.yml @@ -59,3 +59,5 @@ syscfg.vals.BLE_CONTROLLER: OS_CPUTIME_FREQ: 32768 OS_CPUTIME_TIMER_NUM: 3 BLE_LL_RFMGMT_ENABLE_TIME: 1500 + +BLE_HCI_TRANSPORT: nrf5340
[GitHub] [mynewt-core] KKopyscinski merged pull request #2488: bsp/nordic_pca10095_net: set nrf5340 as default transport
KKopyscinski merged pull request #2488: URL: https://github.com/apache/mynewt-core/pull/2488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2488: bsp/nordic_pca10095_net: set nrf5340 as default transport
apache-mynewt-bot commented on pull request #2488: URL: https://github.com/apache/mynewt-core/pull/2488#issuecomment-781202637 ## Style check summary No suggestions at this time! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] KKopyscinski opened a new pull request #2488: bsp/nordic_pca10095_net: set nrf5340 as default transport
KKopyscinski opened a new pull request #2488: URL: https://github.com/apache/mynewt-core/pull/2488 Net core app should use IPC transport by default , as it's used to communicate with app running on net core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org