[GitHub] [mynewt-nimble] CDPA-SCA commented on a change in pull request #707: nimble/controller: Use mynewt-core crypto driver for certain crypto operations on nrf5x

[GitBox]

CDPA-SCA commented on a change in pull request #707:
URL: https://github.com/apache/mynewt-nimble/pull/707#discussion_r628671817



##
File path: nimble/controller/src/ble_ll_resolv.c
##
@@ -138,13 +138,13 @@ ble_ll_resolv_rpa_timer_cb(struct ble_npl_event *ev)
 
 rl = _ble_ll_resolv_list[0];
 for (i = 0; i < g_ble_ll_resolv_data.rl_cnt; ++i) {
-OS_ENTER_CRITICAL(sr);
+//OS_ENTER_CRITICAL(sr);

Review comment:
   Hi, It seems that this commit is not merged into the master branch. I 
wonder if you are still considering addressing this issue?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #958: Various Mesh fixes

[GitBox]

apache-mynewt-bot removed a comment on pull request #958:
URL: https://github.com/apache/mynewt-nimble/pull/958#issuecomment-834071963


   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #958: Various Mesh fixes

[GitBox]

apache-mynewt-bot commented on pull request #958:
URL: https://github.com/apache/mynewt-nimble/pull/958#issuecomment-834402631


   
   ## Style check fail: Payload was too large


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-newtmgr] sw commented on issue #185: Flash alignment mismatch leads to large overhead with Zephyr mcumgr

[GitBox]

sw commented on issue #185:
URL: https://github.com/apache/mynewt-newtmgr/issues/185#issuecomment-834220928


   This seems to have gotten worse in 1.9.0 compared to 1.8.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] prasad-alatkar commented on pull request #898: NimBLE host: Modify `ble_gap_wl_set` to help remove all addresses from controller whitelist

[GitBox]

prasad-alatkar commented on pull request #898:
URL: https://github.com/apache/mynewt-nimble/pull/898#issuecomment-834174308


   @rymanluk @sjanc I have incorporated your suggested changes. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] prasad-alatkar commented on pull request #932: nimble/host: Fix error return in `ble_store_util_bonded_peers`

[GitBox]

prasad-alatkar commented on pull request #932:
URL: https://github.com/apache/mynewt-nimble/pull/932#issuecomment-834173606


   @rymanluk PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org