[GitHub] [mynewt-nffs] sjanc opened a new pull request, #20: Remove travis integration

2023-01-17 Thread GitBox


sjanc opened a new pull request, #20:
URL: https://github.com/apache/mynewt-nffs/pull/20

   ASF is moving away from Travis towards GithubAction. Since this repo is 
mostly abandonned for now just disable travis. If needed (unlikely) we can add 
GHA in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2919: Add initial STM32H723ZG MCU support with external repos downloading

2023-01-17 Thread GitBox


apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1385573128

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32h7xx/src/hal_timer_freq.c
   
   
   ```diff
   @@ -101,10 +101,10 @@
case (uintptr_t)TIM14:
#endif
#ifdef TIM23
   -case (uintptr_t)TIM23:
   +case (uintptr_t)TIM23:
#endif
#ifdef TIM24
   -case (uintptr_t)TIM24:
   +case (uintptr_t)TIM24:
#endif
freq = HAL_RCC_GetPCLK1Freq();
div = stm32_hal_timer_abp_clk_div(clocks.APB1CLKDivider);
   ```
   
   
   
    hw/mcu/stm/stm32h7xx/src/system_stm32h7xx.c
   
   
   ```diff
   @@ -1,48 +1,48 @@
/**
   -  
**
   -  * @filesystem_stm32h7xx.c
   -  * @author  MCD Application Team
   -  * @brief   CMSIS Cortex-Mx Device Peripheral Access Layer System Source 
File.
   -  *
   -  *   This file provides two functions and one global variable to be called 
from
   -  *   user application:
   -  *  - SystemInit(): This function is called at startup just after 
reset and
   -  *  before branch to main program. This call is made 
inside
   -  *  the "startup_stm32h7xx.s" file.
   -  *
   -  *  - SystemCoreClock variable: Contains the core clock, it can be used
   -  *  by the user application to setup the 
SysTick
   -  *  timer or configure other parameters.
   -  *
   -  *  - SystemCoreClockUpdate(): Updates the variable SystemCoreClock 
and must
   -  * be called whenever the core clock is 
changed
   -  * during program execution.
   -  *
   -  *
   -  
**
   -  * @attention
   -  *
   -  * Copyright (c) 2017 STMicroelectronics.
   -  * All rights reserved.
   -  *
   -  * This software is licensed under terms that can be found in the LICENSE 
file
   -  * in the root directory of this software component.
   -  * If no LICENSE file comes with this software, it is provided AS-IS.
   -  *
   -  
**
   -  */
   + 
**
   + * @filesystem_stm32h7xx.c
   + * @author  MCD Application Team
   + * @brief   CMSIS Cortex-Mx Device Peripheral Access Layer System Source 
File.
   + *
   + *   This file provides two functions and one global variable to be called 
from
   + *   user application:
   + *  - SystemInit(): This function is called at startup just after reset 
and
   + *  before branch to main program. This call is made 
inside
   + *  the "startup_stm32h7xx.s" file.
   + *
   + *  - SystemCoreClock variable: Contains the core clock, it can be used
   + *  by the user application to setup the 
SysTick
   + *  timer or configure other parameters.
   + *
   + *  - SystemCoreClockUpdate(): Updates the variable SystemCoreClock and 
must
   + * be called whenever the core clock is 
changed
   + * during program execution.
   + *
   + *
   + 
**
   + * @attention
   + *
   + * Copyright (c) 2017 STMicroelectronics.
   + * All rights reserved.
   + *
   + * This software is licensed under terms that can be found in the LICENSE 
file
   + * in the root directory of this software component.
   + * If no LICENSE file comes with this software, it is provided AS-IS.
   + *
   + 
**
   + */

/** @addtogroup CMSIS
   -  * @{
   -  */
   + * @{
   + */

/** @addtogroup stm32h7xx_system
   -  * @{
   -  */
   + * @{
   + */

/** @addtogroup STM32H7xx_System_Private_Includes
   -  * @{
   -  */
   + * @{
   + */

#include "bsp/stm32h7xx_hal_conf.h"
#include "stm32h7xx.h"
   ```
   
   
   
    hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c
   
   
   ```diff
   @@ -56,94 +57,92 @@
#if defined(STM32L152xC)
#include "stm32l1xx_hal.h"

   -HAL_StatusTypeDef HAL_SPI_Init(SPI_HandleTypeDef *hspi)
   -{
   -  /* Check the SPI handle allocation */
   -  if (hspi == NULL)
   -  {
   -return HAL_ERROR;
   -  }
   -
   -  /* Check the parameters */
   -  assert_param(IS_SPI_ALL_INSTANCE(hspi->Instance));
   -  assert_param(IS_SPI_MODE(hspi->Init.Mode));
   -  assert_param(IS_SPI_DATASIZE(hspi->Init.DataSize));
   -  assert_param(IS_SPI_CPOL(hspi->Init.CLK