[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2924: stm32: Update syscfg for timers

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #2924:
URL: https://github.com/apache/mynewt-core/pull/2924#issuecomment-1397998787

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer opened a new pull request, #2924: stm32: Update syscfg for timers

2023-01-19 Thread GitBox


kasjer opened a new pull request, #2924:
URL: https://github.com/apache/mynewt-core/pull/2924

   TIMER_3, TIMER_4 and TIMER_5 were referenced at code stm32_periph.c yet 
there were not definitions for them.
   This just adds missing definitions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397996704

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397991343

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_gatt_priv.h
   
   
   ```diff
   @@ -34,57 +34,57 @@
struct ble_att_prep_write_cmd;

STATS_SECT_START(ble_gattc_stats)
   -STATS_SECT_ENTRY(mtu)
   -STATS_SECT_ENTRY(mtu_fail)
   -STATS_SECT_ENTRY(disc_all_svcs)
   -STATS_SECT_ENTRY(disc_all_svcs_fail)
   -STATS_SECT_ENTRY(disc_svc_uuid)
   -STATS_SECT_ENTRY(disc_svc_uuid_fail)
   -STATS_SECT_ENTRY(find_inc_svcs)
   -STATS_SECT_ENTRY(find_inc_svcs_fail)
   -STATS_SECT_ENTRY(disc_all_chrs)
   -STATS_SECT_ENTRY(disc_all_chrs_fail)
   -STATS_SECT_ENTRY(disc_chrs_uuid)
   -STATS_SECT_ENTRY(disc_chrs_uuid_fail)
   -STATS_SECT_ENTRY(disc_all_dscs)
   -STATS_SECT_ENTRY(disc_all_dscs_fail)
   -STATS_SECT_ENTRY(read)
   -STATS_SECT_ENTRY(read_fail)
   -STATS_SECT_ENTRY(read_uuid)
   -STATS_SECT_ENTRY(read_uuid_fail)
   -STATS_SECT_ENTRY(read_long)
   -STATS_SECT_ENTRY(read_long_fail)
   -STATS_SECT_ENTRY(read_mult)
   -STATS_SECT_ENTRY(read_mult_fail)
   -STATS_SECT_ENTRY(write_no_rsp)
   -STATS_SECT_ENTRY(write_no_rsp_fail)
   -STATS_SECT_ENTRY(write)
   -STATS_SECT_ENTRY(write_fail)
   -STATS_SECT_ENTRY(write_long)
   -STATS_SECT_ENTRY(write_long_fail)
   -STATS_SECT_ENTRY(write_reliable)
   -STATS_SECT_ENTRY(write_reliable_fail)
   -STATS_SECT_ENTRY(notify)
   -STATS_SECT_ENTRY(notify_fail)
   -STATS_SECT_ENTRY(multi_notify)
   -STATS_SECT_ENTRY(multi_notify_fail)
   -STATS_SECT_ENTRY(indicate)
   -STATS_SECT_ENTRY(indicate_fail)
   -STATS_SECT_ENTRY(proc_timeout)
   +STATS_SECT_ENTRY(mtu)
   +STATS_SECT_ENTRY(mtu_fail)
   +STATS_SECT_ENTRY(disc_all_svcs)
   +STATS_SECT_ENTRY(disc_all_svcs_fail)
   +STATS_SECT_ENTRY(disc_svc_uuid)
   +STATS_SECT_ENTRY(disc_svc_uuid_fail)
   +STATS_SECT_ENTRY(find_inc_svcs)
   +STATS_SECT_ENTRY(find_inc_svcs_fail)
   +STATS_SECT_ENTRY(disc_all_chrs)
   +STATS_SECT_ENTRY(disc_all_chrs_fail)
   +STATS_SECT_ENTRY(disc_chrs_uuid)
   +STATS_SECT_ENTRY(disc_chrs_uuid_fail)
   +STATS_SECT_ENTRY(disc_all_dscs)
   +STATS_SECT_ENTRY(disc_all_dscs_fail)
   +STATS_SECT_ENTRY(read)
   +STATS_SECT_ENTRY(read_fail)
   +STATS_SECT_ENTRY(read_uuid)
   +STATS_SECT_ENTRY(read_uuid_fail)
   +STATS_SECT_ENTRY(read_long)
   +STATS_SECT_ENTRY(read_long_fail)
   +STATS_SECT_ENTRY(read_mult)
   +STATS_SECT_ENTRY(read_mult_fail)
   +STATS_SECT_ENTRY(write_no_rsp)
   +STATS_SECT_ENTRY(write_no_rsp_fail)
   +STATS_SECT_ENTRY(write)
   +STATS_SECT_ENTRY(write_fail)
   +STATS_SECT_ENTRY(write_long)
   +STATS_SECT_ENTRY(write_long_fail)
   +STATS_SECT_ENTRY(write_reliable)
   +STATS_SECT_ENTRY(write_reliable_fail)
   +STATS_SECT_ENTRY(notify)
   +STATS_SECT_ENTRY(notify_fail)
   +STATS_SECT_ENTRY(multi_notify)
   +STATS_SECT_ENTRY(multi_notify_fail)
   +STATS_SECT_ENTRY(indicate)
   +STATS_SECT_ENTRY(indicate_fail)
   +STATS_SECT_ENTRY(proc_timeout)
STATS_SECT_END
extern STATS_SECT_DECL(ble_gattc_stats) ble_gattc_stats;

STATS_SECT_START(ble_gatts_stats)
   -STATS_SECT_ENTRY(svcs)
   -STATS_SECT_ENTRY(chrs)
   -STATS_SECT_ENTRY(dscs)
   -STATS_SECT_ENTRY(svc_def_reads)
   -STATS_SECT_ENTRY(svc_inc_reads)
   -STATS_SECT_ENTRY(chr_def_reads)
   -STATS_SECT_ENTRY(chr_val_reads)
   -STATS_SECT_ENTRY(chr_val_writes)
   -STATS_SECT_ENTRY(dsc_reads)
   -STATS_SECT_ENTRY(dsc_writes)
   +STATS_SECT_ENTRY(svcs)
   +STATS_SECT_ENTRY(chrs)
   +STATS_SECT_ENTRY(dscs)
   +STATS_SECT_ENTRY(svc_def_reads)
   +STATS_SECT_ENTRY(svc_inc_reads)
   +STATS_SECT_ENTRY(chr_def_reads)
   +STATS_SECT_ENTRY(chr_val_reads)
   +STATS_SECT_ENTRY(chr_val_writes)
   +STATS_SECT_ENTRY(dsc_reads)
   +STATS_SECT_ENTRY(dsc_writes)
STATS_SECT_END
extern STATS_SECT_DECL(ble_gatts_stats) ble_gatts_stats;

   ```
   
   
   
    nimble/host/src/ble_gattc.c
   
   
   ```diff
   @@ -434,48 +434,48 @@
/* Statistics. */
STATS_SECT_DECL(ble_gattc_stats) ble_gattc_stats;
STATS_NAME_START(ble_gattc_stats)
   -STATS_NAME(ble_gattc_stats, mtu)
   -STATS_NAME(ble_gattc_stats, mtu_fail)
   -STATS_NAME(ble_gattc_stats, disc_all_svcs)
   -STATS_NAME(ble_gattc_stats, disc_all_svcs_fail)
   -STATS_NAME(ble_gattc_stats, disc_svc_uuid)
   -STATS_NAME(ble_gattc_stats, disc_svc_uuid_fail)
   -STATS_NAME(ble_gattc_stats, find_inc_svcs)
   -STATS_NAME(ble_gattc_stats, find_inc_svcs_fail)
   -STATS_NAME(ble_gattc_stats, disc_all_chrs)
   -STATS_NAME(ble_gattc_stats, disc_all_chrs_fail)
   -STATS_NAME(ble_gattc_stats, disc_chrs_uuid)
   -STATS_NAME(ble_gattc_stats, disc_chrs_uuid_fail)
   -STATS_NAME(ble_gattc_stats, disc_all_d

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397975025

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397965509

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_att.c
   
   
   ```diff
   @@ -78,61 +78,61 @@

STATS_SECT_DECL(ble_att_stats) ble_att_stats;
STATS_NAME_START(ble_att_stats)
   -STATS_NAME(ble_att_stats, error_rsp_rx)
   -STATS_NAME(ble_att_stats, error_rsp_tx)
   -STATS_NAME(ble_att_stats, mtu_req_rx)
   -STATS_NAME(ble_att_stats, mtu_req_tx)
   -STATS_NAME(ble_att_stats, mtu_rsp_rx)
   -STATS_NAME(ble_att_stats, mtu_rsp_tx)
   -STATS_NAME(ble_att_stats, find_info_req_rx)
   -STATS_NAME(ble_att_stats, find_info_req_tx)
   -STATS_NAME(ble_att_stats, find_info_rsp_rx)
   -STATS_NAME(ble_att_stats, find_info_rsp_tx)
   -STATS_NAME(ble_att_stats, find_type_value_req_rx)
   -STATS_NAME(ble_att_stats, find_type_value_req_tx)
   -STATS_NAME(ble_att_stats, find_type_value_rsp_rx)
   -STATS_NAME(ble_att_stats, find_type_value_rsp_tx)
   -STATS_NAME(ble_att_stats, read_type_req_rx)
   -STATS_NAME(ble_att_stats, read_type_req_tx)
   -STATS_NAME(ble_att_stats, read_type_rsp_rx)
   -STATS_NAME(ble_att_stats, read_type_rsp_tx)
   -STATS_NAME(ble_att_stats, read_req_rx)
   -STATS_NAME(ble_att_stats, read_req_tx)
   -STATS_NAME(ble_att_stats, read_rsp_rx)
   -STATS_NAME(ble_att_stats, read_rsp_tx)
   -STATS_NAME(ble_att_stats, read_blob_req_rx)
   -STATS_NAME(ble_att_stats, read_blob_req_tx)
   -STATS_NAME(ble_att_stats, read_blob_rsp_rx)
   -STATS_NAME(ble_att_stats, read_blob_rsp_tx)
   -STATS_NAME(ble_att_stats, read_mult_req_rx)
   -STATS_NAME(ble_att_stats, read_mult_req_tx)
   -STATS_NAME(ble_att_stats, read_mult_rsp_rx)
   -STATS_NAME(ble_att_stats, read_mult_rsp_tx)
   -STATS_NAME(ble_att_stats, read_group_type_req_rx)
   -STATS_NAME(ble_att_stats, read_group_type_req_tx)
   -STATS_NAME(ble_att_stats, read_group_type_rsp_rx)
   -STATS_NAME(ble_att_stats, read_group_type_rsp_tx)
   -STATS_NAME(ble_att_stats, write_req_rx)
   -STATS_NAME(ble_att_stats, write_req_tx)
   -STATS_NAME(ble_att_stats, write_rsp_rx)
   -STATS_NAME(ble_att_stats, write_rsp_tx)
   -STATS_NAME(ble_att_stats, prep_write_req_rx)
   -STATS_NAME(ble_att_stats, prep_write_req_tx)
   -STATS_NAME(ble_att_stats, prep_write_rsp_rx)
   -STATS_NAME(ble_att_stats, prep_write_rsp_tx)
   -STATS_NAME(ble_att_stats, exec_write_req_rx)
   -STATS_NAME(ble_att_stats, exec_write_req_tx)
   -STATS_NAME(ble_att_stats, exec_write_rsp_rx)
   -STATS_NAME(ble_att_stats, exec_write_rsp_tx)
   -STATS_NAME(ble_att_stats, notify_req_rx)
   -STATS_NAME(ble_att_stats, notify_req_tx)
   -STATS_NAME(ble_att_stats, indicate_req_rx)
   -STATS_NAME(ble_att_stats, indicate_req_tx)
   -STATS_NAME(ble_att_stats, indicate_rsp_rx)
   -STATS_NAME(ble_att_stats, indicate_rsp_tx)
   -STATS_NAME(ble_att_stats, multi_notify_req_rx)
   -STATS_NAME(ble_att_stats, write_cmd_rx)
   -STATS_NAME(ble_att_stats, write_cmd_tx)
   +STATS_NAME(ble_att_stats, error_rsp_rx)
   +STATS_NAME(ble_att_stats, error_rsp_tx)
   +STATS_NAME(ble_att_stats, mtu_req_rx)
   +STATS_NAME(ble_att_stats, mtu_req_tx)
   +STATS_NAME(ble_att_stats, mtu_rsp_rx)
   +STATS_NAME(ble_att_stats, mtu_rsp_tx)
   +STATS_NAME(ble_att_stats, find_info_req_rx)
   +STATS_NAME(ble_att_stats, find_info_req_tx)
   +STATS_NAME(ble_att_stats, find_info_rsp_rx)
   +STATS_NAME(ble_att_stats, find_info_rsp_tx)
   +STATS_NAME(ble_att_stats, find_type_value_req_rx)
   +STATS_NAME(ble_att_stats, find_type_value_req_tx)
   +STATS_NAME(ble_att_stats, find_type_value_rsp_rx)
   +STATS_NAME(ble_att_stats, find_type_value_rsp_tx)
   +STATS_NAME(ble_att_stats, read_type_req_rx)
   +STATS_NAME(ble_att_stats, read_type_req_tx)
   +STATS_NAME(ble_att_stats, read_type_rsp_rx)
   +STATS_NAME(ble_att_stats, read_type_rsp_tx)
   +STATS_NAME(ble_att_stats, read_req_rx)
   +STATS_NAME(ble_att_stats, read_req_tx)
   +STATS_NAME(ble_att_stats, read_rsp_rx)
   +STATS_NAME(ble_att_stats, read_rsp_tx)
   +STATS_NAME(ble_att_stats, read_blob_req_rx)
   +STATS_NAME(ble_att_stats, read_blob_req_tx)
   +STATS_NAME(ble_att_stats, read_blob_rsp_rx)
   +STATS_NAME(ble_att_stats, read_blob_rsp_tx)
   +STATS_NAME(ble_att_stats, read_mult_req_rx)
   +STATS_NAME(ble_att_stats, read_mult_req_tx)
   +STATS_NAME(ble_att_stats, read_mult_rsp_rx)
   +STATS_NAME(ble_att_stats, read_mult_rsp_tx)
   +STATS_NAME(ble_att_stats, read_group_type_req_rx)
   +STATS_NAME(ble_att_stats, read_group_type_req_tx)
   +STATS_NAME(ble_att_stats, read_group_type_rsp_rx)
   +STATS_NAME(ble_att_stats, read_group_type_rsp_tx)
   +STATS_NAME(ble_att_stats, write_req_rx)
   +STATS_NAME(ble_att_stats, write_req_tx)
   

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1432: Initial Github Action integration

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397737066

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1397695268

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1432: Initial Github Action integration

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397623248

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc commented on pull request #1432: Initial Github Action integration

2023-01-19 Thread GitBox


sjanc commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397621556

   verified locally with act


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1432: Initial Github Action integration

2023-01-19 Thread GitBox


sjanc opened a new pull request, #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432

   This adds:
- building all test targets on Linux
- runing 'newt test all'
- building dummy and Linux ports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc opened a new issue, #1431: Add RAT check similar to core checks

2023-01-19 Thread GitBox


sjanc opened a new issue, #1431:
URL: https://github.com/apache/mynewt-nimble/issues/1431

   Should be implemented after migration to GH Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc opened a new issue, #1430: Migrate from Travis to Github Actions

2023-01-19 Thread GitBox


sjanc opened a new issue, #1430:
URL: https://github.com/apache/mynewt-nimble/issues/1430

   - [ ] build test targets on Linux
   - [ ]  build test targets on Windows
   - [ ] build ports on Linux
   - [ ] style check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] sjanc opened a new issue, #2923: Migrate from Travis to Github Actions

2023-01-19 Thread GitBox


sjanc opened a new issue, #2923:
URL: https://github.com/apache/mynewt-core/issues/2923

   - [ ] newt test all
   - [ ] blinky build for all BSPs 
   - [ ] build test targets on Linux
   - [ ] build test targets on Windows
   - [ ] style check
   - [ ] RAT check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1429: nimble/ll: Add missing definition of min and max macros

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1429:
URL: https://github.com/apache/mynewt-nimble/pull/1429#issuecomment-1397221924

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1429: nimble/ll: Add missing definition of min and max macros

2023-01-19 Thread GitBox


sjanc opened a new pull request, #1429:
URL: https://github.com/apache/mynewt-nimble/pull/1429

   Those were removed from headers to avoid conflicts with C++. Until we 
convert codebase to MIN/MAX macros just define those where needed.
   
   This was affecting RIOT port.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] rymanluk commented on issue #1421: When using COC server and send is stalled, disconnects are not detected

2023-01-19 Thread GitBox


rymanluk commented on issue #1421:
URL: https://github.com/apache/mynewt-nimble/issues/1421#issuecomment-1397101306

   Do you possibly have any logs to share?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1397061936

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396809082

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396655797

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_att_clt.c
   
   
   ```diff
   @@ -908,8 +906,8 @@
}


/*
   - * $multi handle value notification 
 *
   - 
*/
   +* $multi handle value notification  
*
   
+*/

int
ble_att_clt_tx_multi_notify(uint16_t conn_handle, struct ble_gatt_hv 
*tuples,
   @@ -977,8 +975,8 @@
}


/*
   - * $handle value indication 
 *
   - 
*/
   +* $handle value indication  
*
   
+*/

int
ble_att_clt_tx_indicate(uint16_t conn_handle, uint16_t handle,
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2922: Initial Github Action integration

2023-01-19 Thread GitBox


apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1396583877

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] sjanc commented on pull request #2922: Initial Github Action integration

2023-01-19 Thread GitBox


sjanc commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1396582342

   tested locally with 'act'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org