[GitHub] [mynewt-newt] supervillain101 opened a new pull request, #518: Fixed issue where packages with the same sysinit value were odered in…
supervillain101 opened a new pull request, #518: URL: https://github.com/apache/mynewt-newt/pull/518 … non-deterministic and no longer lexicographic order -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-nimble] branch master updated: nimble/ll: Fix encryption start procedure
This is an automated email from the ASF dual-hosted git repository.
andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
The following commit(s) were added to refs/heads/master by this push:
new a60ee37b nimble/ll: Fix encryption start procedure
a60ee37b is described below
commit a60ee37b8ffa9f6c0a3e635480680069a0f351a9
Author: Andrzej Kaczmarek
AuthorDate: Tue May 23 15:04:50 2023 +0200
nimble/ll: Fix encryption start procedure
We need to update rx packet counter and direction bit after sending
LL_START_ENC_RSP in central role as otherwise we will fail to decrypt
LL_START_ENC_RSP from peripheral and will drop connection due to MIC
failure.
This only happens if peripheral replies with LL_START_ENC_RSP in the
next slot after we send LL_START_ENC_RSP. If peripheral replies with an
empty PDU instead, we will update direction bit on continuation and
decryption on rx will be successful.
---
nimble/controller/src/ble_ll_conn.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/nimble/controller/src/ble_ll_conn.c
b/nimble/controller/src/ble_ll_conn.c
index 78146f4f..a4e67241 100644
--- a/nimble/controller/src/ble_ll_conn.c
+++ b/nimble/controller/src/ble_ll_conn.c
@@ -1372,6 +1372,9 @@ conn_tx_pdu:
ble_phy_encrypt_iv_set(connsm->enc_data.iv);
ble_phy_encrypt_counter_set(connsm->enc_data.tx_pkt_cntr,
CONN_IS_CENTRAL(connsm));
+if (txend_func == NULL) {
+txend_func = ble_ll_conn_continue_rx_encrypt;
+}
} else if (is_ctrl && (opcode == BLE_LL_CTRL_START_ENC_REQ)) {
/*
* Only the peripheral sends this and it gets sent unencrypted but
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1505: nimble/ll: Fix encryption start procedure
andrzej-kaczmarek merged PR #1505: URL: https://github.com/apache/mynewt-nimble/pull/1505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] codecoup-tester commented on pull request #1505: nimble/ll: Fix encryption start procedure
codecoup-tester commented on PR #1505: URL: https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559460084 AutoPTS Bot results: No failed test found. Successful testsSM SM/CEN/JW/BI-04-C PASS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] codecoup-tester commented on pull request #1505: nimble/ll: Fix encryption start procedure
codecoup-tester commented on PR #1505: URL: https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559444680 Scheduled PR #https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559436705 after 16:00:26. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] mkasenberg commented on pull request #1505: nimble/ll: Fix encryption start procedure
mkasenberg commented on PR #1505: URL: https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559436705 #AutoPTS run mynewt SM/CEN/JW/BI-04-C -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] kasjer opened a new pull request, #2999: hw/ipc_nrf5340: Support for flexible memory sharing
kasjer opened a new pull request, #2999: URL: https://github.com/apache/mynewt-core/pull/2999 This adds easy way to add application specific shared memory regions that will be defined on application core and can be easily found on network core. This is done so linker scripts for network and application core does not have to be carefully synchronized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
