[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2413: STM32 RTC based os tick

2021-02-05 Thread GitBox 


apache-mynewt-bot commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-774317539


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2413: STM32 RTC based os tick

2020-11-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-731284061


   
   
   
   ## Style check summary
   
    No suggestions at this time!
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2413: STM32 RTC based os tick

2020-11-20 Thread GitBox 


apache-mynewt-bot commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-731283332


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/hal_os_tick.c
   
   
   ```diff
   @@ -81,7 +81,8 @@
#define IS_RTC_ENABLED (RCC->BDCR & RCC_BDCR_RTCEN)
#endif

   -_Static_assert(SUB_SECONDS_BITS == __builtin_popcount(SYNCH_PREDIV), 
"SUB_SECONDS_BITS should be number of 1s in SYNCH_PREDIV");
   +_Static_assert(SUB_SECONDS_BITS == __builtin_popcount(
   +SYNCH_PREDIV), "SUB_SECONDS_BITS should be number of 1s in 
SYNCH_PREDIV");

/* RTC time of the last tick. */
static uint32_t last_rtc_time;
   ```
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2413: STM32 RTC based os tick

2020-11-19 Thread GitBox 


apache-mynewt-bot commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-730683742


   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/stm/stm32_common/src/hal_os_tick.c
   
   
   ```diff
   @@ -81,7 +81,8 @@
#define IS_RTC_ENABLED (RCC->BDCR & RCC_BDCR_RTCEN)
#endif

   -_Static_assert(SUB_SECONDS_BITS == __builtin_popcount(SYNCH_PREDIV), 
"SUB_SECONDS_BITS should be number of 1s in SYNCH_PREDIV");
   +_Static_assert(SUB_SECONDS_BITS == __builtin_popcount(
   +SYNCH_PREDIV), "SUB_SECONDS_BITS should be number of 1s in 
SYNCH_PREDIV");

/* RTC time of the last tick. */
static uint32_t last_rtc_time;
   ```
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org