[GitHub] [mynewt-core] vrahane commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support
vrahane commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-672188586 @jipanienko Can you please approve it, addressed all the review comments! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support
vrahane commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670961427 @jipanienko Thanks for the in-depth review. Really appreciate it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support
vrahane commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670645358 I have fixed some of the coding style issues, others I think are supposed to be the way they are. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support
vrahane commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670280350 Others can review as well, I just wanted to add @wes3 and @ccollins476ad cause they know about it and helped me get through the hurdles This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support
vrahane commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670278594 I will squash all useless commits and keep only the useful ones. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
