[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #1549: nimble: [WIP] Eatt initial implementation
KKopyscinski commented on PR #1549: URL: https://github.com/apache/mynewt-nimble/pull/1549#issuecomment-1665447927 This was tested against PTS and implemented features are passing. After rebase some commits were added and some modified. Changes between rebase and current version can be seen here: https://gist.github.com/KKopyscinski/5ed12fe57bb457f21a8d98d2a84e0406 rebased version without these changes is here https://github.com/KKopyscinski/mynewt-nimble/tree/eatt_initial_rebase TODO: Add support for sending Multiple Handle Variable Length Notification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #1549: nimble: [WIP] Eatt initial implementation
KKopyscinski commented on PR #1549:
URL: https://github.com/apache/mynewt-nimble/pull/1549#issuecomment-1645187686
Found bug in Read Multiple Variable Length handling: implementation is OK,
but btshell must be changed.
Code seems copied from other read/write callbacks, but here format is
different. Response is single message with multiple tuples of {length, value}
pairs, that is up to MTU in size. If more should be returned, it's trimmed: so
we don't use `BLE_HS_EDONE` to mark final message, we will receive only one,
with success code of 0. `struct ble_gatt_attr *attr` points to the first
attreibute in list, and `num_handles` must be used to access the rest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #1549: nimble: [WIP] Eatt initial implementation
KKopyscinski commented on PR #1549: URL: https://github.com/apache/mynewt-nimble/pull/1549#issuecomment-1637907150 TODO: it may be worth checking `client_att_busy` flag reset after disconnection. Because `ble_gatt_conn_test_disconnect` tests only GATT API for broken connection (connection instance still exists) it probably should be done as separate test, maybe in GAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
