[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1263636722
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1263538105
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1262097981
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1262027479
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/transport/common/hci_ipc/src/hci_ipc.c
```diff
@@ -84,7 +84,7 @@
switch (sm->hdr.type) {
#if MYNEWT_VAL(BLE_CONTROLLER)
-case HCI_IPC_TYPE_CMD:
+case HCI_IPC_TYPE_CMD:
ble_transport_to_ll_cmd(sm->buf);
break;
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1261424400
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/transport/common/hci_ipc/src/hci_ipc.c
```diff
@@ -84,7 +84,7 @@
switch (sm->hdr.type) {
#if MYNEWT_VAL(BLE_CONTROLLER)
-case HCI_IPC_TYPE_CMD:
+case HCI_IPC_TYPE_CMD:
ble_transport_to_ll_cmd(sm->buf);
break;
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1260102087
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1260094540
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/transport/nrf5340/src/nrf5340_ble_hci.c
```diff
@@ -86,7 +86,7 @@
ble_transport_to_hs_evt_impl(void *buf)
{
uint8_t ind = HCI_IPC_TYPE_EVT;
-uint8_t* hci_ev = buf;
+uint8_t * hci_ev = buf;
int len = 2 + hci_ev[1];
int rc;
@@ -167,7 +167,7 @@
" cmp r1, #0 \n"
" bne 1b \n"
: [ret] "=" (ret)
- : [addr] "r"(num)
+ : [addr] "r" (num)
: "r1", "r2", "memory");
return ret;
@@ -183,6 +183,6 @@
" cmp r2, #0\n"
" bne 1b\n"
:
- : [addr] "r"(num)
+ : [addr] "r" (num)
: "r1", "r2", "memory");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
