[GitHub] mlampert commented on issue #947: Refactor/easing library
mlampert commented on issue #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#issuecomment-378403101 Can't claim I understand the rationale but it sounds like we don't want to move ahead with this change. I close the PR and we can create a new one once we know where we're going with this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mlampert commented on issue #947: Refactor/easing library
mlampert commented on issue #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#issuecomment-377616242 A general comment on the "precision" question. I love the library, use it all the time ever since the PR was posted the first time. Yet, as is it is IMHO not very practical because it's resource requirements are too high. The reason I started looking into this was because the output of `console` started to have pauses (in the middle of printing a word) when I used the library for a single LED. Having this library is insanely cool but I cannot afford 0.5-1ms execution times in a timer interrupt callback. Maybe I'm missing a use case here - is there one that requires `double` precision? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mlampert commented on issue #947: Refactor/easing library
mlampert commented on issue #947: Refactor/easing library URL: https://github.com/apache/mynewt-core/pull/947#issuecomment-375175612 The math is identical to the original implementation. Is there anything specific you're looking for? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
