[GitHub] vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer

2018-04-04 Thread GitBox 
vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus 
to read from input-buffer 
URL: https://github.com/apache/mynewt-core/pull/940#issuecomment-378788330
 
 
   Sounds good to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer

2018-04-04 Thread GitBox 
vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus 
to read from input-buffer 
URL: https://github.com/apache/mynewt-core/pull/940#issuecomment-378732631
 
 
   @ncasaril Yes, you are right there:
   
   >  I think I understand that it would need to be resolved to a port, but the 
same thing would then apply to the hal_i2c_init function? And also to the 
NRF_>PIN_CNF[] section above my change in hal_i2c_clear_bus, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer

2018-03-30 Thread GitBox 
vrahane commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus 
to read from input-buffer 
URL: https://github.com/apache/mynewt-core/pull/940#issuecomment-377584468
 
 
   @ncasaril hope you got what I mean in the above comment ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services