Re: [PR] Fix Coverity issues in mesh [mynewt-nimble]

[via GitHub]

github-advanced-security[bot] commented on code in PR #:
URL: https://github.com/apache/mynewt-nimble/pull/#discussion_r1510768677


##
nimble/host/mesh/src/testing.c:
##
@@ -123,18 +123,18 @@
console_printf("IV Index: %08lx\n", (long) bt_mesh.iv_index);
console_printf("Dev key: %s\n", bt_hex(bt_mesh.dev_key, 16));
 
-   for (i = 0; i < ARRAY_SIZE(bt_mesh_cdb.app_keys); ++i)
+   for (i = 0; i < ARRAY_SIZE(bt_mesh_cdb.subnets); ++i)

Review Comment:
   ## Comparison result is always the same
   
   Comparison is always false because i >= 0.
   
   [Show more 
details](https://github.com/apache/mynewt-nimble/security/code-scanning/83)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix Coverity issues in mesh [mynewt-nimble]

[via GitHub]

KKopyscinski commented on code in PR #:
URL: https://github.com/apache/mynewt-nimble/pull/#discussion_r1510739784


##
nimble/host/mesh/src/cfg_cli.c:
##
@@ -815,17 +815,13 @@ static int node_identity_status(struct bt_mesh_model 
*model,
}
 
status = net_buf_simple_pull_u8(buf);
-   net_idx = net_buf_simple_pull_le16(buf) & 0xfff;
+   net_buf_simple_pull_le16(buf);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix Coverity issues in mesh [mynewt-nimble]

[via GitHub]

rymanluk commented on code in PR #:
URL: https://github.com/apache/mynewt-nimble/pull/#discussion_r1510697349


##
nimble/host/mesh/src/cfg_cli.c:
##
@@ -815,17 +815,13 @@ static int node_identity_status(struct bt_mesh_model 
*model,
}
 
status = net_buf_simple_pull_u8(buf);
-   net_idx = net_buf_simple_pull_le16(buf) & 0xfff;
+   net_buf_simple_pull_le16(buf);

Review Comment:
   would be good to explain in commit message why this action is not necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org