Re: [PR] ci: Fix `Check ports syscfg update` workflow [mynewt-nimble]
sjanc merged PR #1812: URL: https://github.com/apache/mynewt-nimble/pull/1812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ci: Fix `Check ports syscfg update` workflow [mynewt-nimble]
wpiet opened a new pull request, #1812: URL: https://github.com/apache/mynewt-nimble/pull/1812 Amends incorrect relative path to the LICENSE_TEMPLATE file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ci: Fix Check ports syscfg update workflow [mynewt-nimble]
wpiet closed pull request #1716: ci: Fix Check ports syscfg update workflow URL: https://github.com/apache/mynewt-nimble/pull/1716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ci: Fix Check ports syscfg update workflow [mynewt-nimble]
wpiet commented on code in PR #1716: URL: https://github.com/apache/mynewt-nimble/pull/1716#discussion_r1521198384 ## .github/workflows/ports_syscfg_check.yml: ## @@ -58,15 +58,18 @@ jobs: run: | cd build ./repos/apache-mynewt-nimble/porting/update_generated_files.sh - cd repos/apache-mynewt-nimble + cd .. Review Comment: Agreed, but that was what @sjanc suggested for this script to be more future-proof. Should I remove these 'cd's at the end of each step? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ci: Fix Check ports syscfg update workflow [mynewt-nimble]
andrzej-kaczmarek commented on code in PR #1716: URL: https://github.com/apache/mynewt-nimble/pull/1716#discussion_r1509662478 ## .github/workflows/ports_syscfg_check.yml: ## @@ -58,15 +58,18 @@ jobs: run: | cd build ./repos/apache-mynewt-nimble/porting/update_generated_files.sh - cd repos/apache-mynewt-nimble + cd .. Review Comment: there's no point in changing working directory at the end of script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ci: Fix Check ports syscfg update workflow [mynewt-nimble]
wpiet opened a new pull request, #1716: URL: https://github.com/apache/mynewt-nimble/pull/1716 Changes the way 'cd' command is used, so it takes into account that each step is run in a separate shell instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
