Re: [PR] nimble/host:Handled error return value BLE_ERR_UNK_CONN_ID when encryption is enabled without distributing IRK. [mynewt-nimble]
abhi152 commented on code in PR #1620: URL: https://github.com/apache/mynewt-nimble/pull/1620#discussion_r1363844340 ## nimble/host/src/ble_gap.c: ## @@ -6062,6 +6063,9 @@ ble_gap_unpair(const ble_addr_t *peer_addr) ble_hs_pvcy_remove_entry(peer_addr->type, Review Comment: Thanks for your suggestion. So I have made further changes including above mentioned in this API and will update this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host:Handled error return value BLE_ERR_UNK_CONN_ID when encryption is enabled without distributing IRK. [mynewt-nimble]
sjanc commented on code in PR #1620: URL: https://github.com/apache/mynewt-nimble/pull/1620#discussion_r1363830318 ## nimble/host/src/ble_gap.c: ## @@ -6062,6 +6063,9 @@ ble_gap_unpair(const ble_addr_t *peer_addr) ble_hs_pvcy_remove_entry(peer_addr->type, Review Comment: looks like return value from ble_hs_pvcy_remove_entry() is never stored in rc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
