Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]
rahult-github commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-2100388705 Hello @sjanc , please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]
rahult-github commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-1985516657 > Hi, > > Does this fix any use of uninitialized memory or is just a precaution? > > As for style, please use sizeof(*foo) syntax Currently , just precaution, since i didn't find any issue as such during my testing. But in many places in nimble, such memset is already existing, hence added at places where it is missing. For style, sure, will change and re-push -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]
sjanc commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-1985497307 Hi, Does this fix any use of uninitialized memory or is just a precaution? As for style, please use sizeof(*foo) syntax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]
rahult-github commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-1958712231 @andrzej-kaczmarek , @sjanc , please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
