Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]
Singh-Sumeet commented on PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#issuecomment-1945658172 @sjanc PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] host/ble_iso.h: remove unused functions [mynewt-nimble]
KKopyscinski opened a new pull request, #1696: URL: https://github.com/apache/mynewt-nimble/pull/1696 ble_gap_rx_create_big_complete and ble_gap_rx_terminate_big_complete are a leftover from initial implementation and shall be removed. Correct, implemented funcions are ble_iso_rx_create_big_complete and ble_iso_rx_terminate_big_completem, in private API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(mynewt-nimble) branch master updated: host/ble_iso.h: remove unused functions
This is an automated email from the ASF dual-hosted git repository. kopyscinski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new b27535edb host/ble_iso.h: remove unused functions b27535edb is described below commit b27535edbc5f8e1bd60824fbe48c1de1014143ab Author: Krzysztof Kopyściński AuthorDate: Thu Feb 15 10:11:52 2024 +0100 host/ble_iso.h: remove unused functions ble_gap_rx_create_big_complete and ble_gap_rx_terminate_big_complete are a leftover from initial implementation and shall be removed. Correct, implemented funcions are ble_iso_rx_create_big_complete and ble_iso_rx_terminate_big_completem, in private API --- nimble/host/include/host/ble_iso.h | 8 1 file changed, 8 deletions(-) diff --git a/nimble/host/include/host/ble_iso.h b/nimble/host/include/host/ble_iso.h index 44877dca6..0d2ddbb11 100644 --- a/nimble/host/include/host/ble_iso.h +++ b/nimble/host/include/host/ble_iso.h @@ -109,14 +109,6 @@ int ble_iso_create_big(const struct ble_iso_create_big_params *create_params, int ble_iso_terminate_big(uint8_t big_id); -void -ble_gap_rx_create_big_complete(const struct - ble_hci_ev_le_subev_create_big_complete *ev); -void -ble_gap_rx_terminate_big_complete(const struct - ble_hci_ev_le_subev_terminate_big_complete - *ev); - int ble_iso_tx(uint16_t conn_handle, void *data, uint16_t data_len); int ble_iso_init(void);
Re: [PR] host/ble_iso.h: remove unused functions [mynewt-nimble]
KKopyscinski merged PR #1696: URL: https://github.com/apache/mynewt-nimble/pull/1696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]
andrzej-kaczmarek commented on code in PR #1668:
URL: https://github.com/apache/mynewt-nimble/pull/1668#discussion_r1490679313
##
nimble/host/include/host/ble_gap.h:
##
@@ -292,6 +295,19 @@ struct hci_conn_update;
/** @} */
+/**
+ * @defgroup GAP Authorize event possible responses.
+ * @{
+ */
+
+/** GAP Authorize event response: accept */
+#define BLE_GAP_AUTHORIZE_ACCEPT1
+
+/** GAP Authorize event response: reject */
+#define BLE_GAP_AUTHORIZE_REJECT2
Review Comment:
1. just return non-zero and this means reject
2. that's expected behavior, otherwise apps that do not have this event
handled would reject all requests which is not what we want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
