[GitHub] mkiiskila opened a new pull request #302: Oic update

2017-06-01 Thread git 
mkiiskila opened a new pull request #302: Oic update
URL: https://github.com/apache/incubator-mynewt-core/pull/302
 
 
   Mostly moving header files which are depended from outside net/oic to be 
under include/oic.
   Also minor bug fixes to BLE adapter and a dup-free of an mbuf in certain 
memory shortage situation.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed pull request #301: oic - Fix for missing 128-bit iotivity svc.

2017-06-01 Thread git 
ccollins476ad closed pull request #301: oic - Fix for missing 128-bit iotivity 
svc.
URL: https://github.com/apache/incubator-mynewt-core/pull/301
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad opened a new pull request #301: oic - Fix for missing 128-bit iotivity svc.

2017-06-01 Thread git 
ccollins476ad opened a new pull request #301: oic - Fix for missing 128-bit 
iotivity svc.
URL: https://github.com/apache/incubator-mynewt-core/pull/301
 
 
   Due to a typo in the BLE service definition array, the 16-bit Runtime
   UUID was overwriting the 128-bit iotivity UUID.
   
   Also, the Runtime characteristics were overwriting the iotivity value
   handle variables.  This caused notifications to be sent for the wrong
   characteristic.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rymanluk commented on a change in pull request #279: BLE Host - Policy for SM key overflow

2017-06-01 Thread git 
rymanluk commented on a change in pull request #279: BLE Host - Policy for SM 
key overflow
URL: 
https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r119708778
 
 

 ##
 File path: net/nimble/host/include/host/ble_store.h
 ##
 @@ -31,6 +31,12 @@ extern "C" {
 #define BLE_STORE_OBJ_TYPE_PEER_SEC 2
 #define BLE_STORE_OBJ_TYPE_CCCD 3
 
+/** Failed to persist record; insufficient storage capacity. */
+#define BLE_STORE_EVENT_OVERFLOW1
+
+/** About to execute a procedure that may fail due to overflow. */
+#define BLE_STORE_EVENT_OVERFLOW_NEXT   2
 
 Review comment:
   good point. somehow I forgot about that obj_type. So callback first checks 
event_type then looks into obj_type and then specific data.  You are right.. in 
this case it makes sense to have generic event_type.
   
   So maybe we can try to improve name: e.g.  BLE_STORE_EVENT_OVERFLOW_WARNING, 
BLE_STORE_EVENT_OVERFLOW_IS_COMING, BLE_STORE_EVENT_OVERFLOW_AHEAD, 
BLE_STORE_EVENT_POSSIBLE_OVERFLOW ? Not sure if any of this is better :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services