[GitHub] ccollins476ad closed pull request #65: MYNEWT-649 Validate target variable target set command.

[git]

ccollins476ad closed pull request #65: MYNEWT-649 Validate target variable 
target set command.
URL: https://github.com/apache/incubator-mynewt-newt/pull/65
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed pull request #306: Nosig armv7

[git]

ccollins476ad closed pull request #306: Nosig armv7
URL: https://github.com/apache/incubator-mynewt-core/pull/306
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed pull request #309: MYNEWT-760 Switch testbench app over to CoAP (from plain NMP)

[git]

ccollins476ad closed pull request #309: MYNEWT-760  Switch testbench app over 
to CoAP (from plain NMP)
URL: https://github.com/apache/incubator-mynewt-core/pull/309
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed pull request #310: Indicate custom

[git]

ccollins476ad closed pull request #310: Indicate custom
URL: https://github.com/apache/incubator-mynewt-core/pull/310
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane opened a new pull request #318: MYNEWT-681 remove flash write protection in download scripts

[git]

vrahane opened a new pull request #318: MYNEWT-681 remove flash write 
protection in download scripts 
URL: https://github.com/apache/incubator-mynewt-core/pull/318
 
 
   - removing write protection in download script by setting the write
 protection bits in the BPROT config registers. Also, setting the
 DISABLEINDEBUG register.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad opened a new pull request #317: mn_socket: Unix domain socket support.

[git]

ccollins476ad opened a new pull request #317: mn_socket: Unix domain socket 
support.
URL: https://github.com/apache/incubator-mynewt-core/pull/317
 
 
   This adds unix domain socket support to the mn_socket / native_sockets 
packages.  This is needed for blehostd.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] d3zd3z opened a new pull request #66: image: Add support for RSA-PSS signatures

[git]

d3zd3z opened a new pull request #66: image: Add support for RSA-PSS signatures
URL: https://github.com/apache/incubator-mynewt-newt/pull/66
 
 
   Currently, RSA signatures are done with PKCS#1 v1.5.  Newer versions of
   this standard (starting with 2.1) define a newer signing algorithm, PSS,
   and enourage adoption of this algorithm over the older method.
   
   Add support for this to the 'newt' tool so that create-image can sign
   RSA with PSS.  Since the keys are the same, add a command line argument
   `--rsa-pss` to use the new algorithm.  Once this is adopted more fully
   by the bootloader this could be made the default.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cwanda commented on issue #65: MYNEWT-649 Validate target variable target set command.

[git]

cwanda commented on issue #65: MYNEWT-649 Validate target variable target set 
command.
URL: 
https://github.com/apache/incubator-mynewt-newt/pull/65#issuecomment-306903446
 
 
   Hi Chris,
   Good catch. I added the space.  Thanks  for your reviews of all the newt prs.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane closed pull request #258: MYNEWT-744 SensorAPI: improvements

[git]

vrahane closed pull request #258: MYNEWT-744 SensorAPI: improvements
URL: https://github.com/apache/incubator-mynewt-core/pull/258
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane commented on a change in pull request #258: MYNEWT-744 SensorAPI: improvements

[git]

vrahane commented on a change in pull request #258: MYNEWT-744 SensorAPI: 
improvements
URL: 
https://github.com/apache/incubator-mynewt-core/pull/258#discussion_r120715999
 
 

 ##
 File path: apps/sensors_test/src/main.c
 ##
 @@ -182,6 +189,7 @@ sensor_oic_advertise(void)
 return;
 }
 
+#if 0
 
 Review comment:
   Removed, thanks for pointing it out. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane commented on a change in pull request #258: MYNEWT-744 SensorAPI: improvements

[git]

vrahane commented on a change in pull request #258: MYNEWT-744 SensorAPI: 
improvements
URL: 
https://github.com/apache/incubator-mynewt-core/pull/258#discussion_r120711292
 
 

 ##
 File path: hw/bsp/ruuvi_tag_revb2/src/hal_bsp.c
 ##
 @@ -187,71 +164,62 @@ hal_bsp_get_nvic_priority(int irq_num, uint32_t pri)
 return cfg_pri;
 }
 
-#if MYNEWT_VAL(LSM303DLHC_PRESENT) || MYNEWT_VAL(BNO055_PRESENT)
+/**
+ * BME280 Sensor default configuration used by the creator package
+ *
+ * @return 0 on success, non-zero on failure
+ */
+#if MYNEWT_VAL(BME280_ONB)
 static int
-accel_init(struct os_dev *dev, void *arg)
+config_bme280_sensor(void)
 {
-   return (0);
-}
-#endif
+int rc;
+struct os_dev *dev;
+struct bme280_cfg bmecfg;
 
-#if MYNEWT_VAL(TSL2561_PRESENT)
-static int
-slinky_light_init(struct os_dev *dev, void *arg)
-{
-return (0);
-}
-#endif
+dev = (struct os_dev *) os_dev_open("bme280_0", OS_TIMEOUT_NEVER, NULL);
+assert(dev != NULL);
 
-#if MYNEWT_VAL(TCS34725_PRESENT)
-static int
-color_init(struct os_dev *dev, void *arg)
-{
-return (0);
-}
-#endif
+if (!(dev->od_flags & OS_DEV_F_STATUS_READY)) {
+rc = SYS_EINVAL;
+goto err;
+}
 
-#if MYNEWT_VAL(BME280_PRESENT)
-static int
-press_init(struct os_dev *dev, void *arg)
-{
-return (0);
+memset(, 0, sizeof(bmecfg));
+
+bmecfg.bc_mode = BME280_MODE_NORMAL;
+bmecfg.bc_iir = BME280_FILTER_X16;
+bmecfg.bc_sby_dur = BME280_STANDBY_MS_0_5;
+bmecfg.bc_boc[0].boc_type = SENSOR_TYPE_RELATIVE_HUMIDITY;
+bmecfg.bc_boc[1].boc_type = SENSOR_TYPE_PRESSURE;
+bmecfg.bc_boc[2].boc_type = SENSOR_TYPE_AMBIENT_TEMPERATURE;
+bmecfg.bc_boc[0].boc_oversample = BME280_SAMPLING_X1;
+bmecfg.bc_boc[1].boc_oversample = BME280_SAMPLING_X16;
+bmecfg.bc_boc[2].boc_oversample = BME280_SAMPLING_X2;
+bmecfg.bc_s_mask = SENSOR_TYPE_AMBIENT_TEMPERATURE|
+   SENSOR_TYPE_PRESSURE|
+   SENSOR_TYPE_RELATIVE_HUMIDITY;
+
+rc = bme280_config((struct bme280 *)dev, );
+
+err:
+os_dev_close(dev);
+return rc;
 }
 #endif
 
 static void
 sensor_dev_create(void)
 {
 int rc;
-
 (void)rc;
-#if MYNEWT_VAL(LSM303DLHC_PRESENT)
-rc = os_dev_create((struct os_dev *) , "accel0",
-  OS_DEV_INIT_PRIMARY, 0, accel_init, NULL);
-assert(rc == 0);
-#endif
-
-#if MYNEWT_VAL(BNO055_PRESENT)
-rc = os_dev_create((struct os_dev *) , "accel1",
-  OS_DEV_INIT_PRIMARY, 0, accel_init, NULL);
-assert(rc == 0);
-#endif
 
-#if MYNEWT_VAL(TSL2561_PRESENT)
-rc = os_dev_create((struct os_dev *) , "light0",
-  OS_DEV_INIT_PRIMARY, 0, light_init, NULL);
-assert(rc == 0);
-#endif
-
-#if MYNEWT_VAL(TCS34725_PRESENT)
-rc = os_dev_create((struct os_dev *) , "color0",
-  OS_DEV_INIT_PRIMARY, 0, color_init, NULL);
+#if MYNEWT_VAL(BME280_ONB)
+rc = os_dev_create((struct os_dev *) , "bme280",
+  OS_DEV_INIT_PRIMARY, 0, bme280_init, (void *)_0_itf_bme);
 assert(rc == 0);
-#endif
 
-#if MYNEWT_VAL(BME280_PRESENT)
-rc = os_dev_create((struct os_dev *) , "bme280",
-  OS_DEV_INIT_PRIMARY, 0, press_init, NULL);
+rc = config_bme280_sensor();
 
 Review comment:
   The consensus was, there would be an initial config that happens at the bsp 
level. The user of the sensor can then go and re-config the sensor in the app 
if needed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wes3 closed pull request #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.

[git]

wes3 closed pull request #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.
URL: https://github.com/apache/incubator-mynewt-core/pull/314
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkiiskila commented on a change in pull request #306: Nosig armv7

[git]

mkiiskila commented on a change in pull request #306: Nosig armv7
URL: 
https://github.com/apache/incubator-mynewt-core/pull/306#discussion_r120698693
 
 

 ##
 File path: hw/bsp/native-armv7/include/bsp/bsp.h
 ##
 @@ -16,24 +16,32 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-#include 
-#include 
-#include 
-
-#include "os/os.h"
-#include "os_priv.h"
-
-void
-__assert_func(const char *file, int line, const char *func, const char *e)
-{
-char msg[256];
-
-if (file) {
-snprintf(msg, sizeof(msg), "assert at %s:%d\n", file, line);
-} else {
-snprintf(msg, sizeof(msg), "assert @ %p\n",
- __builtin_return_address(0));
-}
-write(1, msg, strlen(msg));
-_exit(1);
+
+#ifndef __NATIVE_ARMV7_BSP_H
+#define __NATIVE_ARMV7_BSP_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/* Define special stackos sections */
+#define sec_data_core
+#define sec_bss_core
+#define sec_bss_nz_core
+
+/* More convenient section placement macros. */
+#define bssnz_t
+
+/* LED pins */
+#define LED_BLINK_PIN   (0x1)
+
+/* UART info */
+#define CONSOLE_UART   "uart0"
 
 Review comment:
   Dont' forget to remove this line, and the other one in native-mips bsp when 
pull request #314 gets merged.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkiiskila commented on a change in pull request #258: MYNEWT-744 SensorAPI: improvements

[git]

mkiiskila commented on a change in pull request #258: MYNEWT-744 SensorAPI: 
improvements
URL: 
https://github.com/apache/incubator-mynewt-core/pull/258#discussion_r120697146
 
 

 ##
 File path: apps/sensors_test/src/main.c
 ##
 @@ -182,6 +189,7 @@ sensor_oic_advertise(void)
 return;
 }
 
+#if 0
 
 Review comment:
   If it's #if 0, maybe you should consider removing the code block altogether?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkiiskila commented on a change in pull request #258: MYNEWT-744 SensorAPI: improvements

[git]

mkiiskila commented on a change in pull request #258: MYNEWT-744 SensorAPI: 
improvements
URL: 
https://github.com/apache/incubator-mynewt-core/pull/258#discussion_r120697958
 
 

 ##
 File path: hw/bsp/ruuvi_tag_revb2/src/hal_bsp.c
 ##
 @@ -187,71 +164,62 @@ hal_bsp_get_nvic_priority(int irq_num, uint32_t pri)
 return cfg_pri;
 }
 
-#if MYNEWT_VAL(LSM303DLHC_PRESENT) || MYNEWT_VAL(BNO055_PRESENT)
+/**
+ * BME280 Sensor default configuration used by the creator package
+ *
+ * @return 0 on success, non-zero on failure
+ */
+#if MYNEWT_VAL(BME280_ONB)
 static int
-accel_init(struct os_dev *dev, void *arg)
+config_bme280_sensor(void)
 {
-   return (0);
-}
-#endif
+int rc;
+struct os_dev *dev;
+struct bme280_cfg bmecfg;
 
-#if MYNEWT_VAL(TSL2561_PRESENT)
-static int
-slinky_light_init(struct os_dev *dev, void *arg)
-{
-return (0);
-}
-#endif
+dev = (struct os_dev *) os_dev_open("bme280_0", OS_TIMEOUT_NEVER, NULL);
+assert(dev != NULL);
 
-#if MYNEWT_VAL(TCS34725_PRESENT)
-static int
-color_init(struct os_dev *dev, void *arg)
-{
-return (0);
-}
-#endif
+if (!(dev->od_flags & OS_DEV_F_STATUS_READY)) {
+rc = SYS_EINVAL;
+goto err;
+}
 
-#if MYNEWT_VAL(BME280_PRESENT)
-static int
-press_init(struct os_dev *dev, void *arg)
-{
-return (0);
+memset(, 0, sizeof(bmecfg));
+
+bmecfg.bc_mode = BME280_MODE_NORMAL;
+bmecfg.bc_iir = BME280_FILTER_X16;
+bmecfg.bc_sby_dur = BME280_STANDBY_MS_0_5;
+bmecfg.bc_boc[0].boc_type = SENSOR_TYPE_RELATIVE_HUMIDITY;
+bmecfg.bc_boc[1].boc_type = SENSOR_TYPE_PRESSURE;
+bmecfg.bc_boc[2].boc_type = SENSOR_TYPE_AMBIENT_TEMPERATURE;
+bmecfg.bc_boc[0].boc_oversample = BME280_SAMPLING_X1;
+bmecfg.bc_boc[1].boc_oversample = BME280_SAMPLING_X16;
+bmecfg.bc_boc[2].boc_oversample = BME280_SAMPLING_X2;
+bmecfg.bc_s_mask = SENSOR_TYPE_AMBIENT_TEMPERATURE|
+   SENSOR_TYPE_PRESSURE|
+   SENSOR_TYPE_RELATIVE_HUMIDITY;
+
+rc = bme280_config((struct bme280 *)dev, );
+
+err:
+os_dev_close(dev);
+return rc;
 }
 #endif
 
 static void
 sensor_dev_create(void)
 {
 int rc;
-
 (void)rc;
-#if MYNEWT_VAL(LSM303DLHC_PRESENT)
-rc = os_dev_create((struct os_dev *) , "accel0",
-  OS_DEV_INIT_PRIMARY, 0, accel_init, NULL);
-assert(rc == 0);
-#endif
-
-#if MYNEWT_VAL(BNO055_PRESENT)
-rc = os_dev_create((struct os_dev *) , "accel1",
-  OS_DEV_INIT_PRIMARY, 0, accel_init, NULL);
-assert(rc == 0);
-#endif
 
-#if MYNEWT_VAL(TSL2561_PRESENT)
-rc = os_dev_create((struct os_dev *) , "light0",
-  OS_DEV_INIT_PRIMARY, 0, light_init, NULL);
-assert(rc == 0);
-#endif
-
-#if MYNEWT_VAL(TCS34725_PRESENT)
-rc = os_dev_create((struct os_dev *) , "color0",
-  OS_DEV_INIT_PRIMARY, 0, color_init, NULL);
+#if MYNEWT_VAL(BME280_ONB)
+rc = os_dev_create((struct os_dev *) , "bme280",
+  OS_DEV_INIT_PRIMARY, 0, bme280_init, (void *)_0_itf_bme);
 assert(rc == 0);
-#endif
 
-#if MYNEWT_VAL(BME280_PRESENT)
-rc = os_dev_create((struct os_dev *) , "bme280",
-  OS_DEV_INIT_PRIMARY, 0, press_init, NULL);
+rc = config_bme280_sensor();
 
 Review comment:
   Sensor config is not done by the user of the sensor?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wes3 commented on issue #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.

[git]

wes3 commented on issue #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.
URL: 
https://github.com/apache/incubator-mynewt-core/pull/314#issuecomment-306847932
 
 
   Yes, there will be PRs for the other repos. Thanks for reminding me.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkiiskila commented on issue #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.

[git]

mkiiskila commented on issue #314: MYNEWT_689: Make CONSOLE_UART a syscfg 
variable.
URL: 
https://github.com/apache/incubator-mynewt-core/pull/314#issuecomment-306824665
 
 
   Is there going to be another PR against BSPs in arduino zero repo as well?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] francois-berder opened a new pull request #316: hw: mcu: pic32mz2048efg100: Implement hal_reset_cause

[git]

francois-berder opened a new pull request #316: hw: mcu: pic32mz2048efg100: 
Implement hal_reset_cause
URL: https://github.com/apache/incubator-mynewt-core/pull/316
 
 
   Tested on a Wi-Fire board the following resets: POR, Watchdog, EXTR (MCLR 
pin) and soft reset caused by hal_system_reset. I did not manage to cause a BOR 
reset.
   
   Signed-off-by: Francois Berder 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] utzig commented on issue #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.

[git]

utzig commented on issue #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.
URL: 
https://github.com/apache/incubator-mynewt-core/pull/314#issuecomment-306773774
 
 
   I just merged `stm32f7discovery` which will probably require those changes 
applied too.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] utzig closed pull request #315: BSP for STM32F7-Discovery board

[git]

utzig closed pull request #315: BSP for STM32F7-Discovery board
URL: https://github.com/apache/incubator-mynewt-core/pull/315
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonathanpallant opened a new pull request #315: BSP for STM32F7-Discovery board

[git]

jonathanpallant opened a new pull request #315: BSP for STM32F7-Discovery board
URL: https://github.com/apache/incubator-mynewt-core/pull/315
 
 
   See http://www.st.com/en/evaluation-tools/32f746gdiscovery.html
   
   LED blink and serial console (using VCP) tested OK.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services