[jira] [Commented] (NETBEANS-251) Generate hashCode/equals() throws NPE

2018-01-12 Thread Jan Lahoda (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325007#comment-16325007
 ] 

Jan Lahoda commented on NETBEANS-251:
-

Thanks, I can reproduce now. Seems the fix will be mostly removing some code 
(which is good), but this involves a weirdly attributed tree which I'd like to 
investigate a little.


> Generate hashCode/equals() throws NPE
> -
>
> Key: NETBEANS-251
> URL: https://issues.apache.org/jira/browse/NETBEANS-251
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Completion & Templates
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-159-on-20180102)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>Assignee: Jan Lahoda
>  Labels: regression
> Attachments: GenerateEqualsNPE.zip
>
>
> 1. Invoke Generate -> equals() and hashCode()
> 2. Select any field(s)
> 3. Click "Generate"
> 4. Exception thrown:
> {code}
> java.lang.NullPointerException
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.widthQ(WidthEstimator.java:92)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.width(WidthEstimator.java:76)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.visitSelect(WidthEstimator.java:262)
>   at 
> com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2110)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.estimateWidth(WidthEstimator.java:48)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitBinary(VeryPretty.java:1703)
>   at com.sun.tools.javac.tree.JCTree$JCBinary.accept(JCTree.java:1989)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printNoParenExpr(VeryPretty.java:2807)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitIf(VeryPretty.java:1391)
>   at com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1421)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStat(VeryPretty.java:2873)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStats(VeryPretty.java:2929)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:3011)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:2948)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitMethodDef(VeryPretty.java:1002)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.print(VeryPretty.java:276)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3936)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffClassDef(CasualDiff.java:1086)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5215)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5008)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3854)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTopLevel(CasualDiff.java:578)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5188)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5020)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diff(CasualDiff.java:346)
>   at 
> org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:907)
>   at 
>

[jira] [Assigned] (NETBEANS-251) Generate hashCode/equals() throws NPE

2018-01-12 Thread Jan Lahoda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Lahoda reassigned NETBEANS-251:
---

Assignee: Jan Lahoda

> Generate hashCode/equals() throws NPE
> -
>
> Key: NETBEANS-251
> URL: https://issues.apache.org/jira/browse/NETBEANS-251
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Completion & Templates
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-159-on-20180102)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>Assignee: Jan Lahoda
>  Labels: regression
> Attachments: GenerateEqualsNPE.zip
>
>
> 1. Invoke Generate -> equals() and hashCode()
> 2. Select any field(s)
> 3. Click "Generate"
> 4. Exception thrown:
> {code}
> java.lang.NullPointerException
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.widthQ(WidthEstimator.java:92)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.width(WidthEstimator.java:76)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.visitSelect(WidthEstimator.java:262)
>   at 
> com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2110)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.estimateWidth(WidthEstimator.java:48)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitBinary(VeryPretty.java:1703)
>   at com.sun.tools.javac.tree.JCTree$JCBinary.accept(JCTree.java:1989)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printNoParenExpr(VeryPretty.java:2807)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitIf(VeryPretty.java:1391)
>   at com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1421)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStat(VeryPretty.java:2873)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStats(VeryPretty.java:2929)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:3011)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:2948)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitMethodDef(VeryPretty.java:1002)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.print(VeryPretty.java:276)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3936)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffClassDef(CasualDiff.java:1086)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5215)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5008)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3854)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTopLevel(CasualDiff.java:578)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5188)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5020)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diff(CasualDiff.java:346)
>   at 
> org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:907)
>   at 
> org.netbeans.api.java.source.WorkingCopy.getChanges(WorkingCopy.java:1319)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:675)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)
>   at 
>

[jira] [Updated] (NETBEANS-279) Better code formatting and UI

2018-01-12 Thread Hyeonwoo O (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hyeonwoo O updated NETBEANS-279:

Description: 
Following are what I felt need improvements using NetBeans.

*[C/C++]*
1. Auto-completion doesn't work when I put text quickly.
2. Auto-completion for standard header files(<...>) doesn't work when I remove 
and write it again.
3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 'Run 
Project' button is disabled.

*[Java]*
1. I hope an option to active command prompt.(not floating 'Output' window)
2. Auto-completion for global variables and methods doesn't work.

*[General]*
1. Directory tree status isn't saved when restart NetBeans. Even I open some 
folders, IDE is always start with closed directory tree.
2. It would be better if auto-formatting for *spaces and braces* is supported 
when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
set my coding style with Options->Editor->Formatting option.
3. It would be better if there is a Project Group window dockable with Project 
browser.
4. Sometimes mark occurrence doesn't work correctly like attached image: There 
are same methods but some were not chosen.
5. Please make Welcome Page to be opened separately without other projects. And 
add an option to turn on/off Welcome Page. At first time I turn it off and I 
couldn't restore it anywhere.

I have more to write about but I'll end here. Since I am not an English user, 
so my expression may be slightly inaccurate. If so, I apologize.

  was:
Following are what I felt need improvements using NetBeans.

*[C/C++]*
1. Auto-completion doesn't work when I put text quickly.
2. Auto-completion for standard header files(<...>) doesn't work when I remove 
and write it again.
3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 'Run 
Project' button is disabled.

*[Java]*
1. I hope an option to active command prompt.(not floating 'Output' window)
2. Auto-completion for global variables and methods doesn't work.

*[General]*
1. Directory tree status isn't saved when restart NetBeans. Even I open some 
folders, IDE is always start with closed directory tree.
2. It would be better if auto-formatting for *spaces and braces* is supported 
when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
set my coding style with Options->Editor->Formatting option.
3. It would be better if there is a Project Group window dockable with Project 
browser.
4. Sometimes mark occurrence doesn't work correctly like attached image.
These are same methods but some were not chosen.
5. Please make Welcome Page to be opened separately without other projects. And 
add an option to turn on/off Welcome Page. At first time I turn it off and I 
couldn't restore it anywhere.

I have more to write about but I'll end here. Since I am not an English user, 
so my expression may be slightly inaccurate. If so, I apologize.


> Better code formatting and UI
> -
>
> Key: NETBEANS-279
> URL: https://issues.apache.org/jira/browse/NETBEANS-279
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Formatting & Indentation, ide - UI
>Affects Versions: 9.0
> Environment: Windows 10
>Reporter: Hyeonwoo O
>  Labels: features
> Fix For: 9.0
>
> Attachments: highlighting.png
>
>
> Following are what I felt need improvements using NetBeans.
> *[C/C++]*
> 1. Auto-completion doesn't work when I put text quickly.
> 2. Auto-completion for standard header files(<...>) doesn't work when I 
> remove and write it again.
> 3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 
> 'Run Project' button is disabled.
> *[Java]*
> 1. I hope an option to active command prompt.(not floating 'Output' window)
> 2. Auto-completion for global variables and methods doesn't work.
> *[General]*
> 1. Directory tree status isn't saved when restart NetBeans. Even I open some 
> folders, IDE is always start with closed directory tree.
> 2. It would be better if auto-formatting for *spaces and braces* is supported 
> when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
> set my coding style with Options->Editor->Formatting option.
> 3. It would be better if there is a Project Group window dockable with 
> Project browser.
> 4. Sometimes mark occurrence doesn't work correctly like attached image: 
> There are same methods but some were not chosen.
> 5. Please make Welcome Page to be opened separately without other projects. 
> And add an option to turn on/off Welcome Page. At first time I turn it off 
> and I couldn't restore it anywhere.
> I have more to write about but I'll end here. Since I am not an English user, 
> so my expression may be slightly inaccurate. If so, I apologize.



--
This

[jira] [Updated] (NETBEANS-279) Better code formatting and UI

2018-01-12 Thread Hyeonwoo O (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hyeonwoo O updated NETBEANS-279:

Description: 
Following are what I felt need improvements using NetBeans.

*[C/C++]*
1. Auto-completion doesn't work when I put text quickly.
2. Auto-completion for standard header files(<...>) doesn't work when I remove 
and write it again.
3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 'Run 
Project' button is disabled.

*[Java]*
1. I hope an option to active command prompt.(not floating 'Output' window)
2. Auto-completion for global variables and methods doesn't work.

*[General]*
1. Directory tree status isn't saved when restart NetBeans. Even I open some 
folders, IDE is always start with closed directory tree.
2. It would be better if auto-formatting for *spaces and braces* is supported 
when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
set my coding style with Options->Editor->Formatting option.
3. It would be better if there is a Project Group window dockable with Project 
browser.
4. Sometimes mark occurrence doesn't work correctly like attached image.
These are same methods but some were not chosen.
5. Please make Welcome Page to be opened separately without other projects. And 
add an option to turn on/off Welcome Page. At first time I turn it off and I 
couldn't restore it anywhere.

I have more to write about but I'll end here. Since I am not an English user, 
so my expression may be slightly inaccurate. If so, I apologize.

  was:
Following are what I felt need improvements using NetBeans.

*[C/C++]*
1. Auto-completion doesn't work when I put text quickly.
2. Auto-completion for standard header files(<...>) doesn't work when I remove 
and write it again.
3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 'Run 
Project' button is disabled.

*[Java]*
1. I hope an option to active command prompt.(not floating 'Output' window)
2. Auto-completion for global variables and methods doesn't work.

*[General]*
1. Directory tree status isn't saved when restart NetBeans. Even I open some 
folders, IDE is always start with closed directory tree.
2. It would be better if auto-formatting for *spaces and braces* is supported 
when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
set my coding style with Options->Editor->Formatting option.
3. It would be better if there is a Project Group window dockable with Project 
browser.
4. Sometimes mark occurrence doesn't work correctly like this:
!highlighting.png|thumbnail!
These are same methods but some were not chosen.
5. Please make Welcome Page to be opened separately without other projects. And 
add an option to turn on/off Welcome Page. At first time I turn it off and I 
couldn't restore it anywhere.

I have more to write about but I'll end here. Since I am not an English user, 
so my expression may be slightly inaccurate. If so, I apologize.


> Better code formatting and UI
> -
>
> Key: NETBEANS-279
> URL: https://issues.apache.org/jira/browse/NETBEANS-279
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Formatting & Indentation, ide - UI
>Affects Versions: 9.0
> Environment: Windows 10
>Reporter: Hyeonwoo O
>  Labels: features
> Fix For: 9.0
>
> Attachments: highlighting.png
>
>
> Following are what I felt need improvements using NetBeans.
> *[C/C++]*
> 1. Auto-completion doesn't work when I put text quickly.
> 2. Auto-completion for standard header files(<...>) doesn't work when I 
> remove and write it again.
> 3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 
> 'Run Project' button is disabled.
> *[Java]*
> 1. I hope an option to active command prompt.(not floating 'Output' window)
> 2. Auto-completion for global variables and methods doesn't work.
> *[General]*
> 1. Directory tree status isn't saved when restart NetBeans. Even I open some 
> folders, IDE is always start with closed directory tree.
> 2. It would be better if auto-formatting for *spaces and braces* is supported 
> when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
> set my coding style with Options->Editor->Formatting option.
> 3. It would be better if there is a Project Group window dockable with 
> Project browser.
> 4. Sometimes mark occurrence doesn't work correctly like attached image.
> These are same methods but some were not chosen.
> 5. Please make Welcome Page to be opened separately without other projects. 
> And add an option to turn on/off Welcome Page. At first time I turn it off 
> and I couldn't restore it anywhere.
> I have more to write about but I'll end here. Since I am not an English user, 
> so my expression may be slightly inaccurate. If so, I apologize.

[jira] [Created] (NETBEANS-279) Better code formatting and UI

2018-01-12 Thread Hyeonwoo O (JIRA) 
Hyeonwoo O created NETBEANS-279:
---

 Summary: Better code formatting and UI
 Key: NETBEANS-279
 URL: https://issues.apache.org/jira/browse/NETBEANS-279
 Project: NetBeans
  Issue Type: Improvement
  Components: editor - Formatting & Indentation, ide - UI
Affects Versions: 9.0
 Environment: Windows 10
Reporter: Hyeonwoo O
 Fix For: 9.0
 Attachments: highlighting.png

Following are what I felt need improvements using NetBeans.

*[C/C++]*
1. Auto-completion doesn't work when I put text quickly.
2. Auto-completion for standard header files(<...>) doesn't work when I remove 
and write it again.
3. When NetBeans is opened with C/C++ project or changing to C/C++ group, 'Run 
Project' button is disabled.

*[Java]*
1. I hope an option to active command prompt.(not floating 'Output' window)
2. Auto-completion for global variables and methods doesn't work.

*[General]*
1. Directory tree status isn't saved when restart NetBeans. Even I open some 
folders, IDE is always start with closed directory tree.
2. It would be better if auto-formatting for *spaces and braces* is supported 
when I put a semicolon or press enter key.(like Visual Studio) It is hard to 
set my coding style with Options->Editor->Formatting option.
3. It would be better if there is a Project Group window dockable with Project 
browser.
4. Sometimes mark occurrence doesn't work correctly like this:
!highlighting.png|thumbnail!
These are same methods but some were not chosen.
5. Please make Welcome Page to be opened separately without other projects. And 
add an option to turn on/off Welcome Page. At first time I turn it off and I 
couldn't restore it anywhere.

I have more to write about but I'll end here. Since I am not an English user, 
so my expression may be slightly inaccurate. If so, I apologize.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-278) Erroneous "The array is only written to, never read from" warning

2018-01-12 Thread Daniel Trebbien (JIRA) 
Daniel Trebbien created NETBEANS-278:


 Summary: Erroneous "The array is only written to, never read from" 
warning
 Key: NETBEANS-278
 URL: https://issues.apache.org/jira/browse/NETBEANS-278
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Reporter: Daniel Trebbien


Test case:

{code:java}
package hintstest;

import java.util.Map;

public class MismatchedReadAndWriteOfArrayTest {
public void test(Map map, Object k) {
int[] iarr = map.get(k);
iarr[0] = -1;
}
}
{code}

A warning is shown on the declaration of {{iarr}}. However, I think that the 
warning is incorrect because, although {{iarr}} might not be read from within 
test(), we don't know whether the {{int}} array will be retrieved from the map 
and read from elsewhere.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-252) Code Generator unable to add method to enum constants

2018-01-12 Thread Daniel Trebbien (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324850#comment-16324850
 ] 

Daniel Trebbien commented on NETBEANS-252:
--

I created PR 364 to fix this issue: 
https://github.com/apache/incubator-netbeans/pull/364

> Code Generator unable to add method to enum constants
> -
>
> Key: NETBEANS-252
> URL: https://issues.apache.org/jira/browse/NETBEANS-252
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Reporter: Jan Lahoda
>Assignee: Jan Lahoda
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Based on:
> https://netbeans.org/bugzilla/show_bug.cgi?id=271633
> reported by [~cowwoc]
> Consider code like this:
> ---
> package javaapplication1;
> public enum E {
> A
> {
> };
> }
> ---
> Place the caret between the { } of the enum constant, invoke code completion 
> and try to override toString(). This will fail, and the method won't be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-252) Code Generator unable to add method to enum constants

2018-01-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-252:

Labels: pull-request-available  (was: )

> Code Generator unable to add method to enum constants
> -
>
> Key: NETBEANS-252
> URL: https://issues.apache.org/jira/browse/NETBEANS-252
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Reporter: Jan Lahoda
>Assignee: Jan Lahoda
>  Labels: pull-request-available
>
> Based on:
> https://netbeans.org/bugzilla/show_bug.cgi?id=271633
> reported by [~cowwoc]
> Consider code like this:
> ---
> package javaapplication1;
> public enum E {
> A
> {
> };
> }
> ---
> Place the caret between the { } of the enum constant, invoke code completion 
> and try to override toString(). This will fail, and the method won't be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Vieiro updated NETBEANS-276:

Attachment: diff.txt

Differences file

{noformat}
incubator-netbeans$ diff -r . ../incubating > diff.txt
{noformat}


> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>Priority: Blocker
> Attachments: diff.txt
>
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324636#comment-16324636
 ] 

Antonio Vieiro commented on NETBEANS-276:
-


{noformat}

incubator-netbeans$ diff LICENSE ../incubating/LICENSE 
1,204c1,203
< /*
<  * Apache License
<  *   Version 2.0, January 2004
<  *http://www.apache.org/licenses/
<  *
[...]
> 
>  Apache License
>Version 2.0, January 2004
> http://www.apache.org/licenses/
> 
[...]

{noformat}

i.e, trailing "*" at the beginning of lines

> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>Priority: Blocker
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324632#comment-16324632
 ] 

Antonio Vieiro commented on NETBEANS-276:
-

NOTICE file diff

{noformat}
antonio@cernicalo:~/tmp/incubator-netbeans$ diff NOTICE ../incubating/NOTICE
2c2
< Copyright 2017-2017 The Apache Software Foundation
---
> Copyright 2017-2018 The Apache Software Foundation
7,8c7,13
< The code is based on NetBeans Copyright (c) Oracle Corp
< that has been kindly donated to the Apache Software Foundation.
\ No newline at end of file
---
> The code is based on NetBeans, that has been kindly donated to the Apache
> Software Foundation by Oracle.  
> 
> The code was Copyright 1997-2016 Oracle and/or its affiliates.  The Initial
> Developer of the Original Software was Sun Microsystems, Inc. Portions
> Copyright 1997-2006 Sun Microsystems, Inc. 
> 
{noformat}


> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>Priority: Blocker
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Comment Edited] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324632#comment-16324632
 ] 

Antonio Vieiro edited comment on NETBEANS-276 at 1/12/18 10:18 PM:
---

NOTICE file diff

{noformat}
incubator-netbeans$ diff NOTICE ../incubating/NOTICE
2c2
< Copyright 2017-2017 The Apache Software Foundation
---
> Copyright 2017-2018 The Apache Software Foundation
7,8c7,13
< The code is based on NetBeans Copyright (c) Oracle Corp
< that has been kindly donated to the Apache Software Foundation.
\ No newline at end of file
---
> The code is based on NetBeans, that has been kindly donated to the Apache
> Software Foundation by Oracle.  
> 
> The code was Copyright 1997-2016 Oracle and/or its affiliates.  The Initial
> Developer of the Original Software was Sun Microsystems, Inc. Portions
> Copyright 1997-2006 Sun Microsystems, Inc. 
> 
{noformat}



was (Author: vieiro):
NOTICE file diff

{noformat}
antonio@cernicalo:~/tmp/incubator-netbeans$ diff NOTICE ../incubating/NOTICE
2c2
< Copyright 2017-2017 The Apache Software Foundation
---
> Copyright 2017-2018 The Apache Software Foundation
7,8c7,13
< The code is based on NetBeans Copyright (c) Oracle Corp
< that has been kindly donated to the Apache Software Foundation.
\ No newline at end of file
---
> The code is based on NetBeans, that has been kindly donated to the Apache
> Software Foundation by Oracle.  
> 
> The code was Copyright 1997-2016 Oracle and/or its affiliates.  The Initial
> Developer of the Original Software was Sun Microsystems, Inc. Portions
> Copyright 1997-2006 Sun Microsystems, Inc. 
> 
{noformat}


> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>Priority: Blocker
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-277) NPE at org.netbeans.modules.java.editor.imports.FastImportAction$1.run(FastImportAction.java:100)

2018-01-12 Thread Gili (JIRA) 
Gili created NETBEANS-277:
-

 Summary: NPE at 
org.netbeans.modules.java.editor.imports.FastImportAction$1.run(FastImportAction.java:100)
 Key: NETBEANS-277
 URL: https://issues.apache.org/jira/browse/NETBEANS-277
 Project: NetBeans
  Issue Type: Bug
  Components: java - Source
 Environment: Product Version: Apache NetBeans IDE Dev (Build 
20180106-unknown-revn)
Updates: Updates available
Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
Runtime: Java(TM) SE Runtime Environment 9.0.1+11
System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
Reporter: Gili
 Attachments: TradeStream.java

1. Open attached file.
2. Position caret on the first word of line 79 ("BigDecimal")
3. Hit ALT+SHIFT+I
4. Exception thrown:

{code}
java.lang.NullPointerException
at 
javax.lang.model.util.ElementFilter.listFilter(ElementFilter.java:216)
at javax.lang.model.util.ElementFilter.typesIn(ElementFilter.java:154)
at 
org.netbeans.modules.java.editor.imports.FastImportAction$1.run(FastImportAction.java:100)
at 
org.netbeans.modules.java.editor.imports.FastImportAction$1.run(FastImportAction.java:90)
at 
org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:501)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
at 
org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
at 
org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
at 
org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
at 
org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
at 
org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
at 
org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
at 
org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:451)
at 
org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:422)
at 
org.netbeans.modules.java.editor.imports.FastImportAction$2.run(FastImportAction.java:126)
at 
org.netbeans.modules.progress.ui.RunOffEDTImpl$1.run(RunOffEDTImpl.java:146)
at 
org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
at 
org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
at 
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
Caused: org.openide.util.RequestProcessor$SlowItem: task failed due to
at org.openide.util.RequestProcessor.post(RequestProcessor.java:395)
at 
org.netbeans.modules.progress.ui.RunOffEDTImpl.runOffEventDispatchThreadImpl(RunOffEDTImpl.java:140)
at 
org.netbeans.modules.progress.ui.RunOffEDTImpl.runOffEventDispatchThread(RunOffEDTImpl.java:83)
at 
org.netbeans.api.progress.BaseProgressUtils.runOffEventDispatchThread(BaseProgressUtils.java:90)
at 
org.netbeans.api.progress.ProgressUtils.runOffEventDispatchThread(ProgressUtils.java:67)
at 
org.netbeans.modules.java.editor.imports.FastImportAction.actionPerformed(FastImportAction.java:122)
at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:322)
at 
java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1805)
at 
java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2901)
at 
java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2949)
at 
java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2863)
at java.desktop/java.awt.Component.processEvent(Component.java:6355)
at java.desktop/java.awt.Container.processEvent(Container.java:2259)
at 
java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4961)
at 
java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2317)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4793)
at 
java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1955)
at

[jira] [Commented] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324630#comment-16324630
 ] 

Antonio Vieiro commented on NETBEANS-276:
-

The ant task used to build this must be corrected. I'll be adding more comments 
in a minute.

> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>Priority: Blocker
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Comment Edited] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Geertjan Wielenga (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324626#comment-16324626
 ] 

Geertjan Wielenga edited comment on NETBEANS-276 at 1/12/18 10:16 PM:
--

I confirm this is correct, i.e., these are included and should not be. What 
needs to change to fix this?


was (Author: geertjanwielenga):
I confirm this is correct. What needs to change to fix this?

> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Vieiro updated NETBEANS-276:

Priority: Blocker  (was: Major)

> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>Priority: Blocker
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Geertjan Wielenga (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324626#comment-16324626
 ] 

Geertjan Wielenga commented on NETBEANS-276:


I confirm this is correct. What needs to change to fix this?

> Binaries wrongly included in source zip
> ---
>
> Key: NETBEANS-276
> URL: https://issues.apache.org/jira/browse/NETBEANS-276
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Antonio Vieiro
>
> The task that builds the zip file includes wrong jars.
> See [the mailing list for more 
> info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]
> Differences are:
> incubator-netbeans$ diff -qr . ../extracted-source-files
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in .: .travis.yml
> Only in ../incubating: DEPENDENCIES
> Files ./LICENSE and ../incubating/LICENSE differ
> Files ./NOTICE and ../incubating/NOTICE differ
> Only in .: form.binding
> Only in .: hibernate
> Only in .: hibernate4lib
> Only in ../incubating/javahelp/external: jhall-2.0_05.jar
> Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
> Only in ../incubating/libs.junit4/external: junit-4.12.jar
> Only in .: libs.svnClientAdapter.svnkit
> Only in ../incubating/nbbuild: build
> Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
> Only in ../incubating/nbbuild/external: apitest.jar
> Only in ../incubating/nbbuild/external: langtools-9.zip
> Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
> Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
> Only in .: o.jdesktop.beansbinding
> Only in .: travis-check-line-endings.sh



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-276) Binaries wrongly included in source zip

2018-01-12 Thread Antonio Vieiro (JIRA) 
Antonio Vieiro created NETBEANS-276:
---

 Summary: Binaries wrongly included in source zip
 Key: NETBEANS-276
 URL: https://issues.apache.org/jira/browse/NETBEANS-276
 Project: NetBeans
  Issue Type: Bug
Reporter: Antonio Vieiro


The task that builds the zip file includes wrong jars.

See [the mailing list for more 
info|http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201801.mbox/browser]

Differences are:

incubator-netbeans$ diff -qr . ../extracted-source-files
Only in .: .git
Only in .: .gitattributes
Only in .: .gitignore
Only in .: .travis.yml
Only in ../incubating: DEPENDENCIES
Files ./LICENSE and ../incubating/LICENSE differ
Files ./NOTICE and ../incubating/NOTICE differ
Only in .: form.binding
Only in .: hibernate
Only in .: hibernate4lib
Only in ../incubating/javahelp/external: jhall-2.0_05.jar
Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
Only in ../incubating/libs.junit4/external: junit-4.12.jar
Only in .: libs.svnClientAdapter.svnkit
Only in ../incubating/nbbuild: build
Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
Only in ../incubating/nbbuild/external: apitest.jar
Only in ../incubating/nbbuild/external: langtools-9.zip
Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
Only in .: o.jdesktop.beansbinding
Only in .: travis-check-line-endings.sh




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-274) Make more JPA implementations available as library

2018-01-12 Thread Karl Richter (JIRA) 
Karl Richter created NETBEANS-274:
-

 Summary: Make more JPA implementations available as library
 Key: NETBEANS-274
 URL: https://issues.apache.org/jira/browse/NETBEANS-274
 Project: NetBeans
  Issue Type: Improvement
  Components: javaee - Persistence
Affects Versions: 9.0
Reporter: Karl Richter


By default only EclipseLink is available in the choice of persistence libraries 
of a persistence unit. The auto-completion of the `provider` element seems to 
be limited to the set of libraries. It'd be nice to have support for well-known 
implementations like Hibernate ORM and Apache OpenJPA.

experienced with 9.0-beta-rc1-4-g2b21706d8



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-251) Generate hashCode/equals() throws NPE

2018-01-12 Thread Gili (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324425#comment-16324425
 ] 

Gili commented on NETBEANS-251:
---

Agreed. I see the same.

> Generate hashCode/equals() throws NPE
> -
>
> Key: NETBEANS-251
> URL: https://issues.apache.org/jira/browse/NETBEANS-251
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Completion & Templates
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-159-on-20180102)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>  Labels: regression
> Attachments: GenerateEqualsNPE.zip
>
>
> 1. Invoke Generate -> equals() and hashCode()
> 2. Select any field(s)
> 3. Click "Generate"
> 4. Exception thrown:
> {code}
> java.lang.NullPointerException
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.widthQ(WidthEstimator.java:92)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.width(WidthEstimator.java:76)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.visitSelect(WidthEstimator.java:262)
>   at 
> com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2110)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.estimateWidth(WidthEstimator.java:48)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitBinary(VeryPretty.java:1703)
>   at com.sun.tools.javac.tree.JCTree$JCBinary.accept(JCTree.java:1989)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printNoParenExpr(VeryPretty.java:2807)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitIf(VeryPretty.java:1391)
>   at com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1421)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStat(VeryPretty.java:2873)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStats(VeryPretty.java:2929)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:3011)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:2948)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitMethodDef(VeryPretty.java:1002)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.print(VeryPretty.java:276)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3936)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffClassDef(CasualDiff.java:1086)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5215)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5008)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3854)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTopLevel(CasualDiff.java:578)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5188)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5020)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diff(CasualDiff.java:346)
>   at 
> org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:907)
>   at 
> org.netbeans.api.java.source.WorkingCopy.getChanges(WorkingCopy.java:1319)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:675)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)
>   at 
>

[incubator-netbeans] 01/01: Merge pull request #357 from matthiasblaesing/issue-250

2018-01-12 Thread matthiasblaesing 
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git

commit 2b21706d814a873d2626f409ed3d699b8e9a395d
Merge: 2e845bc 09afffa
Author: Matthias Bläsing 
AuthorDate: Fri Jan 12 19:59:19 2018 +0100

Merge pull request #357 from matthiasblaesing/issue-250

[NETBEANS-250] Code-complete corrupts pom.xml when updating dependency 
version

 .../xml/text/completion/XMLCompletionQuery.java| 12 ++---
 .../text/completion/XMLCompletionQueryTest.java| 59 ++
 .../text/completion/res/docResourceUnclosed.html   | 22 
 3 files changed, 87 insertions(+), 6 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
"commits@netbeans.apache.org" .

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[incubator-netbeans] branch master updated (2e845bc -> 2b21706)

2018-01-12 Thread matthiasblaesing 
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git.


from 2e845bc  Merge pull request #360 from ebarboni/patch-1
 add 09afffa  [NETBEANS-250] Code-complete corrupts pom.xml when updating 
dependency version
 new 2b21706  Merge pull request #357 from matthiasblaesing/issue-250

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../xml/text/completion/XMLCompletionQuery.java| 12 ++---
 .../text/completion/XMLCompletionQueryTest.java| 59 ++
 .../text/completion/res/docResourceUnclosed.html   |  9 +---
 3 files changed, 67 insertions(+), 13 deletions(-)
 create mode 100644 
xml.text/test/unit/src/org/netbeans/modules/xml/text/completion/XMLCompletionQueryTest.java
 copy api.java/src/org/netbeans/spi/java/queries/package.html => 
xml.text/test/unit/src/org/netbeans/modules/xml/text/completion/res/docResourceUnclosed.html
 (85%)

-- 
To stop receiving notification emails like this one, please contact
['"commits@netbeans.apache.org" '].

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[incubator-netbeans] 01/01: Merge pull request #360 from ebarboni/patch-1

2018-01-12 Thread matthiasblaesing 
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git

commit 2e845bc9182fcb2d454a175111800a1d207d6edc
Merge: dd5eb86 c311bbe
Author: Matthias Bläsing 
AuthorDate: Fri Jan 12 19:04:06 2018 +0100

Merge pull request #360 from ebarboni/patch-1

ignore build artifacts nbbuild/nbms

 .gitignore | 1 +
 1 file changed, 1 insertion(+)

-- 
To stop receiving notification emails like this one, please contact
"commits@netbeans.apache.org" .

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[incubator-netbeans] branch master updated (dd5eb86 -> 2e845bc)

2018-01-12 Thread matthiasblaesing 
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git.


from dd5eb86  Merge pull request #346 from jherkel/master
 add c311bbe  ignore nbbuild/nbms
 new 2e845bc  Merge pull request #360 from ebarboni/patch-1

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

-- 
To stop receiving notification emails like this one, please contact
['"commits@netbeans.apache.org" '].

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Commented] (NETBEANS-251) Generate hashCode/equals() throws NPE

2018-01-12 Thread Geertjan Wielenga (JIRA) 

[ 
https://issues.apache.org/jira/browse/NETBEANS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323939#comment-16323939
 ] 

Geertjan Wielenga commented on NETBEANS-251:


I can reproduce with the attached project.

> Generate hashCode/equals() throws NPE
> -
>
> Key: NETBEANS-251
> URL: https://issues.apache.org/jira/browse/NETBEANS-251
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Completion & Templates
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-159-on-20180102)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>  Labels: regression
> Attachments: GenerateEqualsNPE.zip
>
>
> 1. Invoke Generate -> equals() and hashCode()
> 2. Select any field(s)
> 3. Click "Generate"
> 4. Exception thrown:
> {code}
> java.lang.NullPointerException
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.widthQ(WidthEstimator.java:92)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.width(WidthEstimator.java:76)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.visitSelect(WidthEstimator.java:262)
>   at 
> com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2110)
>   at 
> org.netbeans.modules.java.source.pretty.WidthEstimator.estimateWidth(WidthEstimator.java:48)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitBinary(VeryPretty.java:1703)
>   at com.sun.tools.javac.tree.JCTree$JCBinary.accept(JCTree.java:1989)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printNoParenExpr(VeryPretty.java:2807)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitIf(VeryPretty.java:1391)
>   at com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1421)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printExpr(VeryPretty.java:2816)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStat(VeryPretty.java:2873)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printStats(VeryPretty.java:2929)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:3011)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.printBlock(VeryPretty.java:2948)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.visitMethodDef(VeryPretty.java:1002)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.doAccept(VeryPretty.java:407)
>   at 
> org.netbeans.modules.java.source.pretty.VeryPretty.print(VeryPretty.java:276)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3936)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffClassDef(CasualDiff.java:1086)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5215)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5008)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffList(CasualDiff.java:3854)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTopLevel(CasualDiff.java:578)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl0(CasualDiff.java:5188)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTreeImpl(CasualDiff.java:5109)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5037)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diffTree(CasualDiff.java:5020)
>   at 
> org.netbeans.modules.java.source.save.CasualDiff.diff(CasualDiff.java:346)
>   at 
> org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:907)
>   at 
> org.netbeans.api.java.source.WorkingCopy.getChanges(WorkingCopy.java:1319)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:675)
>   at

[jira] [Created] (NETBEANS-273) Problems adding module deps in NetBeans Module projects

2018-01-12 Thread Geertjan Wielenga (JIRA) 
Geertjan Wielenga created NETBEANS-273:
--

 Summary: Problems adding module deps in NetBeans Module projects
 Key: NETBEANS-273
 URL: https://issues.apache.org/jira/browse/NETBEANS-273
 Project: NetBeans
  Issue Type: Bug
Reporter: Geertjan Wielenga


1. Build 9.0 Beta rc1.
2. Start it up (in my case on JDK 8, then install nb-javac).
3. Create new NetBeans module project from New Project wizard.
4. Use New Window wizard, enter values, click Finish.
5. Import statements are not resolved because certain dependencies have not 
been automatically added.
5. One of these is Settings API. When trying to add manually, fails, message: 
"Adding project Settings API as dependency would introduce cyclic dependency! 
Dependency was not added."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-271) Caret in Watch window renders in wrong position

2018-01-12 Thread Gili (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gili updated NETBEANS-271:
--
Description: 
This is a regression relative to version 8.2

Repro steps:
1. Assuming you have "row.toString()" in a debugging session watch
2. Edit the watch
3. Position the caret so it visually looks like it is after the dot
4. Hit DEL keyboard button
5. Notice that "o" gets deleted instead of "t"
6. Similarly, any characters you type will get inserted in the wrong position 
(one index off)

It is difficult to know where the IDE will insert/delete characters because the 
caret isn't showing up in the right place.

  was:
This is a regression relative to version 8.2

Repro steps:
1. Assuming you have "row.toString()" in a debugging session watch
2. Edit the watch
3. Position the caret so it visually looks like it is after the dot
4. Hit DEL keyboard button
5. Notice that "o" gets deleted instead of "t"

In other words, it is difficult to know where the IDE will insert/delete 
characters because the caret isn't showing up in the right place.


> Caret in Watch window renders in wrong position
> ---
>
> Key: NETBEANS-271
> URL: https://issues.apache.org/jira/browse/NETBEANS-271
> Project: NetBeans
>  Issue Type: Bug
>  Components: debugger - Java
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> 20180106-unknown-revn)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>  Labels: regression
>
> This is a regression relative to version 8.2
> Repro steps:
> 1. Assuming you have "row.toString()" in a debugging session watch
> 2. Edit the watch
> 3. Position the caret so it visually looks like it is after the dot
> 4. Hit DEL keyboard button
> 5. Notice that "o" gets deleted instead of "t"
> 6. Similarly, any characters you type will get inserted in the wrong position 
> (one index off)
> It is difficult to know where the IDE will insert/delete characters because 
> the caret isn't showing up in the right place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-271) Caret in Watch window renders in wrong position

2018-01-12 Thread Gili (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gili updated NETBEANS-271:
--
Environment: 
Product Version: Apache NetBeans IDE Dev (Build 20180106-unknown-revn)
Updates: Updates available
Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
Runtime: Java(TM) SE Runtime Environment 9.0.1+11
System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev

> Caret in Watch window renders in wrong position
> ---
>
> Key: NETBEANS-271
> URL: https://issues.apache.org/jira/browse/NETBEANS-271
> Project: NetBeans
>  Issue Type: Bug
>  Components: debugger - Java
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> 20180106-unknown-revn)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>  Labels: regression
>
> This is a regression relative to version 8.2
> Repro steps:
> 1. Assuming you have "row.toString()" in a debugging session watch
> 2. Edit the watch
> 3. Position the caret so it visually looks like it is after the dot
> 4. Hit DEL keyboard button
> 5. Notice that "o" gets deleted instead of "t"
> In other words, it is difficult to know where the IDE will insert/delete 
> characters because the caret isn't showing up in the right place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Updated] (NETBEANS-238) Invoking code-complete in Maven projects is extremely slow

2018-01-12 Thread Gili (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NETBEANS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gili updated NETBEANS-238:
--
Attachment: code-complete2.npss

[~jlahoda] I'm attaching a second IDE profiler dump for your review.

This is running on a patched IDE (using your diff). I went into an existing 
class that implements an interface but did not implement a mandatory method. I 
invoked CTRL+SPACE to get a list of implementable methods and code-complete 
took 12-14 seconds to complete. I reproduced this multiple times by restarting 
the IDE and repeating the steps in the same class. This profiler dump looks 
different in that I cannot figure out who is consuming the time. Please let me 
know if you figure it out.

> Invoking code-complete in Maven projects is extremely slow
> --
>
> Key: NETBEANS-238
> URL: https://issues.apache.org/jira/browse/NETBEANS-238
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 9.0
> Environment: build 152
>Reporter: Gili
>Priority: Critical
> Attachments: NETBEANS-238-experiment.diff, 
> SlowCodeCompleteAntAndMaven.zip, code-complete-profiler.npss, 
> code-complete2.npss, messages.log
>
>
> Say I'm in a class that has a field {{singletonScope}} where this class is 
> defined within the same Maven module.
> I type {{singletonScope.}} then wait for auto-complete to suggest possible 
> methods. Code-complete takes roughly 10 seconds to come back.
> This is reproducible 100% of the time.
> Expected behavior: Code-complete should complete within 300ms or less.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists