[jira] [Updated] (NETBEANS-418) Code templates shows up in code completion
[ https://issues.apache.org/jira/browse/NETBEANS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Andersen updated NETBEANS-418: - Description: When you want to see class methods/properties on an instance after typing ->, you get all the "Code templates" as well. $foo-> // "Popup Completion Window" should only show methods/properties on the object, and not Code templates was: When you want to see class methods on an instance after typing ->, you get all the "Code templates" as well. $foo-> // "Popup Completion Window" should only show methods/properties on the object, and not Code templates > Code templates shows up in code completion > -- > > Key: NETBEANS-418 > URL: https://issues.apache.org/jira/browse/NETBEANS-418 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 9.0 >Reporter: Bo Andersen >Priority: Minor > > When you want to see class methods/properties on an instance after typing ->, > you get all the "Code templates" as well. > > $foo-> // "Popup Completion Window" should only show methods/properties on > the object, and not Code templates -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-418) Code templates shows up in code completion
Bo Andersen created NETBEANS-418: Summary: Code templates shows up in code completion Key: NETBEANS-418 URL: https://issues.apache.org/jira/browse/NETBEANS-418 Project: NetBeans Issue Type: Bug Components: php - Editor Affects Versions: 9.0 Reporter: Bo Andersen When you want to see class methods on an instance after typing ->, you get all the "Code templates" as well. $foo-> // "Popup Completion Window" should only show methods/properties on the object, and not Code templates -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-320) Mac modal dialogs pop-under non-modal dialogs
[ https://issues.apache.org/jira/browse/NETBEANS-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373318#comment-16373318 ] Austin Stephens commented on NETBEANS-320: -- I have noticed that there is a possible issue with this solution. If the parent dialog closes while the child is still open, it will close the child dialog. It could be possible that the parent dialog was something temporary like a bubble notification. That would cause issues. I am looking at it. > Mac modal dialogs pop-under non-modal dialogs > - > > Key: NETBEANS-320 > URL: https://issues.apache.org/jira/browse/NETBEANS-320 > Project: NetBeans > Issue Type: Bug > Components: platform - Window System >Affects Versions: 8.2, 9.0 > Environment: Mac OS >Reporter: Austin Stephens >Assignee: Austin Stephens >Priority: Major > Labels: mac-os-x, pull-request-available > Attachments: Screen Shot 2018-01-23 at 1.28.20 PM.png, Screen Shot > 2018-01-26 at 11.37.55 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > It is very annoying to users. One easy way to reproduce this is to find a > module with a wrapped jar and then go to (Right > click)>Properties>Libraries>Wrapped JARs and select a wrapped jar. Then click > "Edit...". If your Mac is more severely affected, the "Edit Jar Reference" > dialog will pop-under the Project Properties, if you Mac is less severly > affected, then clicking on the Project Properties window while the "Edit Jar > Reference" dialog is open will cause the Project Properties window to hide > the dialog. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-295) Create/Update Tests dialog updates pom.xml even if operation is aborted
[
https://issues.apache.org/jira/browse/NETBEANS-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anton V. Kirilchik reassigned NETBEANS-295:
---
Assignee: Anton V. Kirilchik
> Create/Update Tests dialog updates pom.xml even if operation is aborted
> ---
>
> Key: NETBEANS-295
> URL: https://issues.apache.org/jira/browse/NETBEANS-295
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Maven
> Environment: Product Version: Apache NetBeans IDE Dev (Build
> 20180117-unknown-revn)
> Updates: Updates available
> Java: 9.0.1; Java HotSpot(TM) 64-Bit Server VM 9.0.1+11
> Runtime: Java(TM) SE Runtime Environment 9.0.1+11
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
> User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
> Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
>Reporter: Gili
>Assignee: Anton V. Kirilchik
>Priority: Major
>
> 1. Given a Maven project with a Java file open in the editor
> 2. The user mistakenly hits CTRL+SHIFT+U which opens the "Create/Update
> Tests" dialog
> 3. User hits ESC to cancel the operation.
> 4. The following lines are added to pom.xml:
> {code}
>
> org.seleniumhq.selenium
> selenium-java
> test
> 2.44.0
>
>
> com.opera
> operadriver
> test
> 1.5
>
>
>
> org.seleniumhq.selenium
>
> selenium-remote-driver
>
>
>
>
> junit
> junit
> test
> 4.11
>
> {code}
> Expected behavior: pom.xml should not be modified if operation is aborted
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-415) Revisit hashCode(), equals() implementation
[
https://issues.apache.org/jira/browse/NETBEANS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372999#comment-16372999
]
Niklas Matthies commented on NETBEANS-415:
--
I agree regarding equals(). Note that the test for {{obj == null}} should be
omitted when {{instanceof}} is used, because {{obj instanceof Type == true}}
already implies {{obj != null}}. Furthermore, the current implementation
generates code like:
{{ if (!Objects.equals(this.property, other.property)) {}}
{{ return false;}}
{{ }}}
{{ return true;}}
This should be replaced with the negationless and more straightforward:
{{ return Objects.equals(this.property, other.property);}}
> Revisit hashCode(), equals() implementation
> ---
>
> Key: NETBEANS-415
> URL: https://issues.apache.org/jira/browse/NETBEANS-415
> Project: NetBeans
> Issue Type: Improvement
> Components: editor - Completion Templates
>Reporter: Gili
>Priority: Major
>
> (CCing as many people from the original discussion as I could find:
> [~svatoun] [~matthies] [~jlahoda])
> Given that Netbeans now requires JDK 7, consider having the code generator
> delegate to
> {{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result
> in cleaner code than what is currently being generated.
> As for {{equals()}}, the implementation generated by Netbeans violates the
> Java specification of java.lang.Object and should be fixed right away. You
> can read a more detailed discussion at
> [https://netbeans.org/bugzilla/show_bug.cgi?id=156994] [1] but essentially we
> agreed to fix this with a flag in the Options dialog to let users decide
> which approach they prefer.
> [1] In my last post I suggested:
> # Making "instanceof" the default.
> # Warning if a class uses "instanceof" and subclasses override
> equals/hashCode.
> # Allowing users to configure whether they prefer instanceof or
> getClass()-based implementations of equals/hashcode on a project-level.
> # Warning if a class uses "getClass()" and has any subclasses.
> # Warnings should appear on the subclasses, not the parent class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-417) Adjust Native windows ide lauchner for jdk 9
[ https://issues.apache.org/jira/browse/NETBEANS-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-417: Labels: pull-request-available (was: ) > Adjust Native windows ide lauchner for jdk 9 > - > > Key: NETBEANS-417 > URL: https://issues.apache.org/jira/browse/NETBEANS-417 > Project: NetBeans > Issue Type: Bug >Reporter: Eric Barboni >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-417) Adjust Native windows ide lauchner for jdk 9
Eric Barboni created NETBEANS-417: - Summary: Adjust Native windows ide lauchner for jdk 9 Key: NETBEANS-417 URL: https://issues.apache.org/jira/browse/NETBEANS-417 Project: NetBeans Issue Type: Bug Reporter: Eric Barboni -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-416) Excessive CPU usage
Acs created NETBEANS-416: Summary: Excessive CPU usage Key: NETBEANS-416 URL: https://issues.apache.org/jira/browse/NETBEANS-416 Project: NetBeans Issue Type: Bug Affects Versions: 8.2 Environment: Windows 10 Pro 64bit Reporter: Acs Attachments: 2018-02-22 14_34_52-Task Manager.png, selfsampler.npss Hey, Something I have noticed in Netbeans is that from time to time Netbeans CPU usage will go up to around 20% and most of the times I have Netbeans in the background so I am not doing anything in Netbeans. Please fix this as this is a huge annoyance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-331) Unexpected errors with Java
[
https://issues.apache.org/jira/browse/NETBEANS-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiří Kovalský updated NETBEANS-331:
---
Priority: Critical (was: Major)
> Unexpected errors with Java
> ---
>
> Key: NETBEANS-331
> URL: https://issues.apache.org/jira/browse/NETBEANS-331
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Code
>Affects Versions: 9.0
> Environment: Windows 10, JDK 9
>Reporter: Hyeonwoo O
>Assignee: Hyeonwoo O
>Priority: Critical
> Labels: errors
>
> When I'm configuring some options, following error messages came out.
> {noformat}
> java.lang.NullPointerException
> {noformat}
> or
> {noformat}
> javax.swing.text.BadLocationException
> {noformat}
> These messages came out suddenly so I couldn't reproduce it.
> It is occurred in Development Version and I wrote only simple test code like
> this:
> {code:java}
> package javatest;
> public class MainClass {
> public static void main(String[] args) {
> System.out.println("Hello World!");
> }
> }
> {code}
> Build number is NetBeans IDE 201801230002.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-331) Unexpected errors with Java
[
https://issues.apache.org/jira/browse/NETBEANS-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiří Kovalský updated NETBEANS-331:
---
Priority: Major (was: Critical)
> Unexpected errors with Java
> ---
>
> Key: NETBEANS-331
> URL: https://issues.apache.org/jira/browse/NETBEANS-331
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Code
>Affects Versions: 9.0
> Environment: Windows 10, JDK 9
>Reporter: Hyeonwoo O
>Assignee: Hyeonwoo O
>Priority: Major
> Labels: errors
>
> When I'm configuring some options, following error messages came out.
> {noformat}
> java.lang.NullPointerException
> {noformat}
> or
> {noformat}
> javax.swing.text.BadLocationException
> {noformat}
> These messages came out suddenly so I couldn't reproduce it.
> It is occurred in Development Version and I wrote only simple test code like
> this:
> {code:java}
> package javatest;
> public class MainClass {
> public static void main(String[] args) {
> System.out.println("Hello World!");
> }
> }
> {code}
> Build number is NetBeans IDE 201801230002.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-181) NetBeans should be aware of WSL (Ubuntu on Windows 10)
[ https://issues.apache.org/jira/browse/NETBEANS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372713#comment-16372713 ] Christian Lenz edited comment on NETBEANS-181 at 2/22/18 11:53 AM: --- I don't know why it shouldn't possible, because it is a native ubuntu. The wsl is part of the Windows Kernel, no cygwin or emulation or whatever, with their own file system which is a folder in windows called lxss. So Everything (or most of it) you can use the bash in windows for your work. [~Cruiser] was (Author: chrizzly): I don't know but I don't think that this isn't possible, because it is a native ubuntu. The wsl is part of the Windows Kernel, no cygwin or emulation or whatever, with their own file system which is a folder in windows called lxss. So Everything (or most of it) you can use the bash in windows for your work. [~Cruiser] > NetBeans should be aware of WSL (Ubuntu on Windows 10) > -- > > Key: NETBEANS-181 > URL: https://issues.apache.org/jira/browse/NETBEANS-181 > Project: NetBeans > Issue Type: New Feature > Components: cnd - Terminalemulator >Affects Versions: Next > Environment: NetBeans 8.2, Windows 10 x64 >Reporter: Christian Lenz >Priority: Major > > Yeah Ubuntu on Windows is, I think still in beta but I use it for my daily > work. At home and at work. It is really handy to setup enviroment stuff > easily. So for this, NetBeans should be aware of installed stuff inside the > ubuntu on windows. The path is "C:\Users\Chrizzly\AppData\Local\lxss (hidden > folder)". So if NetBeans are aware of a cygwin installation, it should be > treated like that too. > And for everything else like I installed node, c/c++ stuff, php and so on. > Would be great enhancement. I created such ticket for Terminal integration > too, because of the Cygwin thing: > http://netbeans.org/bugzilla/show_bug.cgi?id=267478 > Regards > Chris -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-181) NetBeans should be aware of WSL (Ubuntu on Windows 10)
[ https://issues.apache.org/jira/browse/NETBEANS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372713#comment-16372713 ] Christian Lenz commented on NETBEANS-181: - I don't know but I don't think that this isn't possible, because it is a native ubuntu. The wsl is part of the Windows Kernel, no cygwin or emulation or whatever, with their own file system which is a folder in windows called lxss. So Everything (or most of it) you can use the bash in windows for your work. > NetBeans should be aware of WSL (Ubuntu on Windows 10) > -- > > Key: NETBEANS-181 > URL: https://issues.apache.org/jira/browse/NETBEANS-181 > Project: NetBeans > Issue Type: New Feature > Components: cnd - Terminalemulator >Affects Versions: Next > Environment: NetBeans 8.2, Windows 10 x64 >Reporter: Christian Lenz >Priority: Major > > Yeah Ubuntu on Windows is, I think still in beta but I use it for my daily > work. At home and at work. It is really handy to setup enviroment stuff > easily. So for this, NetBeans should be aware of installed stuff inside the > ubuntu on windows. The path is "C:\Users\Chrizzly\AppData\Local\lxss (hidden > folder)". So if NetBeans are aware of a cygwin installation, it should be > treated like that too. > And for everything else like I installed node, c/c++ stuff, php and so on. > Would be great enhancement. I created such ticket for Terminal integration > too, because of the Cygwin thing: > http://netbeans.org/bugzilla/show_bug.cgi?id=267478 > Regards > Chris -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-415) Revisit hashCode(), equals() implementation
[
https://issues.apache.org/jira/browse/NETBEANS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372686#comment-16372686
]
Gili commented on NETBEANS-415:
---
[~GeertjanWielenga] Right, what I'm saying is that if the project source-code
level is set to JDK 7 or higher then we should generate code based on
{{Object.hash(Object...)}} because it is more readable than what we had in
earlier versions.
> Revisit hashCode(), equals() implementation
> ---
>
> Key: NETBEANS-415
> URL: https://issues.apache.org/jira/browse/NETBEANS-415
> Project: NetBeans
> Issue Type: Improvement
> Components: editor - Completion Templates
>Reporter: Gili
>Priority: Major
>
> (CCing as many people from the original discussion as I could find:
> [~svatoun] [~matthies] [~jlahoda])
> Given that Netbeans now requires JDK 7, consider having the code generator
> delegate to
> {{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result
> in cleaner code than what is currently being generated.
> As for {{equals()}}, the implementation generated by Netbeans violates the
> Java specification of java.lang.Object and should be fixed right away. You
> can read a more detailed discussion at
> [https://netbeans.org/bugzilla/show_bug.cgi?id=156994] [1] but essentially we
> agreed to fix this with a flag in the Options dialog to let users decide
> which approach they prefer.
> [1] In my last post I suggested:
> # Making "instanceof" the default.
> # Warning if a class uses "instanceof" and subclasses override
> equals/hashCode.
> # Allowing users to configure whether they prefer instanceof or
> getClass()-based implementations of equals/hashcode on a project-level.
> # Warning if a class uses "getClass()" and has any subclasses.
> # Warnings should appear on the subclasses, not the parent class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-415) Revisit hashCode(), equals() implementation
[
https://issues.apache.org/jira/browse/NETBEANS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372596#comment-16372596
]
Geertjan Wielenga commented on NETBEANS-415:
NetBeans does not require or run on JDK 7. Only JDK 8 and above are supported.
> Revisit hashCode(), equals() implementation
> ---
>
> Key: NETBEANS-415
> URL: https://issues.apache.org/jira/browse/NETBEANS-415
> Project: NetBeans
> Issue Type: Improvement
> Components: editor - Completion Templates
>Reporter: Gili
>Priority: Major
>
> (CCing as many people from the original discussion as I could find:
> [~svatoun] [~matthies] [~jlahoda])
> Given that Netbeans now requires JDK 7, consider having the code generator
> delegate to
> {{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result
> in cleaner code than what is currently being generated.
> As for {{equals()}}, the implementation generated by Netbeans violates the
> Java specification of java.lang.Object and should be fixed right away. You
> can read a more detailed discussion at
> [https://netbeans.org/bugzilla/show_bug.cgi?id=156994] [1] but essentially we
> agreed to fix this with a flag in the Options dialog to let users decide
> which approach they prefer.
> [1] In my last post I suggested:
> # Making "instanceof" the default.
> # Warning if a class uses "instanceof" and subclasses override
> equals/hashCode.
> # Allowing users to configure whether they prefer instanceof or
> getClass()-based implementations of equals/hashcode on a project-level.
> # Warning if a class uses "getClass()" and has any subclasses.
> # Warnings should appear on the subclasses, not the parent class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-415) Revisit hashCode(), equals() implementation
[
https://issues.apache.org/jira/browse/NETBEANS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gili updated NETBEANS-415:
--
Description:
(CCing as many people from the original discussion as I could find: [~svatoun]
[~matthies] [~jlahoda])
Given that Netbeans now requires JDK 7, consider having the code generator
delegate to
{{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result in
cleaner code than what is currently being generated.
As for {{equals()}}, the implementation generated by Netbeans violates the Java
specification of java.lang.Object and should be fixed right away. You can read
a more detailed discussion at
[https://netbeans.org/bugzilla/show_bug.cgi?id=156994] [1] but essentially we
agreed to fix this with a flag in the Options dialog to let users decide which
approach they prefer.
[1] In my last post I suggested:
# Making "instanceof" the default.
# Warning if a class uses "instanceof" and subclasses override equals/hashCode.
# Allowing users to configure whether they prefer instanceof or
getClass()-based implementations of equals/hashcode on a project-level.
# Warning if a class uses "getClass()" and has any subclasses.
# Warnings should appear on the subclasses, not the parent class.
was:
Given that Netbeans now requires JDK 7, consider having the code generator
delegate to
{{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result in
cleaner code than what is currently being generated.
As for {{equals()}}, the implementation generated by Netbeans violates the Java
specification of java.lang.Object and should be fixed right away. You can read
a more detailed discussion at
[https://netbeans.org/bugzilla/show_bug.cgi?id=156994] but essentially we
agreed to fix this with a flag in the Options dialog to let users decide which
approach they prefer.
> Revisit hashCode(), equals() implementation
> ---
>
> Key: NETBEANS-415
> URL: https://issues.apache.org/jira/browse/NETBEANS-415
> Project: NetBeans
> Issue Type: Improvement
> Components: editor - Completion Templates
>Reporter: Gili
>Priority: Major
>
> (CCing as many people from the original discussion as I could find:
> [~svatoun] [~matthies] [~jlahoda])
> Given that Netbeans now requires JDK 7, consider having the code generator
> delegate to
> {{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result
> in cleaner code than what is currently being generated.
> As for {{equals()}}, the implementation generated by Netbeans violates the
> Java specification of java.lang.Object and should be fixed right away. You
> can read a more detailed discussion at
> [https://netbeans.org/bugzilla/show_bug.cgi?id=156994] [1] but essentially we
> agreed to fix this with a flag in the Options dialog to let users decide
> which approach they prefer.
> [1] In my last post I suggested:
> # Making "instanceof" the default.
> # Warning if a class uses "instanceof" and subclasses override
> equals/hashCode.
> # Allowing users to configure whether they prefer instanceof or
> getClass()-based implementations of equals/hashcode on a project-level.
> # Warning if a class uses "getClass()" and has any subclasses.
> # Warnings should appear on the subclasses, not the parent class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-415) Revisit hashCode(), equals() implementation
[
https://issues.apache.org/jira/browse/NETBEANS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gili updated NETBEANS-415:
--
Description:
Given that Netbeans now requires JDK 7, consider having the code generator
delegate to
{{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result in
cleaner code than what is currently being generated.
As for {{equals()}}, the implementation generated by Netbeans violates the Java
specification of java.lang.Object and should be fixed right away. You can read
a more detailed discussion at
[https://netbeans.org/bugzilla/show_bug.cgi?id=156994] but essentially we
agreed to fix this with a flag in the Options dialog to let users decide which
approach they prefer.
was:
Given that Netbeans now requires JDK 7, consider having the code generator
delegate to
{{Objects.hashCode(Object)}} and {{Objects.hash(Object...) as they result in
cleaner code.}}
As for {{equals()}}, the implementation generated by Netbeans violates the Java
specification of java.lang.Object and should be fixed right away. You can read
a more detailed discussion at
[https://netbeans.org/bugzilla/show_bug.cgi?id=156994] but essentially we
agreed to fix this with a flag in the Options dialog to let users decide which
approach they prefer.
> Revisit hashCode(), equals() implementation
> ---
>
> Key: NETBEANS-415
> URL: https://issues.apache.org/jira/browse/NETBEANS-415
> Project: NetBeans
> Issue Type: Improvement
> Components: editor - Completion Templates
>Reporter: Gili
>Priority: Major
>
> Given that Netbeans now requires JDK 7, consider having the code generator
> delegate to
> {{Objects.hashCode(Object)}} and {{Objects.hash(Object...)}} as they result
> in cleaner code than what is currently being generated.
> As for {{equals()}}, the implementation generated by Netbeans violates the
> Java specification of java.lang.Object and should be fixed right away. You
> can read a more detailed discussion at
> [https://netbeans.org/bugzilla/show_bug.cgi?id=156994] but essentially we
> agreed to fix this with a flag in the Options dialog to let users decide
> which approach they prefer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-415) Revisit hashCode(), equals() implementation
Gili created NETBEANS-415:
-
Summary: Revisit hashCode(), equals() implementation
Key: NETBEANS-415
URL: https://issues.apache.org/jira/browse/NETBEANS-415
Project: NetBeans
Issue Type: Improvement
Components: editor - Completion Templates
Reporter: Gili
Given that Netbeans now requires JDK 7, consider having the code generator
delegate to
{{Objects.hashCode(Object)}} and {{Objects.hash(Object...) as they result in
cleaner code.}}
As for {{equals()}}, the implementation generated by Netbeans violates the Java
specification of java.lang.Object and should be fixed right away. You can read
a more detailed discussion at
[https://netbeans.org/bugzilla/show_bug.cgi?id=156994] but essentially we
agreed to fix this with a flag in the Options dialog to let users decide which
approach they prefer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
