[jira] [Created] (NETBEANS-487) Small "Java" icon in Options dialog breaks layout

2018-03-19 Thread Niklas Matthies (JIRA) 
Niklas Matthies created NETBEANS-487:


 Summary: Small "Java" icon in Options dialog breaks layout
 Key: NETBEANS-487
 URL: https://issues.apache.org/jira/browse/NETBEANS-487
 Project: NetBeans
  Issue Type: Bug
  Components: platform - OptionsSettings
 Environment: Windows 7 (with classic theme)
Reporter: Niklas Matthies
 Attachments: coffee-cup-32x32.png, netbeans-options-header.png

In the top header of the Options dialog, the "Java" item has a smaller icon 
(20x20 pixels) than the other items (32x32 pixels), breaking the layout. It 
causes the "Java" label to be vertically misaligned and also is too narrow 
compared with the other icons (cf. the attached screenshot 
netbeans-options-header.png). This probably happened as the old Java logo 
(owned by Oracle) was replaced with the NetBeans logo.

I attached a PNG (coffee-cup-32x32.png) that could be used as a replacement and 
which matches "Java" better than the NetBeans logo. It's adapted from 
[https://commons.wikimedia.org/wiki/File:Coffee_cup_flat.svg] (public domain) 
with some minor manual adjustments. Of course, if someone can come up with a 
better icon that would be great too.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[jira] [Created] (NETBEANS-486) org.netbeans.modules.parsing.spi.ParseException when invoking code-complete

2018-03-19 Thread Gili (JIRA) 
Gili created NETBEANS-486:
-

 Summary: org.netbeans.modules.parsing.spi.ParseException when 
invoking code-complete
 Key: NETBEANS-486
 URL: https://issues.apache.org/jira/browse/NETBEANS-486
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Completion  Templates
 Environment: Product Version: Apache NetBeans IDE Dev (Build 
incubator-netbeans-release-228-on-20180312)
Java: 9.0.4; Java HotSpot(TM) 64-Bit Server VM 9.0.4+11
Runtime: Java(TM) SE Runtime Environment 9.0.4+11
System: Windows 10 version 10.0 running on amd64; Cp1252; en_CA (nb)
User directory: C:\Users\Gili\AppData\Roaming\NetBeans\dev
Cache directory: C:\Users\Gili\AppData\Local\NetBeans\Cache\dev
Reporter: Gili


I invoked code-complete in the editor and the following exception was thrown:

{code}
com.sun.tools.javac.comp.Infer$InferenceException
at com.sun.tools.javac.comp.Infer.(Infer.java:115)
at com.sun.tools.javac.comp.Infer.instance(Infer.java:102)
at com.sun.tools.javac.comp.DeferredAttr.(DeferredAttr.java:114)
at com.sun.tools.javac.comp.DeferredAttr.instance(DeferredAttr.java:103)
at com.sun.tools.javac.comp.Resolve.(Resolve.java:123)
at org.netbeans.lib.nbjavac.services.NBResolve.(NBResolve.java:50)
at org.netbeans.lib.nbjavac.services.NBResolve$1.make(NBResolve.java:44)
at org.netbeans.lib.nbjavac.services.NBResolve$1.make(NBResolve.java:42)
at com.sun.tools.javac.util.Context.get(Context.java:150)
at com.sun.tools.javac.comp.Resolve.instance(Resolve.java:158)
at com.sun.tools.javac.comp.Check.(Check.java:117)
at com.sun.tools.javac.comp.Check.instance(Check.java:105)
at com.sun.tools.javac.comp.Modules.(Modules.java:185)
at com.sun.tools.javac.comp.Modules.instance(Modules.java:175)
at com.sun.tools.javac.code.Symtab.(Symtab.java:484)
at com.sun.tools.javac.code.Symtab.instance(Symtab.java:88)
at com.sun.tools.javac.comp.Attr.(Attr.java:127)
at org.netbeans.lib.nbjavac.services.NBAttr.(NBAttr.java:50)
at org.netbeans.lib.nbjavac.services.NBAttr$1.make(NBAttr.java:42)
at org.netbeans.lib.nbjavac.services.NBAttr$1.make(NBAttr.java:40)
at com.sun.tools.javac.util.Context.get(Context.java:150)
at com.sun.tools.javac.comp.Attr.instance(Attr.java:116)
at com.sun.tools.javac.comp.Annotate.(Annotate.java:102)
at com.sun.tools.javac.comp.Annotate.instance(Annotate.java:77)
at com.sun.tools.javac.jvm.ClassReader.(ClassReader.java:234)
at 
org.netbeans.lib.nbjavac.services.NBClassReader.(NBClassReader.java:50)
at 
org.netbeans.lib.nbjavac.services.NBClassReader$1.make(NBClassReader.java:41)
at 
org.netbeans.lib.nbjavac.services.NBClassReader$1.make(NBClassReader.java:39)
at com.sun.tools.javac.util.Context.get(Context.java:150)
at com.sun.tools.javac.jvm.ClassReader.instance(ClassReader.java:225)
at com.sun.tools.javac.code.ClassFinder.(ClassFinder.java:186)
at 
com.sun.tools.javadoc.main.JavadocClassFinder.(JavadocClassFinder.java:71)
at 
com.sun.tools.javadoc.main.JavadocClassFinder.lambda$preRegister$0(JavadocClassFinder.java:60)
at com.sun.tools.javac.util.Context.get(Context.java:150)
at com.sun.tools.javac.code.ClassFinder.instance(ClassFinder.java:177)
at com.sun.tools.javac.main.JavaCompiler.(JavaCompiler.java:393)
at com.sun.tools.javac.main.JavaCompiler.instance(JavaCompiler.java:114)
at 
com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:207)
at com.sun.tools.javac.api.JavacTaskImpl.parse(JavacTaskImpl.java:247)
at 
org.netbeans.modules.java.source.nbjavac.parsing.SequentialParsingImpl.parse(SequentialParsingImpl.java:38)
at 
org.netbeans.modules.java.source.parsing.JavacParser.moveToPhase(JavacParser.java:580)
at 
org.netbeans.modules.java.source.parsing.CompilationInfoImpl.toPhase(CompilationInfoImpl.java:361)
at 
org.netbeans.api.java.source.CompilationController.toPhase(CompilationController.java:84)
at 
org.netbeans.modules.java.completion.BaseTask.getCompletionEnvironment(BaseTask.java:215)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.resolve(JavaCompletionTask.java:265)
at org.netbeans.modules.java.completion.BaseTask.run(BaseTask.java:93)
at 
org.netbeans.modules.java.completion.JavaCompletionTask.run(JavaCompletionTask.java:58)
at 
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at 
org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
at

[incubator-netbeans] branch master updated: [NETBEANS-417] Adjust C file to handle new registry layout starting with jdk9 (#433)

2018-03-19 Thread geertjan 
This is an automated email from the ASF dual-hosted git repository.

geertjan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 54c1194  [NETBEANS-417] Adjust C file to handle new registry layout 
starting with jdk9  (#433)
54c1194 is described below

commit 54c119485939fe29041872da4426ed797e89cbb4
Author: Eric Barboni 
AuthorDate: Mon Mar 19 09:10:42 2018 +0100

[NETBEANS-417] Adjust C file to handle new registry layout starting with 
jdk9  (#433)

* [NETBEANS-417] fix return type in case of error

* [NETBEANS-417] add check to new registry key
---
 ide/launcher/windows/nblauncher.cpp| 4 ++--
 o.n.bootstrap/launcher/windows/jvmlauncher.cpp | 9 +
 o.n.bootstrap/launcher/windows/jvmlauncher.h   | 3 +++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/ide/launcher/windows/nblauncher.cpp 
b/ide/launcher/windows/nblauncher.cpp
index f85acb1..ffb8c51 100644
--- a/ide/launcher/windows/nblauncher.cpp
+++ b/ide/launcher/windows/nblauncher.cpp
@@ -401,7 +401,7 @@ bool NbLauncher::findCacheDir(const char *str) {
 string NbLauncher::getDefaultUserDirRoot() {
 TCHAR defUserDirRootChar[MAX_PATH];
 if (FAILED(SHGetFolderPath(NULL, CSIDL_APPDATA, NULL, 0, 
defUserDirRootChar))) {
-return false;
+return std::string();
 }
 defUserDirRoot = ((string) defUserDirRootChar) + NETBEANS_DIRECTORY;
 defUserDirRoot.erase(defUserDirRoot.rfind('\\'));
@@ -412,7 +412,7 @@ string NbLauncher::getDefaultUserDirRoot() {
 string NbLauncher::getDefaultCacheDirRoot() {
 TCHAR defCacheDirRootChar[MAX_PATH];
 if (FAILED(SHGetFolderPath(NULL, CSIDL_LOCAL_APPDATA, NULL, 0, 
defCacheDirRootChar))) {
-return false;
+return std::string();
 }
 defCacheDirRoot = ((string) defCacheDirRootChar) + 
NETBEANS_CACHES_DIRECTORY;
 defCacheDirRoot.erase(defCacheDirRoot.rfind('\\'));
diff --git a/o.n.bootstrap/launcher/windows/jvmlauncher.cpp 
b/o.n.bootstrap/launcher/windows/jvmlauncher.cpp
index a292773..7e297f1 100644
--- a/o.n.bootstrap/launcher/windows/jvmlauncher.cpp
+++ b/o.n.bootstrap/launcher/windows/jvmlauncher.cpp
@@ -28,6 +28,8 @@ using namespace std;
 
 const char *JvmLauncher::JDK_KEY = "Software\\JavaSoft\\Java Development Kit";
 const char *JvmLauncher::JRE_KEY = "Software\\JavaSoft\\Java Runtime 
Environment";
+const char *JvmLauncher::JDK_POST9_KEY = "Software\\JavaSoft\\JDK";
+const char *JvmLauncher::JRE_POST9_KEY = "Software\\JavaSoft\\JRE";
 const char *JvmLauncher::CUR_VERSION_NAME = "CurrentVersion";
 const char *JvmLauncher::JAVA_HOME_NAME = "JavaHome";
 const char *JvmLauncher::JAVA_BIN_DIR = "\\bin";
@@ -399,6 +401,13 @@ bool JvmLauncher::startOutProcJvm(const char 
*mainClassName, const std::listhttps://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[incubator-netbeans] branch master updated (747bbe4 -> 7e8c73a)

2018-03-19 Thread emi 
This is an automated email from the ASF dual-hosted git repository.

emi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git.


from 747bbe4  Adding new Apache NetBeans Logo (#447)
 add e1c560f  Makes ProgressHandle and AggregateProgressHandle AutoCloseable
 new 7e8c73a  Merge pull request #460 from emilianbold/emi-autocloseable

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 api.progress/nbproject/project.properties  |  2 +-
 .../src/org/netbeans/api/progress/BaseProgressUtils.java   |  9 +++--
 api.progress/src/org/netbeans/api/progress/ProgressHandle.java | 10 +-
 .../api/progress/aggregate/AggregateProgressHandle.java| 10 +-
 .../project/universe/PlatformLayersCacheManager.java   |  6 +-
 diff/src/org/netbeans/modules/diff/DiffAction.java |  6 +-
 diff/src/org/netbeans/modules/diff/PatchAction.java|  6 +-
 diff/src/org/netbeans/modules/diff/builtin/DiffPresenter.java  |  7 ++-
 image/nbproject/project.properties |  2 +-
 image/src/org/netbeans/modules/image/ImageViewer.java  |  7 ++-
 10 files changed, 30 insertions(+), 35 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
e...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists