[jira] [Resolved] (NETBEANS-2392) Opening type from Go To Type fails

2019-05-07 Thread Jan Lahoda (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Lahoda resolved NETBEANS-2392.
--
   Resolution: Fixed
Fix Version/s: Next

Fixed by the linked Pull Request on GitHUb.

> Opening type from Go To Type fails
> --
>
> Key: NETBEANS-2392
> URL: https://issues.apache.org/jira/browse/NETBEANS-2392
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Navigation, java - Platform
>Affects Versions: 10.0
> Environment: Netbeans 10 and 11
> Open JDK 11
> Gradle 5.2.1
>Reporter: Netbeans User 2019
>Assignee: Jan Lahoda
>Priority: Critical
>  Labels: pull-request-available
> Fix For: Next
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> It is simply not open a type that it is clicked from dialog and dialog is 
> closed, but you have to type such type to editor and import it and then click 
> it from there for sucessful open.
> It seems that does not happend for opened project/sub-projects sources, even 
> seems no issue e.g. with junit or Java SE API sources.
> Additionally this is seen from notification after:
> java.lang.ClassCastException: class com.sun.tools.javac.code.Type$ClassType 
> cannot be cast to class com.sun.tools.javac.code.Type$ErrorType 
> (com.sun.tools.javac.code.Type$ClassType and 
> com.sun.tools.javac.code.Type$ErrorType are in unnamed module of loader 
> org.netbeans.StandardModule$OneModuleClassLoader @27597305)
>  at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:863)
>  at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1119)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.computeAnnotationTree(CodeGenerator.java:449)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.computeMods(CodeGenerator.java:411)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitType(CodeGenerator.java:373)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitType(CodeGenerator.java:285)
>  at com.sun.tools.javac.code.Symbol$ClassSymbol.accept(Symbol.java:1473)
>  at 
> javax.lang.model.util.AbstractElementVisitor6.visit(AbstractElementVisitor6.java:106)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator.generateCode(CodeGenerator.java:275)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator$1.run(CodeGenerator.java:232)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator$1.run(CodeGenerator.java:152)
>  at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
>  at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)
>  at org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:501)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
>  at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
>  at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
>  at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
>  at 
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
>  at 
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
>  at 
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
>  at 
> org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
>  at 
> org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:451)
>  at 
> org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:422)
>  at 
> org.netbeans.api.java.source.JavaSource.runModificationTask(JavaSource.java:683)
>  at 
> org.netbeans.modules.java.classfile.CodeGenerator.generateCode(CodeGenerator.java:152)
>  at 
> org.netbeans.modules.java.classfile.BinaryElementOpenImpl.open(BinaryElementOpenImpl.java:44)
>  at 
> org.netbeans.api.java.source.ui.ElementOpen.binaryOpen(ElementOpen.java:118)
>  at org.netbeans.api.java.source.ui.ElementOpen.open(ElementOpen.java:99)
>  at 
> org.netbeans.modules.java.source.ui.JavaTypeDescription.open(JavaTypeDescription.java:121)
>  at 
> org.netbeans.modules.jumpto.type.GoToTypeAction.actionPerformed(GoToTypeAction.java:153)
>  at org.openide.windows.TopComponent.processKeyBinding(TopComponent.java:1151)
>  at 
> java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2962)
>  at java.desktop/j

[jira] [Created] (NETBEANS-2516) Warnings hints for Convert rule switch to Traditional switch

2019-05-07 Thread vikas kumar prabhakar (JIRA)
vikas kumar prabhakar created NETBEANS-2516:
---

 Summary: Warnings hints for Convert rule switch to Traditional 
switch
 Key: NETBEANS-2516
 URL: https://issues.apache.org/jira/browse/NETBEANS-2516
 Project: NetBeans
  Issue Type: Improvement
Reporter: vikas kumar prabhakar
Assignee: vikas kumar prabhakar


Implementation of warning hints for  "Convert rule switch to Traditional switch"

Use case:

Actual code:

public void test(int i){
 String result;
 switch(i){
 case 1 -> System.out.println("One");
 case 2 -> System.out.println("Two");
 default -> System.out.println("Default");
 }
 }

Warning Hints : "Convert to traditional switch"

After Fix:

public void test(int i){
 String result;
 switch(i){
 case 1 :
 System.out.println("One");
 break;
 case 2 :
 System.out.println("Two");
 break;
 default:
 System.out.println("Default");
 break;
 }
 }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] 05/07: [NETBEANS-2293] Fix possible NPE on selected method detection.

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit c3071d7ca8c29fc1c097cf11b8a9cb7b4df90708
Author: Laszlo Kishalmi 
AuthorDate: Sat Apr 6 15:23:06 2019 -0700

[NETBEANS-2293] Fix possible NPE on selected method detection.
---
 .../gradle/java/GradleJavaTokenProvider.java   | 86 ++
 .../modules/gradle/java/action-mapping.xml |  4 +-
 .../gradle/java/api/output/LocationOpener.java | 58 +++
 3 files changed, 52 insertions(+), 96 deletions(-)

diff --git 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
index 87018fb..8e79ed4 100644
--- 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
+++ 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
@@ -24,24 +24,13 @@ import org.netbeans.modules.gradle.api.execute.RunUtils;
 import org.netbeans.modules.gradle.java.api.GradleJavaProject;
 import org.netbeans.modules.gradle.java.api.GradleJavaSourceSet;
 import org.netbeans.modules.gradle.spi.actions.ReplaceTokenProvider;
-import com.sun.source.tree.CompilationUnitTree;
-import com.sun.source.tree.Tree;
-import com.sun.source.util.Trees;
 import java.io.File;
-import java.io.IOException;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.List;
 import java.util.Map;
 import java.util.Set;
-import javax.lang.model.element.Element;
-import javax.lang.model.element.ElementKind;
-import javax.lang.model.element.TypeElement;
-import org.netbeans.api.java.source.CompilationController;
-import org.netbeans.api.java.source.JavaSource;
-import org.netbeans.api.java.source.Task;
 import org.netbeans.api.project.Project;
 import org.netbeans.spi.project.ProjectServiceProvider;
 import org.netbeans.spi.project.SingleMethod;
@@ -85,32 +74,20 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 private void processSelectedPackageAndClass(final Map map, 
Lookup context) {
 FileObject fo = RunUtils.extractFileObjectfromLookup(context);
 GradleJavaProject gjp = GradleJavaProject.get(project);
-if ((gjp != null) && (fo != null)) {
-File f = FileUtil.toFile(fo);
-GradleJavaSourceSet sourceSet = gjp.containingSourceSet(f);
-if (sourceSet != null)  {
-if (f.isFile()) {
-String relPath = sourceSet.relativePath(f);
-String className = (relPath.lastIndexOf('.') > 0 ?
-relPath.substring(0, relPath.lastIndexOf('.')) :
-relPath).replace('/', '.');
-map.put("selectedClass", className);  //NOI18N
-f = f.getParentFile();
-} else {
-String pkg = sourceSet.relativePath(f).replace('/', '.');
-map.put("selectedClass", pkg + "*"); //NOI18N
-}
-}
+String className = evaluateClassName(gjp, fo);
+if (className != null) {
+map.put("selectedClass", className);
 }
 }
 
-private static void processSelectedMethod(final Map map, 
Lookup context) {
+private void processSelectedMethod(final Map map, Lookup 
context) {
 SingleMethod method = context.lookup(SingleMethod.class);
 FileObject fo = method != null ? method.getFile() : 
RunUtils.extractFileObjectfromLookup(context);
-String methodName = method != null ? method.getMethodName() : null;
-if (fo != null) {
- String selectedMethod = evaluateSingleMethod(fo, methodName);
- map.put("selectedMethod", selectedMethod); //NOI18N
+if ((fo != null) && fo.isData()) {
+GradleJavaProject gjp = GradleJavaProject.get(project);
+String className = evaluateClassName(gjp, fo);
+String selectedMethod = method != null ? className + '.' + 
method.getMethodName() : className;
+map.put("selectedMethod", selectedMethod);
 }
 }
 
@@ -137,37 +114,22 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 }
 }
 
-private static String evaluateSingleMethod(final FileObject fo, final 
String method) {
-final Object[] ret = new Object[1];
-JavaSource javaSource = JavaSource.forFileObject(fo);
-if (javaSource != null) {
-try {
-javaSource.runUserActionTask(new Task() 
{
-@Override
-public void run(CompilationController 
compilationController) throws Exception {
-
compilationController.toPhase(JavaSource.Phase.ELEMENTS_RESOLVED);
- 

[netbeans] branch release110-gradle-patch-1 created (now b2a39ac)

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a change to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


  at b2a39ac  [NETBEANS-2035] Enable Always show Gradle Build output by 
default.

This branch includes the following new commits:

 new aebe5f9  [NETBEANS-2346] Fixed index out of bound exception in GAV 
parsing.
 new bad021c  [NETBEANS-2378] Tighten the Groovy more to the Gralde plugin
 new 152d90d  [NETBEANS-2348] Added support for 'Test Package'.
 new e2dbd27  [NETBEANS-2348] Less intrustive support for Test Package.
 new c3071d7  [NETBEANS-2293] Fix possible NPE on selected method detection.
 new f5ecf6f  [NETBEANS-2399] Make sub Project node as a Tree based on the 
paths on the Gradle projects
 new b2a39ac  [NETBEANS-2035] Enable Always show Gradle Build output by 
default.

The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] 02/07: [NETBEANS-2378] Tighten the Groovy more to the Gralde plugin

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit bad021ced2440cbe21b3df825a568d91c6991ffc
Author: Laszlo Kishalmi 
AuthorDate: Tue Apr 9 06:38:06 2019 -0700

[NETBEANS-2378] Tighten the Groovy more to the Gralde plugin
---
 groovy/gradle/manifest.mf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/groovy/gradle/manifest.mf b/groovy/gradle/manifest.mf
index b80a5f9..fedf0d3 100644
--- a/groovy/gradle/manifest.mf
+++ b/groovy/gradle/manifest.mf
@@ -4,3 +4,4 @@ OpenIDE-Module: org.netbeans.modules.gradle
 OpenIDE-Module-Layer: org/netbeans/modules/gradle/layer.xml
 OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gradle/Bundle.properties
 OpenIDE-Module-Specification-Version: 1.0.1
+


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] 07/07: [NETBEANS-2035] Enable Always show Gradle Build output by default.

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit b2a39acaf2b8fb931b461654f92e1414fdb84128
Author: Laszlo Kishalmi 
AuthorDate: Fri Apr 26 11:34:46 2019 -0700

[NETBEANS-2035] Enable Always show Gradle Build output by default.
---
 groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java 
b/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
index 20bb104..6a0102d 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java
@@ -170,7 +170,7 @@ public final class GradleSettings {
 }
 
 public boolean isAlwaysShowOutput() {
-return getPreferences().getBoolean(PROP_ALWAYS_SHOW_OUTPUT, false);
+return getPreferences().getBoolean(PROP_ALWAYS_SHOW_OUTPUT, true);
 }
 
 public void setStartDaemonOnStart(boolean b) {


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] 03/07: [NETBEANS-2348] Added support for 'Test Package'.

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit 152d90d3f2630a98a19476b7b287794ceb525b1c
Author: Laszlo Kishalmi 
AuthorDate: Sat Apr 6 10:55:46 2019 -0700

[NETBEANS-2348] Added support for 'Test Package'.
---
 .../gradle/java/GradleJavaTokenProvider.java   | 32 ++
 .../modules/gradle/java/JavaActionProvider.java| 30 +---
 .../modules/gradle/java/action-mapping.xml |  3 ++
 .../modules/gradle/ActionProviderImpl.java | 19 +++--
 .../gradle/execute/GradleDaemonExecutor.java   |  4 +--
 5 files changed, 62 insertions(+), 26 deletions(-)

diff --git 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
index d396a45..980c122 100644
--- 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
+++ 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
@@ -57,11 +57,12 @@ import org.openide.util.Lookup;
 public class GradleJavaTokenProvider implements ReplaceTokenProvider {
 
 private static final Set SUPPORTED = 
Collections.unmodifiableSet(new HashSet(Arrays.asList(
-"selectedClass",
-"selectedMethod",
-"affectedBuildTasks"
+"selectedClass",   //NOI18N
+"selectedMethod",  //NOI18N
+"selectedPackage", //NOI18N
+"affectedBuildTasks"   //NOI18N
 )));
-
+
 final Project project;
 
 public GradleJavaTokenProvider(Project project) {
@@ -76,22 +77,29 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 @Override
 public Map createReplacements(String action, Lookup 
context) {
 Map ret = new HashMap<>();
-processSelectedClass(ret, context);
+processSelectedPackageAndClass(ret, context);
 processSelectedMethod(ret, context);
 processSourceSets(ret, context);
 return ret;
 }
 
-private void processSelectedClass(final Map map, Lookup 
context) {
+private void processSelectedPackageAndClass(final Map map, 
Lookup context) {
 FileObject fo = RunUtils.extractFileObjectfromLookup(context);
 GradleJavaProject gjp = GradleJavaProject.get(project);
 if ((gjp != null) && (fo != null)) {
 File f = FileUtil.toFile(fo);
 GradleJavaSourceSet sourceSet = gjp.containingSourceSet(f);
-if (sourceSet != null) {
-String relPath = sourceSet.relativePath(f);
-String className = relPath.substring(0, 
relPath.lastIndexOf('.')).replace('/', '.');
-map.put("selectedClass", className);
+if (sourceSet != null)  {
+if (f.isFile()) {
+String relPath = sourceSet.relativePath(f);
+String className = (relPath.lastIndexOf('.') > 0 ?
+relPath.substring(0, relPath.lastIndexOf('.')) :
+relPath).replace('/', '.');
+map.put("selectedClass", className);  //NOI18N
+f = f.getParentFile();
+}
+String pkg = sourceSet.relativePath(f).replace('/', '.');
+map.put("selectedPackage", pkg); //NOI18N
 }
 }
 }
@@ -102,7 +110,7 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 String methodName = method != null ? method.getMethodName() : null;
 if (fo != null) {
  String selectedMethod = evaluateSingleMethod(fo, methodName);
- map.put("selectedMethod", selectedMethod);
+ map.put("selectedMethod", selectedMethod); //NOI18N
 }
 }
 
@@ -125,7 +133,7 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 for (String task : buildTasks) {
 tasks.append(task).append(' ');
 }
-map.put("affectedBuildTasks", tasks.toString());
+map.put("affectedBuildTasks", tasks.toString()); //NOI18N
 }
 }
 
diff --git 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
index 305c786..3add6f2 100644
--- 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
+++ 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
@@ -25,6 +25,7 @@ import org.netbeans.modules.gradle.java.api.GradleJavaProject;
 import org.netbeans.modules.gradle.java.api.GradleJavaSourceSet;
 import org.netbeans.modules.gradle.spi.actions.DefaultGradleActionsProvider;
 import org.netbeans.modules.gradle.spi.actions.GradleActions

[netbeans] 06/07: [NETBEANS-2399] Make sub Project node as a Tree based on the paths on the Gradle projects

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit f5ecf6fc867cffdbe2d8433497f2ebb1315c1a19
Author: Laszlo Kishalmi 
AuthorDate: Sat Apr 20 08:01:36 2019 -0700

[NETBEANS-2399] Make sub Project node as a Tree based on the paths on
the Gradle projects
---
 .../modules/gradle/nodes/SubProjectsNode.java  | 79 --
 1 file changed, 58 insertions(+), 21 deletions(-)

diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java 
b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
index 3b25ef5..0114cb0 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/SubProjectsNode.java
@@ -30,6 +30,7 @@ import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.HashSet;
 import java.util.List;
 import javax.swing.AbstractAction;
 import javax.swing.Action;
@@ -53,6 +54,11 @@ import org.openide.util.WeakListeners;
 
 import static org.netbeans.modules.gradle.nodes.Bundle.*;
 import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import org.netbeans.modules.gradle.spi.Utils;
+import org.openide.ErrorManager;
+import org.openide.nodes.Children;
 
 /**
  *
@@ -63,14 +69,23 @@ public class SubProjectsNode extends AbstractNode {
 @StaticResource
 private static final String SP_BADGE
 = "org/netbeans/modules/gradle/resources/gradle-badge.png";
-private final NbGradleProjectImpl proj;
 
 @NbBundle.Messages("LBL_SubProjects=Sub Projects")
+public SubProjectsNode(NbGradleProjectImpl proj, String path) {
+super(FilterNode.Children.create(new SubProjectsChildFactory(proj, 
path), true));
+if (":".equals(path)) { //NOI18N
+setName("SubProjects"); //NOI18N
+setDisplayName(LBL_SubProjects());
+} else {
+int colon = path.lastIndexOf(':', path.length() - 2);
+String partName = path.substring(colon + 1, path.length() - 1);
+setDisplayName(Utils.capitalize(partName));
+setName(path);
+}
+}
+
 public SubProjectsNode(NbGradleProjectImpl proj) {
-super(FilterNode.Children.create(new SubProjectsChildFactory(proj), 
true));
-this.proj = proj;
-setName("SubProjects"); //NOI18N
-setDisplayName(LBL_SubProjects());
+this(proj, ":"); //NOI18N
 }
 
 @Override
@@ -78,7 +93,7 @@ public class SubProjectsNode extends AbstractNode {
 return new Action[]{};
 }
 
-private Image getIcon(boolean opened) {
+private static Image getIcon(boolean opened) {
 Image badge = ImageUtilities.loadImage(SP_BADGE, true); //NOI18N
 return ImageUtilities.mergeImages(NodeUtils.getTreeFolderIcon(opened), 
badge, 8, 8);
 }
@@ -93,13 +108,15 @@ public class SubProjectsNode extends AbstractNode {
 return getIcon(true);
 }
 
-private static class SubProjectsChildFactory extends 
ChildFactory {
+private static class SubProjectsChildFactory extends ChildFactory {
 
 private final NbGradleProjectImpl project;
 private final PropertyChangeListener listener;
+private final String rootPath;
 
-SubProjectsChildFactory(NbGradleProjectImpl proj) {
+SubProjectsChildFactory(NbGradleProjectImpl proj, String rootPath) {
 project = proj;
+this.rootPath = rootPath;
 NbGradleProject watcher = project.getProjectWatcher();
 listener = new PropertyChangeListener() {
 @Override
@@ -115,34 +132,54 @@ public class SubProjectsNode extends AbstractNode {
 }
 
 @Override
-protected boolean createKeys(final List modules) {
+protected boolean createKeys(final List paths) {
 Map subProjects = 
project.getGradleProject().getBaseProject().getSubProjects();
+Set components = new TreeSet();
+Set projects = new TreeSet<>();
 for (String path : subProjects.keySet()) {
-File projDir = subProjects.get(path);
-FileObject fo = FileUtil.toFileObject(projDir);
+if (path.startsWith(rootPath)) {
+String relPath = path.substring(rootPath.length());
+int firstColon = relPath.indexOf(':');
+int lastColon = relPath.lastIndexOf(':');
+if ((firstColon >= 0) && (firstColon == lastColon)) {
+components.add(path.substring(0, rootPath.length() + 
firstColon + 1));
+}
+if (firstColon < 0 ) {
+projects.add(path);
+}
+}
+}
+paths.addA

[netbeans] 04/07: [NETBEANS-2348] Less intrustive support for Test Package.

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit e2dbd2756ab0f03d1e977d168db6519f0bed7dfd
Author: Laszlo Kishalmi 
AuthorDate: Fri Apr 12 20:00:58 2019 -0700

[NETBEANS-2348] Less intrustive support for Test Package.
---
 .../gradle/java/GradleJavaTokenProvider.java   |  6 +-
 .../modules/gradle/java/JavaActionProvider.java| 65 ++
 .../modules/gradle/java/action-mapping.xml |  3 -
 .../modules/gradle/ActionProviderImpl.java | 19 +--
 4 files changed, 34 insertions(+), 59 deletions(-)

diff --git 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
index 980c122..87018fb 100644
--- 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
+++ 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java
@@ -59,7 +59,6 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 private static final Set SUPPORTED = 
Collections.unmodifiableSet(new HashSet(Arrays.asList(
 "selectedClass",   //NOI18N
 "selectedMethod",  //NOI18N
-"selectedPackage", //NOI18N
 "affectedBuildTasks"   //NOI18N
 )));
 
@@ -97,9 +96,10 @@ public class GradleJavaTokenProvider implements 
ReplaceTokenProvider {
 relPath).replace('/', '.');
 map.put("selectedClass", className);  //NOI18N
 f = f.getParentFile();
+} else {
+String pkg = sourceSet.relativePath(f).replace('/', '.');
+map.put("selectedClass", pkg + "*"); //NOI18N
 }
-String pkg = sourceSet.relativePath(f).replace('/', '.');
-map.put("selectedPackage", pkg); //NOI18N
 }
 }
 }
diff --git 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
index 3add6f2..4aab8cb 100644
--- 
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
+++ 
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/JavaActionProvider.java
@@ -47,7 +47,6 @@ import org.openide.util.lookup.ServiceProvider;
 @ServiceProvider(service = GradleActionsProvider.class)
 public class JavaActionProvider extends DefaultGradleActionsProvider {
 
-public static final String COMMAND_TEST_SINGLE_PACKAGE = 
"test.single.package"; //NOI18N
 private static final String GATLING_PLUGIN = 
"com.github.lkishalmi.gatling"; //NOI18N
 private static final String SIMULATION_POSTFIX = "Simulation.scala"; 
//NOI18N
 
@@ -67,7 +66,6 @@ public class JavaActionProvider extends 
DefaultGradleActionsProvider {
 COMMAND_RUN_SINGLE,
 COMMAND_DEBUG_SINGLE,
 COMMAND_COMPILE_SINGLE,
-COMMAND_TEST_SINGLE_PACKAGE
 };
 
 public JavaActionProvider() {
@@ -86,47 +84,42 @@ public class JavaActionProvider extends 
DefaultGradleActionsProvider {
 } else {
 ret = false;
 GradleJavaProject gjp = GradleJavaProject.get(project);
-switch (action) {
-case COMMAND_COMPILE_SINGLE:
-FileBuiltQuery.Status status = 
FileBuiltQuery.getStatus(fo);
-ret = status == null || !status.isBuilt();
-break;
-case COMMAND_DEBUG_SINGLE:
-case COMMAND_RUN_SINGLE: {
-if (RunUtils.isAugmentedBuildEnabled(project) && 
(gjp != null)) {
-File f = FileUtil.toFile(fo);
-GradleJavaSourceSet sourceSet = 
gjp.containingSourceSet(f);
-if ((sourceSet != null) && fo.isData()) {
-String relPath = sourceSet.relativePath(f);
-if (relPath != null) {
-relPath = relPath.substring(0, 
relPath.lastIndexOf('.')).replace('/', '.');
-ret = SourceUtils.isMainClass(relPath, 
ClasspathInfo.create(fo), true);
+if ( gjp != null ) {
+switch (action) {
+case COMMAND_COMPILE_SINGLE:
+FileBuiltQuery.Status status = 
FileBuiltQuery.getStatus(fo);
+ret = status == null || !status.isBuilt();
+break;
+case COMMAND_DEBUG_SINGLE:
+case COMMAND_RUN_SINGL

[netbeans] 01/07: [NETBEANS-2346] Fixed index out of bound exception in GAV parsing.

2019-05-07 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch release110-gradle-patch-1
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit aebe5f9bf438c7df73d5fdac1ce3b9c10c634796
Author: Laszlo Kishalmi 
AuthorDate: Sat Apr 6 05:35:25 2019 -0700

[NETBEANS-2346] Fixed index out of bound exception in GAV parsing.
---
 .../modules/gradle/api/GradleBaseProject.java  |  2 +-
 .../modules/gradle/api/GradleConfiguration.java|  2 +-
 .../modules/gradle/api/GradleDependency.java   | 15 -
 .../modules/gradle/nodes/ConfigurationsNode.java   |  4 +-
 .../actions/ActionMappingPropertyReaderTest.java   | 22 +++---
 .../modules/gradle/api/GradleDepandencyTest.java   | 78 ++
 6 files changed, 105 insertions(+), 18 deletions(-)

diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java 
b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
index 8c16759..49a4f14 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleBaseProject.java
@@ -256,7 +256,7 @@ public final class GradleBaseProject implements 
Serializable, ModuleSearchSuppor
 
 @Override
 public Set findModules(String gav) {
-String parts[] = gav.split(":");
+String parts[] = GradleDependency.gavSplit(gav);
 if (parts.length != 3) {
 throw new IllegalArgumentException("Invalid gav filter: "  + gav);
 }
diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java 
b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
index f269b5e..fe6b233 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleConfiguration.java
@@ -86,7 +86,7 @@ public final class GradleConfiguration implements 
Serializable, ModuleSearchSupp
 
 @Override
 public Set findModules(String gav) {
-String parts[] = gav.split(":");
+String parts[] = GradleDependency.gavSplit(gav);
 if (parts.length != 3) {
 throw new IllegalArgumentException("Invalid gav filter: "  + gav);
 }
diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java 
b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
index 7d1decb..ab2b588 100644
--- a/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
+++ b/groovy/gradle/src/org/netbeans/modules/gradle/api/GradleDependency.java
@@ -63,6 +63,19 @@ public abstract class GradleDependency implements 
Serializable, Comparable artifacts) {
 super(id);
 this.artifacts = artifacts;
-String[] parts = id.split(":");
+String[] parts = gavSplit(id);
 group = parts[0];
 name = parts[1];
 version = parts[2];
diff --git 
a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java 
b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
index e57077e..4300195 100644
--- 
a/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
+++ 
b/groovy/gradle/src/org/netbeans/modules/gradle/nodes/ConfigurationsNode.java
@@ -290,7 +290,7 @@ public class ConfigurationsNode extends AbstractNode {
 GradleProject gp = project.getGradleProject();
 ArrayList ret = new ArrayList<>();
 GradleConfiguration conf = 
gp.getBaseProject().getConfigurations().get(configuration);
-// We can get null here ins ome extreme cases, e.g. when the 
project is being deleted
+// We can get null here in some extreme cases, e.g. when the 
project is being deleted
 if (conf != null) {
 ret.addAll(conf.getUnresolved());
 ret.addAll(conf.getProjects());
@@ -370,7 +370,7 @@ public class ConfigurationsNode extends AbstractNode {
 
 @Override
 public String getDisplayName() {
-return module.getName() + ":" + module.getVersion();
+return module.getVersion().isEmpty() ? module.getName() : 
module.getName() + ":" + module.getVersion();
 }
 
 @Override
diff --git 
a/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
 
b/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
index 99a7dfd..d6ad668 100644
--- 
a/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
+++ 
b/groovy/gradle/test/unit/src/org/netbeans/modules/gradle/actions/ActionMappingPropertyReaderTest.java
@@ -22,10 +22,6 @@ import java.util.Arrays;
 import java.util.HashSet;
 import java.util.Properties;
 import java.util.Set;
-import org.junit.After;
-import org.junit.AfterClass;
-import 

[jira] [Resolved] (NETBEANS-2350) Null pointer exception while doing auto complete in rule switch block

2019-05-07 Thread vikas kumar prabhakar (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vikas kumar prabhakar resolved NETBEANS-2350.
-
Resolution: Fixed

> Null pointer exception while doing auto complete in rule switch block
> -
>
> Key: NETBEANS-2350
> URL: https://issues.apache.org/jira/browse/NETBEANS-2350
> Project: NetBeans
>  Issue Type: Bug
>Reporter: vikas kumar prabhakar
>Assignee: vikas kumar prabhakar
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Null pointer exception while doing auto complete in rule switch block
> Code scenario:
> enum Days\{MON, TUES, WED, THUR, FRI};
> private static void test1(Days day) {
> switch (day)
> { case FRI -> 
> System.out.println("javaapplication2.JavaApplication2.test1()");   position>   --> Auto complete press 'Ctrl+Space' throw Null pointer exception 
> }
> }
>  
>  
> java.lang.NullPointerException
> at 
> org.netbeans.modules.java.completion.JavaCompletionTask.insideSwitch(JavaCompletionTask.java:2296)
> at 
> org.netbeans.modules.java.completion.JavaCompletionTask.resolve(JavaCompletionTask.java:412)
> at org.netbeans.modules.java.completion.BaseTask.run(BaseTask.java:93)
> at 
> org.netbeans.modules.java.completion.JavaCompletionTask.run(JavaCompletionTask.java:60)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
> at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
> at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
> at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
> at 
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
> at 
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
> at 
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
> Caused: org.netbeans.modules.parsing.spi.ParseException
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:186)
> at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
> [catch] at 
> org.netbeans.modules.editor.java.JavaCompletionProvider$JavaCompletionQuery.query(JavaCompletionProvider.java:193)
> at 
> org.netbeans.spi.editor.completion.support.AsyncCompletionTask.run(AsyncCompletionTask.java:198)
> at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
> at 
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
> at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-2350) Null pointer exception while doing auto complete in rule switch block

2019-05-07 Thread vikas kumar prabhakar (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vikas kumar prabhakar closed NETBEANS-2350.
---

> Null pointer exception while doing auto complete in rule switch block
> -
>
> Key: NETBEANS-2350
> URL: https://issues.apache.org/jira/browse/NETBEANS-2350
> Project: NetBeans
>  Issue Type: Bug
>Reporter: vikas kumar prabhakar
>Assignee: vikas kumar prabhakar
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Null pointer exception while doing auto complete in rule switch block
> Code scenario:
> enum Days\{MON, TUES, WED, THUR, FRI};
> private static void test1(Days day) {
> switch (day)
> { case FRI -> 
> System.out.println("javaapplication2.JavaApplication2.test1()");   position>   --> Auto complete press 'Ctrl+Space' throw Null pointer exception 
> }
> }
>  
>  
> java.lang.NullPointerException
> at 
> org.netbeans.modules.java.completion.JavaCompletionTask.insideSwitch(JavaCompletionTask.java:2296)
> at 
> org.netbeans.modules.java.completion.JavaCompletionTask.resolve(JavaCompletionTask.java:412)
> at org.netbeans.modules.java.completion.BaseTask.run(BaseTask.java:93)
> at 
> org.netbeans.modules.java.completion.JavaCompletionTask.run(JavaCompletionTask.java:60)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
> at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
> at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
> at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
> at 
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
> at 
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
> at 
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
> Caused: org.netbeans.modules.parsing.spi.ParseException
> at 
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:186)
> at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
> [catch] at 
> org.netbeans.modules.editor.java.JavaCompletionProvider$JavaCompletionQuery.query(JavaCompletionProvider.java:193)
> at 
> org.netbeans.spi.editor.completion.support.AsyncCompletionTask.run(AsyncCompletionTask.java:198)
> at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
> at 
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
> at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



svn commit: r33939 - /dev/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/ /release/netbeans/netbeans-html4j/ /release/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/

2019-05-07 Thread jtulach
Author: jtulach
Date: Wed May  8 03:54:51 2019
New Revision: 33939

Log:
Release Apache NetBeans HTML/Java API 1.6.1

Added:
release/netbeans/netbeans-html4j/
release/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/
  - copied from r33906, dev/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/
Removed:
dev/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/

release/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/netbeans-html4j-1.6.1.zip.md5

release/netbeans/netbeans-html4j/netbeans-html4j-1.6.1/netbeans-html4j-1.6.1.zip.sha1


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-2437) Unit tests of php.editor fail

2019-05-07 Thread Junichi Yamamoto (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Junichi Yamamoto resolved NETBEANS-2437.

   Resolution: Fixed
Fix Version/s: Next

> Unit tests of php.editor fail
> -
>
> Key: NETBEANS-2437
> URL: https://issues.apache.org/jira/browse/NETBEANS-2437
> Project: NetBeans
>  Issue Type: Bug
>  Components: php - Editor
>Affects Versions: 11.0
>Reporter: Junichi Yamamoto
>Assignee: Junichi Yamamoto
>Priority: Major
>  Labels: pull-request-available
> Fix For: Next
>
> Attachments: log1.txt, log2.txt, nb-php-unit-test-errors-1.png, 
> nb-php-unit-test-errors-2.png, nb-php-unit-test-errors-3.png, 
> nb-php-unit-test-errors-4.png, nb-php-unit-test-errors-5.png
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Some unit tests fail.
> h2. Steps to reproduce
> # Open php.editor module
> # Right-click the module then click Run
> # Install Oracle JS Parser implementation
> # Stop the module
> # Open a unit test file: see the below
> # Right-click the editor
> # Click Run File or Test File
> I've investigated a bit. It seems that unit tests fail after GraalJS Parser 
> is removed.
>  commit: 
> [https://github.com/apache/incubator-netbeans/commit/3357fa5b18590908ac9de4ad7e55ab1fdf88cd50]
> e.g.
>  - 
> [https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/actions/ImportDataCreatorTest.java]
>  - 
> [https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/indent/PHPFormatterHtmlTest.java]
> Unit tests passed when I've checkout 
> [https://github.com/apache/incubator-netbeans/commit/123f616488cbd335d63da493bb19b1aaabd0ac2f]
>  (previous commit)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-2437) Unit tests of php.editor fail

2019-05-07 Thread Junichi Yamamoto (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Junichi Yamamoto reassigned NETBEANS-2437:
--

Assignee: Junichi Yamamoto

> Unit tests of php.editor fail
> -
>
> Key: NETBEANS-2437
> URL: https://issues.apache.org/jira/browse/NETBEANS-2437
> Project: NetBeans
>  Issue Type: Bug
>  Components: php - Editor
>Affects Versions: 11.0
>Reporter: Junichi Yamamoto
>Assignee: Junichi Yamamoto
>Priority: Major
>  Labels: pull-request-available
> Attachments: log1.txt, log2.txt, nb-php-unit-test-errors-1.png, 
> nb-php-unit-test-errors-2.png, nb-php-unit-test-errors-3.png, 
> nb-php-unit-test-errors-4.png, nb-php-unit-test-errors-5.png
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Some unit tests fail.
> h2. Steps to reproduce
> # Open php.editor module
> # Right-click the module then click Run
> # Install Oracle JS Parser implementation
> # Stop the module
> # Open a unit test file: see the below
> # Right-click the editor
> # Click Run File or Test File
> I've investigated a bit. It seems that unit tests fail after GraalJS Parser 
> is removed.
>  commit: 
> [https://github.com/apache/incubator-netbeans/commit/3357fa5b18590908ac9de4ad7e55ab1fdf88cd50]
> e.g.
>  - 
> [https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/actions/ImportDataCreatorTest.java]
>  - 
> [https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/indent/PHPFormatterHtmlTest.java]
> Unit tests passed when I've checkout 
> [https://github.com/apache/incubator-netbeans/commit/123f616488cbd335d63da493bb19b1aaabd0ac2f]
>  (previous commit)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-2437] Unit tests of php.editor fail (#1232)

2019-05-07 Thread junichi11
This is an automated email from the ASF dual-hosted git repository.

junichi11 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new aaf699d  [NETBEANS-2437] Unit tests of php.editor fail (#1232)
aaf699d is described below

commit aaf699d492d0f0d74d954c7f37d811a4b17166ba
Author: Junichi Yamamoto 
AuthorDate: Wed May 8 07:44:04 2019 +0900

[NETBEANS-2437] Unit tests of php.editor fail (#1232)

- Fix nashorn.prepend and bootclasspath.prepend of project.properties
- Add libs.nashorn as test dependency
---
 php/php.editor/nbproject/project.properties   | 4 ++--
 php/php.editor/nbproject/project.xml  | 6 ++
 webcommon/javascript2.editor/nbproject/project.properties | 4 ++--
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/php/php.editor/nbproject/project.properties 
b/php/php.editor/nbproject/project.properties
index b19c4dd..7498378 100644
--- a/php/php.editor/nbproject/project.properties
+++ b/php/php.editor/nbproject/project.properties
@@ -78,5 +78,5 @@ test.config.stableBTD.excludes=\
 **/ParamDeclTypes68Test.class,\
 **/SemanticAnalyzerTest.class,\
 **/ToggleBlockCommentActionTest.class
-nashorn.prepend=${basedir}/../libs.nashorn/external/nashorn-02f810c26ff9-patched.jar
-bootclasspath.prepend=${nashorn.prepend}${path.separator}${basedir}/../libs.nashorn/external/asm-all-4.0.jar
+nashorn.prepend=${basedir}/../../webcommon/libs.nashorn/external/com.oracle.js.parser-ba7a8bc42268.jar
+bootclasspath.prepend=${nashorn.prepend}
diff --git a/php/php.editor/nbproject/project.xml 
b/php/php.editor/nbproject/project.xml
index a86e530..22f3d4e 100644
--- a/php/php.editor/nbproject/project.xml
+++ b/php/php.editor/nbproject/project.xml
@@ -474,6 +474,12 @@
 
 
 
+
org.netbeans.libs.nashorn
+
+
+
+
+
 
org.netbeans.modules.csl.api
 
 
diff --git a/webcommon/javascript2.editor/nbproject/project.properties 
b/webcommon/javascript2.editor/nbproject/project.properties
index d0cafa8..7390cea 100644
--- a/webcommon/javascript2.editor/nbproject/project.properties
+++ b/webcommon/javascript2.editor/nbproject/project.properties
@@ -29,5 +29,5 @@ extra.module.files=\
 jsstubs/reststubs.zip
 jnlp.indirect.jars=jsstubs/*.zip
 
-nashorn.prepend=${basedir}/../libs.nashorn/external/nashorn-02f810c26ff9-patched.jar
-bootclasspath.prepend=${nashorn.prepend}${path.separator}${basedir}/../libs.nashorn/external/asm-all-4.0.jar
+nashorn.prepend=${basedir}/../libs.nashorn/external/com.oracle.js.parser-ba7a8bc42268.jar
+bootclasspath.prepend=${nashorn.prepend}


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2455) Splash screens for development version

2019-05-07 Thread Antonio Vieiro (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835140#comment-16835140
 ] 

Antonio Vieiro commented on NETBEANS-2455:
--

Mmmm Two more unexpected pngs enter the party...
 * ./ide.branding/core.startup/src/org/netbeans/core/startup/about_dark_nb.png
 * ./ide.branding/core.startup/src/org/netbeans/core/startup/about_nb.png

> Splash screens for development version
> --
>
> Key: NETBEANS-2455
> URL: https://issues.apache.org/jira/browse/NETBEANS-2455
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - UI
>Reporter: Junichi Yamamoto
>Assignee: Antonio Vieiro
>Priority: Major
>  Labels: pull-request-available
> Attachments: apache-netbeans-splash.png, apache-netbeans-splash.svg, 
> splash.png
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently, the version of the splash screen is 10 in the master branch. So we 
> should fix it (e.g. Dev., Development Version, ...).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2514) remove sun.misc.Unsafe

2019-05-07 Thread Brad Walker (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835122#comment-16835122
 ] 

Brad Walker commented on NETBEANS-2514:
---

I believe that I follow the logic. But, making a change such as this is beyond 
my current knowledge/experience and I would be unconfortable doing it. Hence, 
the reason that I simply wanted to keep the change to removing use of 
sun.misc.Unsafe.

> remove sun.misc.Unsafe
> --
>
> Key: NETBEANS-2514
> URL: https://issues.apache.org/jira/browse/NETBEANS-2514
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Brad Walker
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> NetBeans uses a proprietary API that will be removed in the future.
> Therefore, try to remove the use of sun.misc.Unsafe.
>  
> {quote}...compile:
>  [nb-javac] Compiling 212 source files to 
> /home/bwalker/src/netbeans-11.0-test/java/java.source.base/build/classes
>    [repeat] 
> /home/bwalker/src/netbeans-11.0-test/java/java.source.base/src/org/netbeans/modules/java/source/NoJavacHelper.java:34:
>  warning: Unsafe is internal proprietary API and may be removed in a future 
> release
>    [repeat] import sun.misc.Unsafe;
>    [repeat]    ^
> ...
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2514) remove sun.misc.Unsafe

2019-05-07 Thread Brad Walker (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835120#comment-16835120
 ] 

Brad Walker commented on NETBEANS-2514:
---

I think I follow your logic. But, a change like this is something that I'm 
uncomfortable doing since I just don't have the knowledge/experience to do it 
correctly.

This is why I simply wanted to keep my change to just removing the use of 
sun.misc.Unsafe.

> remove sun.misc.Unsafe
> --
>
> Key: NETBEANS-2514
> URL: https://issues.apache.org/jira/browse/NETBEANS-2514
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Brad Walker
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> NetBeans uses a proprietary API that will be removed in the future.
> Therefore, try to remove the use of sun.misc.Unsafe.
>  
> {quote}...compile:
>  [nb-javac] Compiling 212 source files to 
> /home/bwalker/src/netbeans-11.0-test/java/java.source.base/build/classes
>    [repeat] 
> /home/bwalker/src/netbeans-11.0-test/java/java.source.base/src/org/netbeans/modules/java/source/NoJavacHelper.java:34:
>  warning: Unsafe is internal proprietary API and may be removed in a future 
> release
>    [repeat] import sun.misc.Unsafe;
>    [repeat]    ^
> ...
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2514) remove sun.misc.Unsafe

2019-05-07 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-2514:
-
Labels: pull-request-available  (was: )

> remove sun.misc.Unsafe
> --
>
> Key: NETBEANS-2514
> URL: https://issues.apache.org/jira/browse/NETBEANS-2514
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Brad Walker
>Priority: Major
>  Labels: pull-request-available
>
> NetBeans uses a proprietary API that will be removed in the future.
> Therefore, try to remove the use of sun.misc.Unsafe.
>  
> {quote}...compile:
>  [nb-javac] Compiling 212 source files to 
> /home/bwalker/src/netbeans-11.0-test/java/java.source.base/build/classes
>    [repeat] 
> /home/bwalker/src/netbeans-11.0-test/java/java.source.base/src/org/netbeans/modules/java/source/NoJavacHelper.java:34:
>  warning: Unsafe is internal proprietary API and may be removed in a future 
> release
>    [repeat] import sun.misc.Unsafe;
>    [repeat]    ^
> ...
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2455) Splash screens for development version

2019-05-07 Thread Antonio Vieiro (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835021#comment-16835021
 ] 

Antonio Vieiro commented on NETBEANS-2455:
--

Hi all,

Just a quick update on the progress on this.I'm adding ${buildnum} in the 
splash screen. I think that's the proper property value to add to the splash 
screen, right?

Here's how it's looking right now. Note the room at the bottom for the progress 
bar and the running text. The build number is imprinted with a slight white 
alpha to improve readibility, don't know if that's what we want, though.

 

!splash.png!

 

As requested eariler, alternate SVG solutions are most welcome!.

 

> Splash screens for development version
> --
>
> Key: NETBEANS-2455
> URL: https://issues.apache.org/jira/browse/NETBEANS-2455
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - UI
>Reporter: Junichi Yamamoto
>Assignee: Antonio Vieiro
>Priority: Major
>  Labels: pull-request-available
> Attachments: apache-netbeans-splash.png, apache-netbeans-splash.svg, 
> splash.png
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently, the version of the splash screen is 10 in the master branch. So we 
> should fix it (e.g. Dev., Development Version, ...).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2455) Splash screens for development version

2019-05-07 Thread Antonio Vieiro (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Vieiro updated NETBEANS-2455:
-
Attachment: splash.png

> Splash screens for development version
> --
>
> Key: NETBEANS-2455
> URL: https://issues.apache.org/jira/browse/NETBEANS-2455
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - UI
>Reporter: Junichi Yamamoto
>Assignee: Antonio Vieiro
>Priority: Major
>  Labels: pull-request-available
> Attachments: apache-netbeans-splash.png, apache-netbeans-splash.svg, 
> splash.png
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently, the version of the splash screen is 10 in the master branch. So we 
> should fix it (e.g. Dev., Development Version, ...).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2515) cleanup the build issues

2019-05-07 Thread Brad Walker (JIRA)
Brad Walker created NETBEANS-2515:
-

 Summary: cleanup the build issues
 Key: NETBEANS-2515
 URL: https://issues.apache.org/jira/browse/NETBEANS-2515
 Project: NetBeans
  Issue Type: Improvement
Reporter: Brad Walker


The build process has a lot of errors/warnings.

I've created this Jira to track all the issues related to cleaning up

The first canidate is: NETBEANS-2514



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2514) remove sun.misc.Unsafe

2019-05-07 Thread Brad Walker (JIRA)
Brad Walker created NETBEANS-2514:
-

 Summary: remove sun.misc.Unsafe
 Key: NETBEANS-2514
 URL: https://issues.apache.org/jira/browse/NETBEANS-2514
 Project: NetBeans
  Issue Type: Improvement
Reporter: Brad Walker


NetBeans uses a proprietary API that will be removed in the future.

Therefore, try to remove the use of sun.misc.Unsafe.

 
{quote}...compile:
 [nb-javac] Compiling 212 source files to 
/home/bwalker/src/netbeans-11.0-test/java/java.source.base/build/classes
   [repeat] 
/home/bwalker/src/netbeans-11.0-test/java/java.source.base/src/org/netbeans/modules/java/source/NoJavacHelper.java:34:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
   [repeat] import sun.misc.Unsafe;
   [repeat]    ^

...
{quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2513) LESS syntax checker display error when use each function

2019-05-07 Thread Ivan Borisov (JIRA)
Ivan Borisov created NETBEANS-2513:
--

 Summary: LESS syntax checker display error when use each function
 Key: NETBEANS-2513
 URL: https://issues.apache.org/jira/browse/NETBEANS-2513
 Project: NetBeans
  Issue Type: Bug
  Components: web - CSS Preprocessors (SASS, LESS, ...)
Affects Versions: 10.0
 Environment: 
Product Version: Apache NetBeans IDE 10.0 (Build 
incubator-netbeans-release-380-on-20181217)
Java: 11.0.2; OpenJDK 64-Bit Server VM 11.0.2+9-Ubuntu-3ubuntu118.04.3
Runtime: OpenJDK Runtime Environment 11.0.2+9-Ubuntu-3ubuntu118.04.3
System: Linux version 4.18.0-18-generic running on amd64; UTF-8; bg_BG (nb)
User directory: /home/vankata/.netbeans/10.0
Cache directory: /home/vankata/.cache/netbeans/10.0
Reporter: Ivan Borisov
 Attachments: Screenshot_20190507_184944.png

When use *each* function, syntax checker display error
{code:java}
@selectors: blue, green, red;

each(@selectors, {
  .sel-@{value} {
    a: b;
  }
});{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2512) NullPointerException when I try to Refactor / rename a Java class

2019-05-07 Thread Al Ourtilani (JIRA)
Al Ourtilani created NETBEANS-2512:
--

 Summary: NullPointerException when I try to Refactor / rename a 
Java class
 Key: NETBEANS-2512
 URL: https://issues.apache.org/jira/browse/NETBEANS-2512
 Project: NetBeans
  Issue Type: Bug
Affects Versions: 11.0
 Environment:   Mac OS X, 10.14.4, x86_64
  Java HotSpot(TM) 64-Bit Server VM, 25.181-b13, Java(TM) SE Runtime 
Environment, 1.8.0_181-b13
Reporter: Al Ourtilani



  2019-05-07T16:53:30
  1557240810445
  533
  700
  28
  UI_USER_CONFIGURATION
  UI_USER_CONFIGURATION
  org.netbeans.modules.uihandler.Bundle
  Mac OS X, 10.14.4, x86_64
  Java HotSpot(TM) 64-Bit Server VM, 25.181-b13, Java(TM) SE Runtime 
Environment, 1.8.0_181-b13
  Apache NetBeans IDE 11.0 (Build 
incubator-netbeans-release-404-on-20190319)
  
  NullPointerException at 
org.netbeans.modules.refactoring.java.ui.ContextAnalyzer$NodeToFileObjectTask.run
  
  *


I tried to rename a java class using the Refactor menu from Project view / 
Files view and Editor and nothing happened.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2511) Netbeans IDE toolbars configuration does not work

2019-05-07 Thread Jerome Lelasseux (JIRA)
Jerome Lelasseux created NETBEANS-2511:
--

 Summary: Netbeans IDE toolbars configuration does not work
 Key: NETBEANS-2511
 URL: https://issues.apache.org/jira/browse/NETBEANS-2511
 Project: NetBeans
  Issue Type: Bug
  Components: ide - UI
Affects Versions: 11.0
 Environment: Product Version: Apache NetBeans IDE 11.0 (Build 
incubator-netbeans-release-404-on-20190319)
Java: 1.8.0_73; Java HotSpot(TM) 64-Bit Server VM 25.73-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_73-b02
System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb)

Reporter: Jerome Lelasseux
 Attachments: 2019-05-07 16_20_08-Window.png

Under the IDE 11.0 on Win 10, right-click menu in the toolbar zone to 
add/remove toolbars.

The menu is correct, but adding/removing toolbars does not work: sometimes all 
the toolbars disappear, sometimes nothing change, and I see repaint problems.

Using Reset toolbars is the only way to restore everything OK.

I attached a screen capture right after I removed the File toolbar: nothing 
happens and you see some repaint problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2494) autocomplete deletes instead of completes

2019-05-07 Thread JIRA


[ 
https://issues.apache.org/jira/browse/NETBEANS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834683#comment-16834683
 ] 

René Kraneis commented on NETBEANS-2494:


I've definitely also seen this in NB11 but failed to reproduce it in a "clean" 
(mve) project.

> autocomplete deletes instead of completes
> -
>
> Key: NETBEANS-2494
> URL: https://issues.apache.org/jira/browse/NETBEANS-2494
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.0
> Environment: OS X 10.14.3 (18D109)
> Java 1.8.0_181
> Product Version: Apache NetBeans IDE 11.0 (Build 
> incubator-netbeans-release-404-on-20190319)
> Java: 1.8.0_181; Java HotSpot(TM) 64-Bit Server VM 25.181-b13
> Runtime: Java(TM) SE Runtime Environment 1.8.0_181-b13
> System: Mac OS X version 10.14.3 running on x86_64; UTF-8; en_US (nb)
> User directory: ~/Library/Application Support/NetBeans/11.0
> Cache directory: ~/Library/Caches/NetBeans/11.0
>Reporter: Paul
>Priority: Critical
>
> easily reproducible (on Mac anyway).
> In any java class, inside method body type this:
>  
> OutputStream os = new ByteArra
> then press Ctrl-Space, press down-cursor to go to 
> java.io.ByteArrayOutputStream constructor., press Enter.
> Instead of completing as requestedor offering user input to choose what to 
> actually put there, NB11 deletes the new ByteArra.
> The only way to get it to actually complete is mouse-click.
> Super-long time NB user here - grew accustomed to a pleasurable dev 
> experience, and loss of this functionality is so taxing it's worth just using 
> Eclipse at this point.
>  
> Looking forward to a fix
>  
> Related: NETBEANS-2490



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-2470) Better support for build-helper-maven-plugin plugin - sources added via "add-test-source" cannot be refactored AND add-test-resource is not supported

2019-05-07 Thread ANTONIO FERRER GONZALEZ (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ANTONIO FERRER GONZALEZ reassigned NETBEANS-2470:
-

Assignee: ANTONIO FERRER GONZALEZ

>  Better support for build-helper-maven-plugin plugin - sources added via 
> "add-test-source" cannot be refactored AND add-test-resource is not supported
> --
>
> Key: NETBEANS-2470
> URL: https://issues.apache.org/jira/browse/NETBEANS-2470
> Project: NetBeans
>  Issue Type: Improvement
>  Components: apisupport - Maven
>Affects Versions: 8.2, 9.0, 10.0, 11.0
> Environment: Product Version: Apache NetBeans IDE 11.0 (Build 
> incubator-netbeans-release-404-on-20190319)
> Java: 1.8.0_201; Java HotSpot(TM) 64-Bit Server VM 25.201-b09
> Runtime: Java(TM) SE Runtime Environment 1.8.0_201-b09
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb)
>Reporter: Arnaud Bourrée
>Assignee: ANTONIO FERRER GONZALEZ
>Priority: Major
>
> Old issue https://netbeans.org/bugzilla/show_bug.cgi?id=231240
> When we separate integration tests from unit tests in different folders as 
> suggested 
> [here|https://cwiki.apache.org/confluence/display/MAVENOLD/best+practices+-+testing+strategies]
>  
> We need build-helper-maven-plugin with the following configuration:
> {{
> add-test-source
> 
> add-test-source
> 
> 
> 
> src/it/java
> src/it/resources
> 
> 
> 
> }}
> Many IDEs support second test folder, NetBeans show it as Generated folder: 
> "Generated Test Sources (java)"/ "Generated Test Sourced (resources)" nodes 
> in the project tree.
> And yes you cannot do any refactoring (Move/Copy/Refactoring hints) in 
> classes below those nodes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-1912) java/a*.*

2019-05-07 Thread ANTONIO FERRER GONZALEZ (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ANTONIO FERRER GONZALEZ reassigned NETBEANS-1912:
-

Assignee: ANTONIO FERRER GONZALEZ  (was: Antonio Vieiro)

> java/a*.*
> -
>
> Key: NETBEANS-1912
> URL: https://issues.apache.org/jira/browse/NETBEANS-1912
> Project: NetBeans
>  Issue Type: Sub-task
>  Components: website
>Reporter: Antonio Vieiro
>Assignee: ANTONIO FERRER GONZALEZ
>Priority: Major
>  Labels: documentation, third-donation, tutorials, website
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-2490) Clicking on an autocomplete suggestion in the java editor sometimes does nothing (ie: the code isnt automatically inserted into the editor)

2019-05-07 Thread ANTONIO FERRER GONZALEZ (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ANTONIO FERRER GONZALEZ reassigned NETBEANS-2490:
-

Assignee: ANTONIO FERRER GONZALEZ

> Clicking on an autocomplete suggestion in the java editor sometimes does 
> nothing (ie: the code isnt automatically inserted into the editor)
> ---
>
> Key: NETBEANS-2490
> URL: https://issues.apache.org/jira/browse/NETBEANS-2490
> Project: NetBeans
>  Issue Type: Bug
> Environment: Windows 10, JDK1.8.0_181, Apache Netbeans IDE 11.0
>Reporter: TheYuv
>Assignee: ANTONIO FERRER GONZALEZ
>Priority: Major
> Attachments: assertion_error.txt
>
>
> Sometimes, when the autocomplete suggestions are raised, hitting enter or 
> clicking on a suggestion does not execute the desired result (of putting the 
> suggested code into the editor).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2440) Cannot Debug Focused Test Method with project created by Netbean 8.2 in Netbean 11

2019-05-07 Thread Thai Thien (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834497#comment-16834497
 ] 

Thai Thien commented on NETBEANS-2440:
--

There is work around by edit the project file: 

Edit nbproject/build-impl.xml then make sure 2 following line is available in 
file (I think most case, first line is already there, you need the second line)

 

 


> Cannot Debug Focused Test Method with project created by Netbean 8.2 in 
> Netbean 11
> --
>
> Key: NETBEANS-2440
> URL: https://issues.apache.org/jira/browse/NETBEANS-2440
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 8.2, 11.0
>Reporter: Thai Thien
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> How to reproduce:
>  # Create project with Netbean 8.2 
>  # Create test method in Netbean 8.2 (right click -> Tools -> create/update 
> tests) 
>  # Select (highlight) a method in test, right click -> Debug Focused Test 
> Method. Make sure it can run with Netbean 8.2
>  # Close Netbean 8.2 
>  # Open project with Netbean 11.0 
>  # Select (highlight) a method in test, right click -> Debug Focused Test 
> Method. Make sure it can run with Netbean 8.2
>  # it show error 
> Target "debug-single-method" does not exist in the project "your project name"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists