[jira] [Commented] (NETBEANS-1899) Indexing of PHP array's keys

2019-09-13 Thread Junichi Yamamoto (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929558#comment-16929558
 ] 

Junichi Yamamoto commented on NETBEANS-1899:


My comment is just a workaround(another way) at the moment :)

> Indexing of PHP array's keys
> 
>
> Key: NETBEANS-1899
> URL: https://issues.apache.org/jira/browse/NETBEANS-1899
> Project: NetBeans
>  Issue Type: Improvement
>  Components: php - Code, php - Editor
>Affects Versions: 10.0
>Reporter: Los Vitaly
>Priority: Major
> Attachments: Screenshot from 2019-09-13 19-52-24.png, demo.png
>
>
> NB does not index array's keys and values, so netbeans can't autocomplete 
> associative array keys. It very helpful feature, that prevent from mistyping, 
> etc
> I know, that phpstorm autocomplete it, maybe another IDEs too. I add image 
> for better understanding, because English not my native language :)  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated (511b1a3 -> f93d8f5)

2019-09-13 Thread matthiasblaesing
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


from 511b1a3  [NETBEANS-3097]:Changed font color type name for 
text-block(JDK-13) (#1498)
 new d91d665  [NETBEANS-75] Remove unnecessary dependencies from jna module
 new 7042994  Update netbeans bundled JNA library to 5.4.0
 new 31f6881  Remove deprecated JNA function loadLibrary and use 
@FieldOrder annotation
 new e2feecc  Make the JNA and JNA Platform modules API public exported
 new f93d8f5  Merge pull request #1488 from matthiasblaesing/update-jna

The 2936 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 contrib/libs.svnClientAdapter.svnkit/manifest.mf   |  2 +-
 .../nbproject/project.xml  |  4 +-
 ide/dlight.nativeexecution/nbproject/project.xml   |  4 +-
 .../nativeexecution/LocalNativeProcess.java|  2 +-
 .../nativeexecution/support/Win32APISupport.java   | 21 ++--
 ide/extexecution.process/nbproject/project.xml |  4 +-
 ide/libs.jsch.agentproxy/nbproject/project.xml |  8 +--
 platform/core.nativeaccess/nbproject/project.xml   | 18 +++
 platform/core.network/nbproject/project.xml|  8 +--
 .../proxy/mac/MacCoreFoundationLibrary.java|  7 ++-
 .../core/network/proxy/mac/MacNetworkProxy.java|  2 +-
 .../network/proxy/mac/MacNetworkProxyLibrary.java  |  2 +-
 .../network/proxy/windows/WindowsNetworkProxy.java |  6 +--
 .../proxy/windows/WindowsNetworkProxyLibrary.java  | 32 
 .../core/network/utils/hname/unix/CLib.java|  2 +-
 .../core/network/utils/hname/win/Winsock2Lib.java  |  2 +-
 platform/keyring.impl/nbproject/project.xml| 14 ++---
 .../modules/keyring/gnome/GnomeKeyringLibrary.java | 27 --
 .../modules/keyring/mac/SecurityLibrary.java   |  2 +-
 .../modules/keyring/win32/Win32Protect.java| 18 +++
 platform/libs.jna.platform/external/binaries-list  |  2 +-
 ...-license.txt => jna-platform-5.4.0-license.txt} |  2 +-
 platform/libs.jna.platform/manifest.mf |  4 +-
 .../libs.jna.platform/nbproject/project.properties |  2 +-
 platform/libs.jna.platform/nbproject/project.xml   | 20 
 platform/libs.jna/external/binaries-list   |  2 +-
 ...jna-4.4.0-license.txt => jna-5.4.0-license.txt} |  2 +-
 platform/libs.jna/manifest.mf  |  4 +-
 platform/libs.jna/nbproject/project.properties | 22 
 platform/libs.jna/nbproject/project.xml| 37 ++
 .../src/org/netbeans/libs/jna/Installer.java   |  3 +-
 platform/masterfs.linux/nbproject/project.xml  |  4 +-
 .../masterfs/watcher/linux/LinuxNotifier.java  | 15 +++---
 platform/masterfs.macosx/nbproject/project.xml |  4 +-
 .../masterfs/watcher/macosx/OSXNotifier.java   |  7 +--
 platform/masterfs.windows/nbproject/project.xml|  4 +-
 .../masterfs/watcher/windows/WindowsNotifier.java  | 59 +-
 webcommon/extbrowser.chrome/nbproject/project.xml  | 32 ++--
 .../netbeans/modules/extbrowser/plugins/Utils.java | 19 ++-
 39 files changed, 156 insertions(+), 273 deletions(-)
 rename platform/libs.jna.platform/external/{jna-platform-4.4.0-license.txt => 
jna-platform-5.4.0-license.txt} (99%)
 rename platform/libs.jna/external/{jna-4.4.0-license.txt => 
jna-5.4.0-license.txt} (99%)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-936) In Maven project depending on Guava, viewing Guava's source files is slow

2019-09-13 Thread Jeffrey Morlan (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929395#comment-16929395
 ] 

Jeffrey Morlan commented on NETBEANS-936:
-

Seems to be fixed - I could reproduce this in 11.0 but not in 11.1.

> In Maven project depending on Guava, viewing Guava's source files is slow
> -
>
> Key: NETBEANS-936
> URL: https://issues.apache.org/jira/browse/NETBEANS-936
> Project: NetBeans
>  Issue Type: Bug
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Priority: Major
>
> * Have the JDK's src.zip installed
>  * Create a Maven project
>  * Add Guava as a dependency (com.google.guava:guava, latest version 25.1-jre)
>  * "Download Sources" for the Guava dependency
>  * Try to open any Guava class
> It will take ~10 seconds to parse, sometimes hanging the UI. Somehow NetBeans 
> 9 is ending up parsing hundreds of src.zip files along with it. This did not 
> happen in NetBeans 8.2.
> Guava has a "${java.home}/../src.zip" dependency in 
> its pom.xml, which may be related.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-1899) Indexing of PHP array's keys

2019-09-13 Thread Los Vitaly (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Los Vitaly updated NETBEANS-1899:
-
Attachment: Screenshot from 2019-09-13 19-52-24.png

> Indexing of PHP array's keys
> 
>
> Key: NETBEANS-1899
> URL: https://issues.apache.org/jira/browse/NETBEANS-1899
> Project: NetBeans
>  Issue Type: Improvement
>  Components: php - Code, php - Editor
>Affects Versions: 10.0
>Reporter: Los Vitaly
>Priority: Major
> Attachments: Screenshot from 2019-09-13 19-52-24.png, demo.png
>
>
> NB does not index array's keys and values, so netbeans can't autocomplete 
> associative array keys. It very helpful feature, that prevent from mistyping, 
> etc
> I know, that phpstorm autocomplete it, maybe another IDEs too. I add image 
> for better understanding, because English not my native language :)  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1899) Indexing of PHP array's keys

2019-09-13 Thread Los Vitaly (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929362#comment-16929362
 ] 

Los Vitaly commented on NETBEANS-1899:
--

Yes, it's work, but only when array is on the same page or array is in included 
files. And we need to remember  array's keys.

In phpstorm autocomplete work through project, not just on page with array. 

And we can trigger all aray's keys in via drop down list. It's very convenient. 
I make screenshot how work storm  !Screenshot from 2019-09-13 19-52-24.png!

> Indexing of PHP array's keys
> 
>
> Key: NETBEANS-1899
> URL: https://issues.apache.org/jira/browse/NETBEANS-1899
> Project: NetBeans
>  Issue Type: Improvement
>  Components: php - Code, php - Editor
>Affects Versions: 10.0
>Reporter: Los Vitaly
>Priority: Major
> Attachments: Screenshot from 2019-09-13 19-52-24.png, demo.png
>
>
> NB does not index array's keys and values, so netbeans can't autocomplete 
> associative array keys. It very helpful feature, that prevent from mistyping, 
> etc
> I know, that phpstorm autocomplete it, maybe another IDEs too. I add image 
> for better understanding, because English not my native language :)  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3072) org.openide.util.ImageUtilities$ToolTipImage cannot be cast to javax.swing.ImageIcon

2019-09-13 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-3072.
---
Fix Version/s: 11.2
   Resolution: Fixed

The corresponding PR got merged.

> org.openide.util.ImageUtilities$ToolTipImage cannot be cast to 
> javax.swing.ImageIcon
> 
>
> Key: NETBEANS-3072
> URL: https://issues.apache.org/jira/browse/NETBEANS-3072
> Project: NetBeans
>  Issue Type: Bug
>  Components: groovy - Editor
>Affects Versions: 11.1
>Reporter: Bartosz Tomasik
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.2
>
> Attachments: idelog.log, uilog.log
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> #  created new gradle project
> #  typed
> wrapper {
>  }
> in build.gradle
> #  put carret between above braces and hit ctrl+space for code completition
> # classcast occurs



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2953) NPE after pressing "DTDs and XML Schemas" menu entry

2019-09-13 Thread Benjamin Graf (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Graf updated NETBEANS-2953:

Fix Version/s: 11.2

> NPE after pressing "DTDs and XML Schemas" menu entry
> 
>
> Key: NETBEANS-2953
> URL: https://issues.apache.org/jira/browse/NETBEANS-2953
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.1
> Environment: Windows 10
> OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)
>Reporter: Benjamin Graf
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Following stacktrace occurs every time when trying to open  "DTDs and XML 
> Schemas" menu entry:
> {noformat}
> java.lang.NullPointerException
>   at 
> java.base/java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
>   at java.base/java.util.Properties.get(Properties.java:1311)
>   at org.openide.util.NbCollections$CheckedMap.get(NbCollections.java:385)
>   at org.openide.util.NbBundle$PBundle.handleGetObject(NbBundle.java:880)
>   at java.base/java.util.ResourceBundle.getObject(ResourceBundle.java:555)
>   at java.base/java.util.ResourceBundle.getString(ResourceBundle.java:521)
>   at org.openide.util.NbBundle.getMessage(NbBundle.java:617)
>   at 
> org.netbeans.modules.payara.jakartaee.RunTimeDDCatalog.getDisplayName(RunTimeDDCatalog.java:382)
>   at 
> org.netbeans.modules.xml.catalog.CatalogRootNode$RootChildren.compare(CatalogRootNode.java:249)
>   at java.base/java.util.TreeMap.put(TreeMap.java:550)
>   at java.base/java.util.TreeSet.add(TreeSet.java:255)
>   at 
> org.netbeans.modules.xml.catalog.CatalogRootNode$RootChildren.createKeys(CatalogRootNode.java:225)
>   at 
> org.netbeans.modules.xml.catalog.CatalogRootNode$RootChildren.addNotify(CatalogRootNode.java:183)
>   at org.openide.nodes.Children.callAddNotify(Children.java:550)
>   at 
> org.openide.nodes.EntrySupportDefault.getArray(EntrySupportDefault.java:627)
>   at 
> org.openide.nodes.EntrySupportDefault.getNodes(EntrySupportDefault.java:98)
>   at 
> org.openide.nodes.EntrySupportDefault.getNodes(EntrySupportDefault.java:149)
>   at 
> org.openide.nodes.EntrySupportDefault.getNodesCount(EntrySupportDefault.java:153)
>   at org.openide.nodes.Children.getNodesCount(Children.java:484)
>   at 
> org.openide.explorer.view.VisualizerNode.getChildren(VisualizerNode.java:234)
>   at 
> org.openide.explorer.view.VisualizerNode.getChildren(VisualizerNode.java:224)
>   at 
> org.openide.explorer.view.VisualizerNode.getChildCount(VisualizerNode.java:301)
>   at 
> java.desktop/javax.swing.tree.DefaultTreeModel.getChildCount(DefaultTreeModel.java:192)
>   at 
> java.desktop/javax.swing.tree.FixedHeightLayoutCache$FHTreeStateNode.expand(FixedHeightLayoutCache.java:1155)
>   at 
> java.desktop/javax.swing.tree.FixedHeightLayoutCache.rebuild(FixedHeightLayoutCache.java:620)
>   at 
> java.desktop/javax.swing.tree.FixedHeightLayoutCache.treeStructureChanged(FixedHeightLayoutCache.java:492)
>   at 
> java.desktop/javax.swing.plaf.basic.BasicTreeUI$Handler.treeStructureChanged(BasicTreeUI.java:4324)
>   at 
> java.desktop/javax.swing.tree.DefaultTreeModel.fireTreeStructureChanged(DefaultTreeModel.java:607)
>   at 
> java.desktop/javax.swing.tree.DefaultTreeModel.nodeStructureChanged(DefaultTreeModel.java:391)
>   at 
> java.desktop/javax.swing.tree.DefaultTreeModel.setRoot(DefaultTreeModel.java:141)
>   at org.openide.explorer.view.NodeTreeModel$1.run(NodeTreeModel.java:98)
>   at 
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.doEvent(NbMutexEventProvider.java:95)
>   at 
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.readAccess(NbMutexEventProvider.java:70)
>   at 
> org.netbeans.modules.openide.util.LazyMutexImplementation.readAccess(LazyMutexImplementation.java:66)
>   at org.openide.util.Mutex.readAccess(Mutex.java:235)
>   at 
> org.openide.explorer.view.NodeTreeModel.setNode(NodeTreeModel.java:83)
>   at org.openide.explorer.view.TreeView$4.run(TreeView.java:831)
>   at 
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.doEvent(NbMutexEventProvider.java:95)
>   at 
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.readAccess(NbMutexEventProvider.java:70)
>   at 
> org.netbeans.modules.openide.util.LazyMutexImplementation.readAccess(LazyMutexImplementation.java:66)
>   at org.openide.util.Mutex.readAccess(Mutex.java:235)
>   at 
> org.openide.explorer.view.TreeView.synchronizeRootContext(TreeView.java:821)
>   at 
> 

[jira] [Resolved] (NETBEANS-3097) Changing font-color type name for text-block(JDK-13)

2019-09-13 Thread ARUNAVA SINHA (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ARUNAVA SINHA resolved NETBEANS-3097.
-
Resolution: Fixed

> Changing font-color type name for text-block(JDK-13)
> 
>
> Key: NETBEANS-3097
> URL: https://issues.apache.org/jira/browse/NETBEANS-3097
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.2
>Reporter: ARUNAVA SINHA
>Assignee: ARUNAVA SINHA
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently font-color type names can be viewed from
> Tools -> Options->Fonts & Colors ->  Syntax Tab  Language : Java -> Category
> for text-block type name used is "mod-unindented-text-block"
> It would be better is be use type name as "text-block"
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-3097]:Changed font color type name for text-block(JDK-13) (#1498)

2019-09-13 Thread arusinha
This is an automated email from the ASF dual-hosted git repository.

arusinha pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 511b1a3  [NETBEANS-3097]:Changed font color type name for 
text-block(JDK-13) (#1498)
511b1a3 is described below

commit 511b1a3299fa3ce77565e5c122f369d2ff42422c
Author: Arunava Sinha 
AuthorDate: Fri Sep 13 20:11:00 2019 +0530

[NETBEANS-3097]:Changed font color type name for text-block(JDK-13) (#1498)
---
 .../src/org/netbeans/modules/java/editor/resources/fontsColors.xml  | 2 +-
 .../src/org/netbeans/modules/java/editor/semantic/ColoringManager.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/java/java.editor/src/org/netbeans/modules/java/editor/resources/fontsColors.xml
 
b/java/java.editor/src/org/netbeans/modules/java/editor/resources/fontsColors.xml
index 668ecb7..4f9c647 100644
--- 
a/java/java.editor/src/org/netbeans/modules/java/editor/resources/fontsColors.xml
+++ 
b/java/java.editor/src/org/netbeans/modules/java/editor/resources/fontsColors.xml
@@ -87,7 +87,7 @@
 
 
 
-
+
 
 
 

[netbeans] branch master updated: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new bff377d  [NETBEANS-3072] Use actual ImageIcons as code completion 
actually like.
bff377d is described below

commit bff377d2a242c23e5b59bacc0adf4288eaf1f105
Author: Laszlo Kishalmi 
AuthorDate: Thu Sep 12 23:46:20 2019 -0700

[NETBEANS-3072] Use actual ImageIcons as code completion actually like.
---
 .../editor/api/completion/CompletionItem.java  |  2 -
 .../src/org/netbeans/modules/java/ui/Icons.java| 44 +-
 2 files changed, 18 insertions(+), 28 deletions(-)

diff --git 
a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
 
b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
index 3e0da7b..e04b1f3 100644
--- 
a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
+++ 
b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
@@ -1003,7 +1003,6 @@ public abstract class CompletionItem extends 
DefaultCompletionProposal {
 
 @Override
 public ImageIcon getIcon() {
-// todo: what happens, if i get a CCE here?
 return (ImageIcon) 
ElementIcons.getElementIcon(javax.lang.model.element.ElementKind.FIELD,
 Utilities.gsfModifiersToModel(modifiers, null));
 }
@@ -1045,7 +1044,6 @@ public abstract class CompletionItem extends 
DefaultCompletionProposal {
 
 @Override
 public ImageIcon getIcon() {
-// todo: what happens, if i get a CCE here?
 return (ImageIcon) 
ElementIcons.getElementIcon(javax.lang.model.element.ElementKind.LOCAL_VARIABLE,
 null);
 }
 
diff --git a/java/java.source/src/org/netbeans/modules/java/ui/Icons.java 
b/java/java.source/src/org/netbeans/modules/java/ui/Icons.java
index 6dc9b67..28c173a 100644
--- a/java/java.source/src/org/netbeans/modules/java/ui/Icons.java
+++ b/java/java.source/src/org/netbeans/modules/java/ui/Icons.java
@@ -19,15 +19,12 @@
 
 package org.netbeans.modules.java.ui;
 
-import java.awt.Image;
 import java.util.Collection;
 import java.util.Collections;
 import javax.lang.model.element.ElementKind;
 import javax.lang.model.element.Modifier;
-import javax.swing.Icon;
 import javax.swing.ImageIcon;
 import org.openide.util.ImageUtilities;
-import org.openide.util.Utilities;
 
 /**
  *
@@ -44,64 +41,59 @@ public final class Icons {
 private Icons() {
 }
 
-public static Icon getBusyIcon () {
-Image img = ImageUtilities.loadImage (WAIT);
-if (img == null) {
-return null;
-}
-else {
-return ImageUtilities.image2Icon (img);
-}
+public static ImageIcon getBusyIcon () {
+ImageIcon icon = ImageUtilities.loadImageIcon(WAIT, false);
+return icon;
 }
 
 
-public static Icon getElementIcon( ElementKind elementKind, 
Collection modifiers ) {
+public static ImageIcon getElementIcon( ElementKind elementKind, 
Collection modifiers ) {
 
 if ( modifiers == null ) {
 modifiers = Collections.emptyList();
 }
 
-Image img = null;
+ImageIcon icon = null;

switch( elementKind ) {
 case MODULE:
-img = ImageUtilities.loadImage( ICON_BASE + "module" + 
PNG_EXTENSION );
+icon = ImageUtilities.loadImageIcon(ICON_BASE + "module" + 
PNG_EXTENSION, false );
break;
case PACKAGE:
-   img = ImageUtilities.loadImage( ICON_BASE + "package" + 
GIF_EXTENSION );
+   icon = ImageUtilities.loadImageIcon(ICON_BASE + "package" + 
GIF_EXTENSION, false );
break;
case ENUM:  
-   img = ImageUtilities.loadImage( ICON_BASE + "enum" + 
PNG_EXTENSION );
+   icon = ImageUtilities.loadImageIcon( ICON_BASE + "enum" + 
PNG_EXTENSION, false );
break;
case ANNOTATION_TYPE:
-   img = ImageUtilities.loadImage( ICON_BASE + "annotation" + 
PNG_EXTENSION );
+   icon = ImageUtilities.loadImageIcon( ICON_BASE + "annotation" + 
PNG_EXTENSION, false );
break;
case CLASS: 
-   img = ImageUtilities.loadImage( ICON_BASE + "class" + 
PNG_EXTENSION );
+   icon = ImageUtilities.loadImageIcon( ICON_BASE + "class" + 
PNG_EXTENSION, false );
break;
case INTERFACE:
-   img = ImageUtilities.loadImage( ICON_BASE + "interface"  + 
PNG_EXTENSION );
+   icon = ImageUtilities.loadImageIcon( ICON_BASE + "interface"  + 
PNG_EXTENSION, false );
break;
case FIELD:
-   

[jira] [Commented] (NETBEANS-3098) Netbeans 11.1 threw a Null Pointer Exception on start up

2019-09-13 Thread Christian Oyarzun (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929131#comment-16929131
 ] 

Christian Oyarzun commented on NETBEANS-3098:
-

This is a duplicate of NETBEANS-3095. I have a pull request that hopefully will 
make it in 11.2.

> Netbeans 11.1 threw a Null Pointer Exception on start up
> 
>
> Key: NETBEANS-3098
> URL: https://issues.apache.org/jira/browse/NETBEANS-3098
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.1
> Environment: Windows 10 Pro
>Reporter: kenneth west
>Priority: Trivial
> Attachments: messages.log
>
>
> NetBeans 11.1 issued a "Null Pointer Exception" notification on start up.  
> However, it did start up OK and the bug doesn't seem to have adversely 
> affected its operation in respect to PHP and Javascript coding.  I'm 
> reporting it as requested by the notification and have attached the Message 
> Log for your review.
>  
> UPDATE:  after filing this Bug Report I restarted Windows and NetBeans and 
> the error didn't reoccur.
>  
> Ken West



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3095) SplashPainter may produce null pointer exception

2019-09-13 Thread Christian Oyarzun (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Oyarzun updated NETBEANS-3095:

Fix Version/s: 11.2

> SplashPainter may produce null pointer exception
> 
>
> Key: NETBEANS-3095
> URL: https://issues.apache.org/jira/browse/NETBEANS-3095
> Project: NetBeans
>  Issue Type: Bug
>  Components: core
>Affects Versions: 11.1
> Environment: Windows, macOS, Linux
>Reporter: Christian Oyarzun
>Assignee: Christian Oyarzun
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 11.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Randomly getting null pointer exception when starting a RCP application.
> java.lang.NullPointerExceptionjava.lang.NullPointerException at 
> org.netbeans.core.startup.Splash$SplashPainter$1.run(Splash.java:521) at 
> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) at 
> java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) at 
> java.awt.EventQueue.access$500(EventQueue.java:97) at 
> java.awt.EventQueue$3.run(EventQueue.java:709) at 
> java.awt.EventQueue$3.run(EventQueue.java:703) at 
> java.security.AccessController.doPrivileged(Native Method) at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
>  at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)[catch] at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
>  at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>  at 
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
>  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at 
> java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at 
> java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3082) Formatting issue on use of Switch-Expression

2019-09-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3082:
-
Labels: pull-request-available  (was: )

> Formatting issue on use of Switch-Expression
> 
>
> Key: NETBEANS-3082
> URL: https://issues.apache.org/jira/browse/NETBEANS-3082
> Project: NetBeans
>  Issue Type: Improvement
>Affects Versions: 11.1
>Reporter: ARUNAVA SINHA
>Assignee: ARUNAVA SINHA
>Priority: Major
>  Labels: pull-request-available
>
> Suppose We have below  Code Snippet
>  
> int a = switch(1)
> { default : yield 1 };
> System.out.println(a);
>  
> Expressions/Statements used after Switch-Expression are getting wrongly 
> indented.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3098) Netbeans 11.1 threw a Null Pointer Exception on start up

2019-09-13 Thread kenneth west (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kenneth west updated NETBEANS-3098:
---
Description: 
NetBeans 11.1 issued a "Null Pointer Exception" notification on start up.  
However, it did start up OK and the bug doesn't seem to have adversely affected 
its operation in respect to PHP and Javascript coding.  I'm reporting it as 
requested by the notification and have attached the Message Log for your review.

 

UPDATE:  after filing this Bug Report I restarted Windows and NetBeans and the 
error didn't reoccur.

 

Ken West

  was:
Netbeans 11.1 issued a "Null Pointer Exception" notification on start up.  
However, it did start up OK and the bug doesn't seem to have adversely affected 
its operation in respect to PHP and Javascript coding.  I'm reporting it as 
requested by the notification and have attached the Message Log for your review.

 

Ken West


> Netbeans 11.1 threw a Null Pointer Exception on start up
> 
>
> Key: NETBEANS-3098
> URL: https://issues.apache.org/jira/browse/NETBEANS-3098
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.1
> Environment: Windows 10 Pro
>Reporter: kenneth west
>Priority: Trivial
> Attachments: messages.log
>
>
> NetBeans 11.1 issued a "Null Pointer Exception" notification on start up.  
> However, it did start up OK and the bug doesn't seem to have adversely 
> affected its operation in respect to PHP and Javascript coding.  I'm 
> reporting it as requested by the notification and have attached the Message 
> Log for your review.
>  
> UPDATE:  after filing this Bug Report I restarted Windows and NetBeans and 
> the error didn't reoccur.
>  
> Ken West



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3097) Changing font-color type name for text-block(JDK-13)

2019-09-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3097:
-
Labels: pull-request-available  (was: )

> Changing font-color type name for text-block(JDK-13)
> 
>
> Key: NETBEANS-3097
> URL: https://issues.apache.org/jira/browse/NETBEANS-3097
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Editor
>Affects Versions: 11.2
>Reporter: ARUNAVA SINHA
>Assignee: ARUNAVA SINHA
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.2
>
>
> Currently font-color type names can be viewed from
> Tools -> Options->Fonts & Colors ->  Syntax Tab  Language : Java -> Category
> for text-block type name used is "mod-unindented-text-block"
> It would be better is be use type name as "text-block"
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3098) Netbeans 11.1 threw a Null Pointer Exception on start up

2019-09-13 Thread kenneth west (Jira)
kenneth west created NETBEANS-3098:
--

 Summary: Netbeans 11.1 threw a Null Pointer Exception on start up
 Key: NETBEANS-3098
 URL: https://issues.apache.org/jira/browse/NETBEANS-3098
 Project: NetBeans
  Issue Type: Bug
Affects Versions: 11.1
 Environment: Windows 10 Pro
Reporter: kenneth west
 Attachments: messages.log

Netbeans 11.1 issued a "Null Pointer Exception" notification on start up.  
However, it did start up OK and the bug doesn't seem to have adversely affected 
its operation in respect to PHP and Javascript coding.  I'm reporting it as 
requested by the notification and have attached the Message Log for your review.

 

Ken West



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3097) Changing font-color type name for text-block(JDK-13)

2019-09-13 Thread ARUNAVA SINHA (Jira)
ARUNAVA SINHA created NETBEANS-3097:
---

 Summary: Changing font-color type name for text-block(JDK-13)
 Key: NETBEANS-3097
 URL: https://issues.apache.org/jira/browse/NETBEANS-3097
 Project: NetBeans
  Issue Type: Bug
  Components: java - Editor
Affects Versions: 11.2
Reporter: ARUNAVA SINHA
Assignee: ARUNAVA SINHA
 Fix For: 11.2


Currently font-color type names can be viewed from

Tools -> Options->Fonts & Colors ->  Syntax Tab  Language : Java -> Category

for text-block type name used is "mod-unindented-text-block"

It would be better is be use type name as "text-block"

 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3032) Copy & paste improvement of variable names in PHP editor

2019-09-13 Thread Czukowski (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929019#comment-16929019
 ] 

Czukowski commented on NETBEANS-3032:
-

[~junichi11] thank you for your reply!

These are indeed great features that have their uses, however they involve 
invoking various kinds of dialogues that might be at times little bit 
distracting, and when working on already existing code, the generated code is 
likely to be placed at a different location than I would write it so it 
requires a few tweaks afterwards. That's why I thought a feature like 
contextual copy & paste would be a good addition for some situations :) (of 
course, if at all possible or feasible to implement)

> Copy & paste improvement of variable names in PHP editor
> 
>
> Key: NETBEANS-3032
> URL: https://issues.apache.org/jira/browse/NETBEANS-3032
> Project: NetBeans
>  Issue Type: New Feature
>  Components: php - Editor
>Affects Versions: 11.1
>Reporter: Czukowski
>Priority: Minor
> Attachments: netbeans-3032.gif
>
>
> I would like to propose an improvement for PHP editor. When one needs to have 
> class method that set object properties, such as setter methods or 
> constructors for dependency injection, method parameter names are often same 
> as the object properties, so copy and pasting of the parameters names often 
> occurs. However the variable names are being selected including the dollar 
> sign prefix {{$}} and after pasting it needs to be removed. If there are many 
> parameters to set, this may become very routine work.
> The idea is that when the paste _containing a variable name_ occurs right 
> after {{$this->}} (or perhaps rather after object instance operator {{->}}), 
> then it will be pasted _without the {{$}} sign_. I believe this would greatly 
> improve the workflow.
> {code:php}
> function __construct($someProperty) {
> $this->someProperty = $someProperty;
> }
> {code}
> So in order to achieve property assignment, one would need to type
> {{$this->}}, ctrl+v, {{=}}, ctrl+v
> instead of, for example:
> {{$this->}}, ctrl+v, ctrl+back-arrow (multiple times), backspace, end, {{=}}, 
> ctrl+v
> Of course, there could be variable variables, but I believe these haven't 
> been considered a good practice for a long time and in any case, are much 
> much more rare than the use case above.
> Do you see any possible drawbacks to this?
> There could also be a suggestion to generate the assignment for even less 
> keystrokes, but I figure it would be far more complex solution than this.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-3032) Copy & paste improvement of variable names in PHP editor

2019-09-13 Thread Czukowski (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929019#comment-16929019
 ] 

Czukowski edited comment on NETBEANS-3032 at 9/13/19 7:04 AM:
--

[~junichi11] thank you for your reply!

These are indeed great features that have their uses, however they involve 
invoking various kinds of dialogues that might be at times little bit 
distracting, and when working on already existing code, the generated code is 
likely to be placed at a different location than I would write it so it still 
requires a few tweaks afterwards. That's why I thought a feature like 
contextual copy & paste would be a good addition for some situations :) (of 
course, if at all possible or feasible to implement)


was (Author: czukowski):
[~junichi11] thank you for your reply!

These are indeed great features that have their uses, however they involve 
invoking various kinds of dialogues that might be at times little bit 
distracting, and when working on already existing code, the generated code is 
likely to be placed at a different location than I would write it so it 
requires a few tweaks afterwards. That's why I thought a feature like 
contextual copy & paste would be a good addition for some situations :) (of 
course, if at all possible or feasible to implement)

> Copy & paste improvement of variable names in PHP editor
> 
>
> Key: NETBEANS-3032
> URL: https://issues.apache.org/jira/browse/NETBEANS-3032
> Project: NetBeans
>  Issue Type: New Feature
>  Components: php - Editor
>Affects Versions: 11.1
>Reporter: Czukowski
>Priority: Minor
> Attachments: netbeans-3032.gif
>
>
> I would like to propose an improvement for PHP editor. When one needs to have 
> class method that set object properties, such as setter methods or 
> constructors for dependency injection, method parameter names are often same 
> as the object properties, so copy and pasting of the parameters names often 
> occurs. However the variable names are being selected including the dollar 
> sign prefix {{$}} and after pasting it needs to be removed. If there are many 
> parameters to set, this may become very routine work.
> The idea is that when the paste _containing a variable name_ occurs right 
> after {{$this->}} (or perhaps rather after object instance operator {{->}}), 
> then it will be pasted _without the {{$}} sign_. I believe this would greatly 
> improve the workflow.
> {code:php}
> function __construct($someProperty) {
> $this->someProperty = $someProperty;
> }
> {code}
> So in order to achieve property assignment, one would need to type
> {{$this->}}, ctrl+v, {{=}}, ctrl+v
> instead of, for example:
> {{$this->}}, ctrl+v, ctrl+back-arrow (multiple times), backspace, end, {{=}}, 
> ctrl+v
> Of course, there could be variable variables, but I believe these haven't 
> been considered a good practice for a long time and in any case, are much 
> much more rare than the use case above.
> Do you see any possible drawbacks to this?
> There could also be a suggestion to generate the assignment for even less 
> keystrokes, but I figure it would be far more complex solution than this.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3072) org.openide.util.ImageUtilities$ToolTipImage cannot be cast to javax.swing.ImageIcon

2019-09-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3072:
-
Labels: pull-request-available  (was: )

> org.openide.util.ImageUtilities$ToolTipImage cannot be cast to 
> javax.swing.ImageIcon
> 
>
> Key: NETBEANS-3072
> URL: https://issues.apache.org/jira/browse/NETBEANS-3072
> Project: NetBeans
>  Issue Type: Bug
>  Components: groovy - Editor
>Affects Versions: 11.1
>Reporter: Bartosz Tomasik
>Priority: Major
>  Labels: pull-request-available
> Attachments: idelog.log, uilog.log
>
>
> #  created new gradle project
> #  typed
> wrapper {
>  }
> in build.gradle
> #  put carret between above braces and hit ctrl+space for code completition
> # classcast occurs



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3087) ClassCastException on Code Completion

2019-09-13 Thread Laszlo Kishalmi (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929016#comment-16929016
 ] 

Laszlo Kishalmi commented on NETBEANS-3087:
---

Sorry it was Groovy in Gradle. Already found some patch for it.

> ClassCastException on Code Completion
> -
>
> Key: NETBEANS-3087
> URL: https://issues.apache.org/jira/browse/NETBEANS-3087
> Project: NetBeans
>  Issue Type: Bug
>  Components: cnd - Code Completion
>Reporter: luca campagnaro
>Priority: Critical
>
> {noformat}
> java.lang.ClassCastException: class 
> org.openide.util.ImageUtilities$ToolTipImage cannot be cast to class 
> javax.swing.ImageIcon (org.openide.util.ImageUtilities$ToolTipImage is in 
> unnamed module of loader 'app'; javax.swing.ImageIcon is in module 
> java.desktop of loader 'bootstrap')
>  at 
> org.netbeans.modules.groovy.editor.api.completion.CompletionItem$TypeItem.getIcon(CompletionItem.java:664)
>  at 
> org.netbeans.modules.csl.editor.completion.GsfCompletionItem$DelegatedItem.getIcon(GsfCompletionItem.java:233){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists