[jira] [Commented] (NETBEANS-3769) Cannot rename project and directory

2020-02-04 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030388#comment-17030388
 ] 

Eirik Bakke commented on NETBEANS-3769:
---

Added a PR for this at https://github.com/apache/netbeans/pull/1922/files .

> Cannot rename project and directory
> ---
>
> Key: NETBEANS-3769
> URL: https://issues.apache.org/jira/browse/NETBEANS-3769
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Generic Infrastructure, projects - Generic 
> Projects UI
>Affects Versions: 11.3
> Environment: NB 11.3b running on JDK-13.0.2, Win7
>Reporter: Ernie Rael
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
> Attachments: CannotRenameProject.log.1, CannotRenameProject.log.2, 
> ProjRenameAtRename.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> (Attaching log with relevant exceptions)
> To reproduce
>  # NewProject > JavaWithAnt > JavaApplication; accept all defaults
>  # From context menu on new project, select "Rename..."
>  # In dialog change the name
>  # Select "Also Rename Project Folder"
>  # Click "Rename" button
> Observe error dialog
> {quote}Error
> Cannot rename file JavaApplication8 in F:/j/nb-stuff/NetBeansProjects to 
> RenameProject
> {quote}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3671) IllegalArgumentException CachedHiDPIIcon

2020-02-04 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030390#comment-17030390
 ] 

Eirik Bakke commented on NETBEANS-3671:
---

Added a PR for this at https://github.com/apache/netbeans/pull/1922/files .

> IllegalArgumentException CachedHiDPIIcon
> 
>
> Key: NETBEANS-3671
> URL: https://issues.apache.org/jira/browse/NETBEANS-3671
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Other
>Affects Versions: 11.1
> Environment: Linux: Ubuntu 18.04.3 LTS
>Reporter: Thomas
>Assignee: Eirik Bakke
>Priority: Major
>
> Now and then I get the following exception when opening the "Tools" menu item 
> via mouse:
>  
> java.lang.IllegalArgumentException
>  at org.openide.util.CachedHiDPIIcon.(CachedHiDPIIcon.java:63)
>  at org.openide.util.FilteredIcon.(FilteredIcon.java:50)
>  at org.openide.util.FilteredIcon.create(FilteredIcon.java:58)
>  at 
> org.openide.util.ImageUtilities.createDisabledIcon(ImageUtilities.java:415)
>  at org.openide.awt.Actions$MenuBridge.updateButtonIcon(Actions.java:1375)
>  at org.openide.awt.Actions$MenuBridge.updateState(Actions.java:1324)
>  at org.openide.awt.Actions$MenuItem.synchMenuPresenters(Actions.java:1667)
>  at org.openide.awt.DynaMenuModel.checkSubmenu(DynaMenuModel.java:171)
>  at org.openide.awt.MenuBar$LazyMenu.setPopupMenuVisible(MenuBar.java:722)
>  at 
> java.desktop/javax.swing.JPopupMenu.menuSelectionChanged(JPopupMenu.java:1486)
>  at 
> java.desktop/javax.swing.MenuSelectionManager.setSelectedPath(MenuSelectionManager.java:129)
>  at 
> java.desktop/javax.swing.plaf.basic.BasicMenuUI.appendPath(BasicMenuUI.java:259)
>  at 
> java.desktop/javax.swing.plaf.basic.BasicMenuUI$Handler.mousePressed(BasicMenuUI.java:520)
>  at java.desktop/java.awt.Component.processMouseEvent(Component.java:6629)
>  at 
> java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
>  at java.desktop/java.awt.Component.processEvent(Component.java:6397)
>  at java.desktop/java.awt.Container.processEvent(Container.java:2263)
>  at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5008)
>  at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
>  at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
>  at 
> java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
>  at 
> java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4544)
>  at 
> java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
>  at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
>  at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
>  at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
>  at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
>  at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
>  at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
>  at java.base/java.security.AccessController.doPrivileged(Native Method)
>  at 
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
>  at 
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
>  at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
>  at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
>  at java.base/java.security.AccessController.doPrivileged(Native Method)
>  at 
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
>  at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
>  at 
> org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136)
>  [catch] at 
> java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
>  at 
> java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
>  at 
> java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
>  at 
> java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
>  at 
> java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
>  at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3769) Cannot rename project and directory

2020-02-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3769:
-
Labels: pull-request-available  (was: )

> Cannot rename project and directory
> ---
>
> Key: NETBEANS-3769
> URL: https://issues.apache.org/jira/browse/NETBEANS-3769
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Generic Infrastructure, projects - Generic 
> Projects UI
>Affects Versions: 11.3
> Environment: NB 11.3b running on JDK-13.0.2, Win7
>Reporter: Ernie Rael
>Assignee: Eirik Bakke
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
> Attachments: CannotRenameProject.log.1, CannotRenameProject.log.2, 
> ProjRenameAtRename.png
>
>
> (Attaching log with relevant exceptions)
> To reproduce
>  # NewProject > JavaWithAnt > JavaApplication; accept all defaults
>  # From context menu on new project, select "Rename..."
>  # In dialog change the name
>  # Select "Also Rename Project Folder"
>  # Click "Rename" button
> Observe error dialog
> {quote}Error
> Cannot rename file JavaApplication8 in F:/j/nb-stuff/NetBeansProjects to 
> RenameProject
> {quote}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3737) FlatLaf: Toolbar icons feel cramped

2020-02-04 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-3737.
---
Fix Version/s: 11.3
   Resolution: Fixed

> FlatLaf: Toolbar icons feel cramped
> ---
>
> Key: NETBEANS-3737
> URL: https://issues.apache.org/jira/browse/NETBEANS-3737
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - UI
>Affects Versions: 11.3
>Reporter: Benjamin Graf
>Assignee: Karl Tauber
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 11.3
>
> Attachments: image-2020-01-23-16-40-39-512.png
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Toolbar icons in FlatLaf themes are feeling cramped especially if small icons 
> are chosen. The theme should add some padding around them like the other 
> themes already are doing. 
>  
> !image-2020-01-23-16-40-39-512.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3739) Strange Versioning Colors in FlatLafDark

2020-02-04 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-3739.
---
Fix Version/s: 11.3
   Resolution: Fixed

> Strange Versioning Colors in FlatLafDark
> 
>
> Key: NETBEANS-3739
> URL: https://issues.apache.org/jira/browse/NETBEANS-3739
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.3
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The Project/File view Versioning colors are displayed as white for 
> modified/ignored files.
> They are displayed right (green) for added ones.
> It's only happening on FlatLaf Dark. FlatLafLight are displaying the those 
> files correctly. I've checked the AnnotationColorProvider, is seems to 
> generate the annotations fine, for ignored.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3735) FlatLaf: Desktop does not repaint after closing the last editor tab.

2020-02-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3735:
-
Labels: ide-ui pull-request-available  (was: ide-ui)

> FlatLaf: Desktop does not repaint after closing the last editor tab.
> 
>
> Key: NETBEANS-3735
> URL: https://issues.apache.org/jira/browse/NETBEANS-3735
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Major
>  Labels: ide-ui, pull-request-available
> Attachments: FlatLafNoRepaint.mp4
>
>
> When all the side comonents are minimized and the last editor window is 
> closed the focus is moved to the global search, in this case the desktop does 
> not repaint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf

2020-02-04 Thread Laszlo Kishalmi (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030073#comment-17030073
 ] 

Laszlo Kishalmi commented on NETBEANS-3727:
---

I like it! I'm really curious of the PR!

> Probably a darker color of the desktop background would be good for FlatLaf
> ---
>
> Key: NETBEANS-3727
> URL: https://issues.apache.org/jira/browse/NETBEANS-3727
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Minor
> Attachments: image-2020-01-21-16-30-56-282.png, 
> image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png, 
> image-2020-02-04-19-27-10-325.png
>
>
> Well, I'm not entirely convinced that this is an issue at all.
> Those rare times when we do not have an editor window open, the IDE might 
> look strange not having upper/left/right border on the opened tabs. I'd not 
> put border there, but probably mark the desktop color different (like the 
> editor default background on FlatLafDark).
> [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this 
> one.
> !image-2020-01-21-16-30-56-282.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2452) -Xbootclasspath/p is no longer a supported option

2020-02-04 Thread Claudia Arriaga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030064#comment-17030064
 ] 

Claudia Arriaga commented on NETBEANS-2452:
---

Thank you very much [~j-f-k] , problem solved

> -Xbootclasspath/p is no longer a supported option
> -
>
> Key: NETBEANS-2452
> URL: https://issues.apache.org/jira/browse/NETBEANS-2452
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler, java - Platform, projects - Ant
>Affects Versions: 9.0, 10.0, 11.0
> Environment: OpenJDK 11
>Reporter: Emile Brinkman
>Assignee: Emile Brinkman
>Priority: Major
>  Labels: patch
> Fix For: 11.0
>
>
> I have upgraded from NetBeans 8.2 and JDK1.8 to Apache NetBeans 11.0 and 
> OpenJDK 11. The Xbootclasspath option is no longer supported bij JDK11 and 
> apparently has to be changed to --patch-module. It is however still used in 
> the ANT build-impl.xml file under endorsed.classpath.path. The problem is 
> that if you change "-Xbootclasspath/p:" to "-patch module java.base=" that 
> NetBeans automatically overwrites it back to "-Xbootclasspath/p" when you 
> change properties of a project. -Xbootclasspath/a and -Xbootclasspath also 
> don't work.
> I also get the following error when running a class even when I changed 
> everything to --patch module:
> {{-Xbootclasspath/p is no longer a supported option.}}
>  {{Error: Could not create the Java Virtual Machine.}}
>  {{Error: A fatal exception has occurred. Program will exit.}}
>  
> {{C:\Users\user1\AppData\Local\NetBeans\Cache\11.0\executor-snippets\run.xml:111:
>  The following error occurred while executing this line:}}
>  
> {{C:\Users\user1\AppData\Local\NetBeans\Cache\11.0\executor-snippets\run.xml:94:
>  Java returned: 1}}
>  {{BUILD FAILED (total time: 0 seconds)}}
> Removing the cache folder doesn't help. I am not able anymore to run this 
> class even when I change the Source/Binary format of the project back to 
> JDK1.8. It seems that Apache NetBeans has hardcoded -Xbootclasspath 
> internally?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3793) Debug of single Source Java File not working in windows

2020-02-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3793:
-
Labels: pull-request-available  (was: )

> Debug of single Source Java File not working in windows
> ---
>
> Key: NETBEANS-3793
> URL: https://issues.apache.org/jira/browse/NETBEANS-3793
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: Next
>Reporter: Arunava Sinha
>Assignee: Arunava Sinha
>Priority: Major
>  Labels: pull-request-available
>
> Debug of single Source Java File not working in windows
> The issue in related to below bug:
> https://issues.apache.org/jira/browse/NETBEANS-3616



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf

2020-02-04 Thread Karl Tauber (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030045#comment-17030045
 ] 

Karl Tauber commented on NETBEANS-3727:
---

Here is a screenshot with background same as menubar background. LGTM.

!image-2020-02-04-19-25-05-570.png!

FlatLaf Light with darker background:

!image-2020-02-04-19-27-10-325.png!

What do you think?

> Probably a darker color of the desktop background would be good for FlatLaf
> ---
>
> Key: NETBEANS-3727
> URL: https://issues.apache.org/jira/browse/NETBEANS-3727
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Minor
> Attachments: image-2020-01-21-16-30-56-282.png, 
> image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png, 
> image-2020-02-04-19-27-10-325.png
>
>
> Well, I'm not entirely convinced that this is an issue at all.
> Those rare times when we do not have an editor window open, the IDE might 
> look strange not having upper/left/right border on the opened tabs. I'd not 
> put border there, but probably mark the desktop color different (like the 
> editor default background on FlatLafDark).
> [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this 
> one.
> !image-2020-01-21-16-30-56-282.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf

2020-02-04 Thread Karl Tauber (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Tauber updated NETBEANS-3727:
--
Attachment: image-2020-02-04-19-27-10-325.png

> Probably a darker color of the desktop background would be good for FlatLaf
> ---
>
> Key: NETBEANS-3727
> URL: https://issues.apache.org/jira/browse/NETBEANS-3727
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Minor
> Attachments: image-2020-01-21-16-30-56-282.png, 
> image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png, 
> image-2020-02-04-19-27-10-325.png
>
>
> Well, I'm not entirely convinced that this is an issue at all.
> Those rare times when we do not have an editor window open, the IDE might 
> look strange not having upper/left/right border on the opened tabs. I'd not 
> put border there, but probably mark the desktop color different (like the 
> editor default background on FlatLafDark).
> [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this 
> one.
> !image-2020-01-21-16-30-56-282.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf

2020-02-04 Thread Karl Tauber (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Tauber updated NETBEANS-3727:
--
Attachment: image-2020-02-04-19-25-05-570.png

> Probably a darker color of the desktop background would be good for FlatLaf
> ---
>
> Key: NETBEANS-3727
> URL: https://issues.apache.org/jira/browse/NETBEANS-3727
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Minor
> Attachments: image-2020-01-21-16-30-56-282.png, 
> image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png
>
>
> Well, I'm not entirely convinced that this is an issue at all.
> Those rare times when we do not have an editor window open, the IDE might 
> look strange not having upper/left/right border on the opened tabs. I'd not 
> put border there, but probably mark the desktop color different (like the 
> editor default background on FlatLafDark).
> [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this 
> one.
> !image-2020-01-21-16-30-56-282.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2452) -Xbootclasspath/p is no longer a supported option

2020-02-04 Thread Ernestas Gruodis (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030036#comment-17030036
 ] 

Ernestas Gruodis commented on NETBEANS-2452:


Hi, just find the build-impl.xml file in your project and set
{code:java}
endorsed.classpath={code}
I mean after equal sign the value should be empty.

> -Xbootclasspath/p is no longer a supported option
> -
>
> Key: NETBEANS-2452
> URL: https://issues.apache.org/jira/browse/NETBEANS-2452
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler, java - Platform, projects - Ant
>Affects Versions: 9.0, 10.0, 11.0
> Environment: OpenJDK 11
>Reporter: Emile Brinkman
>Assignee: Emile Brinkman
>Priority: Major
>  Labels: patch
> Fix For: 11.0
>
>
> I have upgraded from NetBeans 8.2 and JDK1.8 to Apache NetBeans 11.0 and 
> OpenJDK 11. The Xbootclasspath option is no longer supported bij JDK11 and 
> apparently has to be changed to --patch-module. It is however still used in 
> the ANT build-impl.xml file under endorsed.classpath.path. The problem is 
> that if you change "-Xbootclasspath/p:" to "-patch module java.base=" that 
> NetBeans automatically overwrites it back to "-Xbootclasspath/p" when you 
> change properties of a project. -Xbootclasspath/a and -Xbootclasspath also 
> don't work.
> I also get the following error when running a class even when I changed 
> everything to --patch module:
> {{-Xbootclasspath/p is no longer a supported option.}}
>  {{Error: Could not create the Java Virtual Machine.}}
>  {{Error: A fatal exception has occurred. Program will exit.}}
>  
> {{C:\Users\user1\AppData\Local\NetBeans\Cache\11.0\executor-snippets\run.xml:111:
>  The following error occurred while executing this line:}}
>  
> {{C:\Users\user1\AppData\Local\NetBeans\Cache\11.0\executor-snippets\run.xml:94:
>  Java returned: 1}}
>  {{BUILD FAILED (total time: 0 seconds)}}
> Removing the cache folder doesn't help. I am not able anymore to run this 
> class even when I change the Source/Binary format of the project back to 
> JDK1.8. It seems that Apache NetBeans has hardcoded -Xbootclasspath 
> internally?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2452) -Xbootclasspath/p is no longer a supported option

2020-02-04 Thread Claudia Arriaga (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030033#comment-17030033
 ] 

Claudia Arriaga commented on NETBEANS-2452:
---

Hi! [~j-f-k], could you guide me as I do that, I have the same problem when 
migrating my web project to Netbeans 11 and jdk 11

> -Xbootclasspath/p is no longer a supported option
> -
>
> Key: NETBEANS-2452
> URL: https://issues.apache.org/jira/browse/NETBEANS-2452
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler, java - Platform, projects - Ant
>Affects Versions: 9.0, 10.0, 11.0
> Environment: OpenJDK 11
>Reporter: Emile Brinkman
>Assignee: Emile Brinkman
>Priority: Major
>  Labels: patch
> Fix For: 11.0
>
>
> I have upgraded from NetBeans 8.2 and JDK1.8 to Apache NetBeans 11.0 and 
> OpenJDK 11. The Xbootclasspath option is no longer supported bij JDK11 and 
> apparently has to be changed to --patch-module. It is however still used in 
> the ANT build-impl.xml file under endorsed.classpath.path. The problem is 
> that if you change "-Xbootclasspath/p:" to "-patch module java.base=" that 
> NetBeans automatically overwrites it back to "-Xbootclasspath/p" when you 
> change properties of a project. -Xbootclasspath/a and -Xbootclasspath also 
> don't work.
> I also get the following error when running a class even when I changed 
> everything to --patch module:
> {{-Xbootclasspath/p is no longer a supported option.}}
>  {{Error: Could not create the Java Virtual Machine.}}
>  {{Error: A fatal exception has occurred. Program will exit.}}
>  
> {{C:\Users\user1\AppData\Local\NetBeans\Cache\11.0\executor-snippets\run.xml:111:
>  The following error occurred while executing this line:}}
>  
> {{C:\Users\user1\AppData\Local\NetBeans\Cache\11.0\executor-snippets\run.xml:94:
>  Java returned: 1}}
>  {{BUILD FAILED (total time: 0 seconds)}}
> Removing the cache folder doesn't help. I am not able anymore to run this 
> class even when I change the Source/Binary format of the project back to 
> JDK1.8. It seems that Apache NetBeans has hardcoded -Xbootclasspath 
> internally?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-3791) Unclear use of Java hint: “Illegal Use of instanceOf operator”

2020-02-04 Thread dennis lucero (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

dennis lucero reassigned NETBEANS-3791:
---

Assignee: Jan Lahoda

> Unclear use of Java hint: “Illegal Use of instanceOf operator”
> --
>
> Key: NETBEANS-3791
> URL: https://issues.apache.org/jira/browse/NETBEANS-3791
> Project: NetBeans
>  Issue Type: Improvement
>  Components: java - Hints
> Environment: JDK 8 project, NetBeans running on JDK 13
>Reporter: dennis lucero
>Assignee: Jan Lahoda
>Priority: Minor
>  Labels: hints
>
> In an annotation processor similar to
> {code:java}
> @SupportedAnnotationTypes("org.example.MyAnnotation")
> public final class MyGenerator 
> extends javax.annotation.processing.AbstractProcessor {
> @Override
> public boolean process(
> final Set annotations,
> final RoundEnvironment roundEnvironment) {
> final Set elements
> = 
> roundEnvironment.getElementsAnnotatedWith(MyAnnotation.class);
> for (final Element element : elements) {
> PackageElement packageElement = null;
> for (Element currentElement = typeElement;
> currentElement != null;
> currentElement = currentElement.getEnclosingElement()) {
> if (currentElement instanceof PackageElement) { // Illegal 
> Use of instanceOf
> packageElement = (PackageElement) currentElement;
> break;
> }
> {code}
> I get the warning “Illegal Use of instanceOf operator” (in the line with the 
> comment). It is unclear why this use would be illegal, as it works fine.
> The description of the hint in the options should clearly say why it’s 
> illegal to use instanceOf or, if this warning is obsolete, the hint should be 
> removed.
> (According to http://wiki.netbeans.org/Java_Hints, this hint is disabled by 
> default.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3793) Debug of single Source Java File not working in windows

2020-02-04 Thread Arunava Sinha (Jira)
Arunava Sinha created NETBEANS-3793:
---

 Summary: Debug of single Source Java File not working in windows
 Key: NETBEANS-3793
 URL: https://issues.apache.org/jira/browse/NETBEANS-3793
 Project: NetBeans
  Issue Type: Bug
Affects Versions: Next
Reporter: Arunava Sinha
Assignee: Arunava Sinha


Debug of single Source Java File not working in windows

The issue in related to below bug:

https://issues.apache.org/jira/browse/NETBEANS-3616



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-3739] FlatLaf: fix missing versioning colors for modified/ignored files in FlatLaf Dark

2020-02-04 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 099f5b1  [NETBEANS-3739] FlatLaf: fix missing versioning colors for 
modified/ignored files in FlatLaf Dark
 new 700c560  Merge pull request #1919 from 
DevCharly/flatlaf-dark-versioning-colors
099f5b1 is described below

commit 099f5b1b62bfc64eed5ff636ab8fcf71d142bff3
Author: Karl Tauber 
AuthorDate: Tue Feb 4 15:43:54 2020 +0100

[NETBEANS-3739] FlatLaf: fix missing versioning colors for modified/ignored 
files in FlatLaf Dark
---
 platform/openide.awt/src/org/openide/awt/HtmlLabelUI.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/openide.awt/src/org/openide/awt/HtmlLabelUI.java 
b/platform/openide.awt/src/org/openide/awt/HtmlLabelUI.java
index d52ce95..26c70cd 100644
--- a/platform/openide.awt/src/org/openide/awt/HtmlLabelUI.java
+++ b/platform/openide.awt/src/org/openide/awt/HtmlLabelUI.java
@@ -408,7 +408,7 @@ class HtmlLabelUI extends LabelUI {
 
 if (!replace) {
 dif = difference(fg, bg);
-replace = dif < 80;
+replace = dif < 60;
 }
 
 if (replace) {


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3701) Color setting for changed and ignored files is not used in Projects and Files views with FlatLaf Dark

2020-02-04 Thread Alessandro Falappa (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alessandro Falappa resolved NETBEANS-3701.
--
Resolution: Duplicate

> Color setting for changed and ignored files is not used in Projects and Files 
> views with FlatLaf Dark
> -
>
> Key: NETBEANS-3701
> URL: https://issues.apache.org/jira/browse/NETBEANS-3701
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Settings, FlatLaf
>Affects Versions: 11.3
> Environment: Product Version: Apache NetBeans IDE DEV (Build 
> dev-71270e6cd2ac4daf7bfd1baf3727aa90735c60fc)
> Java: 1.8.0_201; Java HotSpot(TM) 64-Bit Server VM 25.201-b09
> Runtime: Java(TM) SE Runtime Environment 1.8.0_201-b09
> System: Linux version 4.15.0-74-generic running on amd64; UTF-8; en_US (nb)
>Reporter: Tomáš Procházka
>Priority: Minor
>
> Files changed and ignored Under FlatLaf Dark look and feel are displayed in 
> white color in Projects and Files views instead of dark grey as in editor 
> tab. Problem seems to be that color setting is used only for editor tab and 
> not for views Projects and Files.
> Steps to reproduce:
>  # Open project from Git.
>  # Create file, add it to ignored files, open that file.
>  # Use look and feel "FlatLaf Dark".
>  # Under Fonts & Colors set Versioning - Git - Ignored color to Magenta.
>  # Name of ignored file in editor tab will be magenta.
>  # Name of file in Projects and Files views will be white - it should be also 
> magenta.
> Another places with white instead of magenta are list of files opened by 
> Ctrl+Tab and list of open files opened by button at the right side of open 
> tabs.
> Same problem is with changed files - tab title shows blue filename for 
> changed file, but list in Projects, Files, swithing file with Ctrl+Tab and 
> list of open files in tab bar show file name in white color.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3735) FlatLaf: Desktop does not repaint after closing the last editor tab.

2020-02-04 Thread Alessandro Falappa (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alessandro Falappa updated NETBEANS-3735:
-
Labels: ide-ui  (was: )

> FlatLaf: Desktop does not repaint after closing the last editor tab.
> 
>
> Key: NETBEANS-3735
> URL: https://issues.apache.org/jira/browse/NETBEANS-3735
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Major
>  Labels: ide-ui
> Attachments: FlatLafNoRepaint.mp4
>
>
> When all the side comonents are minimized and the last editor window is 
> closed the focus is moved to the global search, in this case the desktop does 
> not repaint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3758) "Run File" is often disabled after introducing a main() method

2020-02-04 Thread Alessandro Falappa (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029931#comment-17029931
 ] 

Alessandro Falappa commented on NETBEANS-3758:
--

Another guess is that your projects are on a filesystem where the file watching 
mechanism is not working properly, i.e. network mounted share.

> "Run File" is often disabled after introducing a main() method
> --
>
> Key: NETBEANS-3758
> URL: https://issues.apache.org/jira/browse/NETBEANS-3758
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Actions/Menu/Toolbar
>Affects Versions: 11.1
>Reporter: Marco Herrn
>Priority: Major
>  Labels: run
> Attachments: main.png
>
>
> Often when introducing a new `main` method into an existing class, the "Run 
> File" and "Debug File" menu entries are still disabled and is therefore 
> impossible to execute this `main` method.
> In most cases it is necessary to closes netbeans and clear the netbeans cache 
> to be able to execute it, which is absolutely counterproductive if such a 
> method is only temporarily inserted for testing purposes.
> It may be that this only happens with Maven projects, since all my projects 
> are maven based.
> Please see the attached screenshot that shows the context menu after 
> introducing a new `main` method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3758) "Run File" is often disabled after introducing a main() method

2020-02-04 Thread Alessandro Falappa (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029928#comment-17029928
 ] 

Alessandro Falappa commented on NETBEANS-3758:
--

Have you saved the file after adding the main method?

>From my experiments the entries are disabled until the file is saved.

Works for me on maven projects.

> "Run File" is often disabled after introducing a main() method
> --
>
> Key: NETBEANS-3758
> URL: https://issues.apache.org/jira/browse/NETBEANS-3758
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Actions/Menu/Toolbar
>Affects Versions: 11.1
>Reporter: Marco Herrn
>Priority: Major
>  Labels: run
> Attachments: main.png
>
>
> Often when introducing a new `main` method into an existing class, the "Run 
> File" and "Debug File" menu entries are still disabled and is therefore 
> impossible to execute this `main` method.
> In most cases it is necessary to closes netbeans and clear the netbeans cache 
> to be able to execute it, which is absolutely counterproductive if such a 
> method is only temporarily inserted for testing purposes.
> It may be that this only happens with Maven projects, since all my projects 
> are maven based.
> Please see the attached screenshot that shows the context menu after 
> introducing a new `main` method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3760) cannot load java.lang

2020-02-04 Thread Alessandro Falappa (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alessandro Falappa resolved NETBEANS-3760.
--
Resolution: Incomplete

No description of problem

> cannot load java.lang
> -
>
> Key: NETBEANS-3760
> URL: https://issues.apache.org/jira/browse/NETBEANS-3760
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Jorge M Morales
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3781) java运行不了

2020-02-04 Thread Alessandro Falappa (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029925#comment-17029925
 ] 

Alessandro Falappa commented on NETBEANS-3781:
--

Please rewrite the issue in english

> java运行不了
> 
>
> Key: NETBEANS-3781
> URL: https://issues.apache.org/jira/browse/NETBEANS-3781
> Project: NetBeans
>  Issue Type: Bug
>Reporter: 鲍禹含
>Priority: Major
> Attachments: messages.log, messages.log.1, messages.log.2, metrics, 
> uigestures, uigestures.1, updater.log.0
>
>
> 同样的程序前段时间在单位可以运行,回家之后点击运行,出现一个对话框,里面写着:Available Main Classes:
> Initializing view,please wait...
> 然后就一直卡在这不动了,不知道什么原因。
> 应该是哪里配置出了问题,不是程序的问题。



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3739) Strange Versioning Colors in FlatLafDark

2020-02-04 Thread Karl Tauber (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029889#comment-17029889
 ] 

Karl Tauber commented on NETBEANS-3739:
---

This happens also in other LAFs when using custom colors. E.g. go to "Options > 
Fonts & Colors > Git" and change "Modified in working tree" color to "Cyan". 
Then the same happens in Windows LAF and FlatLaf Light (and probably in all 
other light LAFs too).

After debugging for some hours I've found the reason. It is in 
[HtmlLabelUI.ensureContrastingColor(Color fg, Color 
bg)|https://github.com/apache/netbeans/blob/b4413352033a7da5ba6ba794a2b8110d643ae8a3/platform/openide.awt/src/org/openide/awt/HtmlLabelUI.java#L375-L426],
 which compares the luminance of the foreground and background colors. If the 
difference is smaller than 80 (max is 255), then either black or white is 
returned.

In case of FlatLaf Dark, the luminance difference is 73 for modified and 65 for 
ignored files.

I think a reasonable solution is to lower the luminance difference limit from 
80 to 60.

I'll create a PR...

> Strange Versioning Colors in FlatLafDark
> 
>
> Key: NETBEANS-3739
> URL: https://issues.apache.org/jira/browse/NETBEANS-3739
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Project/File view Versioning colors are displayed as white for 
> modified/ignored files.
> They are displayed right (green) for added ones.
> It's only happening on FlatLaf Dark. FlatLafLight are displaying the those 
> files correctly. I've checked the AnnotationColorProvider, is seems to 
> generate the annotations fine, for ignored.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3792) Hardcoded colors for "Remove Surrounding Code" action

2020-02-04 Thread Alessandro Falappa (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alessandro Falappa updated NETBEANS-3792:
-
Attachment: remove-surrounding-on-darktheme.png

> Hardcoded colors for "Remove Surrounding Code" action
> -
>
> Key: NETBEANS-3792
> URL: https://issues.apache.org/jira/browse/NETBEANS-3792
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Painting  Printing, ide - UI
>Affects Versions: 11.2
>Reporter: Alessandro Falappa
>Priority: Minor
> Attachments: remove-surrounding-on-darktheme.png
>
>
> The RemoveSurroundingCode action contains hardcoded colors here:
>  
> [https://github.com/apache/netbeans/blob/accdbada0a9c5105bd3f06e435024230c1618316/java/java.editor/src/org/netbeans/modules/java/editor/codegen/RemoveSurroundingCodeAction.java#L215]
> The choosen colors look too bright on dark themes. The colors should be taken 
> from the LAF's defaults or better exposed in the editor color profile and 
> made customizable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-3792) Hardcoded colors for "Remove Surrounding Code" action

2020-02-04 Thread Alessandro Falappa (Jira)
Alessandro Falappa created NETBEANS-3792:


 Summary: Hardcoded colors for "Remove Surrounding Code" action
 Key: NETBEANS-3792
 URL: https://issues.apache.org/jira/browse/NETBEANS-3792
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Painting  Printing, ide - UI
Affects Versions: 11.2
Reporter: Alessandro Falappa


The RemoveSurroundingCode action contains hardcoded colors here:
 
[https://github.com/apache/netbeans/blob/accdbada0a9c5105bd3f06e435024230c1618316/java/java.editor/src/org/netbeans/modules/java/editor/codegen/RemoveSurroundingCodeAction.java#L215]

The choosen colors look too bright on dark themes. The colors should be taken 
from the LAF's defaults or better exposed in the editor color profile and made 
customizable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3785) Make memory gauge look better, especially on HiDPI displays

2020-02-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3785:
-
Labels: HiDPI pull-request-available  (was: HiDPI)

> Make memory gauge look better, especially on HiDPI displays
> ---
>
> Key: NETBEANS-3785
> URL: https://issues.apache.org/jira/browse/NETBEANS-3785
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.2
> Environment: Windows, MacOS, and probably Linux, especially on 
> HiDPI/retina displays
>Reporter: Eirik Bakke
>Priority: Minor
>  Labels: HiDPI, pull-request-available
> Attachments: gauge.jpg
>
>
> Scott Palmer writes: "Does anyone else see really ugly text in the memory 
> usage widget on the toolbar?  This has been an issue for a while and I can’t 
> recall if I have reported it or it is already a known issue.  It seems like 
> something that shouldn’t be hard to address.  The text showing heap used vs 
> available heap is rendered in such a way that the letters are very puffy and 
> jagged.  Almost like any anti-aliasing that would be blending the edges has 
> the alpha channel interpreted as a binary 0% or 100% opacity.  I’ve attached 
> an image, not sure if it will are it through. I’m testing NB 11.3-beta 2 with 
> JDK 13.0.2 on macOS 10.15.3 (beta)"
> Eirik Bakke confirms that this has been an issue for a long time. In 
> particular, the memory gauge should be updated to look good on HiDPI/Retina 
> displays.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-3737] FlatLaf: fix cramped Toolbar icons

2020-02-04 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 1393f5f  [NETBEANS-3737] FlatLaf: fix cramped Toolbar icons
 new ef2dc1b  Merge pull request #1917 from DevCharly/flatlaf-toolbar-icons
1393f5f is described below

commit 1393f5f5c02142fdb56214da6c41899d1a4a5b1e
Author: Karl Tauber 
AuthorDate: Tue Feb 4 11:04:03 2020 +0100

[NETBEANS-3737] FlatLaf: fix cramped Toolbar icons
---
 platform/openide.loaders/src/org/openide/awt/Toolbar.java | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/platform/openide.loaders/src/org/openide/awt/Toolbar.java 
b/platform/openide.loaders/src/org/openide/awt/Toolbar.java
index e9fb162..9cf9b40 100644
--- a/platform/openide.loaders/src/org/openide/awt/Toolbar.java
+++ b/platform/openide.loaders/src/org/openide/awt/Toolbar.java
@@ -24,7 +24,6 @@ import java.awt.Component;
 import java.awt.Insets;
 import java.awt.event.ActionEvent;
 import java.beans.PropertyChangeListener;
-import java.io.File;
 import java.io.IOException;
 import java.util.EventListener;
 import java.util.EventObject;
@@ -78,6 +77,9 @@ public class Toolbar extends ToolbarWithOverflow 
/*implemented by patchsuperclas
 //needed to turn off the painting of toolbar button borders on ocean
 private static final boolean isMetalLaF =
 
MetalLookAndFeel.class.isAssignableFrom(UIManager.getLookAndFeel().getClass());
+
+private static final boolean isFlatLaF =
+UIManager.getLookAndFeel().getID().startsWith("FlatLaf");
 
 static final long serialVersionUID = 5011742660516204764L;
 static {
@@ -182,7 +184,7 @@ public class Toolbar extends ToolbarWithOverflow 
/*implemented by patchsuperclas
 }
 //This is active for GTK L It should be fixed in JDK
 //but it is not fixed in JDK 6.0.
-if (!isMetalLaF) {
+if (!isMetalLaF && !isFlatLaF) {
 ((AbstractButton) c).setMargin( emptyInsets );
 }
 if( null != label && c != label ) {


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3737) FlatLaf: Toolbar icons feel cramped

2020-02-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3737:
-
Labels: pull-request-available  (was: )

> FlatLaf: Toolbar icons feel cramped
> ---
>
> Key: NETBEANS-3737
> URL: https://issues.apache.org/jira/browse/NETBEANS-3737
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - UI
>Affects Versions: 11.3
>Reporter: Benjamin Graf
>Assignee: Karl Tauber
>Priority: Minor
>  Labels: pull-request-available
> Attachments: image-2020-01-23-16-40-39-512.png
>
>
> Toolbar icons in FlatLaf themes are feeling cramped especially if small icons 
> are chosen. The theme should add some padding around them like the other 
> themes already are doing. 
>  
> !image-2020-01-23-16-40-39-512.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Reopened] (NETBEANS-3558) Add Spring Framework 5.2.2

2020-02-04 Thread Eric Barboni (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Barboni reopened NETBEANS-3558:


Introduction of 5.x framework make some other part of NetBeans not usable
If you try to create project 
  java with maven > Web application
  java with Ant > Java Web > Web application
and then add framework 5.2.2 inside their becoming
non runnable, because configuration file contains removed stuff (knowledge 
missing) that were ok on 4.x or 3.x

dispatcher-servlet.xml 


> Add Spring Framework 5.2.2
> --
>
> Key: NETBEANS-3558
> URL: https://issues.apache.org/jira/browse/NETBEANS-3558
> Project: NetBeans
>  Issue Type: Improvement
>  Components: javaee - Spring
>Affects Versions: Next
>Reporter: Hector Espert
>Assignee: Hector Espert
>Priority: Minor
>  Labels: pull-request-available
> Fix For: Next
>
> Attachments: Screenshot from 2019-12-22 13-24-24.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Update java/libs.springframework module to add Spring Framework 5.2.2 library 
> dependency for ant projects.
> !Screenshot from 2019-12-22 13-24-24.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3739) Strange Versioning Colors in FlatLafDark

2020-02-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-3739:
-
Labels: pull-request-available  (was: )

> Strange Versioning Colors in FlatLafDark
> 
>
> Key: NETBEANS-3739
> URL: https://issues.apache.org/jira/browse/NETBEANS-3739
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Laszlo Kishalmi
>Assignee: Karl Tauber
>Priority: Major
>  Labels: pull-request-available
>
> The Project/File view Versioning colors are displayed as white for 
> modified/ignored files.
> They are displayed right (green) for added ones.
> It's only happening on FlatLaf Dark. FlatLafLight are displaying the those 
> files correctly. I've checked the AnnotationColorProvider, is seems to 
> generate the annotations fine, for ignored.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists