[jira] [Updated] (NETBEANS-4844) Non modular JDK 9+ Gradle projects falls back to Java 8 sourcelevel
[ https://issues.apache.org/jira/browse/NETBEANS-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-4844: - Labels: pull-request-available (was: ) > Non modular JDK 9+ Gradle projects falls back to Java 8 sourcelevel > --- > > Key: NETBEANS-4844 > URL: https://issues.apache.org/jira/browse/NETBEANS-4844 > Project: NetBeans > Issue Type: Bug >Reporter: Laszlo Kishalmi >Assignee: Laszlo Kishalmi >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-4844) Non modular JDK 9+ Gradle projects falls back to Java 8 sourcelevel
Laszlo Kishalmi created NETBEANS-4844: - Summary: Non modular JDK 9+ Gradle projects falls back to Java 8 sourcelevel Key: NETBEANS-4844 URL: https://issues.apache.org/jira/browse/NETBEANS-4844 Project: NetBeans Issue Type: Bug Reporter: Laszlo Kishalmi Assignee: Laszlo Kishalmi -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4832) fxml code completion fails with modular java
[
https://issues.apache.org/jira/browse/NETBEANS-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ernie Rael updated NETBEANS-4832:
-
Labels: modularization pull-requests-available (was: modularization
pull-request-available)
> fxml code completion fails with modular java
>
>
> Key: NETBEANS-4832
> URL: https://issues.apache.org/jira/browse/NETBEANS-4832
> Project: NetBeans
> Issue Type: Bug
> Components: javafx - Editor
> Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
> startup do not import settings
>Reporter: Ernie Rael
>Priority: Major
> Labels: modularization, pull-requests-available
> Attachments: AllModulesAssert-messages-2.log
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To reproduce (create/open fxml file)
> # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> # Open primary.fxml, in "other sources" "source/main/resources"
> # put cursor within xml, for example after ""
> # Enter Ctrl-Space to bring up code completion
> Observe:
> * Typically have to go through a couple web certification dialogs
> * Typically repeat Ctrl-Space and there's a "downloading..." that never
> finishes
> Note: Works OK when running on and using jdk1.8 with nb-javac.
> Fails with JDK assertion: Assert.checkNonNull(allModules)
> (full message log attached)
> {code}
> java.lang.AssertionError at
> jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at
> jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at
> jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205)
> at
> jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126)
> at
> org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49)
> at
> org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666)
> at
> org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163)
> at
> org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at
> org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.(InstanceCompleter.java:54)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4832) fxml code completion fails with modular java
[
https://issues.apache.org/jira/browse/NETBEANS-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated NETBEANS-4832:
-
Labels: modularization pull-request-available (was: modularization)
> fxml code completion fails with modular java
>
>
> Key: NETBEANS-4832
> URL: https://issues.apache.org/jira/browse/NETBEANS-4832
> Project: NetBeans
> Issue Type: Bug
> Components: javafx - Editor
> Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
> startup do not import settings
>Reporter: Ernie Rael
>Priority: Major
> Labels: modularization, pull-request-available
> Attachments: AllModulesAssert-messages-2.log
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To reproduce (create/open fxml file)
> # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> # Open primary.fxml, in "other sources" "source/main/resources"
> # put cursor within xml, for example after ""
> # Enter Ctrl-Space to bring up code completion
> Observe:
> * Typically have to go through a couple web certification dialogs
> * Typically repeat Ctrl-Space and there's a "downloading..." that never
> finishes
> Note: Works OK when running on and using jdk1.8 with nb-javac.
> Fails with JDK assertion: Assert.checkNonNull(allModules)
> (full message log attached)
> {code}
> java.lang.AssertionError at
> jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at
> jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at
> jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205)
> at
> jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126)
> at
> org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49)
> at
> org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666)
> at
> org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163)
> at
> org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at
> org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.(InstanceCompleter.java:54)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4832) fxml code completion fails with modular java
[
https://issues.apache.org/jira/browse/NETBEANS-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201840#comment-17201840
]
Ernie Rael commented on NETBEANS-4832:
--
Got a fix for the assertion. Then there was the NPE and a fix.
Not sure if this gets fxml up to jdk8 standard.
> fxml code completion fails with modular java
>
>
> Key: NETBEANS-4832
> URL: https://issues.apache.org/jira/browse/NETBEANS-4832
> Project: NetBeans
> Issue Type: Bug
> Components: javafx - Editor
> Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
> startup do not import settings
>Reporter: Ernie Rael
>Priority: Major
> Labels: modularization
> Attachments: AllModulesAssert-messages-2.log
>
>
> To reproduce (create/open fxml file)
> # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
> # Open primary.fxml, in "other sources" "source/main/resources"
> # put cursor within xml, for example after ""
> # Enter Ctrl-Space to bring up code completion
> Observe:
> * Typically have to go through a couple web certification dialogs
> * Typically repeat Ctrl-Space and there's a "downloading..." that never
> finishes
> Note: Works OK when running on and using jdk1.8 with nb-javac.
> Fails with JDK assertion: Assert.checkNonNull(allModules)
> (full message log attached)
> {code}
> java.lang.AssertionError at
> jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at
> jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at
> jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205)
> at
> jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126)
> at
> org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49)
> at
> org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666)
> at
> org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163)
> at
> org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at
> org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.(InstanceCompleter.java:54)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2256) NetBeans 11 vc3: Unable to manage GlassFish 5.1 when running NetBeans using any JDK greater than JDK 8
[ https://issues.apache.org/jira/browse/NETBEANS-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201787#comment-17201787 ] Francesco Savino commented on NETBEANS-2256: does will be fixed in Glassfish 6 ? > NetBeans 11 vc3: Unable to manage GlassFish 5.1 when running NetBeans using > any JDK greater than JDK 8 > --- > > Key: NETBEANS-2256 > URL: https://issues.apache.org/jira/browse/NETBEANS-2256 > Project: NetBeans > Issue Type: Bug > Components: javaee - Web Project, serverplugins - GlassFish >Affects Versions: 11.0 > Environment: Mac OS X 10.13.6 >Reporter: Josh Juneau >Priority: Minor > > If I run Apache NetBeans using JDK 9+, then I am unable to manage GlassFish > server or deployments to GlassFish server from within the IDE. GlassFish 5+ > currently only supports JDK 8, so I believe this is OK. The expectation will > be that Apache NetBeans must be run under the JDK that is being used for > deployment of Java EE applications. > > When running NetBeans under JDK 8, GlassFish support works, as expected. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4305) cleanup dead hardware support
[ https://issues.apache.org/jira/browse/NETBEANS-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-4305: - Labels: pull-request-available (was: ) > cleanup dead hardware support > - > > Key: NETBEANS-4305 > URL: https://issues.apache.org/jira/browse/NETBEANS-4305 > Project: NetBeans > Issue Type: Bug >Affects Versions: Next >Reporter: Brad Walker >Assignee: Brad Walker >Priority: Major > Labels: pull-request-available > Fix For: Next > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Sun Microsystems has not produced a 32-bit microprocessor in years. In > addition, Solaris is now strictly 64-bit and has been that way for a LONG > time. > So cleanup the platform support to remove support for 32-bit SPARC processors > and Solaris. > Java doesn't even run on this equipment. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-4305] - cleanup dead hardware support
This is an automated email from the ASF dual-hosted git repository.
matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 681301e [NETBEANS-4305] - cleanup dead hardware support
new 5743f22 Merge pull request #2131 from
BradWalker/remove_solaris_platform
681301e is described below
commit 681301ee4cb9c989f2fac79e28cfdd7b3b5138bd
Author: Brad Walker
AuthorDate: Mon May 4 23:09:28 2020 -0600
[NETBEANS-4305] - cleanup dead hardware support
Sun Microsystems has not produced a 32-bit microprocessor in years. In
addition, Solaris is
now strictly 64-bit and has been that way for a LONG time.
So cleanup the platform support to remove support for 32-bit SPARC
processors and Solaris.
Java doesn't even run on this equipment!
---
.../nbproject/project.properties | 8 ---
ide/dlight.nativeexecution/tools/Makefile | 1 -
.../tools/build-pty-support.sh | 1 -
ide/dlight.nativeexecution/tools/killall/Makefile | 13 ++---
ide/dlight.nativeexecution/tools/pty/Makefile | 1 -
ide/dlight.nativeexecution/tools/unbuffer/Makefile | 2 -
.../installer/utils/system/SolarisNativeUtils.java | 11 +
nbi/infra/build/jvm/build.xml | 7 ---
.../build/jvm/tools/unzipsfx/solaris-sparc/LICENSE | 49 ---
.../libsrc/org/netbeans/updater/UpdaterFrame.java | 33 -
.../common/integration/IntegrationUtils.java | 18 ++-
.../native/build/buildnative-solaris.sh| 57 --
.../release/remote-pack-defs/build.xml | 9 +---
.../remote-pack-defs/profile-solsparc-15.sh| 34 -
.../remote-pack-defs/profile-solsparc-16.sh| 34 -
.../profiler/attach/dialog/AttachDialog.java | 1 -
.../attach/spi/AbstractRemotePackExporter.java | 1 -
17 files changed, 11 insertions(+), 269 deletions(-)
diff --git a/ide/dlight.nativeexecution/nbproject/project.properties
b/ide/dlight.nativeexecution/nbproject/project.properties
index 41a0bd1..ec6bcf2 100644
--- a/ide/dlight.nativeexecution/nbproject/project.properties
+++ b/ide/dlight.nativeexecution/nbproject/project.properties
@@ -85,14 +85,6 @@ release.external/exechlp-1.0.zip!/MacOSX-x86_64/pty_open
= bin/nativeexec
release.external/exechlp-1.0.zip!/MacOSX-x86_64/stat=
bin/nativeexecution/MacOSX-x86_64/stat
release.external/exechlp-1.0.zip!/MacOSX-x86_64/unbuffer.dylib =
bin/nativeexecution/MacOSX-x86_64/unbuffer.dylib
release.external/exechlp-1.0.zip!/MacOSX-x86_64/killall =
bin/nativeexecution/MacOSX-x86_64/killall
-release.external/exechlp-1.0.zip!/SunOS-sparc/privp =
bin/nativeexecution/SunOS-sparc/privp
-release.external/exechlp-1.0.zip!/SunOS-sparc/process_start =
bin/nativeexecution/SunOS-sparc/process_start
-release.external/exechlp-1.0.zip!/SunOS-sparc/pty =
bin/nativeexecution/SunOS-sparc/pty
-release.external/exechlp-1.0.zip!/SunOS-sparc/pty_open =
bin/nativeexecution/SunOS-sparc/pty_open
-release.external/exechlp-1.0.zip!/SunOS-sparc/sigqueue =
bin/nativeexecution/SunOS-sparc/sigqueue
-release.external/exechlp-1.0.zip!/SunOS-sparc/stat =
bin/nativeexecution/SunOS-sparc/stat
-release.external/exechlp-1.0.zip!/SunOS-sparc/unbuffer.so =
bin/nativeexecution/SunOS-sparc/unbuffer.so
-release.external/exechlp-1.0.zip!/SunOS-sparc/killall =
bin/nativeexecution/SunOS-sparc/killall
release.external/exechlp-1.0.zip!/SunOS-sparc_64/privp =
bin/nativeexecution/SunOS-sparc_64/privp
release.external/exechlp-1.0.zip!/SunOS-sparc_64/process_start =
bin/nativeexecution/SunOS-sparc_64/process_start
release.external/exechlp-1.0.zip!/SunOS-sparc_64/pty=
bin/nativeexecution/SunOS-sparc_64/pty
diff --git a/ide/dlight.nativeexecution/tools/Makefile
b/ide/dlight.nativeexecution/tools/Makefile
index 230d945..0796cbd 100644
--- a/ide/dlight.nativeexecution/tools/Makefile
+++ b/ide/dlight.nativeexecution/tools/Makefile
@@ -33,7 +33,6 @@ CF_Linux-sparc_64 = -DLINUX -D_GNU_SOURCE
-D_XOPEN_SOURCE=700 -m64
CF_Linux-arm = -DLINUX -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -std=c99
CF_MacOSX-x86 = -DMAXOSX -D_DARWIN_C_SOURCE -m32
CF_MacOSX-x86_64= -DMAXOSX -D_DARWIN_C_SOURCE -m64
-CF_SunOS-sparc = -DSOLARIS -D__EXTENSIONS__ -m32
CF_SunOS-sparc_64 = -DSOLARIS -D__EXTENSIONS__ -m64
CF_SunOS-x86 = -DSOLARIS -m32
CF_SunOS-x86_64= -DSOLARIS -m64
diff --git a/ide/dlight.nativeexecution/tools/build-pty-support.sh
b/ide/dlight.nativeexecution/tools/build-pty-support.sh
index ac4609d..2e4bffc 100755
--- a/ide/dlight.nativeexecution/tools/build-pty-support.sh
+++ b/ide/dlight.nativeexecution/tools/build-pty-support.sh
@@ -82,7 +82,6 @@ copy_to_release() {
[jira] [Updated] (NETBEANS-3990) JEP 360: Sealed Types Support in Netbeans
[ https://issues.apache.org/jira/browse/NETBEANS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-3990: - Labels: pull-request-available (was: ) > JEP 360: Sealed Types Support in Netbeans > - > > Key: NETBEANS-3990 > URL: https://issues.apache.org/jira/browse/NETBEANS-3990 > Project: NetBeans > Issue Type: Improvement >Affects Versions: 12.0 >Reporter: Akshay Gupta >Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > Providing all the support needed for new feature sealed types in JDK15. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Show types for chained method invocations.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new c9ff717 Show types for chained method invocations.
c9ff717 is described below
commit c9ff7179ff55d10abb217b2b13d3d988489c5f5f
Author: Jan Lahoda
AuthorDate: Sun Sep 13 12:24:49 2020 +0200
Show types for chained method invocations.
---
.../editor/lib2/view/ParagraphViewChildren.java| 10 +++--
.../base/semantic/SemanticHighlighterBase.java | 49 +
.../java/editor/base/semantic/TokenList.java | 15 ++-
.../java/editor/base/semantic/DetectorTest.java| 51 ++
4 files changed, 121 insertions(+), 4 deletions(-)
diff --git
a/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/ParagraphViewChildren.java
b/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/ParagraphViewChildren.java
index 38c2787..3275a68 100644
---
a/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/ParagraphViewChildren.java
+++
b/ide/editor.lib2/src/org/netbeans/modules/editor/lib2/view/ParagraphViewChildren.java
@@ -168,8 +168,8 @@ final class ParagraphViewChildren extends
ViewChildren {
view.setRawEndOffset(relEndOffset); // Below offset-gap
view.setParent(pView);
// Possibly assign text layout
-if (view instanceof HighlightsView || (view instanceof
PrependedTextView && ((PrependedTextView) view).getDelegate() instanceof
HighlightsView)) {
-HighlightsView hView = (HighlightsView) (view instanceof
HighlightsView ? view : ((PrependedTextView) view).getDelegate());
+if (viewOrDelegate(view) instanceof HighlightsView) {
+HighlightsView hView = (HighlightsView)
viewOrDelegate(view);
// Fill in text layout if necessary
if (hView.getTextLayout() == null) { // Fill in text layout
if (docText == null) {
@@ -430,7 +430,7 @@ final class ParagraphViewChildren extends
ViewChildren {
while (startIndex < endIndex) {
EditorView view = get(startIndex);
Shape childAlloc = getChildAllocation(startIndex, pAlloc);
-if (view.getClass() == NewlineView.class) {
+if (viewOrDelegate(view).getClass() == NewlineView.class) {
// Extend till end of screen (docView's width)
Rectangle2D.Double childRect =
ViewUtils.shape2Bounds(childAlloc);
DocumentView docView = pView.getDocumentView();
@@ -847,6 +847,10 @@ final class ParagraphViewChildren extends
ViewChildren {
return new StringBuilder(10).append("
x=").append(startVisualOffset(index)).toString();
}
+private View viewOrDelegate(View view) {
+return view instanceof PrependedTextView ? ((PrependedTextView)
view).getDelegate() : view;
+}
+
private static final class IndexAndAlloc {
/**
diff --git
a/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
b/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
index 00e115d..8146d84 100644
---
a/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
+++
b/java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
@@ -21,6 +21,7 @@ package org.netbeans.modules.java.editor.base.semantic;
import com.sun.source.tree.ClassTree;
import com.sun.source.tree.CompilationUnitTree;
import com.sun.source.tree.ExportsTree;
+import com.sun.source.tree.ExpressionStatementTree;
import com.sun.source.tree.IdentifierTree;
import com.sun.source.tree.LiteralTree;
import com.sun.source.tree.MemberReferenceTree;
@@ -42,9 +43,12 @@ import com.sun.source.util.TreePath;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Collections;
import java.util.EnumSet;
import java.util.HashMap;
import java.util.IdentityHashMap;
+import java.util.Iterator;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -56,6 +60,7 @@ import javax.lang.model.element.Element;
import javax.lang.model.element.ElementKind;
import javax.lang.model.element.ExecutableElement;
import javax.lang.model.element.Modifier;
+import javax.lang.model.type.TypeMirror;
import javax.swing.text.Document;
import org.netbeans.api.java.lexer.JavaTokenId;
import org.netbeans.api.java.source.CompilationInfo;
@@ -714,6 +719,50 @@ public abstract class SemanticHighlighterBase extends
JavaParserResultTask {
}
@Override
+public Void visitExpressionStatement(ExpressionStatementTree node,
Void p) {
+List
[jira] [Resolved] (NETBEANS-4840) NPE when activating plugins
[ https://issues.apache.org/jira/browse/NETBEANS-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose resolved NETBEANS-4840. Resolution: Fixed Fixed via [PR-2398|https://github.com/apache/netbeans/pull/2398] > NPE when activating plugins > --- > > Key: NETBEANS-4840 > URL: https://issues.apache.org/jira/browse/NETBEANS-4840 > Project: NetBeans > Issue Type: Bug > Components: java - Platform >Affects Versions: 12.2 >Reporter: Jose >Assignee: Jose >Priority: Blocker > Fix For: 12.2 > > Attachments: NPE-20200923.log > > Time Spent: 0.5h > Remaining Estimate: 0h > > Fresh build of current master and then try to activate any of the java > related plugins will end in a _java.lang.NullPointerException_. > Plugins that fail to activate: > * Developing NetBeans > * Groovy > * JavaFX2 > * Java SE > * Java Web and EE > This was integrated by > [PR-2390|https://github.com/apache/netbeans/pull/2390]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-4840) NPE when activating plugins
[ https://issues.apache.org/jira/browse/NETBEANS-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose reassigned NETBEANS-4840: -- Assignee: Jose > NPE when activating plugins > --- > > Key: NETBEANS-4840 > URL: https://issues.apache.org/jira/browse/NETBEANS-4840 > Project: NetBeans > Issue Type: Bug > Components: java - Platform >Affects Versions: 12.2 >Reporter: Jose >Assignee: Jose >Priority: Blocker > Fix For: 12.2 > > Attachments: NPE-20200923.log > > Time Spent: 0.5h > Remaining Estimate: 0h > > Fresh build of current master and then try to activate any of the java > related plugins will end in a _java.lang.NullPointerException_. > Plugins that fail to activate: > * Developing NetBeans > * Groovy > * JavaFX2 > * Java SE > * Java Web and EE > This was integrated by > [PR-2390|https://github.com/apache/netbeans/pull/2390]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
[
https://issues.apache.org/jira/browse/NETBEANS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201577#comment-17201577
]
Laszlo Kishalmi commented on NETBEANS-4842:
---
Well, thanks for this one!
Wouldn't you file this one as a PR? It seems you've already have the source,
why don't get some Open Source credit as well?
Though if you wish, I can put this one into a PR and get it merged as well.
> Go To Source broken with JUnit5 (and Gradle)
>
>
> Key: NETBEANS-4842
> URL: https://issues.apache.org/jira/browse/NETBEANS-4842
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Reporter: Ratcash Developer
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> JUnit4 and TestNG logs tested method names like:
> {noformat}
> testResults.MainTest > testA
> {noformat}
> However, JUnit5 adds the method's parameters, like this:
> {noformat}
> testResults.SecondaryTest > testA()
> testResults.SecondaryTest > testB()
> testResults.SecondaryTest > [1] 1, 2
> {noformat}
> The last one is a result of using
> {noformat}
> @ParametrizedTest
> @MethodSource("generate")
> public void testC(String a, String b) {
>// do something clever
> }
> {noformat}
> Such method names are not understood by the "Go To Source" functionality.
> For gradle projects a quick work-around may be the following change to clean
> method names:
> {code:java}
> ---
> a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> +++
> b/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> @@ -80,7 +80,18 @@ public final class LocationOpener {
> }
> }
>
> - private int getMethodLine(final FileObject fo, final String methodName) {
> + private static String stripMethodParams(String methodNameWithParams) {
> +final int paramsIndex = methodNameWithParams.indexOf("(");
> +String cleanName = methodNameWithParams;
> +if (paramsIndex > 0) {
> +cleanName = methodNameWithParams.substring(0, paramsIndex);
> +}
> +return cleanName;
> +}
> +
> +private int getMethodLine(final FileObject fo, final String
> methodNameWithParams) {
> +String methodName = stripMethodParams(methodNameWithParams);
> final int[] line = new int[1];
> JavaSource javaSource = JavaSource.forFileObject(fo);
> if (javaSource != null) {
> {code}
> Certainly, it'd much better if the LocationOpener became able interpret and
> distinguish parameters and thus able navigate between overloaded methods as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
[
https://issues.apache.org/jira/browse/NETBEANS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ratcash Developer updated NETBEANS-4842:
Description:
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA()
testResults.SecondaryTest > testB()
testResults.SecondaryTest > [1] 1, 2
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest
@MethodSource("generate")
public void testC(String a, String b) {
// do something clever
}
{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a quick work-around may be the following change to clean
method names:
{code:java}
---
a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
+++
b/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
@@ -80,7 +80,18 @@ public final class LocationOpener {
}
}
- private int getMethodLine(final FileObject fo, final String methodName) {
+ private static String stripMethodParams(String methodNameWithParams) {
+final int paramsIndex = methodNameWithParams.indexOf("(");
+String cleanName = methodNameWithParams;
+if (paramsIndex > 0) {
+cleanName = methodNameWithParams.substring(0, paramsIndex);
+}
+return cleanName;
+}
+
+private int getMethodLine(final FileObject fo, final String
methodNameWithParams) {
+String methodName = stripMethodParams(methodNameWithParams);
final int[] line = new int[1];
JavaSource javaSource = JavaSource.forFileObject(fo);
if (javaSource != null) {
{code}
Certainly, it'd much better if the LocationOpener became able interpret and
distinguish parameters and thus able navigate between overloaded methods as
well.
was:
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA()
testResults.SecondaryTest > testB()
testResults.SecondaryTest > [1] 1, 2
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest
@MethodSource("generate")
public void testC(String a, String b) {
// do something clever
}
{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a quick work-around may be the following change to clean
method names:
{code:java}
---
a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
+++
b/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
@@ -80,7 +80,18 @@ public final class LocationOpener {
}
}
- private int getMethodLine(final FileObject fo, final String methodName) {
+ private static String stripMethodParams(String methodNameWithParams) {
+final int paramsIndex = methodNameWithParams.indexOf("(");
+String cleanName = methodNameWithParams;
+if (paramsIndex > 0) {
+cleanName = methodNameWithParams.substring(0, paramsIndex);
+}
+System.out.println("CleanedName = " + cleanName);
+return cleanName;
+}
+
+private int getMethodLine(final FileObject fo, final String
methodNameWithParams) {
+String methodName = stripMethodParams(methodNameWithParams);
final int[] line = new int[1];
JavaSource javaSource = JavaSource.forFileObject(fo);
if (javaSource != null) {
{code}
Certainly, it'd much better if the LocationOpener became able interpret and
distinguish parameters and thus able navigate between overloaded methods as
well.
> Go To Source broken with JUnit5 (and Gradle)
>
>
> Key: NETBEANS-4842
> URL: https://issues.apache.org/jira/browse/NETBEANS-4842
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Reporter: Ratcash Developer
>Priority: Major
>
> JUnit4 and TestNG logs tested method names like:
> {noformat}
> testResults.MainTest > testA
> {noformat}
> However, JUnit5 adds the method's parameters, like this:
> {noformat}
> testResults.SecondaryTest > testA()
> testResults.SecondaryTest > testB()
> testResults.SecondaryTest > [1] 1, 2
> {noformat}
> The last one is a result of using
> {noformat}
> @ParametrizedTest
> @MethodSource("generate")
> public void testC(String a, String b) {
>// do something clever
> }
> {noformat}
> Such method names are not understood by the "Go To Source" functionality.
> For gradle projects a quick work-around may be the following change to clean
> method names:
> {code:java}
> ---
>
[jira] [Assigned] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
[
https://issues.apache.org/jira/browse/NETBEANS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ratcash Developer reassigned NETBEANS-4842:
---
Assignee: Laszlo Kishalmi
> Go To Source broken with JUnit5 (and Gradle)
>
>
> Key: NETBEANS-4842
> URL: https://issues.apache.org/jira/browse/NETBEANS-4842
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Reporter: Ratcash Developer
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> JUnit4 and TestNG logs tested method names like:
> {noformat}
> testResults.MainTest > testA
> {noformat}
> However, JUnit5 adds the method's parameters, like this:
> {noformat}
> testResults.SecondaryTest > testA()
> testResults.SecondaryTest > testB()
> testResults.SecondaryTest > [1] 1, 2
> {noformat}
> The last one is a result of using
> {noformat}
> @ParametrizedTest
> @MethodSource("generate")
> public void testC(String a, String b) {
>// do something clever
> }
> {noformat}
> Such method names are not understood by the "Go To Source" functionality.
> For gradle projects a quick work-around may be the following change to clean
> method names:
> {code:java}
> ---
> a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> +++
> b/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> @@ -80,7 +80,18 @@ public final class LocationOpener {
> }
> }
>
> - private int getMethodLine(final FileObject fo, final String methodName) {
> + private static String stripMethodParams(String methodNameWithParams) {
> +final int paramsIndex = methodNameWithParams.indexOf("(");
> +String cleanName = methodNameWithParams;
> +if (paramsIndex > 0) {
> +cleanName = methodNameWithParams.substring(0, paramsIndex);
> +}
> +return cleanName;
> +}
> +
> +private int getMethodLine(final FileObject fo, final String
> methodNameWithParams) {
> +String methodName = stripMethodParams(methodNameWithParams);
> final int[] line = new int[1];
> JavaSource javaSource = JavaSource.forFileObject(fo);
> if (javaSource != null) {
> {code}
> Certainly, it'd much better if the LocationOpener became able interpret and
> distinguish parameters and thus able navigate between overloaded methods as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
[
https://issues.apache.org/jira/browse/NETBEANS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ratcash Developer updated NETBEANS-4842:
Description:
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA()
testResults.SecondaryTest > testB()
testResults.SecondaryTest > [1] 1, 2
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest
@MethodSource("generate")
public void testC(String a, String b) {
// do something clever
}
{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a quick work-around may be the following change to clean
method names:
{code:java}
---
a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
+++
b/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
@@ -80,7 +80,18 @@ public final class LocationOpener {
}
}
- private int getMethodLine(final FileObject fo, final String methodName) {
+ private static String stripMethodParams(String methodNameWithParams) {
+final int paramsIndex = methodNameWithParams.indexOf("(");
+String cleanName = methodNameWithParams;
+if (paramsIndex > 0) {
+cleanName = methodNameWithParams.substring(0, paramsIndex);
+}
+System.out.println("CleanedName = " + cleanName);
+return cleanName;
+}
+
+private int getMethodLine(final FileObject fo, final String
methodNameWithParams) {
+String methodName = stripMethodParams(methodNameWithParams);
final int[] line = new int[1];
JavaSource javaSource = JavaSource.forFileObject(fo);
if (javaSource != null) {
{code}
Certainly, it'd much better if the LocationOpener became able interpret and
distinguish parameters and thus able navigate between overloaded methods as
well.
was:
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA()
testResults.SecondaryTest > testB()
testResults.SecondaryTest > [1] 1, 2
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest
@MethodSource("generate")
public void testC(String a, String b) {
// do something clever
}
{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a very-dirty work-around may be the following change to
clean method names:
{code:java}
---
a/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
+++
b/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
@@ -260,8 +260,10 @@ public final class GradleTestProgressListener implements
ProgressListener, Gradl
}
-private String searchLocation(String className, String methodName,
String[] stackTrace) {
-StringBuilder ret = new StringBuilder(className.length() +
methodName.length() + 10);
+private String searchLocation(String className, String rawMethodName,
String[] stackTrace) {
+StringBuilder ret = new StringBuilder(className.length() +
rawMethodName.length() + 10);
+// cleanup necessary for JUnit5 method names
+String methodName = rawMethodName.replaceAll("\\(.*", "");
String fileName = null;
String line = null;
if (stackTrace != null) {
{code}
Certainly, it'd much better if the "Jump to source" locator would become able
to interpret method names with parameters and thus able navigate between
overloaded methods.
> Go To Source broken with JUnit5 (and Gradle)
>
>
> Key: NETBEANS-4842
> URL: https://issues.apache.org/jira/browse/NETBEANS-4842
> Project: NetBeans
> Issue Type: Bug
> Components: java - JUnit
>Reporter: Ratcash Developer
>Priority: Major
>
> JUnit4 and TestNG logs tested method names like:
> {noformat}
> testResults.MainTest > testA
> {noformat}
> However, JUnit5 adds the method's parameters, like this:
> {noformat}
> testResults.SecondaryTest > testA()
> testResults.SecondaryTest > testB()
> testResults.SecondaryTest > [1] 1, 2
> {noformat}
> The last one is a result of using
> {noformat}
> @ParametrizedTest
> @MethodSource("generate")
> public void testC(String a, String b) {
>// do something clever
> }
> {noformat}
> Such method names are not understood by the "Go To Source" functionality.
> For gradle projects a quick work-around may be the following change to clean
> method names:
> {code:java}
> ---
> a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> +++
>
[jira] [Updated] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
[
https://issues.apache.org/jira/browse/NETBEANS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ratcash Developer updated NETBEANS-4842:
Component/s: (was: java - JUnit)
projects - Gradle
> Go To Source broken with JUnit5 (and Gradle)
>
>
> Key: NETBEANS-4842
> URL: https://issues.apache.org/jira/browse/NETBEANS-4842
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Reporter: Ratcash Developer
>Priority: Major
>
> JUnit4 and TestNG logs tested method names like:
> {noformat}
> testResults.MainTest > testA
> {noformat}
> However, JUnit5 adds the method's parameters, like this:
> {noformat}
> testResults.SecondaryTest > testA()
> testResults.SecondaryTest > testB()
> testResults.SecondaryTest > [1] 1, 2
> {noformat}
> The last one is a result of using
> {noformat}
> @ParametrizedTest
> @MethodSource("generate")
> public void testC(String a, String b) {
>// do something clever
> }
> {noformat}
> Such method names are not understood by the "Go To Source" functionality.
> For gradle projects a quick work-around may be the following change to clean
> method names:
> {code:java}
> ---
> a/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> +++
> b/java/gradle.java/src/org/netbeans/modules/gradle/java/api/output/LocationOpener.java
> @@ -80,7 +80,18 @@ public final class LocationOpener {
> }
> }
>
> - private int getMethodLine(final FileObject fo, final String methodName) {
> + private static String stripMethodParams(String methodNameWithParams) {
> +final int paramsIndex = methodNameWithParams.indexOf("(");
> +String cleanName = methodNameWithParams;
> +if (paramsIndex > 0) {
> +cleanName = methodNameWithParams.substring(0, paramsIndex);
> +}
> +System.out.println("CleanedName = " + cleanName);
> +return cleanName;
> +}
> +
> +private int getMethodLine(final FileObject fo, final String
> methodNameWithParams) {
> +String methodName = stripMethodParams(methodNameWithParams);
> final int[] line = new int[1];
> JavaSource javaSource = JavaSource.forFileObject(fo);
> if (javaSource != null) {
> {code}
> Certainly, it'd much better if the LocationOpener became able interpret and
> distinguish parameters and thus able navigate between overloaded methods as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
[
https://issues.apache.org/jira/browse/NETBEANS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ratcash Developer updated NETBEANS-4842:
Description:
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA()
testResults.SecondaryTest > testB()
testResults.SecondaryTest > [1] 1, 2
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest
@MethodSource("generate")
public void testC(String a, String b) {
// do something clever
}
{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a very-dirty work-around may be the following change to
clean method names:
{code:java}
---
a/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
+++
b/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
@@ -260,8 +260,10 @@ public final class GradleTestProgressListener implements
ProgressListener, Gradl
}
-private String searchLocation(String className, String methodName,
String[] stackTrace) {
-StringBuilder ret = new StringBuilder(className.length() +
methodName.length() + 10);
+private String searchLocation(String className, String rawMethodName,
String[] stackTrace) {
+StringBuilder ret = new StringBuilder(className.length() +
rawMethodName.length() + 10);
+// cleanup necessary for JUnit5 method names
+String methodName = rawMethodName.replaceAll("\\(.*", "");
String fileName = null;
String line = null;
if (stackTrace != null) {
{code}
Certainly, it'd much better if the "Jump to source" locator would become able
to interpret method names with parameters and thus able navigate between
overloaded methods.
was:
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA() STANDARD_OUT
Doing something 2.
testResults.SecondaryTest > testB() STANDARD_OUT
Doing something 2 different.
testResults.SecondaryTest > [1] 1, 2 STANDARD_OUT
Doing something 2 different.
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a very-dirty work-around may be the following change to
clean method names:
{code:java}
---
a/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
+++
b/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
@@ -260,8 +260,10 @@ public final class GradleTestProgressListener implements
ProgressListener, Gradl
}
-private String searchLocation(String className, String methodName,
String[] stackTrace) {
-StringBuilder ret = new StringBuilder(className.length() +
methodName.length() + 10);
+private String searchLocation(String className, String rawMethodName,
String[] stackTrace) {
+StringBuilder ret = new StringBuilder(className.length() +
rawMethodName.length() + 10);
+// cleanup necessary for JUnit5 method names
+String methodName = rawMethodName.replaceAll("\\(.*", "");
String fileName = null;
String line = null;
if (stackTrace != null) {
{code}
Certainly, it'd much better if the "Jump to source" locator would become able
to interpret method names with parameters and thus able navigate between
overloaded methods.
> Go To Source broken with JUnit5 (and Gradle)
>
>
> Key: NETBEANS-4842
> URL: https://issues.apache.org/jira/browse/NETBEANS-4842
> Project: NetBeans
> Issue Type: Bug
> Components: java - JUnit
>Reporter: Ratcash Developer
>Priority: Major
>
> JUnit4 and TestNG logs tested method names like:
> {noformat}
> testResults.MainTest > testA
> {noformat}
> However, JUnit5 adds the method's parameters, like this:
> {noformat}
> testResults.SecondaryTest > testA()
> testResults.SecondaryTest > testB()
> testResults.SecondaryTest > [1] 1, 2
> {noformat}
> The last one is a result of using
> {noformat}
> @ParametrizedTest
> @MethodSource("generate")
> public void testC(String a, String b) {
>// do something clever
> }
> {noformat}
> Such method names are not understood by the "Go To Source" functionality.
> For gradle projects a very-dirty work-around may be the following change to
> clean method names:
> {code:java}
> ---
> a/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
> +++
>
[jira] [Created] (NETBEANS-4842) Go To Source broken with JUnit5 (and Gradle)
Ratcash Developer created NETBEANS-4842:
---
Summary: Go To Source broken with JUnit5 (and Gradle)
Key: NETBEANS-4842
URL: https://issues.apache.org/jira/browse/NETBEANS-4842
Project: NetBeans
Issue Type: Bug
Components: java - JUnit
Reporter: Ratcash Developer
JUnit4 and TestNG logs tested method names like:
{noformat}
testResults.MainTest > testA
{noformat}
However, JUnit5 adds the method's parameters, like this:
{noformat}
testResults.SecondaryTest > testA() STANDARD_OUT
Doing something 2.
testResults.SecondaryTest > testB() STANDARD_OUT
Doing something 2 different.
testResults.SecondaryTest > [1] 1, 2 STANDARD_OUT
Doing something 2 different.
{noformat}
The last one is a result of using
{noformat}
@ParametrizedTest{noformat}
Such method names are not understood by the "Go To Source" functionality.
For gradle projects a very-dirty work-around may be the following change to
clean method names:
{code:java}
---
a/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
+++
b/java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
@@ -260,8 +260,10 @@ public final class GradleTestProgressListener implements
ProgressListener, Gradl
}
-private String searchLocation(String className, String methodName,
String[] stackTrace) {
-StringBuilder ret = new StringBuilder(className.length() +
methodName.length() + 10);
+private String searchLocation(String className, String rawMethodName,
String[] stackTrace) {
+StringBuilder ret = new StringBuilder(className.length() +
rawMethodName.length() + 10);
+// cleanup necessary for JUnit5 method names
+String methodName = rawMethodName.replaceAll("\\(.*", "");
String fileName = null;
String line = null;
if (stackTrace != null) {
{code}
Certainly, it'd much better if the "Jump to source" locator would become able
to interpret method names with parameters and thus able navigate between
overloaded methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-771) Support for SubVersion CLI client version 1.10
[
https://issues.apache.org/jira/browse/NETBEANS-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201446#comment-17201446
]
Ray Slater commented on NETBEANS-771:
-
To anyone else with this problem who is unable or unwilling to upgrade to a
later version of netbeans, a workaround is to create a wrapper script to call
subversion and lie about it's version number. eg:
{noformat}
#!/bin/ksh
[[ "$1" == "--version" ]] && echo "svn, version 1.9.5 (r1770682)" && exit 0
/usr/bin/svn $*
{noformat}
You can then change the path to the CLI client to your script instead in the
subversion options.
> Support for SubVersion CLI client version 1.10
> --
>
> Key: NETBEANS-771
> URL: https://issues.apache.org/jira/browse/NETBEANS-771
> Project: NetBeans
> Issue Type: Bug
> Components: versioncontrol - Subversion
>Affects Versions: 8.2, 9.0
>Reporter: Petr Hadraba
>Priority: Major
> Fix For: 9.0
>
> Attachments: org-netbeans-modules-subversion.jar,
> org-netbeans-modules-subversion.jar
>
>
> SubVersion CLI client version 1.10 does not work in NetBeans 9.0.
> The following message appears in NetBeans log when invoking refresh in
> SubVersion panel:
> {{ INFO [org.netbeans.modules.subversion]: Commandline client version: 1.10.0
> (r1827917)}}
> {{ WARNING [org.netbeans.modules.subversion]: Unsupported svn version. You
> need >= 1.5}}
> {{ WARNING [org.netbeans.modules.subversion.client.SvnClientFactory]:
> executable binary path set to /opt/local/bin yet client not available.}}
> The dialog box appears and says:
>
> {{1. Download and Install Subversion 1.8 or later
> ([http://subversion.apache.org/packages.html]). }}
> \{{ 2. Add it to PATH. }}
> \{{ Test the installation by running 'svn --version' from a command line }}
> \{{ 3. Restart the IDE.}}
> My SubVersion is the latest version:
> {\{ localhost:~ petr$ which svn}}
> \{{ /opt/local/bin/svn}}
> \{{ localhost:~ petr$ svn --version}}
> \{{ svn, version 1.10.0 (r1827917)}}
> \{{ compiled Apr 18 2018, 01:35:41 on x86_64-apple-darwin17.4.0}}
> \{{ }}
> \{{ Copyright (C) 2018 The Apache Software Foundation.}}
> \{{ This software consists of contributions made by many people;}}
> \{{ see the NOTICE file for more information.}}
> {{ Subversion is open source software, see [http://subversion.apache.org/]}}
> \{{ }}
> \{{ The following repository access (RA) modules are available:}}
> \{{ }}
> * {{ra_svn : Module for accessing a repository using the svn network
> protocol.}}{\{ - with Cyrus SASL authentication}}\{{ - handles 'svn'
> scheme}}
> * {{ra_local : Module for accessing a repository on local disk.}}{\{ -
> handles 'file' scheme}}
> * {{ra_serf : Module for accessing a repository via WebDAV protocol using
> serf.}}{\{ - using serf 1.3.9 (compiled with 1.3.8)}}\{{ - handles 'http'
> scheme}}\{{ - handles 'https' scheme}}\{{ }}\{{ The following
> authentication credential caches are available:}}\{{ }}
> * {{Plaintext cache in /Users/petr/.subversion}}
> * {{GPG-Agent}}
> * {{Mac OS X Keychain}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Add asf.yaml file to ease configuration
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new de2660c Add asf.yaml file to ease configuration new 34f9b8c Merge pull request #2394 from ebarboni/asfyaml de2660c is described below commit de2660c1850491afb0609c5b987254acfdabe44c Author: Eric Barboni AuthorDate: Wed Sep 23 13:31:07 2020 +0200 Add asf.yaml file to ease configuration --- .asf.yaml | 34 ++ 1 file changed, 34 insertions(+) diff --git a/.asf.yaml b/.asf.yaml new file mode 100644 index 000..8573b40 --- /dev/null +++ b/.asf.yaml @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + description: "Apache NetBeans" + homepage: https://netbeans.apache.org/ + labels: +- netbeans + features: +wiki: false +issues: false +projects: false + enabled_merge_buttons: +squash: true +merge: true +rebase: true +notifications: +commits: commits@netbeans.apache.org +issues: notificati...@netbeans.apache.org +pullrequests: notificati...@netbeans.apache.org +jira_options: link label worklog - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (6e6c9cd -> 44eff60)
This is an automated email from the ASF dual-hosted git repository. jtulach pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 6e6c9cd Merge pull request #2396 from sdedic/bugfix/commit-validation/enable-validation2 add c5216b7 Removing useless import add aedfcce Branding API to disable loading of previously opened projects on start add 78fbf67 Search for FileObject if no DataObject found add b43cff3 Recognize, but ignore, new catalog element add 4f69792 Read fully and stop on broken SIGPIPE add 4b50155 Print warnings just once per VM run: Not listening on module system add 4198e62 Run without core.windows module being present add 034a600 Search for FileObject if no DataObject found add cbecea3 Avoiding UI operations in headless mode add 2847f6e Removing unrelated change in friend module list new f9aa503 LOAD_PROJECTS_ON_START shall not be localized new 44eff60 Merging #2386 to master The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../modules/gradle/api/execute/RunUtils.java | 3 ++ ide/code.analysis/manifest.mf | 2 +- .../modules/analysis/api/CodeAnalysis.java | 1 - ide/parsing.indexing/manifest.mf | 1 + ide/parsing.indexing/nbproject/project.properties | 2 +- ide/parsing.nb/manifest.mf | 1 + ide/parsing.nb/nbproject/project.properties| 2 +- ide/projectapi.nb/manifest.mf | 4 +-- ide/projectapi.nb/nbproject/project.xml| 2 +- ide/projectapi/manifest.mf | 4 +-- ide/projectui/apichanges.xml | 14 ide/projectui/arch.xml | 14 ++-- ide/projectui/nbproject/project.properties | 2 +- .../modules/project/ui/OpenProjectList.java| 17 ++--- .../debugger/ui/DebuggerManagerListener.java | 9 +++-- ide/web.browser.api/manifest.mf| 2 +- .../spi/actions/AbstractMavenActionsProvider.java | 4 +++ .../netbeans/nbbuild/AutoUpdateCatalogParser.java | 7 +++- .../o.n.bootstrap/src/org/netbeans/CLIHandler.java | 6 +++- .../org/openide/windows/DummyWindowManager.java| 5 +++ platform/settings/nbproject/project.properties | 2 +- .../modules/settings/RecognizeInstanceObjects.java | 42 +- 22 files changed, 112 insertions(+), 34 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 01/02: LOAD_PROJECTS_ON_START shall not be localized
This is an automated email from the ASF dual-hosted git repository.
jtulach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit f9aa5031d801c2f7995b4aae5b061104aa75a88e
Author: Jaroslav Tulach
AuthorDate: Thu Sep 24 09:21:51 2020 +0200
LOAD_PROJECTS_ON_START shall not be localized
---
ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
b/ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
index 60adfc9..913a732 100644
--- a/ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
+++ b/ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
@@ -443,6 +443,7 @@ public final class OpenProjectList {
}
@NbBundle.Messages({
+"#NOI18N",
"LOAD_PROJECTS_ON_START=true"
})
private void loadOnBackground() {
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 02/02: Merging #2386 to master
This is an automated email from the ASF dual-hosted git repository. jtulach pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git commit 44eff608592ae78fb34b4b534720d20985bc3ed5 Merge: 6e6c9cd f9aa503 Author: Jaroslav Tulach AuthorDate: Thu Sep 24 09:25:11 2020 +0200 Merging #2386 to master .../modules/gradle/api/execute/RunUtils.java | 3 ++ ide/code.analysis/manifest.mf | 2 +- .../modules/analysis/api/CodeAnalysis.java | 1 - ide/parsing.indexing/manifest.mf | 1 + ide/parsing.indexing/nbproject/project.properties | 2 +- ide/parsing.nb/manifest.mf | 1 + ide/parsing.nb/nbproject/project.properties| 2 +- ide/projectapi.nb/manifest.mf | 4 +-- ide/projectapi.nb/nbproject/project.xml| 2 +- ide/projectapi/manifest.mf | 4 +-- ide/projectui/apichanges.xml | 14 ide/projectui/arch.xml | 14 ++-- ide/projectui/nbproject/project.properties | 2 +- .../modules/project/ui/OpenProjectList.java| 17 ++--- .../debugger/ui/DebuggerManagerListener.java | 9 +++-- ide/web.browser.api/manifest.mf| 2 +- .../spi/actions/AbstractMavenActionsProvider.java | 4 +++ .../netbeans/nbbuild/AutoUpdateCatalogParser.java | 7 +++- .../o.n.bootstrap/src/org/netbeans/CLIHandler.java | 6 +++- .../org/openide/windows/DummyWindowManager.java| 5 +++ platform/settings/nbproject/project.properties | 2 +- .../modules/settings/RecognizeInstanceObjects.java | 42 +- 22 files changed, 112 insertions(+), 34 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (432dddb -> 6e6c9cd)
This is an automated email from the ASF dual-hosted git repository. jtulach pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 432dddb Merge pull request #2398 from pepness/fix-npe new 7c98068 Disable Editors/ MIME checking temporarily(!). Enable commit-validation. new a9a5a62 Add commit-validation to workflow. new c27bf0f Remove excess logging. new 6e6c9cd Merge pull request #2396 from sdedic/bugfix/commit-validation/enable-validation2 The 4391 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/main.yml | 26 +++ .travis.yml| 10 ++ .../validation/ValidateLayerConsistencyTest.java | 38 -- 3 files changed, 57 insertions(+), 17 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Fix NullPointerException when using a Collection
This is an automated email from the ASF dual-hosted git repository.
jtulach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 5835a8e Fix NullPointerException when using a Collection
new 432dddb Merge pull request #2398 from pepness/fix-npe
5835a8e is described below
commit 5835a8e29f3420508de136ed27e7ad848dc88d11
Author: Jose Contreras
AuthorDate: Wed Sep 23 18:14:15 2020 -0500
Fix NullPointerException when using a Collection
---
platform/o.n.bootstrap/src/org/netbeans/Util.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/platform/o.n.bootstrap/src/org/netbeans/Util.java
b/platform/o.n.bootstrap/src/org/netbeans/Util.java
index 575149f..161556e 100644
--- a/platform/o.n.bootstrap/src/org/netbeans/Util.java
+++ b/platform/o.n.bootstrap/src/org/netbeans/Util.java
@@ -287,11 +287,11 @@ public final class Util {
for (Dependency dep : f.getDependenciesArray()) {
if (dep.getType() == Dependency.TYPE_REQUIRES) {
Collection providers =
providersOf.get(dep.getName());
-if (providers.contains(m1)) {
-providers = new ArrayList<>(providers);
-providers.remove(m1);
-}
if (providers != null) {
+if (providers.contains(m1)) {
+providers = new ArrayList<>(providers);
+providers.remove(m1);
+}
l = fillMapSlot(m, m1);
l.addAll(providers);
}
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-4841) Opening Projects freezes when current document is HTML
Eugene Pliskin created NETBEANS-4841: Summary: Opening Projects freezes when current document is HTML Key: NETBEANS-4841 URL: https://issues.apache.org/jira/browse/NETBEANS-4841 Project: NetBeans Issue Type: Bug Components: web - HTML Editor Affects Versions: 12.0 Environment: Windows 10 Reporter: Eugene Pliskin At NetBeans start the phase "Opening Projects" freezes showing progress at 14% when current document is HTML. To reproduce open some documents in Web project, activate window with HTML document, then close Netbeans and restart. When "Open Projects" phase reaches 14% it freezes. In this case the following closure of all documents does not help. Need to restart NetBeans when no HTML document is active. Problem reproduced fairly stable. No problem opening projects if the current document is Javascript or if no documents were open when closing NetBeans. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
