[jira] [Created] (NETBEANS-5659) Incorrect highlighting of missing class in JUnit test

2021-05-04 Thread Peter Michael Kirkham (Jira)
Peter Michael Kirkham created NETBEANS-5659:
---

 Summary: Incorrect highlighting of missing class in JUnit test
 Key: NETBEANS-5659
 URL: https://issues.apache.org/jira/browse/NETBEANS-5659
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Hints  Annotations
Affects Versions: 12.3
 Environment: OS: Windows 10 / 64 bit

JDK version: AdoptOpenJDK 11.0.10

NB version: 12.3
Reporter: Peter Michael Kirkham
 Attachments: 2021-05-05 Netbeans 12.3 Incorrect missing class 
highlight - IDE Log.txt, 2021-05-05 Netbeans 12.3 Incorrect missing class 
highlight - UI Log.txt

When editing Java test file syntax highlighting appears to show an error for 
the class being tested. e.g. for class MyClass, the test MyClassTest will 
highlight all instances of MyClass as not found. Code completion cannot find 
the class but the test will compile and run. Appears to be a syntax 
highlighting and code completion issue only.

Easy workaround is to refactor the apparently missing class without renaming 
the test, then refactor back to the original name and recompile. This appears 
to trigger something that means all the highlighting vanishes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-4252] Added PathFinder to Gradle Build Scripts Node

2021-05-04 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new f6a745c  [NETBEANS-4252] Added PathFinder to Gradle Build Scripts Node
f6a745c is described below

commit f6a745c5b9b0460ac4482c207e5a617cef1c2e64
Author: Laszlo Kishalmi 
AuthorDate: Sun May 2 13:18:35 2021 -0700

[NETBEANS-4252] Added PathFinder to Gradle Build Scripts Node
---
 .../modules/gradle/nodes/BuildScriptsNode.java | 32 +-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git 
a/extide/gradle/src/org/netbeans/modules/gradle/nodes/BuildScriptsNode.java 
b/extide/gradle/src/org/netbeans/modules/gradle/nodes/BuildScriptsNode.java
index b6f4fa1..3513723 100644
--- a/extide/gradle/src/org/netbeans/modules/gradle/nodes/BuildScriptsNode.java
+++ b/extide/gradle/src/org/netbeans/modules/gradle/nodes/BuildScriptsNode.java
@@ -34,6 +34,7 @@ import java.util.logging.Logger;
 import java.util.prefs.PreferenceChangeEvent;
 import java.util.prefs.PreferenceChangeListener;
 import org.netbeans.api.annotations.common.StaticResource;
+import org.netbeans.api.project.FileOwnerQuery;
 import org.netbeans.api.project.Project;
 import org.netbeans.api.project.ProjectManager;
 import org.netbeans.modules.gradle.spi.GradleFiles.Kind;
@@ -54,6 +55,7 @@ import org.openide.util.Pair;
 import org.openide.util.lookup.Lookups;
 
 import static org.netbeans.modules.gradle.spi.GradleFiles.Kind.*;
+import org.netbeans.spi.project.ui.PathFinder;
 import org.openide.util.Exceptions;
 /**
  *
@@ -70,7 +72,7 @@ public final class BuildScriptsNode extends 
AnnotatedAbstractNode {
 @NbBundle.Messages("LBL_Build_Scripts=Build Scripts")
 public BuildScriptsNode(NbGradleProjectImpl prj) {
 super(Children.create(new ProjectFilesChildren(prj), true),
-Lookups.fixed(prj.getProjectDirectory()));
+Lookups.fixed(prj.getProjectDirectory(), new Finder(prj)));
 setName("buildscripts"); //NOI18N
 setDisplayName(Bundle.LBL_Build_Scripts());
 }
@@ -96,6 +98,34 @@ public final class BuildScriptsNode extends 
AnnotatedAbstractNode {
 return img;
 }
 
+private static class Finder implements PathFinder {
+
+final Project project;
+
+public Finder(Project project) {
+this.project = project;
+}
+
+@Override
+public Node findPath(Node node, Object target) {
+if (target instanceof FileObject) {
+FileObject fo = (FileObject) target;
+if (project != FileOwnerQuery.getOwner(fo)) {
+return null; // Don't waste time if project does not own the fo
+}
+Node[] nodes = node.getChildren().getNodes(true);
+for (Node n : nodes) {
+FileObject nf = n.getLookup().lookup(FileObject.class);
+if ((nf != null) && (nf.equals(fo))) {
+   return n;
+}
+}
+}
+
+return null;
+}
+}
+
 private static class ProjectFilesChildren extends 
ChildFactory.Detachable> implements 
PropertyChangeListener {
 
 private final NbGradleProjectImpl project;

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Reopened] (NETBEANS-3588) Code Templates not working in Java Editor in for-cycle definition

2021-05-04 Thread Jira


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zdeněk Machač reopened NETBEANS-3588:
-

Hallo,

issue is resolved partialy (on some positions). Testing in NB 12.3 with 
template "St" + TAB key which's translated to "String" string (char '|' is 
cursor position and TAB key pressed):
{code:java}
for (final St|  : list) {code}
works correct but
{code:java}
for (St| : list){code}
doesn't work :( . Tested with "fi" + TAB -> "final" template and other one too.

Thank's  ZM

> Code Templates not working in Java Editor in for-cycle definition
> -
>
> Key: NETBEANS-3588
> URL: https://issues.apache.org/jira/browse/NETBEANS-3588
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Completion  Templates
>Affects Versions: 8.2, 11.2
> Environment: Windows Server 2012 R2, JDK 13.0.1 64-bit
>Reporter: Zdeněk Machač
>Assignee: Arthur Sadykov
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 12.2
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> In Java editor if you type 
> {code:java}
> for (    )
> {code}
> then inside braces not working Code Templates. E.g. typing 'St' + Tab not 
> create 'String' string or 'fi' + Tab not create 'final' string.
> In other places of code Code Templates works well. It's only small bug but 
> many times I must repair my typed code.
> Thanks ZM
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-5602) Project opening failed

2021-05-04 Thread Martin Guidel (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Guidel updated NETBEANS-5602:

Priority: Critical  (was: Major)

> Project opening failed
> --
>
> Key: NETBEANS-5602
> URL: https://issues.apache.org/jira/browse/NETBEANS-5602
> Project: NetBeans
>  Issue Type: Bug
>  Components: javaee - Web Project, serverplugins - Tomcat
>Affects Versions: 12.0
>Reporter: SHARON XAVIER
>Priority: Critical
> Fix For: 12.4
>
>
> 12.java.lang.IllegalAccessError: superclass access check failed: class 
> org.netbeans.lib.nbjavac.services.CancelAbort (in unnamed module @0x7b049b4) 
> cannot access class com.sun.tools.javac.util.Abort (in module jdk.compiler) 
> because module jdk.compiler does not export com.sun.tools.javac.util to 
> unnamed module @0x7b049b4 at 
> java.base/java.lang.ClassLoader.defineClass1(Native Method) at 
> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1010) at 
> org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287) at 
> org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246) at 
> org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174) at 
> org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125) at 
> java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:519) at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer$DefaultCompileWorkerProvider.getWorkers(JavaCustomIndexer.java:1542)
>  at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:359)
>  at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
>  at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
>  [catch] at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
>  at 
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.index(RepositoryUpdater.java:2634)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork$4.call(RepositoryUpdater.java:5714)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork$4.call(RepositoryUpdater.java:5622)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$4.run(RepositoryUpdater.java:2127)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2123)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2104)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.access$1500(RepositoryUpdater.java:136)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork.scanSource(RepositoryUpdater.java:5749)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork.scanSources(RepositoryUpdater.java:5419)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$RootsWork.getDone(RepositoryUpdater.java:5038)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$InitialRootsWork.getDone(RepositoryUpdater.java:5821)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doTheWork(RepositoryUpdater.java:3420)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task._run(RepositoryUpdater.java:6183)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task.access$4300(RepositoryUpdater.java:5834)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task$2$1.run(RepositoryUpdater.java:6099)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at 
> org.netbeans.modules.parsing.impl.RunWhenScanFinishedSupport.performScan(RunWhenScanFinishedSupport.java:83)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task$2.call(RepositoryUpdater.java:6095)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task$2.call(RepositoryUpdater.java:6091)
>  at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
>  at 
> 

[jira] [Commented] (NETBEANS-5602) Project opening failed

2021-05-04 Thread Martin Guidel (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339283#comment-17339283
 ] 

Martin Guidel commented on NETBEANS-5602:
-

is there a solution for this issue?

> Project opening failed
> --
>
> Key: NETBEANS-5602
> URL: https://issues.apache.org/jira/browse/NETBEANS-5602
> Project: NetBeans
>  Issue Type: Bug
>  Components: javaee - Web Project, serverplugins - Tomcat
>Affects Versions: 12.0
>Reporter: SHARON XAVIER
>Priority: Major
> Fix For: 12.4
>
>
> 12.java.lang.IllegalAccessError: superclass access check failed: class 
> org.netbeans.lib.nbjavac.services.CancelAbort (in unnamed module @0x7b049b4) 
> cannot access class com.sun.tools.javac.util.Abort (in module jdk.compiler) 
> because module jdk.compiler does not export com.sun.tools.javac.util to 
> unnamed module @0x7b049b4 at 
> java.base/java.lang.ClassLoader.defineClass1(Native Method) at 
> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1010) at 
> org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:287) at 
> org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:246) at 
> org.netbeans.ProxyClassLoader.doFindClass(ProxyClassLoader.java:174) at 
> org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:125) at 
> java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:519) at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer$DefaultCompileWorkerProvider.getWorkers(JavaCustomIndexer.java:1542)
>  at 
> org.netbeans.modules.java.source.indexing.JavaCustomIndexer.index(JavaCustomIndexer.java:359)
>  at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor$2.run(Indexable.java:138)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runIndexer(RepositoryUpdater.java:275)
>  at 
> org.netbeans.modules.parsing.spi.indexing.Indexable$MyAccessor.index(Indexable.java:136)
>  [catch] at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2750)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
>  at 
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.index(RepositoryUpdater.java:2634)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork$4.call(RepositoryUpdater.java:5714)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork$4.call(RepositoryUpdater.java:5622)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$4.run(RepositoryUpdater.java:2127)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2123)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2104)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.access$1500(RepositoryUpdater.java:136)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork.scanSource(RepositoryUpdater.java:5749)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$AbstractRootsWork.scanSources(RepositoryUpdater.java:5419)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$RootsWork.getDone(RepositoryUpdater.java:5038)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$InitialRootsWork.getDone(RepositoryUpdater.java:5821)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doTheWork(RepositoryUpdater.java:3420)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task._run(RepositoryUpdater.java:6183)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task.access$4300(RepositoryUpdater.java:5834)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task$2$1.run(RepositoryUpdater.java:6099)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at 
> org.netbeans.modules.parsing.impl.RunWhenScanFinishedSupport.performScan(RunWhenScanFinishedSupport.java:83)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task$2.call(RepositoryUpdater.java:6095)
>  at 
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Task$2.call(RepositoryUpdater.java:6091)
>  at 
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
>  at 
> 

[jira] [Updated] (NETBEANS-5658) Add remaining SVG icons in editor toolbar

2021-05-04 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-5658:
--
Labels: HiDPI pull-request-available  (was: pull-request-available)

> Add remaining SVG icons in editor toolbar
> -
>
> Key: NETBEANS-5658
> URL: https://issues.apache.org/jira/browse/NETBEANS-5658
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Other
>Affects Versions: 12.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI, pull-request-available
> Attachments: MoreEditorToolbarIconsEirik.ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> See the associated Pull Request, which adds 14 more SVG icons, adjusts two 
> existing ones, and reuses some existing ones for newly identified duplicates. 
> See NETBEANS-2617 for a more detailed description of this effort.
> The Adobe Illustrator file that was used to produce the latest icons is 
> attached here. I haven't cleaned up the Illustrator file, so it may contain 
> some duplicates from previous Illustrator file in NETBEANS-2617.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-5658) Add remaining SVG icons in editor toolbar

2021-05-04 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-5658:
--
Description: 
See the associated Pull Request, which adds 14 more SVG icons, adjusts two 
existing ones, and reuses some existing ones for newly identified duplicates. 
See NETBEANS-2617 for a more detailed description of this effort.

The Adobe Illustrator file that was used to produce the latest icons is 
attached here. I haven't cleaned up the Illustrator file, so it may contain 
some duplicates from previous Illustrator file in NETBEANS-2617.

  was:
See the associated Pull Request, which adds 14 more SVG icons, adjusts two 
existing ones, and reuses some existing ones for newly identified duplicates.

The Adobe Illustrator file that was used to produce the latest icons is 
attached here.


> Add remaining SVG icons in editor toolbar
> -
>
> Key: NETBEANS-5658
> URL: https://issues.apache.org/jira/browse/NETBEANS-5658
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Other
>Affects Versions: 12.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: pull-request-available
> Attachments: MoreEditorToolbarIconsEirik.ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> See the associated Pull Request, which adds 14 more SVG icons, adjusts two 
> existing ones, and reuses some existing ones for newly identified duplicates. 
> See NETBEANS-2617 for a more detailed description of this effort.
> The Adobe Illustrator file that was used to produce the latest icons is 
> attached here. I haven't cleaned up the Illustrator file, so it may contain 
> some duplicates from previous Illustrator file in NETBEANS-2617.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-5658) Add remaining SVG icons in editor toolbar

2021-05-04 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-5658:
--
Description: 
See the associated Pull Request, which adds 14 more SVG icons, adjusts two 
existing ones, and reuses some existing ones for newly identified duplicates.

The Adobe Illustrator file that was used to produce the latest icons is 
attached here.

  was:Creating this issue for an upcoming Pull Request which will convert the 
rest of the icons in the editor toolbar to SVG.


> Add remaining SVG icons in editor toolbar
> -
>
> Key: NETBEANS-5658
> URL: https://issues.apache.org/jira/browse/NETBEANS-5658
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Other
>Affects Versions: 12.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: pull-request-available
> Attachments: MoreEditorToolbarIconsEirik.ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> See the associated Pull Request, which adds 14 more SVG icons, adjusts two 
> existing ones, and reuses some existing ones for newly identified duplicates.
> The Adobe Illustrator file that was used to produce the latest icons is 
> attached here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-5658) Add remaining SVG icons in editor toolbar

2021-05-04 Thread Eirik Bakke (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eirik Bakke updated NETBEANS-5658:
--
Attachment: MoreEditorToolbarIconsEirik.ai

> Add remaining SVG icons in editor toolbar
> -
>
> Key: NETBEANS-5658
> URL: https://issues.apache.org/jira/browse/NETBEANS-5658
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Other
>Affects Versions: 12.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: pull-request-available
> Attachments: MoreEditorToolbarIconsEirik.ai
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Creating this issue for an upcoming Pull Request which will convert the rest 
> of the icons in the editor toolbar to SVG.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-5658) Add remaining SVG icons in editor toolbar

2021-05-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-5658:
-
Labels: pull-request-available  (was: )

> Add remaining SVG icons in editor toolbar
> -
>
> Key: NETBEANS-5658
> URL: https://issues.apache.org/jira/browse/NETBEANS-5658
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Other
>Affects Versions: 12.2
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Creating this issue for an upcoming Pull Request which will convert the rest 
> of the icons in the editor toolbar to SVG.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2617) Redraw common icons in SVG

2021-05-04 Thread Eirik Bakke (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339167#comment-17339167
 ] 

Eirik Bakke commented on NETBEANS-2617:
---

I've drawn the icons in the previous list above and will be incorporating them 
shortly (NETBEANS-5658).

> Redraw common icons in SVG
> --
>
> Key: NETBEANS-2617
> URL: https://issues.apache.org/jira/browse/NETBEANS-2617
> Project: NetBeans
>  Issue Type: Improvement
>  Components: platform - Other
>Affects Versions: 11.0
> Environment: Windows, Linux, and MacOS
>Reporter: Eirik Bakke
>Priority: Major
>  Labels: HiDPI
> Attachments: ScreenshotExample.png, ide.editor.bookmarks.ai, 
> ide.editor.macros.ai, ide.seperator.breadcrumbs.ai, 
> netbeans_icons_illustrator_template.ai, style example (dark filter).png, 
> style example.png
>
>
> Once NETBEANS-2604 is done, we should start replacing commonly seen NetBeans 
> icons with SVG versions, for improved appearance on Retina/HiDPI displays.
> h2. UPDATE: 
> [Here|https://docs.google.com/spreadsheets/d/1U_pj-I3hk9Wj_7lvHcUDsZfFfBSyCkSGqBuv0qt_qXw/edit?usp=sharing]
>  is a Google Sheet where we can track progress of contributions and 
> prioritization of icons.
> With some practice, it takes on average 30 minutes to create an SVG version 
> of a typical icon in Adobe Illustrator. See the attached illustration and 
> Illustrator template. The Illustrator template includes a few icons which 
> have already been converted.
> In NETBEANS-2605, a prioritized list of icons to convert was produced (now 
> migrated to the Google Sheet above). By redrawing the most commonly seen 
> icons first, we can get the greatest "bang for the buck" in terms of 
> improving NetBeans' appearance on HiDPI displays. Note that in cases where an 
> icon file has been copied around to various places in the NetBeans codebase, 
> the spreadsheet includes only one location, picked arbitrarily. Once we have 
> a batch of icons ready to integrate into the NetBeans repository, Eirik will 
> redo the duplicate detection and ensure the SVGs end up in all relevant 
> locations, and start creating pull requests.
> See also the overview page for HiDPI improvements on 
> https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements
>  .
> If you wish to contribute to this effort, comment here; Eirik will coordinate 
> to make sure multiple people are not working on the same icons.
> h2. Proposed Style Guide for Vectorized Icons
> * Vector icons should be drawn in Adobe Illustrator, or alternatively 
> Inkscape or another free tool. In Illustrator, each icon should be one named 
> artboard, sized to the correct size in pixels. See the attached Illustrator 
> template. (Adobe Illustrator comes with a free 7-day trial, after which it's 
> $35/month. If cost is a problem but you want to contribute your time to draw 
> icons, ask Eirik...)
> * If you prefer to use Inkscape instead, and want to contribute icons, that's 
> fine; just make sure to follow the same consistent style as the other icons. 
> If using Inkscape, perhaps pick another group of icons than the ones that are 
> currently being drawn in Illustrator. It's best to draw all similar-looking 
> icons in the same tool.
> * For each icon to be vectorized, place the old bitmap version of the icon in 
> a separate layer ("Old Bitmap Icons" in the Illustrator template). You can 
> then draw the vectorized version on top.
> * Since most of the existing NetBeans icons follow a quite consistent visual 
> style, and to simplify the job of creating new icons, it is best to keep the 
> shape of the new vectorized icons the same as in the old bitmap icons. For 
> instance, a rectangle of size 5x4px in the bitmap icon should probably become 
> a rectangle of 5x4px in the vector version.
> * Keep the same general colors in vectorized icons as in the corresponding 
> old bitmap icons.
> * Some of the old bitmap icons use grays with a slightly blue tint (e.g. the 
> [file 
> icons|https://raw.githubusercontent.com/apache/netbeans/master/java/refactoring.java/src/org/netbeans/modules/refactoring/java/resources/newFile.png]).
>  This style is out of fashion (resembling 1990s Solaris GUIs etc.); use 
> neutral greys instead.
> * If the old bitmap icon is complex, it is fine to simplify it a bit when 
> drawing vectorized versions.
> * Omit gradients, bevels, and unnecessary drop shadows. They take more time 
> to draw, and with "flat design", they are now out of fashion in any case.
> * Use a stroke width of 1px around the main shapes in the icon, like in the 
> existing bitmap icons. The new icons should look consistent with the existing 
> bitmap icons, especially since we may see bitmap icons and vector icons 
> side-by-side for a long time. Within shapes, 

[jira] [Created] (NETBEANS-5658) Add remaining SVG icons in editor toolbar

2021-05-04 Thread Eirik Bakke (Jira)
Eirik Bakke created NETBEANS-5658:
-

 Summary: Add remaining SVG icons in editor toolbar
 Key: NETBEANS-5658
 URL: https://issues.apache.org/jira/browse/NETBEANS-5658
 Project: NetBeans
  Issue Type: Improvement
  Components: editor - Other
Affects Versions: 12.2
Reporter: Eirik Bakke


Creating this issue for an upcoming Pull Request which will convert the rest of 
the icons in the editor toolbar to SVG.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-904) Support fallback font options

2021-05-04 Thread NithyaSharabheshwara Ananda (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338839#comment-17338839
 ] 

NithyaSharabheshwara Ananda commented on NETBEANS-904:
--

It would definitely be good to have. I am using Intellij for Sanskrit related 
work as Netbeans is not able to support Unicode properly because the hardly any 
font is available there which is both good looking and having all required 
unicode characters. 

> Support fallback font options
> -
>
> Key: NETBEANS-904
> URL: https://issues.apache.org/jira/browse/NETBEANS-904
> Project: NetBeans
>  Issue Type: Improvement
>  Components: editor - Options
>Affects Versions: 8.2, 9.0, 10.0
>Reporter: NDelt
>Priority: Major
> Attachments: 2018_10_01_netbeans_snapshot_monospaced.png, 
> 2018_10_01_netbeans_snapshot_noto_sans_mono_cjk_kr_regular.png
>
>
> Currently I can't type text that the font cannot represents.(It is displayed 
> as broken text)
> I would like to use back-up font options like _Fallback Fonts_ in IntelliJ 
> IDEA.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-5657) Order in Gradle Subprojects is NOT alphabetically

2021-05-04 Thread Martin (Jira)
Martin created NETBEANS-5657:


 Summary: Order in Gradle Subprojects is NOT alphabetically
 Key: NETBEANS-5657
 URL: https://issues.apache.org/jira/browse/NETBEANS-5657
 Project: NetBeans
  Issue Type: Bug
Affects Versions: 12.2, 12.3
Reporter: Martin
 Attachments: nb-gradle-order.png

If you open a gradle multi-module project there is "build scripts" and 
"subprojects".

Under subprojects, the projects are in some random order. I only have around 15 
projects but already I find this very annoying. Please fix!

Note: before 12.2 this was sorted

!nb-gradle-order.png!

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-5638] Insane should ignore stub classes in traversal.

2021-05-04 Thread sdedic
This is an automated email from the ASF dual-hosted git repository.

sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new e64c8de  [NETBEANS-5638] Insane should ignore stub classes in 
traversal.
 new 4fd403d  Merge pull request #2923 from sdedic/sdedic/insane-securityex
e64c8de is described below

commit e64c8de432ab7c367cfca6e548a508cbe0f83cd5
Author: Svata Dedic 
AuthorDate: Thu Apr 29 13:38:25 2021 +0200

[NETBEANS-5638] Insane should ignore stub classes in traversal.
---
 .../src/org/netbeans/insane/impl/InsaneEngine.java   | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java 
b/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java
index e1a1b5b..8b9fd36 100644
--- a/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java
+++ b/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java
@@ -83,7 +83,17 @@ public final class InsaneEngine {
 
 // dispatch the recognition
 if (o instanceof Class) {
-recognizeClass((Class)o);
+try {
+recognizeClass((Class)o);
+} catch (SecurityException ex) {
+if (ex.getMessage() == null || 
!ex.getMessage().contains("java.lang")) {
+throw ex;
+}
+// just report: possibly an upwards-compatible method 
+// not linkable on current runtime.
+System.err.println("Failed analysing class " + 
((Class)o).getName() +
+" because of " + ex.getMessage());
+}
 } else {
 recognizeObject(o);
 }

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: Improved messages when project is opened bcs of file being worked on.

2021-05-04 Thread sdedic
This is an automated email from the ASF dual-hosted git repository.

sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 8cffc9c  Improved messages when project is opened bcs of file being 
worked on.
 new 0e13308  Merge pull request #2930 from sdedic/lsp/project-message
8cffc9c is described below

commit 8cffc9cbdb41ec4dde1b68c67cc04a28cebd8c93
Author: Svata Dedic 
AuthorDate: Fri Apr 30 09:27:48 2021 +0200

Improved messages when project is opened bcs of file being worked on.
---
 .../src/org/netbeans/modules/java/lsp/server/protocol/Server.java | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/Server.java
 
b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/Server.java
index 607d328..371a54b 100644
--- 
a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/Server.java
+++ 
b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/Server.java
@@ -342,7 +342,7 @@ public final class Server {
 @NbBundle.Messages({
 "PROMPT_AskOpenProjectForFile=File {0} belongs to project {1}. To 
enable all features, the project should be opened"
 + " and initialized by the Language Server. Do you want to 
proceed ?",
-"PROMPT_AskOpenProjectForFileNoName=File {0} belongs to a project. 
To enable all features, the project should be opened"
+"PROMPT_AskOpenProject=To enable all features of project {0}, it 
should be opened"
 + " and initialized by the Language Server. Do you want to 
proceed ?",
 "PROMPT_AskOpenProjectForFile_Yes=Open and initialize",
 "PROMPT_AskOpenProjectForFile_No=No",
@@ -399,10 +399,10 @@ public final class Server {
 yes,
 new 
MessageActionItem(Bundle.PROMPT_AskOpenProjectForFile_No())
 ));
-if (dispName.equals(prj.getProjectDirectory().getPath())) {
-
smrp.setMessage(Bundle.PROMPT_AskOpenProjectForFileNoName(file.getPath()));
+if (prj.getProjectDirectory() == file) {
+
smrp.setMessage(Bundle.PROMPT_AskOpenProject(dispName));
 } else {
-
smrp.setMessage(Bundle.PROMPT_AskOpenProjectForFile(file.getPath(), dispName));
+
smrp.setMessage(Bundle.PROMPT_AskOpenProjectForFile(file.getNameExt(), 
dispName));
 }
 smrp.setType(MessageType.Info);
 

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-5535) Netbeans 12.3 uses wrong Gradle wrapper

2021-05-04 Thread Alexander Shchelkunov (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338794#comment-17338794
 ] 

Alexander Shchelkunov edited comment on NETBEANS-5535 at 5/4/21, 6:49 AM:
--

Hi [~lkishalmi]!

The URL is the following:
{code:java}
distributionUrl=https\://artifactory.mycompany.com/artifactory/gradle-distributions/com/gradle/distributions/gradle/Wrapper-6.6.0-SNAPSHOT/gradle-Wrapper-6.6.0-SNAPSHOT.zip{code}


was (Author: alexander shchelkunov):
The URL is the following:
{code}distributionUrl=https\://artifactory.mycompany.com/artifactory/gradle-distributions/com/gradle/distributions/gradle/Wrapper-6.6.0-SNAPSHOT/gradle-Wrapper-6.6.0-SNAPSHOT.zip{code}

> Netbeans 12.3 uses wrong Gradle wrapper
> ---
>
> Key: NETBEANS-5535
> URL: https://issues.apache.org/jira/browse/NETBEANS-5535
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Affects Versions: 12.2
> Environment: Windows 10
> Gradle 6.6
> Netbeans 12.3
>Reporter: Alexander Shchelkunov
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Hello,
> I'm trying to open a project which uses a custom plugin available only 
> through the Gradle wrapper and I'm getting the following error:
> {code:java}
> * What went wrong:
> A problem occurred evaluating root project 'XXX'.
> > Plugin with id 'YYY' not found.
> {code}
> I can see that Netbeans is trying to execute the following command and it 
> fails:
> {code:java}
> cd ; .\gradlew.bat --configure-on-demand -x check build
> {code}
> If I execute the same command from the command line, it works fine.
>  Is it possible to make sure that Netbeans uses certain Gradle wrapper when 
> open/build projects? It looks like it uses the wrong one: 
> 'C:\Users\\.gradle\wrapper\dists\gradle-6.7-bin\efvqh8uyq79v2n7rcncuhu9sv\gradle-6.7'.
>  It should use the wrapper specified in 
> gradle/wrapper/gradle-wrapper.properties file.
> Thanks in advance!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5535) Netbeans 12.3 uses wrong Gradle wrapper

2021-05-04 Thread Alexander Shchelkunov (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338794#comment-17338794
 ] 

Alexander Shchelkunov commented on NETBEANS-5535:
-

The URL is the following:
{code}distributionUrl=https\://artifactory.mycompany.com/artifactory/gradle-distributions/com/gradle/distributions/gradle/Wrapper-6.6.0-SNAPSHOT/gradle-Wrapper-6.6.0-SNAPSHOT.zip{code}

> Netbeans 12.3 uses wrong Gradle wrapper
> ---
>
> Key: NETBEANS-5535
> URL: https://issues.apache.org/jira/browse/NETBEANS-5535
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Affects Versions: 12.2
> Environment: Windows 10
> Gradle 6.6
> Netbeans 12.3
>Reporter: Alexander Shchelkunov
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Hello,
> I'm trying to open a project which uses a custom plugin available only 
> through the Gradle wrapper and I'm getting the following error:
> {code:java}
> * What went wrong:
> A problem occurred evaluating root project 'XXX'.
> > Plugin with id 'YYY' not found.
> {code}
> I can see that Netbeans is trying to execute the following command and it 
> fails:
> {code:java}
> cd ; .\gradlew.bat --configure-on-demand -x check build
> {code}
> If I execute the same command from the command line, it works fine.
>  Is it possible to make sure that Netbeans uses certain Gradle wrapper when 
> open/build projects? It looks like it uses the wrong one: 
> 'C:\Users\\.gradle\wrapper\dists\gradle-6.7-bin\efvqh8uyq79v2n7rcncuhu9sv\gradle-6.7'.
>  It should use the wrapper specified in 
> gradle/wrapper/gradle-wrapper.properties file.
> Thanks in advance!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists