[jira] [Commented] (NETBEANS-6381) Ctrl+Click on package name in import statement should browse classes
[ https://issues.apache.org/jira/browse/NETBEANS-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475163#comment-17475163 ] Akhilesh Singh commented on NETBEANS-6381: -- Currently NetBeans is navigating to package descriptor called package-info.java(mostly present in all the packages) on crtl+click of any import package. Other IDE's like Intellij navigating to package explorer not package descriptor and Eclipse not providing any link to navigate. PFB screenshot of NetBeans navigation on click of import pacakge. !image-2022-01-13-13-27-12-725.png!!image-2022-01-13-13-27-12-768.png! > Ctrl+Click on package name in import statement should browse classes > > > Key: NETBEANS-6381 > URL: https://issues.apache.org/jira/browse/NETBEANS-6381 > Project: NetBeans > Issue Type: Improvement > Components: java - Navigation >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Dusan Balek >Priority: Major > Attachments: Screenshot 2022-01-11 at 14.17.08.png, > image-2022-01-13-13-27-12-725.png, image-2022-01-13-13-27-12-768.png > > > Compared to other Java IDE NetBeans is missing feature to allow browsing > classes in package when Ctrl+Click on package name in import statement. This > should expand package in dependencies and allow browsing. This will lead to > open the class selected similar to Ctrl+Click on class name in import > statement. > See underlined {{runtime}} in screenshot > !Screenshot 2022-01-11 at 14.17.08.png! > Currently NB shows message that class runtime cannot be open - missing source. > There is no representation in NetBeans for jar file containing > io.micronaut.runtime. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6381) Ctrl+Click on package name in import statement should browse classes
[ https://issues.apache.org/jira/browse/NETBEANS-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Singh updated NETBEANS-6381: - Attachment: image-2022-01-13-13-27-12-768.png > Ctrl+Click on package name in import statement should browse classes > > > Key: NETBEANS-6381 > URL: https://issues.apache.org/jira/browse/NETBEANS-6381 > Project: NetBeans > Issue Type: Improvement > Components: java - Navigation >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Dusan Balek >Priority: Major > Attachments: Screenshot 2022-01-11 at 14.17.08.png, > image-2022-01-13-13-27-12-725.png, image-2022-01-13-13-27-12-768.png > > > Compared to other Java IDE NetBeans is missing feature to allow browsing > classes in package when Ctrl+Click on package name in import statement. This > should expand package in dependencies and allow browsing. This will lead to > open the class selected similar to Ctrl+Click on class name in import > statement. > See underlined {{runtime}} in screenshot > !Screenshot 2022-01-11 at 14.17.08.png! > Currently NB shows message that class runtime cannot be open - missing source. > There is no representation in NetBeans for jar file containing > io.micronaut.runtime. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6381) Ctrl+Click on package name in import statement should browse classes
[ https://issues.apache.org/jira/browse/NETBEANS-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Singh updated NETBEANS-6381: - Attachment: image-2022-01-13-13-27-12-725.png > Ctrl+Click on package name in import statement should browse classes > > > Key: NETBEANS-6381 > URL: https://issues.apache.org/jira/browse/NETBEANS-6381 > Project: NetBeans > Issue Type: Improvement > Components: java - Navigation >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Dusan Balek >Priority: Major > Attachments: Screenshot 2022-01-11 at 14.17.08.png, > image-2022-01-13-13-27-12-725.png, image-2022-01-13-13-27-12-768.png > > > Compared to other Java IDE NetBeans is missing feature to allow browsing > classes in package when Ctrl+Click on package name in import statement. This > should expand package in dependencies and allow browsing. This will lead to > open the class selected similar to Ctrl+Click on class name in import > statement. > See underlined {{runtime}} in screenshot > !Screenshot 2022-01-11 at 14.17.08.png! > Currently NB shows message that class runtime cannot be open - missing source. > There is no representation in NetBeans for jar file containing > io.micronaut.runtime. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475042#comment-17475042 ] Thomas Schapitz edited comment on NETBEANS-6163 at 1/13/22, 1:34 AM: - [~sworisbreathing] I find the sentence "Most pugins adhere..." below "Please Note" telling enough: somebody at Netbeans has taken note in the past ,-). Whether this is also buried somewhere in Maven doc, I don't know. For me, it goes without saying, to avoid introduction of unnecessary sources into the tree if possible for the stated reasons. Rummaging through a generated tree to look for hidden source roots might make things worse too: Not only could this be time consuming and fruitless, but you might even get more than you bargained for. was (Author: taps): [~sworisbreathing] I find the sentence "Most pugins adhere..." below "Please Note" telling enough: somebody at Netbeans has taken note in the past ,-). Whether this is also buried somewhere in Maven doc, I don't know. For me, it goes without saying, to avoid introduction of unnecessary sources into the tree if possible for the stated reasons. Rummaging through a generated tree to look for hidden source roots might make things worse too: Not only could this be time consuming even fruitless, but you might even get more than you bargained for. > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-50-02-502.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475042#comment-17475042 ] Thomas Schapitz commented on NETBEANS-6163: --- [~sworisbreathing] I find the sentence "Most pugins adhere..." below "Please Note" telling enough: somebody at Netbeans has taken note in the past ,-). Whether this is also buried somewhere in Maven doc, I don't know. For me, it goes without saying, to avoid introduction of unnecessary sources into the tree if possible for the stated reasons. Rummaging through a generated tree to look for hidden source roots might make things worse too: Not only could this be time consuming even fruitless, but you might even get more than you bargained for. > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-50-02-502.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6298) Match NetBeans console encoding to system/app console encoding
[ https://issues.apache.org/jira/browse/NETBEANS-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475029#comment-17475029 ] Thomas Schapitz commented on NETBEANS-6298: --- Ahh sorry, my bad. I was just triggered by the mentioning of the exec plugin at Jan 4th, and the console further up. You might be looking at two different different issues here. Welcome to one of Javas oldest quirks: Please take a look at this: [https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Properties.html#load(java.io.InputStream). |https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Properties.html#load(java.io.InputStream)]. Since its introduction in Java 1.2, Java properties files are specified to be encoded as ISO-8859-1. That is, unless they are written in xml (introduced with Java 1.5), or get loaded using [https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Properties.html#load(java.io.Reader).|https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)], introduced with Java 1.6 In the later case, the user might in fact construct the required Reader with *any* encoding, but not necessarily the one found in system property file.encoding. But this has no power over the method using InputStream. If the property file is loaded by foreign code you can't change, you've got no chance then to comply, and encode it ISO-8859-1. And in fact, most property files get loaded this way, using [https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.String]) If you need to embed characters not encodable in ISO-8859-1 you would need to use proper Unicode escaping. This is a really nasty situation, as the IDE might have allowed to select a different encoding for property files, but didn't elect to; instead opted for safety & compatibility reasons to insist on ISO-8859-1 for properties files. If you can live with that, just don't use something else than ISO-8859-1 in property files. A proper remedy here is really hard to come by. Basically, it would either involve changing Javas implementation of [Properties.html#load(java.io.InputStream)|https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Properties.html#load(java.io.InputStream)] to use file.encoding, which could potentially break thousands of systems running with file.encoding set to something else, so it is rather unlikely to happen, or Netbeans to specify a separate encoding policy for properties files. This is one of the very few examples were eclipse has the upper: it allows to specify the encoding in the properties of every file. Introducing this into Netbeans will require some conviction. > Match NetBeans console encoding to system/app console encoding > -- > > Key: NETBEANS-6298 > URL: https://issues.apache.org/jira/browse/NETBEANS-6298 > Project: NetBeans > Issue Type: Bug > Components: cnd - Editor >Affects Versions: 12.0, 12.1, 12.2, 12.3, 12.4, 12.5, 12.6, NB13, 13 > Environment: Windows 10、JDK1.8.201、Maven3.6.0、Netbeans12.6、Project > encoding UTF-8 >Reporter: luke >Priority: Blocker > Attachments: Garbled.gif, Garbled.png, console-output-well.png, > full_output.png, screenshot-1.png, screenshot-2.png, screenshot-3.png > > > My Windows OS language is Simplified Chinese and the default OS encoding is > GBK. When I open a properties file or a text file, the editor shows the file > contents as garbled, if I add the parameter -J-Dfile.encoding=UTF-8, the > editor opens the file in UTF-8 encoding format and the file is not garbled, > but the console output is garbled. > !Garbled.gif|width=1055,height=536! > !Garbled.png|width=1542,height=843! -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6365) Organise imports removes imports that are records
[ https://issues.apache.org/jira/browse/NETBEANS-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475012#comment-17475012 ] Benjamin Asbach commented on NETBEANS-6365: --- I guess this is already fixed as I could not reproduce it on master branch. > Organise imports removes imports that are records > - > > Key: NETBEANS-6365 > URL: https://issues.apache.org/jira/browse/NETBEANS-6365 > Project: NetBeans > Issue Type: Bug > Components: editor - Other >Affects Versions: 12.6 > Environment: Windows 10 >Reporter: Paul Woods >Priority: Major > Attachments: organize-imports-records-bug.zip > > > Starting with 12.6 when I select 'organise/remove unused imports on save' I > find that an import that is a record rather than a class gets removed. > The keybindings for organise imports also seems to have gone? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474988#comment-17474988 ] Steven Swor edited comment on NETBEANS-6163 at 1/12/22, 10:10 PM: -- [~taps] thanks for the screenshot, but what I was really after was, "Is it written down somewhere *in the maven documentation* (i.e. a page under https://maven.apache.org) how plugins that generate sources should behave, or is this just 'common knowledge' among *maven* plugin developers?" was (Author: sworisbreathing): [~taps] thanks for the screenshot, but what I was really after was, "Is it written down somewhere *in the maven documentation* (i.e. a page under https://maven.apache.org) how plugins that generate sources should behave, or is this just 'common knowledge' among plugin developers?" > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-50-02-502.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474988#comment-17474988 ] Steven Swor commented on NETBEANS-6163: --- [~taps] thanks for the screenshot, but what I was really after was, "Is it written down somewhere *in the maven documentation* (i.e. a page under https://maven.apache.org) how plugins that generate sources should behave, or is this just 'common knowledge' among plugin developers?" > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-50-02-502.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6365) Organise imports removes imports that are records
[ https://issues.apache.org/jira/browse/NETBEANS-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474948#comment-17474948 ] Benjamin Asbach edited comment on NETBEANS-6365 at 1/12/22, 8:56 PM: - I'm also facing this problem. I attached a sample project. Environment: Linux (NixOS), OpenJDK17 1) Enable On Save Action: Organize Imports 2) Go to AClass 3) Press Ctrl + Shift + I to Organize imports 4) Save file was (Author: asbachb): I added a example project. To reproduce 1) Enable On Save Action: Organize Imports 2) Go to AClass 3) Press Ctrl + Shift + I to Organize imports 4) Save file > Organise imports removes imports that are records > - > > Key: NETBEANS-6365 > URL: https://issues.apache.org/jira/browse/NETBEANS-6365 > Project: NetBeans > Issue Type: Bug > Components: editor - Other >Affects Versions: 12.6 > Environment: Windows 10 >Reporter: Paul Woods >Priority: Major > Attachments: organize-imports-records-bug.zip > > > Starting with 12.6 when I select 'organise/remove unused imports on save' I > find that an import that is a record rather than a class gets removed. > The keybindings for organise imports also seems to have gone? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6365) Organise imports removes imports that are records
[ https://issues.apache.org/jira/browse/NETBEANS-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474948#comment-17474948 ] Benjamin Asbach commented on NETBEANS-6365: --- I added a example project. To reproduce 1) Enable On Save Action: Organize Imports 2) Go to AClass 3) Press Ctrl + Shift + I to Organize imports 4) Save file > Organise imports removes imports that are records > - > > Key: NETBEANS-6365 > URL: https://issues.apache.org/jira/browse/NETBEANS-6365 > Project: NetBeans > Issue Type: Bug > Components: editor - Other >Affects Versions: 12.6 > Environment: Windows 10 >Reporter: Paul Woods >Priority: Major > Attachments: organize-imports-records-bug.zip > > > Starting with 12.6 when I select 'organise/remove unused imports on save' I > find that an import that is a record rather than a class gets removed. > The keybindings for organise imports also seems to have gone? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6365) Organise imports removes imports that are records
[ https://issues.apache.org/jira/browse/NETBEANS-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Asbach updated NETBEANS-6365: -- Attachment: organize-imports-records-bug.zip > Organise imports removes imports that are records > - > > Key: NETBEANS-6365 > URL: https://issues.apache.org/jira/browse/NETBEANS-6365 > Project: NetBeans > Issue Type: Bug > Components: editor - Other >Affects Versions: 12.6 > Environment: Windows 10 >Reporter: Paul Woods >Priority: Major > Attachments: organize-imports-records-bug.zip > > > Starting with 12.6 when I select 'organise/remove unused imports on save' I > find that an import that is a record rather than a class gets removed. > The keybindings for organise imports also seems to have gone? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch php81-support updated (3de03d6 -> 6dd2ade)
This is an automated email from the ASF dual-hosted git repository. tmysik pushed a change to branch php81-support in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 3de03d6 Merge pull request #3360 from junichi11/php81-readonly-properties new 0024f25 [NETBEANS-5599] PHP 8.1 Support: New in initializers (Part 1) new 30c022f [NETBEANS-5599] PHP 8.1 Support: New in initializers (Part 2) new 15ee47b [NETBEANS-5599] PHP 8.1 Support: New in initializers (Part 3) new 6dd2ade Merge pull request #3448 from junichi11/php81-new-in-initializers The 6204 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../editor/completion/CompletionContextFinder.java |9 +- .../php/editor/completion/PHPCodeCompletion.java |5 +- .../modules/php/editor/parser/ASTPHP5Parser.java | 5285 ++-- .../modules/php/editor/parser/ASTPHP5Symbols.java |2 +- .../php/editor/parser/EncodedActionTable1.java | 2058 .../php/editor/parser/EncodedActionTable10.java| 950 ++-- .../php/editor/parser/EncodedActionTable11.java| 302 +- .../php/editor/parser/EncodedActionTable12.java| 750 +-- .../php/editor/parser/EncodedActionTable13.java| 818 +-- .../php/editor/parser/EncodedActionTable14.java| 2082 .../php/editor/parser/EncodedActionTable15.java| 376 +- .../php/editor/parser/EncodedActionTable16.java| 620 +-- .../php/editor/parser/EncodedActionTable17.java| 80 +- .../php/editor/parser/EncodedActionTable2.java | 646 +-- .../php/editor/parser/EncodedActionTable3.java | 3702 +++--- .../php/editor/parser/EncodedActionTable4.java | 1420 +++--- .../php/editor/parser/EncodedActionTable5.java | 398 +- .../php/editor/parser/EncodedActionTable6.java | 372 +- .../php/editor/parser/EncodedActionTable7.java | 492 +- .../php/editor/parser/EncodedActionTable8.java | 890 ++-- .../php/editor/parser/EncodedActionTable9.java | 732 +-- .../newInInitializersWithClassConstantError.pass | 58 + .../php81/newInInitializersWithPropertyError.pass | 58 + .../parser/php81/newInInitializers_01.pass | 1266 + ...atorInArrayExpression_GlobalConst_01.completion |1 + ...atorInArrayExpression_GlobalConst_02.completion |1 + ...atorInArrayExpression_GlobalConst_09.completion |1 + testConstructorPropertyPromotion08a.completion |1 + testConstructorPropertyPromotion08b.completion |1 + testConstructorPropertyPromotion09a.completion |1 + testConstructorPropertyPromotion09b.completion |1 + .../testNewInInitializers/newInInitializers.php| 44 + ...alizers.php.testNewInInitializers_01.completion |5 + ...alizers.php.testNewInInitializers_02.completion |4 + ...alizers.php.testNewInInitializers_03.completion |5 + ...alizers.php.testNewInInitializers_04.completion |4 + ...alizers.php.testNewInInitializers_05.completion | 12 + ...alizers.php.testNewInInitializers_06.completion |5 + ...alizers.php.testNewInInitializers_07.completion |4 + ...alizers.php.testNewInInitializers_08.completion |6 + ...alizers.php.testNewInInitializers_09.completion |4 + ...alizers.php.testNewInInitializers_10.completion | 15 + ...alizers.php.testNewInInitializers_11.completion |5 + ...alizers.php.testNewInInitializers_12.completion |4 + ...alizers.php.testNewInInitializers_13.completion |5 + ...alizers.php.testNewInInitializers_14.completion |4 + .../newInInitializersAttributeTyping01.php | 35 + ...stNewInInitializersAttributeTyping01.completion | 91 + .../newInInitializersAttributeTyping02.php | 35 + ...stNewInInitializersAttributeTyping02.completion |5 + .../newInInitializersAttributeTyping03.php | 35 + ...stNewInInitializersAttributeTyping03.completion |4 + .../newInInitializersConstantTyping01.php | 22 + ...estNewInInitializersConstantTyping01.completion | 86 + .../newInInitializersConstantTyping02.php | 22 + ...estNewInInitializersConstantTyping02.completion |5 + .../newInInitializersConstantTyping03.php | 22 + ...estNewInInitializersConstantTyping03.completion |4 + .../newInInitializersFuncTyping01.php | 22 + ...hp.testNewInInitializersFuncTyping01.completion |7 + .../newInInitializersFuncTyping02.php | 22 + ...hp.testNewInInitializersFuncTyping02.completion |5 + .../newInInitializersFuncTyping03.php | 22 + ...hp.testNewInInitializersFuncTyping03.completion |4 + .../newInInitializersMethodTyping01.php| 33 + ...testNewInInitializersMethodTyping01.completion} |6 +- .../newInInitializersMethodTyping02.php
[jira] [Comment Edited] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474694#comment-17474694 ] Thomas Schapitz edited comment on NETBEANS-6163 at 1/12/22, 6:41 PM: - [~sworisbreathing] How this should be configured is actually shown on the projects property page: !image-2022-01-12-16-50-02-502.png! So, yes, this is a standard. What is more, this isn't just a Netbeans invention, but relates to the Maven best practices, how the directory structure within a Maven project should be organized. Note, that the openapi-generator is in fact a multi purpose library, able to parse swagger swagger/open-api schemata, and then generating arbitrary output using plugable generators. This library is then wrapped into several hosting environments, among others a CLI application and the Maven plugin, the later is mainly passing through the various configuration options, that haven't been devised with Maven in mind. One of the generation options is to generate a complete Maven or Gradle project containing the code to implement a client for that API. This could be build, installed, and deployed, to be consumed by an other project as dependency, which is a sensible solution in many use cases, as it avoids duplicating the source and classes. It might also provide sort of a starting point, if you use it to generate server side stubs, e. g. in place of a Maven archetype. But it certainly not intended, to spam a whole project infrastructure into target/generated-sources, if you just want to pick the model classes and the API interfaces, which you might want to use in a customized Spring Boot build. This is indeed an abomination, causing unnecessary waste of time, diskspace and energy. It is equivalent to uprooting and carting off a tree, because you want to eat the apples. You asked: 'What's wrong with having NetBeans pick up the generated sources from maven instead of making an assumption about how plugins are going to behave?' Nothing, You cited the idea back to me, that I mentioned earlier on, didn't I? I'm just a bit reluctant, to drop something as "Major Bug" into the lap of Netbeans, if the work around for this "bug" consists in properly adhering to Mavens standards. Netbeans already has a really big codebase. It might pay to curb the growth a bit. BTW.: if you look into the discussion of the linked PR here: [https://github.com/apache/netbean/pull/3285#discussion_r741711876] the impression is, that Netbeans is already doing this. If I was to vote for this issue, I would downgrade it to it to "Minor Improvement", since it is not exactly stopping the world from turning. was (Author: taps): [~sworisbreathing] How this should be configured is actually shown on the projects property page: !image-2022-01-12-16-50-02-502.png! So, yes, this is a standard. What is more, this isn't just a Netbeans inventions, but relates to the Maven best practices, how the directory structure within a Maven project should be organized. The problem here is due to the fact, that the openapi-generator is in fact a multi purpose library, able to parse swagger swagger/open-api schemata, and then generating arbitrary output using plugable generators. This library is then wrapped into several hosting environments, among others a CLI application and the Maven plugin. One of the generation options is to generate a complete Maven or Gradle project containing the code to implement a client for that API. This could be build, installed, and deployed, to be consumed by an other project as dependency, which is a sensible solution in many use cases, as it avoids duplicating the source and classes. It might also provide sort of a starting point, if you use it to generate server side stubs, e. g. in place of a Maven archetype. But it doesn't make sense, to spam a whole project infrastructure into generated-sources, if you just want to pick the model classes and the API interfaces, which you might want to use in a customized Spring Boot build. This is indeed an abomination, causing unnecessary waste of time, diskspace and energy. It is equivalent to uprooting and carting off a tree, because you want to eat the apples. You asked: 'What's wrong with having NetBeans pick up the generated sources from maven instead of making an assumption about how plugins are going to behave?' Nothing, You cited the idea back to me, that I mentioned earlier on, didn't I? I'm just a bit reluctant, to drop something as "Major Bug" into the lap of Netbeans, if the work around for this "bug" consists in properly adhering to Mavens standards. Netbeans already has a really big codebase. It might pay to curb the growth a bit. BTW.: if you look into the discussion of the linked PR here: [https://github.com/apache/netbean/pull/3285#discussion_r741711876] the impression is, that
[jira] [Updated] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-6384: --- Fix Version/s: NB13 (was: 13.0) > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: NB13 > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2005) Grid CSS support
[ https://issues.apache.org/jira/browse/NETBEANS-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-2005: --- Fix Version/s: NB13 (was: 12.2) (was: 13.0) > Grid CSS support > > > Key: NETBEANS-2005 > URL: https://issues.apache.org/jira/browse/NETBEANS-2005 > Project: NetBeans > Issue Type: Improvement >Reporter: Arnaud BERNARD >Assignee: Matthias Bläsing >Priority: Major > Fix For: NB13 > > Attachments: screen.jpg > > Time Spent: 20m > Remaining Estimate: 0h > > Need support of Grid as soon as possible. This feature is supported by all > browsers now. Thx! -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-6347: --- Fix Version/s: 13 > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Critical > Labels: pull-request-available > Fix For: 13 > > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > Time Spent: 10m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-6347: --- Fix Version/s: NB13 (was: 13) > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Critical > Labels: pull-request-available > Fix For: NB13 > > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > Time Spent: 10m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-6347: --- Priority: Critical (was: Major) > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Critical > Labels: pull-request-available > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > Time Spent: 10m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474728#comment-17474728 ] Neil C Smith commented on NETBEANS-6347: Have opened a pull request to revert the change that causes this. Also breaks the project level actions configuration as well as at global level. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Major > Labels: pull-request-available > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > Time Spent: 10m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-6347: - Labels: pull-request-available (was: ) > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Major > Labels: pull-request-available > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > Time Spent: 10m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (ae6389a -> 66c6df6)
This is an automated email from the ASF dual-hosted git repository. dbalek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from ae6389a Merge pull request #3441 from sdedic/lsp/cancel-handle add 66c6df6 LSP: Modified to prevent errors printed to log from ServerTest. (#3438) No new revisions were added by this update. Summary of changes: .../org/netbeans/modules/java/lsp/server/protocol/ServerTest.java | 6 +++--- .../netbeans/modules/refactoring/java/plugins/JavaPluginUtils.java | 1 + .../modules/refactoring/java/plugins/PushDownTransformer.java | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474694#comment-17474694 ] Thomas Schapitz commented on NETBEANS-6163: --- [~sworisbreathing] How this should be configured is actually shown on the projects property page: !image-2022-01-12-16-50-02-502.png! So, yes, this is a standard. What is more, this isn't just a Netbeans inventions, but relates to the Maven best practices, how the directory structure within a Maven project should be organized. The problem here is due to the fact, that the openapi-generator is in fact a multi purpose library, able to parse swagger swagger/open-api schemata, and then generating arbitrary output using plugable generators. This library is then wrapped into several hosting environments, among others a CLI application and the Maven plugin. One of the generation options is to generate a complete Maven or Gradle project containing the code to implement a client for that API. This could be build, installed, and deployed, to be consumed by an other project as dependency, which is a sensible solution in many use cases, as it avoids duplicating the source and classes. It might also provide sort of a starting point, if you use it to generate server side stubs, e. g. in place of a Maven archetype. But it doesn't make sense, to spam a whole project infrastructure into generated-sources, if you just want to pick the model classes and the API interfaces, which you might want to use in a customized Spring Boot build. This is indeed an abomination, causing unnecessary waste of time, diskspace and energy. It is equivalent to uprooting and carting off a tree, because you want to eat the apples. You asked: 'What's wrong with having NetBeans pick up the generated sources from maven instead of making an assumption about how plugins are going to behave?' Nothing, You cited the idea back to me, that I mentioned earlier on, didn't I? I'm just a bit reluctant, to drop something as "Major Bug" into the lap of Netbeans, if the work around for this "bug" consists in properly adhering to Mavens standards. Netbeans already has a really big codebase. It might pay to curb the growth a bit. BTW.: if you look into the discussion of the linked PR here: [https://github.com/apache/netbean/pull/3285#discussion_r741711876] the impression is, that Netbeans is already doing this. If I was to vote for this issue, I would downgrade it to it to "Minor Improvement", since it is not exactly stopping the world from turning. > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-50-02-502.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474644#comment-17474644 ] Jaroslav Tulach edited comment on NETBEANS-6384 at 1/12/22, 3:57 PM: - Code is at [https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions |https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions] sample extension is [available as well|https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/808/] was (Author: jtulach): Code is at https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 13.0 > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474644#comment-17474644 ] Jaroslav Tulach commented on NETBEANS-6384: --- Code is at https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 13.0 > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schapitz updated NETBEANS-6163: -- Attachment: image-2022-01-12-16-50-02-502.png > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-50-02-502.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schapitz updated NETBEANS-6163: -- Attachment: (was: image-2022-01-12-16-48-47-668.png) > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6163) Maven does not set generated source roots correctly
[ https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schapitz updated NETBEANS-6163: -- Attachment: image-2022-01-12-16-48-47-668.png > Maven does not set generated source roots correctly > --- > > Key: NETBEANS-6163 > URL: https://issues.apache.org/jira/browse/NETBEANS-6163 > Project: NetBeans > Issue Type: Bug > Components: projects - Maven >Reporter: Martin Entlicher >Assignee: Martin Entlicher >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: image-2022-01-12-16-48-47-668.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Clone and build [https://github.com/dsyer/native-image-debug] > Open the project in NetBeans and see that under {{Generated Sources}} there > are packages like: {{src.main.java.org.springframework.aot}}, etc. > The initial {{src/main/java}} should not be included in the source root. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith reassigned NETBEANS-6347: -- Assignee: Neil C Smith > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Major > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-6379) Editor NoSuchMethodError on JDK1.8
[ https://issues.apache.org/jira/browse/NETBEANS-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith closed NETBEANS-6379. -- Resolution: Duplicate Unfortunately, the binary releases of 12.6 don't support editing Java sources when running on JDK 8. You can build from the source release if you really need that, or run the IDE itself on JDK 11 or 17. If the versioning label problem replicates, please open another issue. > Editor NoSuchMethodError on JDK1.8 > -- > > Key: NETBEANS-6379 > URL: https://issues.apache.org/jira/browse/NETBEANS-6379 > Project: NetBeans > Issue Type: Bug > Components: cnd - Editor >Affects Versions: 12.6 > Environment: Fedora 34 and > java-1.8.0-openjdk-1.8.0.312.b07-2.fc34.x86_64 >Reporter: Arnaud Kleinveld >Priority: Major > Attachments: Screenshot from 2022-01-11 14-02-06.png, Screenshot from > 2022-01-11 14-34-21.png, ide.log, ui.log > > > Hit enter at the end of a line (35) the editor throws a NoSuchMethodError and > does not complete the expected indention on the inserted line (36). A green > versioning label/mark is wrongly placed at the start of the next line (37) > after the inserted line. > !Screenshot from 2022-01-11 14-02-06.png|width=575,height=58! -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
svn commit: r52039 - /dev/netbeans/netbeans-vscode-ext/12.6.301/
Author: sdedic Date: Wed Jan 12 12:59:28 2022 New Revision: 52039 Log: Staging interim release of VSNetBeans 12.6.301 Added: dev/netbeans/netbeans-vscode-ext/12.6.301/ dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip (with props) dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.asc dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.sha512 dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix (with props) dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.asc dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.sha512 Added: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip == Binary file - no diff available. Propchange: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip -- svn:mime-type = application/octet-stream Added: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.asc == --- dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.asc (added) +++ dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.asc Wed Jan 12 12:59:28 2022 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEX0LPVLeWj7N4amUxsIquFwkyaDkFAmHezp4ACgkQsIquFwky +aDnsPQ/+L2nSlFIDgU/lPGeZw4Yte9h35xiU+PpAG1D/ibEfqWYd7TdVeYCUcvEN +zcwc2IGzYOy9l9TUBnGhZDFMiWRd1D7KbhVixU8loFgtUqgPz/v52HPaZSD4HZ8i +pYgEUkKxuzxi7DfjASC/L5DdinBKrEggqlyJW3LchVDQmkAt+Dt8O4ZIHLcyO2SE +ukz7Y70JEaq6U2dIOmIuJRfGpqW41WAFsOHjhQENyi6BY8bsucmYXSpNcEygZoN+ +73PVS9noQuL9JvHu9FTxmgm2lfPqxR45ZNv+tRI4615S6SoMoikRtZKVsApNSxuU +OzInfmRPfCuhDv+gYRv47bUm9+sM9hkDYtPcL4ZzgpbzZfP8qtXYXcDAgI9xQyny +RR8jTBm6xEpLeA55ohuc5Z9NikKAHZEgy3ZPa53KwZZQM+jrwXwQkGBWIs5RRiTn +pC1fnBGDOsU3U/+wdNzfh4Oelxa0jqMRNJ2QwQAOtqnhd156ETZo5T/9LhfFkps+ +7IN+H9HCvv+fUoOPSCQoYs2rQxwigtQaSNZWtcSFYe79JlGwosN7x+MH9cSQMt/P +h3i0KCl6BwJhl8IfJHvAu94i1H7Q5ReYY52cAHq7qqHYAIlmg8ZB1MjP24toxUQW +eMRaftMgIXGF2FML3Z0P0KfjEGDKY+MabL5Ld1pSrlhdFEfS288= +=tvA5 +-END PGP SIGNATURE- Added: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.sha512 == --- dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.sha512 (added) +++ dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301-src.zip.sha512 Wed Jan 12 12:59:28 2022 @@ -0,0 +1 @@ +574ef054fe1c792e3f090799122a7269af3fcebe916dc70f9421694fb340b18a94ecd38649ba6e19c5d26e3be339d87eaf431c3abf98cd35a18ac6d1c077134a apache-netbeans-java-12.6.301-src.zip Added: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix == Binary file - no diff available. Propchange: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix -- svn:mime-type = application/octet-stream Added: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.asc == --- dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.asc (added) +++ dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.asc Wed Jan 12 12:59:28 2022 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEX0LPVLeWj7N4amUxsIquFwkyaDkFAmHeu80ACgkQsIquFwky +aDlIFRAAkRzGX9+NhY/sR7OfnSSOghDZt/yEsDUkmFtCf2DBI5N0amvfDDNRkHpS +y2caTUs19p+7l6YwIXQHkfQ52vQ4a1kWAwg1KVt8CoutxblgbvZba+5z1pXbyv7V +viNq4I7Slm6xpJJGAeetN46dYGLNP+WmzlBMPS51pdATJYZws4gBLU6Q/jx6OCk9 +YG4koBdRsk8phjsJSAhs7rqRhR/KZUirymB7DugrN8alk+fKnzeO/rhxdrVVpAKN +w44Wk8e3TWe6nVYaq88djE5Szmv/pZh0mK74oMPRH6jf1EJKInys1j8khaN50XrY +8Cv8JKdYC1rnBAmCLz7gjVK06qPdbNtPw+42hyaJuEn2F7swcPgnQDVlKFVBp5p9 +UqrSdqsTovd9TsRu2sfnSK3eGrTj3LiECvxsAPwaAVqYZU8aJXpfizSb+lUje+tr +m5ErFcm7Mi6XcEwwgfT1/QXIkQN5a0mE+vFLc/B2rxGCtzeY+NzdFoumeyVBgESL +Q6YKxUadg9gI+3LhtGvqHmBWQatlW+rHeSTAj9msj64L0PAING1LKwKrW31zycqu +kNUUgoiGyTod0pujLtidzZcf0k6sa6jcI1P8DzWvaMpircXHu6ONawWN9YDz0edm +SPHEcq6aS6WjDldE/MRJ9KieBGhVxCmWb6tluvreYEGxgexNjT8= +=LBEZ +-END PGP SIGNATURE- Added: dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.sha512 == --- dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.sha512 (added) +++ dev/netbeans/netbeans-vscode-ext/12.6.301/apache-netbeans-java-12.6.301.vsix.sha512 Wed
svn commit: r52038 - /release/netbeans/KEYS
Author: sdedic Date: Wed Jan 12 12:46:27 2022 New Revision: 52038 Log: Added sdedic key, signing VSNetbeans release. Modified: release/netbeans/KEYS Modified: release/netbeans/KEYS == --- release/netbeans/KEYS (original) +++ release/netbeans/KEYS Wed Jan 12 12:46:27 2022 @@ -781,4 +781,63 @@ CDN9gNfgiY+zvcAfHJ0hWn19qJQ9WjDl1KPhXXNJ xz9D35cZV/a63Czr8r1xdWDWKg/Y7Xo8GVSZIJfaVn1WSRwQFjgjGXldGHWeMNXm hQOFz/oDYW4o0H6HN0BS =nY2y --END PGP PUBLIC KEY BLOCK- \ No newline at end of file +-END PGP PUBLIC KEY BLOCK- +pub rsa4096 2022-01-11 [SC] [expires: 2024-01-11] + 5F42CF54B7968FB3786A6531B08AAE1709326839 +uid [ultimate] Svatopluk Dedic (Signing key for NetBeans releases) +sig 3B08AAE1709326839 2022-01-11 Svatopluk Dedic (Signing key for NetBeans releases) +sub rsa4096 2022-01-11 [E] [expires: 2024-01-11] +sig B08AAE1709326839 2022-01-11 Svatopluk Dedic (Signing key for NetBeans releases) + +-BEGIN PGP PUBLIC KEY BLOCK- + +mQINBGHd2zABEACkKqjtiYOzhBpJY9d4tRRwACai9abbx10jtnDQ1ZKoISwDcyRI +EpJ4yI3k6eVNiAAqIg9f0pEPN5uG8EgXWayYk7YwzkK0R0q+NA069L2MEr6FmLlU +89UQ/W6hVWJelTelwerEcpALePb15BVMHinM2THD8UtaLnHzxJWwIF6S0iaL+Xzf +tLivHyL3II+C0eL/MYkLPnjMLO+GAY07jxrHe7CVaz96BxnBLVHklYEC3TqXd9Me +hHpWvRqeDxy1jLtaKFYUFWMiRpf1HZHs5yXow7gbl5enYRA1YHCALeKJimCQsBhG +ZwYR0JdBAERXVYQlbMTlSpZWRIZgKP+q7cruDWMd4nbEaN1ho+TDFQcmjQXsS4Kz +jtKl1LCbfEsNewmzkZJt2Wj2KL1Vi19dbKhcFe/nj3s4BRWNSIPHVz/O211MMgnN +1hzOcSjYOasYso+3efXefporFOoBF07/EnoC42Dd34DTi92KYObEUz79tnft/m2V +32LsMuvSIOq3ZTgwmTCs/UTFbBHreyeizJKG7L8yCU3RxdU0sg7XCzdhpxt7uDF6 +VhMaP8LutLwVlKgcNqvikuiXcR9siKFKhc2G/NRCLwKjBwKAcoPnp6bDmWzs8XVL +7a82k429sVwcm6f2D0Mv1lp+YRQUNWixbcdHSpWrlexde9hZzZgISq09VQARAQAB +tERTdmF0b3BsdWsgRGVkaWMgKFNpZ25pbmcga2V5IGZvciBOZXRCZWFucyByZWxl +YXNlcykgPGdhcmF0QHZvbG55LmN6PokCVAQTAQoAPhYhBF9Cz1S3lo+zeGplMbCK +rhcJMmg5BQJh3dswAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJ +ELCKrhcJMmg54coQAJHTli0BWUodLzbHd/FRFBZTJppqPEtNlIr4DQyCEBvLhxGY +xqLcFiEHHxbMIoReZQlmo9ncTpJMHafjXjahdGM2TnSnXDIK8UuycKXq5k0R1y9h +0zWJxyGBJUKAGls5ReyZ8o0LqQ+8wHt4KeoF6oyxq56966ZtHMtvj1BAOnyqJP5T +UwUIrOup+BtIALBogw0owAphX5oyFSHYRgu35/7FJ1yBWQ5FaDx18mk09LonB1ON +syYJcPB1eQsfTEPHtlGO0VvOEbwIzdPh070O+h2X3N3TI2YmDgbHnCejU+1zFQYx +5KYS61li8G5SVwEVSQmdFBOhwJi0r+YdmJLlrmQG6YzK4ImzKPoHDiMRjXBebP4V +lwYBbSAe2ShhfFf0bmLnDmRFTvBRNfM8+w4GWp0Xd5vRwBQ2rjieq4TI1DE49V33 +EcPckhHwfirPCFd94hyPIiZsT4zRQKNnRicearlmn94lQ4UxLAD64kszSAX5txqo +/wuc6OImbac/XNf/67YagWrwYwIiXkux+DcEM/D32SG/aSJud3tU2n8wiwAPcqDg +SN2PHl7gVDJy2O1bqalhpdsrz7tujEqlVa702r2yjVg5hWfkeHiBWTuL4Yf2bj/e +NZYF7jLzLBXXHCibsjqBPpvNS1DHOUoDSeJQGvon/IaRxVIdY5YUfzso+8NvuQIN +BGHd2zABEAC8vOCnBr2GHBe5Pi+xavBcnPzAh8MYCSTeu8+EzdLC+g9spGaUCqOA +jlm2dUpGbeye1oIsI/8PwjMiCz/QugY9nTLwDQmgfzaPYN5tbYl/V2r57+sh7A9Z +Jrsg/npw5hcuMZZeFXW08uxDkBPrPRqxzLthlf8rZERkrXTGlllbGEGaeqCy9tRS +brkzcgFz1tTy+deI/UuOhCN9WyVa8Nfpk0/373AgqRTyGoku03TuNmR/RHdmgpnv +QTOG9lipUFhslzjMdycQC/9OyYZtAip2MnQmlupGGmAnfyHXSazahqdCnknJ1Jdz +Xn9Ub2tZZezwpafQbkbuMEDJdSvXbdnzRMq8lGJzfry0PYiSY2YI2emEMFfB67Q6 +Hexfqi9v+mkphiVPcdgjWQ82akHUfwah6gat4qtBDytKu0mX1WFxkSGzmXidpwT2 +hfcMLRNkK1P3j+X3DQn15eqPgTLmt0FeKqL/f/diJu9BVG0SoYtwkol6jxp+R/gc +6F7CZ7oxLZC5mutoVVmJ2RahH8A4grvvjfrApphr7q1Rbmgl/8av2RxUPSp4o23W +wnOvKq0s2UU/uNIGmj0WkFiBK7g7wWSnLEYVS4w6/wQP19qnwHT21M9Wm3ctNs+w +pGV5mFsFnh3oiNDCA/Dmt485EER14h0m1NGtxtWq4KE53uqP8g5RdQARAQABiQI8 +BBgBCgAmFiEEX0LPVLeWj7N4amUxsIquFwkyaDkFAmHd2zACGwwFCQPCZwAACgkQ +sIquFwkyaDmSVQ/+OgNhA5R7SZ8tqk0jstFmfiv3E21CYZQZSs0KYzSZtfnNBusn +VqbkbghFT+X73xhw6siWniO2opUeJxIs7GgWvcD7ZQhGmDiaF3uDsBgeeoJj0I3N +1FCfmNztJMgMoWUpTHX+WnXoVTeDKjkXHCaowO3sJNQz0g0MKY69OvguF94UxRXB +GQFduat0/texKkiPGR4d7a3xgBcxg6VDzUx/AwnwgVfu+J9hCMbPl9JPUkaPh/XK +Vr0DTjUau5QBDRYEyxEa+2mkUopuLmbTcyLXeY8qR5nULTae+X8iuGDwitJh6Mqu +UiF3u92/HbH5WuXXhTflmLNMiHDmFXxP3miqLDqBMGyHNrIDrJi/ikdmW6PmdvZP +7N5MPhIfP/s8s1d/NdGdu1TpcZQqujg/K2tIM1TrABq2anMr5M9YrXWV3xxFPYnk +TG8RqO/9/L58xpztCGtdXOtVEYlGjlrKne0SQ9OCy3hySWTUx8I3Vv9YpR5Kt4ay +kcNlF4Zo7xcaWINxj1kzwC5xtbHiNDOBDNBJggdCecvhfPkbZmwGTpB1l5VRjsFo +9xJ8cFuK4Iweotzf2t7//RjzvcmoMUBnOQgVrCCc+lD0hfQtDejhbx3es8OlB7op +wcnfmH3fPeMkNFM20mwPiFqOz+1Vl6MDdMKrdUcNzqbFPIZqc2WVYXlIYTY= +=Q+NI +-END PGP PUBLIC KEY BLOCK- - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Balin updated NETBEANS-6384: --- Summary: Detect another Java support ext and recommend to Disable one (was: Detect another Java support ext and recommend to Disable it) > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 13.0 > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-6384) Detect another Java support ext and recommend to Disable it
Martin Balin created NETBEANS-6384: -- Summary: Detect another Java support ext and recommend to Disable it Key: NETBEANS-6384 URL: https://issues.apache.org/jira/browse/NETBEANS-6384 Project: NetBeans Issue Type: Task Components: vscode Affects Versions: 12.5 Reporter: Martin Balin Assignee: Jaroslav Tulach Fix For: 13.0 VSNetBeans currently detects installation of MS Java ext pack and informs user it will disable some services of it, code lenses and code completion. See [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] {code:javascript} conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, disablingFailed); conf.update('java.debug.settings.enableRunDebugCodeLens', false, false).then(() => {}, disablingFailed); {code} This behaviour should change to better coexist with MS Java ext. VSNetBeans needs to show user a dialog recommending to Enable per workspace one of the Java ext packs. Looking at VSCode API it seems there is still missing API to DISABLE extension programatically, while there is [uninstallExtension|https://code.visualstudio.com/api/references/commands] command? Proposed solution is not perfect: VSNetBeans will show dialog with text like: _Another Java support extension is already installed. It is recommended to use only one Java support per workspace. Please Disable one of Java ext for workspace._ *OK* button to open Extensions panel and user has to do it UX is TBD. Some context info: VSCode plans to stop recommend extensions see [https://github.com/microsoft/vscode/issues/136301] in Feb. And they are also working on extension sets per workspace [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch vsnetbeans_preview_1263 updated: LSP: Change method parameters should refactor access modifier.
This is an automated email from the ASF dual-hosted git repository. dbalek pushed a commit to branch vsnetbeans_preview_1263 in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/vsnetbeans_preview_1263 by this push: new e38a4a3 LSP: Change method parameters should refactor access modifier. e38a4a3 is described below commit e38a4a3e560418b45d0900cae2cfdc4cdd333f8f Author: Dusan Balek AuthorDate: Wed Jan 12 09:44:15 2022 +0100 LSP: Change method parameters should refactor access modifier. --- .../ChangeMethodParametersRefactoring.java | 24 +++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java index 6175429..0e5edc8 100644 --- a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java +++ b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java @@ -25,6 +25,7 @@ import com.sun.source.util.Trees; import java.io.IOException; import java.util.Arrays; import java.util.Collections; +import java.util.HashSet; import java.util.List; import java.util.Set; import java.util.concurrent.CompletableFuture; @@ -208,6 +209,7 @@ public final class ChangeMethodParametersRefactoring extends CodeRefactoring { model.withName(method.getSimpleName().toString()) .withReturnType(Utilities.getTypeName(ci, method.getReturnType(), true).toString()) .withSelectedModifier(mod) + .withIsStatic(method.getModifiers().contains(javax.lang.model.element.Modifier.STATIC)) .withParameters(params) .assignData(client, file, TreePathHandle.from(handle, ClasspathInfo.create(file))); model.applyBindings(); @@ -221,6 +223,7 @@ public final class ChangeMethodParametersRefactoring extends CodeRefactoring { @Model(className = "ChangeMethodParameterUI", targetId = "", instance = true, builder = "with", properties = { @Property(name = "selectedModifier", type = Modifier.class), +@Property(name = "isStatic", type = boolean.class), @Property(name = "name", type = String.class), @Property(name = "returnType", type = String.class), @Property(name = "parameters", type = ParameterUI.class, array = true) @@ -243,6 +246,17 @@ public final class ChangeMethodParametersRefactoring extends CodeRefactoring { void doRefactoring(ChangeMethodParameterUI ui) { try { ChangeParametersRefactoring refactoring = new ChangeParametersRefactoring(handle); +Modifier selectedModifier = ui.getSelectedModifier(); +if (selectedModifier != null) { +Set modifiers = new HashSet<>(1); +switch (selectedModifier) { +case PRIVATE: modifiers.add(javax.lang.model.element.Modifier.PRIVATE);break; +case PACKAGE_PRIVATE: break; /* no modifier */ +case PROTECTED: modifiers.add(javax.lang.model.element.Modifier.PROTECTED); break; +case PUBLIC: modifiers.add(javax.lang.model.element.Modifier.PUBLIC); break; +} +refactoring.setModifiers(modifiers); +} String returnType = ui.getReturnType(); refactoring.setReturnType(returnType.length() > 0 ? returnType : null); List parameters = ui.getParameters(); @@ -310,15 +324,19 @@ public final class ChangeMethodParametersRefactoring extends CodeRefactoring { @ComputedProperty static String preview( -Modifier selectedModifier, String returnType, String name, List parameters +Modifier selectedModifier, boolean isStatic, String returnType, String name, List parameters ) { StringBuilder sb = new StringBuilder(); -sb.append(selectedModifier != null ? selectedModifier.javaName : "").append(" ").append(returnType); +sb.append(selectedModifier != null ? selectedModifier.javaName : "").append(" "); +if (isStatic) { +sb.append("static "); +} +sb.append(returnType); sb.append(" ").append(name).append("("); String sep = ""; for (ParameterUI p : parameters) { sb.append(sep); -sb.append(p.getType()).append(" ").append(p.getName()); +sb.append(p.getType() != null ? p.getType() : "").append(" ").append(p.getName() != null ? p.getName() : ""); sep = ", "; } sb.append(")");