[netbeans] branch master updated: Provide Lambda expression option in Listener generation style.

2023-07-10 Thread mbien
This is an automated email from the ASF dual-hosted git repository.

mbien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 231e2275e0 Provide Lambda expression option in Listener generation 
style.
 new 8b268263d8 Merge pull request #6150 from 
kamilkrzywanski/lambdaListeners
231e2275e0 is described below

commit 231e2275e07ef6b2e9ecf8e00cd8c02d921fdda8
Author: Kamil Krzywanski 
AuthorDate: Tue Jul 4 17:28:34 2023 +0200

Provide Lambda expression option in Listener generation style.

Co-authored-by: Michael Bien 
---
 .../org/netbeans/modules/form/Bundle.properties|   2 +
 .../modules/form/FormEditorCustomizer.java |   2 +-
 .../netbeans/modules/form/JavaCodeGenerator.java   | 164 ++---
 3 files changed, 110 insertions(+), 58 deletions(-)

diff --git a/java/form/src/org/netbeans/modules/form/Bundle.properties 
b/java/form/src/org/netbeans/modules/form/Bundle.properties
index 57914ece61..7dca6e0f7a 100644
--- a/java/form/src/org/netbeans/modules/form/Bundle.properties
+++ b/java/form/src/org/netbeans/modules/form/Bundle.properties
@@ -458,6 +458,7 @@ FMT_MSG_EmptyString=Empty string
 # PARTIAL do not translate TODO
 MSG_EventHandlerBody=// TODO add your handling code here:\n
 
+CTL_LISTENER_LAMBDAS=Lambdas or Anonymous Inner Classes
 CTL_LISTENER_ANONYMOUS_CLASSES=Anonymous Inner Classes
 CTL_LISTENER_CEDL_INNERCLASS=One Inner Class
 CTL_LISTENER_CEDL_MAINCLASS=Main Class
@@ -731,6 +732,7 @@ Public_Modifier=public
 Default_Modifier=
 Protected_Modifier=protected
 Private_Modifier=private
+Lambdas=Lambdas or Anonymous Inner Classes
 Anonymous=Anonymous Inner Classes
 InnerClass=One Inner Class
 MainClass=Main Class
diff --git a/java/form/src/org/netbeans/modules/form/FormEditorCustomizer.java 
b/java/form/src/org/netbeans/modules/form/FormEditorCustomizer.java
index 1c48e4533c..b655a22e36 100644
--- a/java/form/src/org/netbeans/modules/form/FormEditorCustomizer.java
+++ b/java/form/src/org/netbeans/modules/form/FormEditorCustomizer.java
@@ -27,7 +27,6 @@ import java.beans.PropertyEditor;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Modifier;
 import java.util.HashSet;
-import java.util.MissingResourceException;
 import java.util.Set;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -94,6 +93,7 @@ public final class FormEditorCustomizer extends JPanel 
implements  ActionListene
 cbListenerStyle.addItem(loc("Anonymous")); // NOI18N
 cbListenerStyle.addItem(loc("InnerClass")); // NOI18N
 cbListenerStyle.addItem(loc("MainClass")); // NOI18N
+cbListenerStyle.addItem(loc("Lambdas")); // NOI18N
 cbAutoI18n.addItem(loc("CTL_AUTO_RESOURCE_DEFAULT")); // NOI18N
 cbAutoI18n.addItem(loc("CTL_AUTO_RESOURCE_ON")); // NOI18N
 cbAutoI18n.addItem(loc("CTL_AUTO_RESOURCE_OFF")); // NOI18N
diff --git a/java/form/src/org/netbeans/modules/form/JavaCodeGenerator.java 
b/java/form/src/org/netbeans/modules/form/JavaCodeGenerator.java
index 4496933c5a..e36afba067 100644
--- a/java/form/src/org/netbeans/modules/form/JavaCodeGenerator.java
+++ b/java/form/src/org/netbeans/modules/form/JavaCodeGenerator.java
@@ -84,6 +84,7 @@ class JavaCodeGenerator extends CodeGenerator {
 static final String PROP_DECLARATION_PRE = "declarationPre"; // NOI18N
 static final String PROP_DECLARATION_POST = "declarationPost"; // NOI18N
 static final String PROP_GENERATE_MNEMONICS = "generateMnemonicsCode"; // 
Mnemonics support // NOI18N
+static final String PROP_GENERATE_LAMBDA_LISTENERS = 
"generateLambdaListeners"; // Mnemonics support // NOI18N
 static final String PROP_LISTENER_GENERATION_STYLE = 
"listenerGenerationStyle"; // NOI18N
 
 static final String AUX_VARIABLE_MODIFIER =
@@ -130,6 +131,7 @@ class JavaCodeGenerator extends CodeGenerator {
 static final int ANONYMOUS_INNERCLASSES = 0;
 static final int CEDL_INNERCLASS = 1;
 static final int CEDL_MAINCLASS = 2;
+static final int LAMBDAS = 3;
 
 // types of code generation of layout code
 static final int LAYOUT_CODE_AUTO = 0;
@@ -2432,15 +2434,16 @@ class JavaCodeGenerator extends CodeGenerator {
 lastEventSetDesc = eventSetDesc;
 }
 
-if (defaultMode != ANONYMOUS_INNERCLASSES)
+if (defaultMode != ANONYMOUS_INNERCLASSES && defaultMode != 
LAMBDAS) {
 if (mode == defaultMode) {
 if (!event.isInCEDL())
 mode = ANONYMOUS_INNERCLASSES;
-}
-else if (event.isInCEDL())
+} else if (event.isInCEDL()) {
 mixedMode = true;
+}
+}
 
-if (defaultMode == ANONYMOUS_INNERCLASSES || !event.isInCEDL()) {
+if (defaultMode == ANONYMOUS_INNERCLASSES || 

[netbeans] branch master updated: Fix a 'Cannot call invokeAndWait from the event dispatcher thread' exception when calling DatabaseConnection.showConnectionDialog from the EDT.

2023-07-10 Thread ebakke
This is an automated email from the ASF dual-hosted git repository.

ebakke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new cadff49dc7 Fix a 'Cannot call invokeAndWait from the event dispatcher 
thread' exception when calling DatabaseConnection.showConnectionDialog from the 
EDT.
cadff49dc7 is described below

commit cadff49dc7447058ca164a9b3d05107c5e02c8cd
Author: Eirik Bakke 
AuthorDate: Mon Jun 5 19:14:39 2023 -0400

Fix a 'Cannot call invokeAndWait from the event dispatcher thread' 
exception when calling DatabaseConnection.showConnectionDialog from the EDT.
---
 .../modules/db/explorer/action/ConnectAction.java  | 37 ++
 1 file changed, 17 insertions(+), 20 deletions(-)

diff --git 
a/ide/db/src/org/netbeans/modules/db/explorer/action/ConnectAction.java 
b/ide/db/src/org/netbeans/modules/db/explorer/action/ConnectAction.java
index bbe0f41327..ffe4ca8c53 100644
--- a/ide/db/src/org/netbeans/modules/db/explorer/action/ConnectAction.java
+++ b/ide/db/src/org/netbeans/modules/db/explorer/action/ConnectAction.java
@@ -223,27 +223,24 @@ public class ConnectAction extends AbstractAction 
implements ContextAwareAction,
 
 dbcon.addPropertyChangeListener(connectionListener);
 
-try {
-if (headless) {
-connectWithNewInfo(dbcon, input);
-} else {
-ActionListener actionListener = new ActionListener() {
-@Override
-public void actionPerformed(ActionEvent event) {
-if (event.getSource() == 
DialogDescriptor.OK_OPTION) {
-connectWithNewInfo(dbcon, input);
-}
+if (headless) {
+connectWithNewInfo(dbcon, input);
+} else {
+ActionListener actionListener = new ActionListener() {
+@Override
+public void actionPerformed(ActionEvent event) {
+if (event.getSource() == 
DialogDescriptor.OK_OPTION) {
+connectWithNewInfo(dbcon, input);
 }
-};
-
-SwingUtilities.invokeAndWait(() -> {
-ConnectPanel basePanel = input.getConnectPanel();
-dlg = new ConnectionDialog(this, basePanel, 
basePanel.getTitle(), CONNECT_ACTION_HELPCTX, actionListener);
-dlg.setVisible(true);
-});
-}
-} catch (InterruptedException | InvocationTargetException ex) {
-Exceptions.printStackTrace(ex);
+}
+};
+
+Mutex.EVENT.writeAccess((Mutex.Action) () -> {
+ConnectPanel basePanel = input.getConnectPanel();
+dlg = new ConnectionDialog(this, basePanel, 
basePanel.getTitle(), CONNECT_ACTION_HELPCTX, actionListener);
+dlg.setVisible(true);
+return null;
+});
 }
 dbcon.removeExceptionListener(excListener);
 } else { // without dialog with connection data (username, 
password), just with progress dlg


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans-nbpackage] branch master updated: Provide arch option for macOS launcher, or attempt to parse from runtime filename when present.

2023-07-10 Thread neilcsmith
This is an automated email from the ASF dual-hosted git repository.

neilcsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans-nbpackage.git


The following commit(s) were added to refs/heads/master by this push:
 new 7fc49b0  Provide arch option for macOS launcher, or attempt to parse 
from runtime filename when present.
 new 8e0f109  Merge pull request #32 from neilcsmith-net/macos-arch
7fc49b0 is described below

commit 7fc49b0531df8604e08b7e0eda04da6cf7fa914d
Author: Neil C Smith 
AuthorDate: Fri Jun 30 17:35:25 2023 +0100

Provide arch option for macOS launcher, or attempt to parse from runtime 
filename when present.
---
 .../netbeans/nbpackage/macos/AppBundleTask.java| 73 +-
 .../org/apache/netbeans/nbpackage/macos/MacOS.java |  8 +++
 .../netbeans/nbpackage/macos/PkgPackager.java  |  1 +
 .../netbeans/nbpackage/macos/Messages.properties   |  2 +
 .../nbpackage/macos/Package.swift.template |  4 +-
 5 files changed, 71 insertions(+), 17 deletions(-)

diff --git 
a/src/main/java/org/apache/netbeans/nbpackage/macos/AppBundleTask.java 
b/src/main/java/org/apache/netbeans/nbpackage/macos/AppBundleTask.java
index 560a5b6..ef79f6c 100644
--- a/src/main/java/org/apache/netbeans/nbpackage/macos/AppBundleTask.java
+++ b/src/main/java/org/apache/netbeans/nbpackage/macos/AppBundleTask.java
@@ -26,6 +26,7 @@ import java.nio.file.StandardOpenOption;
 import java.text.MessageFormat;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.stream.Collectors;
 import org.apache.netbeans.nbpackage.AbstractPackagerTask;
@@ -44,6 +45,9 @@ class AppBundleTask extends AbstractPackagerTask {
 private static final String JAR_BIN_FILENAME = "jarBinaries";
 private static final String ENTITLEMENTS_FILENAME = "sandbox.plist";
 private static final String LAUNCHER_SRC_DIRNAME = "macos-launcher-src";
+private static final String ARCH_X86_64 = "x86_64";
+private static final String ARCH_ARM64 = "arm64";
+private static final String ARCH_UNIVERSAL = "universal";
 
 private String bundleName;
 
@@ -55,9 +59,9 @@ class AppBundleTask extends AbstractPackagerTask {
 protected void checkPackageRequirements() throws Exception {
 String[] cmds;
 if (context().getValue(MacOS.CODESIGN_ID).isEmpty()) {
-cmds = new String[] {"swift"};
+cmds = new String[]{"swift"};
 } else {
-cmds = new String[] {"swift", "codesign"};
+cmds = new String[]{"swift", "codesign"};
 }
 validateTools(cmds);
 }
@@ -94,7 +98,8 @@ class AppBundleTask extends AbstractPackagerTask {
 .findFirst()
 .map(path -> path.getFileName().toString())
 .orElseThrow();
-Path launcher = compileLauncher(image.resolve(LAUNCHER_SRC_DIRNAME));
+String arch = findArch();
+Path launcher = compileLauncher(image.resolve(LAUNCHER_SRC_DIRNAME), 
arch);
 Files.copy(launcher, bundle.resolve("Contents")
 .resolve("MacOS").resolve(execName),
 StandardCopyOption.COPY_ATTRIBUTES);
@@ -172,7 +177,7 @@ class AppBundleTask extends AbstractPackagerTask {
 }
 
 private Path findLauncher(Path binDir) throws IOException {
-try ( var files = Files.list(binDir)) {
+try (var files = Files.list(binDir)) {
 return files.filter(f -> 
!f.getFileName().toString().endsWith(".exe"))
 .findFirst().orElseThrow(IOException::new);
 }
@@ -226,8 +231,8 @@ class AppBundleTask extends AbstractPackagerTask {
 
 private void setupSigningConfiguration(Path image, Path bundle) throws 
IOException {
 Files.writeString(image.resolve(ENTITLEMENTS_FILENAME),
-MacOS.ENTITLEMENTS_TEMPLATE.load(context())
-, StandardOpenOption.CREATE_NEW);
+MacOS.ENTITLEMENTS_TEMPLATE.load(context()),
+ StandardOpenOption.CREATE_NEW);
 var nativeBinaries = FileUtils.find(bundle,
 context().getValue(MacOS.SIGNING_FILES).orElseThrow());
 Files.writeString(image.resolve(NATIVE_BIN_FILENAME),
@@ -246,17 +251,55 @@ class AppBundleTask extends AbstractPackagerTask {
 StandardOpenOption.CREATE_NEW);
 }
 
-private Path compileLauncher(Path launcherProject) throws IOException, 
InterruptedException {
-var pb = new ProcessBuilder("swift", "build",
-"--configuration", "release",
-"--arch", "x86_64");
+private Path compileLauncher(Path launcherProject, String arch) throws 
IOException, InterruptedException {
+final ProcessBuilder pb;
+switch (arch) {
+case ARCH_X86_64:
+pb = new ProcessBuilder("swift", "build",
+"--configuration", "release",
+"--arch", 

[jira] [Closed] (NETBEANS-4693) Maven project not supporting internal records with nb-javac

2023-07-10 Thread Michael Bien (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bien closed NETBEANS-4693.
--
Resolution: Fixed

should be closed since records work fine by now

> Maven project not supporting internal records with nb-javac
> ---
>
> Key: NETBEANS-4693
> URL: https://issues.apache.org/jira/browse/NETBEANS-4693
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Akshay Gupta
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Maven based project keeps throwing exception for code which contains records 
> inside any class with some parameters.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-6050) java.lang.NoSuchMethodError: java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;

2023-07-10 Thread Michael Bien (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bien closed NETBEANS-6050.
--
Fix Version/s: 13
   Resolution: Fixed

duplicate of https://issues.apache.org/jira/browse/NETBEANS-6285

> java.lang.NoSuchMethodError: java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
> 
>
> Key: NETBEANS-6050
> URL: https://issues.apache.org/jira/browse/NETBEANS-6050
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Formatting  Indentation
>Affects Versions: 12.5
> Environment: OS: Linux 5.11.0-36-generic #40-Ubuntu SMP Fri Sep 17 
> 18:15:22 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> NetBeans: 12.5 installed from the SNAP store
> JDK:
> openjdk version "1.8.0_292"
> OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0ubuntu1-b10)
> OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode)
>Reporter: Pierpaolo Vittorini
>Priority: Major
> Fix For: 13
>
> Attachments: UI.log, message.log, messages.log
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> While writing code, pressing Return causes the error, and no indentation is 
> applied. The problem is present only in the SNAP version of Netbeans 12.5. 
> The binary and source (recompiled) versions works correctly.
> The exception seems to be related to compilation with JDK>=9, while NB should 
> work also on JDK1.8 (the JDK version I am using).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-6388) Source->Inspect no longer works

2023-07-10 Thread Michael Bien (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Bien closed NETBEANS-6388.
--
Fix Version/s: 13
   Resolution: Fixed

should be fixed since [https://github.com/apache/netbeans/pull/3455]

> Source->Inspect no longer works
> ---
>
> Key: NETBEANS-6388
> URL: https://issues.apache.org/jira/browse/NETBEANS-6388
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 12.6
> Environment: macOS Monterey.  Running NB 12.6 with Java 17.
>Reporter: Thomas Wolf
>Priority: Major
>  Labels: pull-request-available
> Fix For: 13
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> It appears that the deprecated FindBugs plugin support is causing the rest of 
> Source->Inspect not to work either.   Very easy to reproduce.
> When I try to define a configuration via the Source-Inspect… dialog, it lets 
> me define it and hit the “Inspect” button, but the results tab simply shows 
> “Required Plugin Missing” even when the configuration I’ve defined and run 
> uses the built-in “Netbeans Java Hints".  As a matter of fact, you don’t even 
> have to define a configuration - just select the “Default” one - which uses 
> the “Netbeans Java Hints” analyzer from the drop-down and hit “Inspect”.  
> You’ll still see (at least I do) the result of “Required Plugin Missing”.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated (3a61869b00 -> 68be4fcc5d)

2023-07-10 Thread neilcsmith
This is an automated email from the ASF dual-hosted git repository.

neilcsmith pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


from 3a61869b00 Merge pull request #6171 from 
junichi11/php-gh-6119-incorrect-abstract-instantiation-hint
 new fed49d82a2 Fix FlatEditorTabCellRenderer to not return close button 
bounds when clipped and not painting it.
 new 8b712913e3 Fix WinFlatEditorTabCellRenderer to not return close button 
bounds when clipped and not painting it.
 new 68be4fcc5d Merge pull request #6164 from 
neilcsmith-net/flatlaf-tab-close

The 8798 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java| 2 +-
 .../netbeans/swing/tabcontrol/plaf/WinFlatEditorTabCellRenderer.java| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: Fix incorrect AbstractClassInstantiationHintError #6119

2023-07-10 Thread junichi11
This is an automated email from the ASF dual-hosted git repository.

junichi11 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new e8bf72eec6 Fix incorrect AbstractClassInstantiationHintError #6119
 new 3a61869b00 Merge pull request #6171 from 
junichi11/php-gh-6119-incorrect-abstract-instantiation-hint
e8bf72eec6 is described below

commit e8bf72eec654d4fb46d3eca1a255ab3b2ece4c28
Author: Junichi Yamamoto 
AuthorDate: Mon Jul 10 00:09:29 2023 +0900

Fix incorrect AbstractClassInstantiationHintError #6119

- https://github.com/apache/netbeans/issues/6119
- Check whether the class name has `$`
- Add unit tests
---
 .../org/netbeans/modules/php/editor/CodeUtils.java |  9 +
 .../AbstractClassInstantiationHintError.java   | 12 --
 .../AbstractClassInstantiationHint/gh6119.php  | 23 +++
 .../gh6119.php.testGH6119.hints|  1 +
 .../testAbstractClassInstantiationHint.php |  0
 ...nt.php.testAbstractClassInstantiationHint.hints |  0
 .../testAbstractClassInstantiationHint_02.php  |  0
 ...php.testAbstractClassInstantiationHint_02.hints |  0
 .../AbstractClassInstantiationHintErrorTest.java   | 47 ++
 .../modules/php/editor/verification/HintsTest.java |  8 
 10 files changed, 89 insertions(+), 11 deletions(-)

diff --git a/php/php.editor/src/org/netbeans/modules/php/editor/CodeUtils.java 
b/php/php.editor/src/org/netbeans/modules/php/editor/CodeUtils.java
index fcc307ef31..d87712a333 100644
--- a/php/php.editor/src/org/netbeans/modules/php/editor/CodeUtils.java
+++ b/php/php.editor/src/org/netbeans/modules/php/editor/CodeUtils.java
@@ -690,6 +690,15 @@ public final class CodeUtils {
 return "__construct".equals(extractMethodName(node)); //NOI18N
 }
 
+public static boolean isDollaredName(ClassName className) {
+Expression name = className.getName();
+if (name instanceof Variable) {
+Variable variable = (Variable) name;
+return variable.isDollared();
+}
+return false;
+}
+
 /**
  * Finds common namespace prefixes for the given sorted namespaces.
  * 
diff --git 
a/php/php.editor/src/org/netbeans/modules/php/editor/verification/AbstractClassInstantiationHintError.java
 
b/php/php.editor/src/org/netbeans/modules/php/editor/verification/AbstractClassInstantiationHintError.java
index f1d3dcc389..375807bed5 100644
--- 
a/php/php.editor/src/org/netbeans/modules/php/editor/verification/AbstractClassInstantiationHintError.java
+++ 
b/php/php.editor/src/org/netbeans/modules/php/editor/verification/AbstractClassInstantiationHintError.java
@@ -19,11 +19,13 @@
 package org.netbeans.modules.php.editor.verification;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Set;
 import org.netbeans.modules.csl.api.Hint;
 import org.netbeans.modules.csl.api.OffsetRange;
 import org.netbeans.modules.csl.spi.support.CancelSupport;
+import org.netbeans.modules.php.editor.CodeUtils;
 import org.netbeans.modules.php.editor.api.ElementQuery.Index;
 import org.netbeans.modules.php.editor.api.NameKind;
 import org.netbeans.modules.php.editor.api.QualifiedName;
@@ -79,7 +81,7 @@ public class AbstractClassInstantiationHintError extends 
HintErrorRule {
 }
 
 public List getHints() {
-return hints;
+return Collections.unmodifiableList(hints);
 }
 
 @Override
@@ -88,7 +90,12 @@ public class AbstractClassInstantiationHintError extends 
HintErrorRule {
 "AbstractClassInstantiationDesc=Abstract class {0} can not be 
instantiated"
 })
 public void visit(ClassInstanceCreation node) {
-if (CancelSupport.getDefault().isCancelled()) {
+if (CancelSupport.getDefault().isCancelled()
+|| CodeUtils.isDollaredName(node.getClassName())) {
+// GH-6119
+// e.g.
+// abstract class AbstractClass {}
+// $a = new $abstractClass();
 return;
 }
 ASTNodeInfo info = ASTNodeInfo.create(node);
@@ -110,7 +117,6 @@ public class AbstractClassInstantiationHintError extends 
HintErrorRule {
 }
 }
 }
-
 }
 
 @Override
diff --git 
a/php/php.editor/test/unit/data/testfiles/verification/AbstractClassInstantiationHint/gh6119.php
 
b/php/php.editor/test/unit/data/testfiles/verification/AbstractClassInstantiationHint/gh6119.php
new file mode 100644
index 00..105ae28aa9
--- /dev/null
+++ 
b/php/php.editor/test/unit/data/testfiles/verification/AbstractClassInstantiationHint/gh6119.php
@@ -0,0 +1,23 @@
+http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the 

[netbeans-jenkins-lib] branch master updated: parent pom v4

2023-07-10 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans-jenkins-lib.git


The following commit(s) were added to refs/heads/master by this push:
 new 010136d  parent pom v4
010136d is described below

commit 010136d39d71c1ad7e16eb6a907883d02fd2eccb
Author: Eric Barboni 
AuthorDate: Mon Jul 10 13:42:57 2023 +0200

parent pom v4
---
 vars/asfMainNetBeansBuild.groovy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/vars/asfMainNetBeansBuild.groovy b/vars/asfMainNetBeansBuild.groovy
index f5ac699..eb39e7a 100644
--- a/vars/asfMainNetBeansBuild.groovy
+++ b/vars/asfMainNetBeansBuild.groovy
@@ -197,7 +197,7 @@ def call(Map params = [:]) {
 sh "mvn 
org.apache.maven.plugins:maven-dependency-plugin:3.5.0:get 
-Dartifact=org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}
 
-DremoteRepositories=apache.snapshots.httpshttps://repository.apache.org/snapshots;
 
 //sh "mvn 
org.apache.netbeans.utilities:nb-repository-plugin:1.5:download 
-DnexusIndexDirectory=${env.WORKSPACE}/repoindex 
-DrepositoryUrl=https://repo.maven.apache.org/maven2;
-sh "mvn 
org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}:populate
 ${commonparam} -DnetbeansNbmDirectory=${netbeansbase}/nbms 
-DnetbeansInstallDirectory=${netbeansbase}/netbeans 
-DnetbeansSourcesDirectory=${netbeansbase}/build/source-zips 
-DnetbeansJavadocDirectory=${netbeansbase}/build/javadoc 
-DparentGAV=org.apache.netbeans:netbeans-parent:3 
-DforcedVersion=${mavenVersion} -DskipInstall=true 
-DdeployId=apache.snapshots.https [...]
+sh "mvn 
org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}:populate
 ${commonparam} -DnetbeansNbmDirectory=${netbeansbase}/nbms 
-DnetbeansInstallDirectory=${netbeansbase}/netbeans 
-DnetbeansSourcesDirectory=${netbeansbase}/build/source-zips 
-DnetbeansJavadocDirectory=${netbeansbase}/build/javadoc 
-DparentGAV=org.apache.netbeans:netbeans-parent:4 
-DforcedVersion=${mavenVersion} -DskipInstall=true 
-DdeployId=apache.snapshots.https [...]
 }
 }
 }
@@ -425,7 +425,7 @@ def doParallelClusters(cconfigs) {
 def commonparam = 
"-Dexternallist=${netbeansbase}/build/external.info"
 //sh "mvn 
org.apache.netbeans.utilities:nb-repository-plugin:1.5:download ${commonparam} 
-DrepositoryUrl=https://repo.maven.apache.org/maven2;
 if (heavyrelease) { // skip mavenrepo 
for vscode
-sh "mvn 
org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}:populate
 ${commonparam} -DnetbeansNbmDirectory=${netbeansbase}/nbms 
-DnetbeansInstallDirectory=${netbeansbase}/netbeans 
-DnetbeansSourcesDirectory=${netbeansbase}/build/source-zips 
-DnetbeansJavadocDirectory=${netbeansbase}/build/javadoc 
-DparentGAV=org.apache.netbeans:netbeans-parent:3 
-DforcedVersion=${mavenVersion} -DskipInstall=true 
-DdeployUrl=file://${env.WORK [...]
+sh "mvn 
org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}:populate
 ${commonparam} -DnetbeansNbmDirectory=${netbeansbase}/nbms 
-DnetbeansInstallDirectory=${netbeansbase}/netbeans 
-DnetbeansSourcesDirectory=${netbeansbase}/build/source-zips 
-DnetbeansJavadocDirectory=${netbeansbase}/build/javadoc 
-DparentGAV=org.apache.netbeans:netbeans-parent:4 
-DforcedVersion=${mavenVersion} -DskipInstall=true 
-DdeployUrl=file://${env.WORK [...]
 zip 
zipFile:'mavenrepo.zip',dir:'mavenrepository',archive:'true'
 }
 // make vsix available to dist to 
pickup (only for main release) need a maven setup


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans-mavenutils-nbm-maven-plugin] branch master updated (a336109 -> 345c2e3)

2023-07-10 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a change to branch master
in repository 
https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-plugin.git


from a336109  correct label
 add 345c2e3  netbeans parent v4

No new revisions were added by this update.

Summary of changes:
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans-mavenutils-archetypes] branch master updated: parent pom v4

2023-07-10 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/netbeans-mavenutils-archetypes.git


The following commit(s) were added to refs/heads/master by this push:
 new 338c9bf  parent pom v4
338c9bf is described below

commit 338c9bf034a5fdf50b5f532e06eb9ab85e112fc2
Author: Eric Barboni 
AuthorDate: Mon Jul 10 13:41:27 2023 +0200

parent pom v4
---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 8b2162f..4d3b33a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -24,7 +24,7 @@ under the License.
 
 org.apache.netbeans
 netbeans-parent
-3
+4
 
 org.apache.netbeans.archetypes
 netbeans-archetype-parent


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: Add @asbachb to collaborator/triage list.

2023-07-10 Thread mbien
This is an automated email from the ASF dual-hosted git repository.

mbien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new bbd08b8fdd Add @asbachb to collaborator/triage list.
 new 4550e47e64 Merge pull request #6167 from mbien/nb-collaborators
bbd08b8fdd is described below

commit bbd08b8fdd63315194eb3b6b749453209d6b887d
Author: Michael Bien 
AuthorDate: Sat Jul 8 18:40:32 2023 +0200

Add @asbachb to collaborator/triage list.
---
 .asf.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.asf.yaml b/.asf.yaml
index acf7b7bf61..7de5d71c5c 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -36,6 +36,8 @@ github:
   protected_branches:
 # no force push to master
 master: {}
+  collaborators:
+- asbachb
 
 notifications:
 commits:  commits@netbeans.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



svn commit: r62906 - /dev/netbeans/netbeans-parent/netbeans-parent-4/ /release/netbeans/netbeans-parent/netbeans-parent-3/ /release/netbeans/netbeans-parent/netbeans-parent-4/

2023-07-10 Thread skygo
Author: skygo
Date: Mon Jul 10 08:43:56 2023
New Revision: 62906

Log:
release Apache NetBeans parent pom 4

Added:
release/netbeans/netbeans-parent/netbeans-parent-4/
  - copied from r62905, dev/netbeans/netbeans-parent/netbeans-parent-4/
Removed:
dev/netbeans/netbeans-parent/netbeans-parent-4/
release/netbeans/netbeans-parent/netbeans-parent-3/


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists