[jira] [Commented] (NETBEANS-5055) NetBeans 12.2 doesn't permit "permits" as identifier

2020-11-23 Thread Jeffrey Morlan (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237786#comment-17237786
 ] 

Jeffrey Morlan commented on NETBEANS-5055:
--

In JDK 15 "permits" is an identifier token and is only treated specially in a 
class declaration; nb-javac instead made it a full fledged new token type in 
com.sun.tools.javac.parser.Tokens

> NetBeans 12.2 doesn't permit "permits" as identifier
> 
>
> Key: NETBEANS-5055
> URL: https://issues.apache.org/jira/browse/NETBEANS-5055
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 12.2
>Reporter: Jeffrey Morlan
>Priority: Major
>
> The following valid Java code fails to parse in 12.2-vc2:
> class MySemaphore {
> MySemaphore(int permits) {}
> }
> May be related to the "Sealed Classes" preview feature which uses a "permits" 
> pseudo-keyword, but it should still be allowed as a variable name (JDK 15 
> javac has no problem with it even with --enable-preview).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-5055) NetBeans 12.2 doesn't permit "permits" as identifier

2020-11-23 Thread Jeffrey Morlan (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan updated NETBEANS-5055:
-
Summary: NetBeans 12.2 doesn't permit "permits" as identifier  (was: 
NetBeans 12.2 doesn't permit "permits" as parameter name)

> NetBeans 12.2 doesn't permit "permits" as identifier
> 
>
> Key: NETBEANS-5055
> URL: https://issues.apache.org/jira/browse/NETBEANS-5055
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 12.2
>Reporter: Jeffrey Morlan
>Priority: Major
>
> The following valid Java code fails to parse in 12.2-vc2:
> class MySemaphore {
> MySemaphore(int permits) {}
> }
> May be related to the "Sealed Classes" preview feature which uses a "permits" 
> pseudo-keyword, but it should still be allowed as a variable name (JDK 15 
> javac has no problem with it even with --enable-preview).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-5055) NetBeans 12.2 doesn't permit "permits" as parameter name

2020-11-23 Thread Jeffrey Morlan (Jira)
Jeffrey Morlan created NETBEANS-5055:


 Summary: NetBeans 12.2 doesn't permit "permits" as parameter name
 Key: NETBEANS-5055
 URL: https://issues.apache.org/jira/browse/NETBEANS-5055
 Project: NetBeans
  Issue Type: Bug
  Components: java - Compiler
Affects Versions: 12.2
Reporter: Jeffrey Morlan


The following valid Java code fails to parse in 12.2-vc2:
class MySemaphore {
MySemaphore(int permits) {}
}

May be related to the "Sealed Classes" preview feature which uses a "permits" 
pseudo-keyword, but it should still be allowed as a variable name (JDK 15 javac 
has no problem with it even with --enable-preview).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-1781) can't open classes in binary .jar (java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be cast to com.sun.tools.javac.code.Type$ErrorType)

2019-12-02 Thread Jeffrey Morlan (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan closed NETBEANS-1781.

Resolution: Duplicate

> can't open classes in binary .jar (java.lang.ClassCastException: 
> com.sun.tools.javac.code.Type$ClassType cannot be cast to 
> com.sun.tools.javac.code.Type$ErrorType)
> ---
>
> Key: NETBEANS-1781
> URL: https://issues.apache.org/jira/browse/NETBEANS-1781
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Affects Versions: 10.0
>Reporter: Jeffrey Morlan
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> After updating to nb-javac 1.51, when I try to open a class in a binary .jar 
> file, it often fails with an exception like this
> java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot 
> be cast to com.sun.tools.javac.code.Type$ErrorType
>      at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:797)
>      at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
>      at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitExecutable(CodeGenerator.java:549)
>      ...
> This happens whenever the class references a class in a different .jar. For 
> example, create a maven project, add org.apache.httpcomponents:httpclient 
> (but don't download source!) and open the HttpClient class - it fails because 
> of the various classes referenced from the httpcore dependency.
> It looks like this started once 
> [http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20|http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20#l9.1]
>  was merged into nb-javac - TreeFactory's assumption that getKind()==ERROR 
> implies ErrorType is no longer true.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-936) In Maven project depending on Guava, viewing Guava's source files is slow

2019-09-13 Thread Jeffrey Morlan (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929395#comment-16929395
 ] 

Jeffrey Morlan commented on NETBEANS-936:
-

Seems to be fixed - I could reproduce this in 11.0 but not in 11.1.

> In Maven project depending on Guava, viewing Guava's source files is slow
> -
>
> Key: NETBEANS-936
> URL: https://issues.apache.org/jira/browse/NETBEANS-936
> Project: NetBeans
>  Issue Type: Bug
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Priority: Major
>
> * Have the JDK's src.zip installed
>  * Create a Maven project
>  * Add Guava as a dependency (com.google.guava:guava, latest version 25.1-jre)
>  * "Download Sources" for the Guava dependency
>  * Try to open any Guava class
> It will take ~10 seconds to parse, sometimes hanging the UI. Somehow NetBeans 
> 9 is ending up parsing hundreds of src.zip files along with it. This did not 
> happen in NetBeans 8.2.
> Guava has a "${java.home}/../src.zip" dependency in 
> its pom.xml, which may be related.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2980) NPE when opening file

2019-09-09 Thread Jeffrey Morlan (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926106#comment-16926106
 ] 

Jeffrey Morlan commented on NETBEANS-2980:
--

The PR did not fix this bug - in the latest development build I still get an 
NPE, just further down in the resolveImport method:

java.lang.NullPointerException
at 
org.netbeans.modules.java.source.pretty.ImportAnalysis2.resolveImport(ImportAnalysis2.java:351)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:475)
at 
org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:74)
at 
com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2203)


> NPE when opening file
> -
>
> Key: NETBEANS-2980
> URL: https://issues.apache.org/jira/browse/NETBEANS-2980
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.1
>Reporter: Shevek
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Open a project.
> Don't have the dependent project(s) open.
> Press ^1, ^O, type a class name.
> Get this:
> java.lang.NullPointerException
>   at 
> org.netbeans.modules.java.source.pretty.ImportAnalysis2.getPackageOf(ImportAnalysis2.java:393)
>   at 
> org.netbeans.modules.java.source.pretty.ImportAnalysis2.resolveImport(ImportAnalysis2.java:310)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:475)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitMemberSelect(ImmutableTreeTranslator.java:74)
>   at 
> com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2203)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translateClassRef(ImmutableTreeTranslator.java:135)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translateClassRef(ImmutableTreeTranslator.java:144)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.rewriteChildren(ImmutableTreeTranslator.java:595)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitClass(ImmutableTreeTranslator.java:335)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitClass(ImmutableTreeTranslator.java:74)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:818)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:198)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.rewriteChildren(ImmutableTreeTranslator.java:545)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitCompilationUnit(ImmutableTreeTranslator.java:322)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.visitCompilationUnit(ImmutableTreeTranslator.java:74)
>   at 
> com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:599)
>   at 
> org.netbeans.modules.java.source.transform.ImmutableTreeTranslator.translate(ImmutableTreeTranslator.java:123)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:871)
>   at 
> org.netbeans.api.java.source.WorkingCopy$5.translate(WorkingCopy.java:867)
>   at 
> org.netbeans.api.java.source.WorkingCopy.processCurrentCompilationUnit(WorkingCopy.java:899)
>   at 
> org.netbeans.api.java.source.WorkingCopy.getChanges(WorkingCopy.java:1326)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:676)
>   at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:663)
>   at 
> org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:502)
>   at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
>   at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
>   at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
>   at 
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
>   at 
> 

[jira] [Updated] (NETBEANS-1781) can't open classes in binary .jar (java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be cast to com.sun.tools.javac.code.Type$ErrorType)

2018-12-05 Thread Jeffrey Morlan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan updated NETBEANS-1781:
-
Description: 
After updating to nb-javac 1.51, when I try to open a class in a binary .jar 
file, it often fails with an exception like this

java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be 
cast to com.sun.tools.javac.code.Type$ErrorType
     at 
org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:797)
     at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
     at 
org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitExecutable(CodeGenerator.java:549)
     ...

This happens whenever the class references a class in a different .jar. For 
example, create a maven project, add org.apache.httpcomponents:httpclient (but 
don't download source!) and open the HttpClient class - it fails because of the 
various classes referenced from the httpcore dependency.

It looks like this started once 
[http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20|http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20#l9.1]
 was merged into nb-javac - TreeFactory's assumption that getKind()==ERROR 
implies ErrorType is no longer true.

  was:
After updating to nb-javac 1.51, when I try to open a class in a binary .jar 
file, it often fails with an exception like this

java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be 
cast to com.sun.tools.javac.code.Type$ErrorType
     at 
org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:797)
     at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
     at 
org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitExecutable(CodeGenerator.java:549)
     ...

This happens whenever the class references a class in a different .jar. For 
example, create a maven project, add org.apache.httpcomponents:httpclient (but 
don't download source!) and open the HttpClient class - it fails because of the 
various classes referenced from the httpcore dependency.

It looks like this started once 
[http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20#l9.1|http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20,]
 was merged into nb-javac - TreeFactory's assumption that getKind()==ERROR 
implies ErrorType is no longer true.


> can't open classes in binary .jar (java.lang.ClassCastException: 
> com.sun.tools.javac.code.Type$ClassType cannot be cast to 
> com.sun.tools.javac.code.Type$ErrorType)
> ---
>
> Key: NETBEANS-1781
> URL: https://issues.apache.org/jira/browse/NETBEANS-1781
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Source
>Affects Versions: 10.0
>Reporter: Jeffrey Morlan
>Priority: Major
>
> After updating to nb-javac 1.51, when I try to open a class in a binary .jar 
> file, it often fails with an exception like this
> java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot 
> be cast to com.sun.tools.javac.code.Type$ErrorType
>      at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:797)
>      at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
>      at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitExecutable(CodeGenerator.java:549)
>      ...
> This happens whenever the class references a class in a different .jar. For 
> example, create a maven project, add org.apache.httpcomponents:httpclient 
> (but don't download source!) and open the HttpClient class - it fails because 
> of the various classes referenced from the httpcore dependency.
> It looks like this started once 
> [http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20|http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20#l9.1]
>  was merged into nb-javac - TreeFactory's assumption that getKind()==ERROR 
> implies ErrorType is no longer true.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-1781) can't open classes in binary .jar (java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be cast to com.sun.tools.javac.code.Type$ErrorType)

2018-12-05 Thread Jeffrey Morlan (JIRA)
Jeffrey Morlan created NETBEANS-1781:


 Summary: can't open classes in binary .jar 
(java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot 
be cast to com.sun.tools.javac.code.Type$ErrorType)
 Key: NETBEANS-1781
 URL: https://issues.apache.org/jira/browse/NETBEANS-1781
 Project: NetBeans
  Issue Type: Bug
  Components: java - Source
Affects Versions: 10.0
Reporter: Jeffrey Morlan


After updating to nb-javac 1.51, when I try to open a class in a binary .jar 
file, it often fails with an exception like this

java.lang.ClassCastException: com.sun.tools.javac.code.Type$ClassType cannot be 
cast to com.sun.tools.javac.code.Type$ErrorType
     at 
org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:797)
     at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
     at 
org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitExecutable(CodeGenerator.java:549)
     ...

This happens whenever the class references a class in a different .jar. For 
example, create a maven project, add org.apache.httpcomponents:httpclient (but 
don't download source!) and open the HttpClient class - it fails because of the 
various classes referenced from the httpcore dependency.

It looks like this started once 
[http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20#l9.1|http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20,]
 was merged into nb-javac - TreeFactory's assumption that getKind()==ERROR 
implies ErrorType is no longer true.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1344) NetBeans looks Ugly on Java 11 on Linux

2018-11-19 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692149#comment-16692149
 ] 

Jeffrey Morlan commented on NETBEANS-1344:
--

[~aldobrucale]: The text rendering issue is unrelated to GTK; that's between 
OpenJDK and newer versions of FreeType, and it affects any Java program. 
https://bugs.openjdk.java.net/browse/JDK-8212071

A workaround for it I use is to set the environment variable 
FREETYPE_PROPERTIES to "truetype:interpreter-version=35"

> NetBeans looks Ugly on Java 11 on Linux
> ---
>
> Key: NETBEANS-1344
> URL: https://issues.apache.org/jira/browse/NETBEANS-1344
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Laszlo Kishalmi
>Priority: Major
>  Labels: Java11, Linux, pull-request-available
> Attachments: Screenshot from 2018-10-04 09-11-28.png, 
> document_tab.png, image-2018-10-15-20-10-48-233.png, 
> image-2018-10-15-20-11-07-846.png, image-2018-10-15-20-16-27-048.png, 
> image-2018-10-15-20-19-36-959.png, image-2018-10-15-20-19-49-797.png, 
> image-2018-10-15-20-21-15-737.png, image-2018-10-15-20-24-00-937.png, 
> java10_code.png, java10_menu_and_toolbar.png, java10_output_window.png, 
> java10_projects.png, java11_code.png, java11_menu_and_toolbar.png, 
> java11_output_window.png, java11_projects.png, java11opt_code.png, 
> java11opt_menu_and_toolbar.png, java11opt_output_window.png, 
> java11opt_projects.png, openjdk-8_code.png, openjdk-8_tree.png, 
> openjdk-8_tree.png, oraclejdk-8_code.png, oraclejdk-8_tree.png, 
> selected_item.png, toolbar_buttons.png
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Well actually Java 11 the defaults Gnome3 on Linux, resulting poor rendering 
> on the default GTK look and feel. Using other Look and feel (Nimbus, Darcula) 
> does not suffer from this issue.
>  Forcing to use GTK 2.2 fixes the GTK look and feel.
> To force gnome we need to pass: {{-Djdk.gtk.version=2.2}} to the Java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-11-19 Thread Jeffrey Morlan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan reassigned NETBEANS-906:
---

Assignee: Jan Lahoda  (was: Dusan Balek)

> nb-javac throws AssertionError compiling valid Java code involving inner 
> classes
> 
>
> Key: NETBEANS-906
> URL: https://issues.apache.org/jira/browse/NETBEANS-906
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 9.0
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Assignee: Jan Lahoda
>Priority: Major
> Attachments: NETBEANS-906.patch
>
>
> NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:
> public class Bug {
>     class A {}
>     static void b(Bug c) \{ c.new A(){}; }
> }
> It throws the following exception:
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-11-19 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692123#comment-16692123
 ] 

Jeffrey Morlan commented on NETBEANS-906:
-

ping [~dbalek], [~jlahoda], [~rtaneja] - nb-javac has gotten updated on the 
plugin portal a few more times without this bug being addressed.

> nb-javac throws AssertionError compiling valid Java code involving inner 
> classes
> 
>
> Key: NETBEANS-906
> URL: https://issues.apache.org/jira/browse/NETBEANS-906
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 9.0
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Assignee: Dusan Balek
>Priority: Major
> Attachments: NETBEANS-906.patch
>
>
> NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:
> public class Bug {
>     class A {}
>     static void b(Bug c) \{ c.new A(){}; }
> }
> It throws the following exception:
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1008) ClassCastException while editing java 8 files

2018-06-27 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525509#comment-16525509
 ] 

Jeffrey Morlan commented on NETBEANS-1008:
--

This is a duplicate of https://issues.apache.org/jira/browse/NETBEANS-715

> ClassCastException while editing java 8 files
> -
>
> Key: NETBEANS-1008
> URL: https://issues.apache.org/jira/browse/NETBEANS-1008
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Tobias Warneke
>Priority: Major
>
> Caused: java.lang.ClassCastException: 
> com.sun.tools.javac.tree.JCTree$JCLambda cannot be cast to 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation
>  at 
> com.sun.tools.javac.comp.ArgumentAttr$ResolvedMethodType.dup(ArgumentAttr.java:607)
>  at com.sun.tools.javac.comp.ArgumentAttr.processArg(ArgumentAttr.java:240)
>  at com.sun.tools.javac.comp.ArgumentAttr.visitLambda(ArgumentAttr.java:293)
>  at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1813)
>  at com.sun.tools.javac.comp.ArgumentAttr.attribArg(ArgumentAttr.java:197)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:658)
>  at com.sun.tools.javac.comp.Attr.attribArgs(Attr.java:769)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2049)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitLambda(Attr.java:2726)
>  at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1813)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.DeferredAttr$4.complete(DeferredAttr.java:371)
>  at 
> com.sun.tools.javac.comp.DeferredAttr$DeferredType.check(DeferredAttr.java:332)
>  at 
> com.sun.tools.javac.comp.DeferredAttr$DeferredType.check(DeferredAttr.java:318)
>  at com.sun.tools.javac.comp.Resolve$MethodResultInfo.check(Resolve.java:1048)
>  at com.sun.tools.javac.comp.Resolve$4.checkArg(Resolve.java:875)
>  at 
> com.sun.tools.javac.comp.Resolve$AbstractMethodCheck.argumentsAcceptable(Resolve.java:783)
>  at com.sun.tools.javac.comp.Resolve$4.argumentsAcceptable(Resolve.java:884)
>  at com.sun.tools.javac.comp.Resolve.rawInstantiate(Resolve.java:626)
>  at com.sun.tools.javac.comp.Resolve.checkMethod(Resolve.java:652)
>  at com.sun.tools.javac.comp.Attr.checkMethod(Attr.java:4401)
>  at com.sun.tools.javac.comp.Attr.checkIdInternal(Attr.java:4189)
>  at com.sun.tools.javac.comp.Attr.checkMethodIdInternal(Attr.java:4088)
>  at com.sun.tools.javac.comp.Attr.checkMethodId(Attr.java:4067)
>  at com.sun.tools.javac.comp.Attr.checkId(Attr.java:4054)
>  at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3939)
>  at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2116)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2066)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.attribExpr(Attr.java:713)
>  at com.sun.tools.javac.comp.Attr.visitExec(Attr.java:1825)
>  at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:736)
>  at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:760)
>  at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1337)
>  at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:69)
>  at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:736)
>  at 
> org.netbeans.modules.java.source.nbjavac.parsing.PartialReparserService.reattrMethodBody(PartialReparserService.java:180)
> [catch] at 
> org.netbeans.modules.java.source.nbjavac.parsing.PartialReparserImpl.reparseMethod(PartialReparserImpl.java:164)
>  at 
> org.netbeans.modules.java.source.parsing.JavacParser.parseImpl(JavacParser.java:397)
>  at 
> org.netbeans.modules.java.source.parsing.JavacParser.parse(JavacParser.java:330)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callParse(TaskProcessor.java:598)
>  at 
> org.netbeans.modules.parsing.impl.SourceCache.getResult(SourceCache.java:228)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:775)
>  at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702)
>  at 
> org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663)
>  at 
> 

[jira] [Commented] (NETBEANS-715) Annotation: java.lang.ClassCastException While Editing Swing Panel Java Source

2018-06-27 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525507#comment-16525507
 ] 

Jeffrey Morlan commented on NETBEANS-715:
-

Here's a simple way to demonstrate this bug - start with the following method:

{{public static void main(String[] args) {}}
{{    //}}
{{    System.out.println(true ? "" : (""));}}
{{}}}

Then, type exactly 7 characters in the comment. "java.lang.ClassCastException: 
com.sun.tools.javac.tree.JCTree$JCConditional cannot be cast to 
com.sun.tools.javac.tree.JCTree$JCParens".

This is caused by stale data in ArgumentAttr.argumentTypeCache. (ArgumentAttr 
was introduced in JDK 9: https://bugs.openjdk.java.net/browse/JDK-8078093)

> Annotation: java.lang.ClassCastException While Editing Swing Panel Java Source
> --
>
> Key: NETBEANS-715
> URL: https://issues.apache.org/jira/browse/NETBEANS-715
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Hints  Annotations
>Affects Versions: 9.0
> Environment: Product Version: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202)
> Java: 10; Java HotSpot(TM) 64-Bit Server VM 10+46
> Runtime: Java(TM) SE Runtime Environment 10+46
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_AU (nb)
> User directory: Z:\tmp\.other\user\netbeans\v09.00-beta\FourAbs
> Cache directory: Z:\tmp\.other\cache\netbeans\FourAbs-09
> Plugins:
>   * Netbeans Gradle plugin v1.4.3
>Reporter: will mason
>Priority: Major
>  Labels: ClassCastException, GUI, Regression, annotations, 
> editor, hints
> Attachments: ClassCastException.logs, JPanelIbaDetails.dump, 
> messages.log
>
>
> h2. context
> *  Gradle project open
> * Panel class open in editor
> * Java debugger running
> * Adding a correction to set value for a JCheckBox field.
> h2. expected / desirable
> * Finish adding source code change
> * Move to next GUI error in debugger and consider how that should work in 
> source
> h2. actual
> *  Annotation exception
> **   stacktrace 
> {code:java}
> An error occurred during parsing of 
> 'D:\work\products\FourAbs\FourAbsClientLibrary\src\main\java\au\com\fourtel\fourabs\client\ibas\JPanelIbaDetails.java'.
>  Please report a bug against java/source and attach dump file 
> 'Z:\tmp\.other\user\netbeans\v09.00-beta\FourAbs\var\log\JPanelIbaDetails.dump'.
> Caused: java.lang.ClassCastException: 
> com.sun.tools.javac.tree.JCTree$JCConditional cannot be cast to 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation
>   at 
> com.sun.tools.javac.comp.ArgumentAttr$ResolvedMethodType.dup(ArgumentAttr.java:607)
>   at 
> com.sun.tools.javac.comp.ArgumentAttr.processArg(ArgumentAttr.java:240)
>   ...
> {code}
> h2.  Impact
> * Interrupts work 
> * Not sure if editing is stable 
> h2.  supporting information
> *  JPanelIbaDetails.dump
> * messages.log
> *  AssertionError.logs - contains ...
> **  stacktrace
> **  UI log
> **  IDE log



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-935) ClassCastException while parsing java source.

2018-06-27 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525508#comment-16525508
 ] 

Jeffrey Morlan commented on NETBEANS-935:
-

This is a duplicate of https://issues.apache.org/jira/browse/NETBEANS-715

> ClassCastException while parsing java source.
> -
>
> Key: NETBEANS-935
> URL: https://issues.apache.org/jira/browse/NETBEANS-935
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Will Shackleford
>Priority: Major
> Attachments: Supervisor.dump
>
>
> An error occurred during parsing of 
> 'C:\Users\shackle\Documents\NetBeansProjects\aprs-framework\src\main\java\aprs\supervisor\main\Supervisor.java'.
>  Please report a bug against java/source and attach dump file 
> 'C:\Users\shackle\AppData\Roaming\NetBeans\dev\var\log\Supervisor.dump'.
> Caused: java.lang.ClassCastException: 
> com.sun.tools.javac.tree.JCTree$JCLambda cannot be cast to 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation
>  at 
> com.sun.tools.javac.comp.ArgumentAttr$ResolvedMethodType.dup(ArgumentAttr.java:607)
>  at com.sun.tools.javac.comp.ArgumentAttr.processArg(ArgumentAttr.java:240)
>  at com.sun.tools.javac.comp.ArgumentAttr.visitLambda(ArgumentAttr.java:293)
>  at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1813)
>  at com.sun.tools.javac.comp.ArgumentAttr.attribArg(ArgumentAttr.java:197)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:658)
>  at com.sun.tools.javac.comp.Attr.attribArgs(Attr.java:769)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2049)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitLambda(Attr.java:2726)
>  at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1813)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.DeferredAttr$4.complete(DeferredAttr.java:371)
>  at 
> com.sun.tools.javac.comp.DeferredAttr$DeferredType.check(DeferredAttr.java:332)
>  at 
> com.sun.tools.javac.comp.DeferredAttr$DeferredType.check(DeferredAttr.java:318)
>  at com.sun.tools.javac.comp.Resolve$MethodResultInfo.check(Resolve.java:1048)
>  at com.sun.tools.javac.comp.Resolve$4.checkArg(Resolve.java:875)
>  at 
> com.sun.tools.javac.comp.Resolve$AbstractMethodCheck.argumentsAcceptable(Resolve.java:783)
>  at com.sun.tools.javac.comp.Resolve$4.argumentsAcceptable(Resolve.java:884)
>  at com.sun.tools.javac.comp.Infer.instantiateMethod(Infer.java:193)
>  at com.sun.tools.javac.comp.Resolve.rawInstantiate(Resolve.java:613)
>  at com.sun.tools.javac.comp.Resolve.checkMethod(Resolve.java:652)
>  at com.sun.tools.javac.comp.Attr.checkMethod(Attr.java:4401)
>  at com.sun.tools.javac.comp.Attr.checkIdInternal(Attr.java:4189)
>  at com.sun.tools.javac.comp.Attr.checkMethodIdInternal(Attr.java:4088)
>  at com.sun.tools.javac.comp.Attr.checkMethodId(Attr.java:4067)
>  at com.sun.tools.javac.comp.Attr.checkId(Attr.java:4054)
>  at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3939)
>  at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2116)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2066)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3815)
>  at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2116)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2066)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3815)
>  at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2116)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2066)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3815)
>  at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2116)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2066)
>  at 
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1640)
>  at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:660)
>  at com.sun.tools.javac.comp.Attr.visitReturn(Attr.java:1918)
>  at com.sun.tools.javac.tree.JCTree$JCReturn.accept(JCTree.java:1552)
> 

[jira] [Commented] (NETBEANS-531) "Duplicate method name in class" when running maven app with CoS enabled

2018-06-21 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519831#comment-16519831
 ] 

Jeffrey Morlan commented on NETBEANS-531:
-

Did some more investigation.

For ant projects, the compileClassPath contains only dependencies. But for 
maven projects, it also contains the target/classes directory. This appears to 
be a new behavior introduced between NetBeans 8.2 and 9: 
[http://hg.netbeans.org/main/rev/c348241a3cac]

CacheClassPath translates that into the corresponding index directory 
containing .sig files.

nb-javac's ClassFinder.preferredFileObject prefers a .sig class over a source 
file (this was introduced long ago: 
http://hg.netbeans.org/main/nb-javac/rev/0084dac11bc9)

During OnePassCompileWorker compilation, the ClassSymbol can get populated with 
synthetic method signatures (lambdas, bridges, etc) from the .sig, causing 
problems when the class actually gets compiled.

> "Duplicate method name in class" when running maven app with CoS 
> enabled
> --
>
> Key: NETBEANS-531
> URL: https://issues.apache.org/jira/browse/NETBEANS-531
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Classfile, java - Compiler, projects - Maven
>Affects Versions: 9.0
> Environment: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202) on OpenJDK 64-Bit Server VM 
> 9.0.4.1+11, Mac OS X version 10.9.5 running on x86_64; UTF-8; en_US (nb)
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: duplicatenamesig.txt, lambda-bug.tar.gz
>
>
> On several occasions, when running a Maven-based NetBeans Platform app from 
> the IDE, the app fails with the exception "java.lang.ClassFormatError: 
> Duplicate method name in class file 
> com/somepackage/project/actions/SomeClass$1". I suspect this might be related 
> to the Compile-on-Save infrastructure. See attached log. A clean build of the 
> entire project is then required in order to make the application runnable 
> again.
> Previous versions of NetBeans required a clean build after changing 
> annotations (see Bugzilla bug 
> [221781|https://netbeans.org/bugzilla/show_bug.cgi?id=221781]). However, this 
> new error appears even when no annotations have been changed. The specific 
> error message shown here is also new to me--it did not appear in previous 
> NetBeans versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-531) "Duplicate method name in class" when running maven app with CoS enabled

2018-06-19 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517652#comment-16517652
 ] 

Jeffrey Morlan commented on NETBEANS-531:
-

I've been seeing this in a large Java 8/Maven project. Whenever I change a 
dependency in pom.xml, NetBeans recompiles all the files, and for many of them 
it often generates invalid class files that fail at runtime with an error like

java.lang.ClassFormatError: Duplicate method name "lambda$main$0" with 
signature "()V" in class file main/Main

If I look at the class file, only the last method contains the actual lambda 
code, all the others just do 'throw new RuntimeException("Uncompilable source 
code")'.

With each dependency change, the class accumulates another erroneous copy of 
each lambda method. Making any change to the .java file will reset it.

This only happens if the project has 500+ files. This is probably related to 
NBJavacCompileWorkerProvider's choice of different compilation strategies for 
<500 or >=500 files changed.

I've attached a minimal project which can reproduce this issue fairly reliably. 
Try running Main - first time, it should work. Then edit the dependency in 
pom.xml. Most of the time, you'll see the size of Main.class increase, and 
it'll fail to run.

[^lambda-bug.tar.gz]

> "Duplicate method name in class" when running maven app with CoS 
> enabled
> --
>
> Key: NETBEANS-531
> URL: https://issues.apache.org/jira/browse/NETBEANS-531
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Classfile, java - Compiler, projects - Maven
>Affects Versions: 9.0
> Environment: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202) on OpenJDK 64-Bit Server VM 
> 9.0.4.1+11, Mac OS X version 10.9.5 running on x86_64; UTF-8; en_US (nb)
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: duplicatenamesig.txt, lambda-bug.tar.gz
>
>
> On several occasions, when running a Maven-based NetBeans Platform app from 
> the IDE, the app fails with the exception "java.lang.ClassFormatError: 
> Duplicate method name in class file 
> com/somepackage/project/actions/SomeClass$1". I suspect this might be related 
> to the Compile-on-Save infrastructure. See attached log. A clean build of the 
> entire project is then required in order to make the application runnable 
> again.
> Previous versions of NetBeans required a clean build after changing 
> annotations (see Bugzilla bug 
> [221781|https://netbeans.org/bugzilla/show_bug.cgi?id=221781]). However, this 
> new error appears even when no annotations have been changed. The specific 
> error message shown here is also new to me--it did not appear in previous 
> NetBeans versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-531) "Duplicate method name in class" when running maven app with CoS enabled

2018-06-19 Thread Jeffrey Morlan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan updated NETBEANS-531:

Attachment: lambda-bug.tar.gz

> "Duplicate method name in class" when running maven app with CoS 
> enabled
> --
>
> Key: NETBEANS-531
> URL: https://issues.apache.org/jira/browse/NETBEANS-531
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Classfile, java - Compiler, projects - Maven
>Affects Versions: 9.0
> Environment: Apache NetBeans IDE Dev (Build 
> incubator-netbeans-release-205-on-20180202) on OpenJDK 64-Bit Server VM 
> 9.0.4.1+11, Mac OS X version 10.9.5 running on x86_64; UTF-8; en_US (nb)
>Reporter: Eirik Bakke
>Priority: Major
> Attachments: duplicatenamesig.txt, lambda-bug.tar.gz
>
>
> On several occasions, when running a Maven-based NetBeans Platform app from 
> the IDE, the app fails with the exception "java.lang.ClassFormatError: 
> Duplicate method name in class file 
> com/somepackage/project/actions/SomeClass$1". I suspect this might be related 
> to the Compile-on-Save infrastructure. See attached log. A clean build of the 
> entire project is then required in order to make the application runnable 
> again.
> Previous versions of NetBeans required a clean build after changing 
> annotations (see Bugzilla bug 
> [221781|https://netbeans.org/bugzilla/show_bug.cgi?id=221781]). However, this 
> new error appears even when no annotations have been changed. The specific 
> error message shown here is also new to me--it did not appear in previous 
> NetBeans versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-06-09 Thread Jeffrey Morlan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan reassigned NETBEANS-906:
---

Assignee: Dusan Balek

> nb-javac throws AssertionError compiling valid Java code involving inner 
> classes
> 
>
> Key: NETBEANS-906
> URL: https://issues.apache.org/jira/browse/NETBEANS-906
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 9.0
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Assignee: Dusan Balek
>Priority: Major
> Attachments: NETBEANS-906.patch
>
>
> NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:
> public class Bug {
>     class A {}
>     static void b(Bug c) \{ c.new A(){}; }
> }
> It throws the following exception:
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-06-08 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506537#comment-16506537
 ] 

Jeffrey Morlan commented on NETBEANS-906:
-

The JDK 10 change conflicted with an older nb-javac change to the same code by 
the same person: hg.netbeans.org/main/nb-javac/rev/252dd0bfe711

Aligning the code to JDK 10 ([^NETBEANS-906.patch]) fixes this problem for me.

> nb-javac throws AssertionError compiling valid Java code involving inner 
> classes
> 
>
> Key: NETBEANS-906
> URL: https://issues.apache.org/jira/browse/NETBEANS-906
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 9.0
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Priority: Major
> Attachments: NETBEANS-906.patch
>
>
> NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:
> public class Bug {
>     class A {}
>     static void b(Bug c) \{ c.new A(){}; }
> }
> It throws the following exception:
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-06-08 Thread Jeffrey Morlan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Morlan updated NETBEANS-906:

Attachment: NETBEANS-906.patch

> nb-javac throws AssertionError compiling valid Java code involving inner 
> classes
> 
>
> Key: NETBEANS-906
> URL: https://issues.apache.org/jira/browse/NETBEANS-906
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 9.0
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Priority: Major
> Attachments: NETBEANS-906.patch
>
>
> NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:
> public class Bug {
>     class A {}
>     static void b(Bug c) \{ c.new A(){}; }
> }
> It throws the following exception:
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-936) In Maven project depending on Guava, viewing Guava's source files is slow

2018-06-08 Thread Jeffrey Morlan (JIRA)
Jeffrey Morlan created NETBEANS-936:
---

 Summary: In Maven project depending on Guava, viewing Guava's 
source files is slow
 Key: NETBEANS-936
 URL: https://issues.apache.org/jira/browse/NETBEANS-936
 Project: NetBeans
  Issue Type: Bug
 Environment: OpenJDK 1.8.0_171 on Ubuntu
Reporter: Jeffrey Morlan


* Have the JDK's src.zip installed
 * Create a Maven project
 * Add Guava as a dependency (com.google.guava:guava, latest version 25.1-jre)
 * "Download Sources" for the Guava dependency
 * Try to open any Guava class

It will take ~10 seconds to parse, sometimes hanging the UI. Somehow NetBeans 9 
is ending up parsing hundreds of src.zip files along with it. This did not 
happen in NetBeans 8.2.

Guava has a "${java.home}/../src.zip" dependency in 
its pom.xml, which may be related.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-06-05 Thread Jeffrey Morlan (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502285#comment-16502285
 ] 

Jeffrey Morlan commented on NETBEANS-906:
-

Appears to be related to "tree.args = 
tree.args.prepend(makeNullCheck(tree.encl));"

In JDK 8, this line of code is in Attr.visitAnonymousClassdefinition.

In JDK 10, it was moved to TransTypes.visitNewClass:
https://bugs.openjdk.java.net/browse/JDK-8044853
http://hg.openjdk.java.net/jdk10/master/rev/22d665f53a4a

In nb-java-x, it's in both places and tree.args is getting prepended twice.

> nb-javac throws AssertionError compiling valid Java code involving inner 
> classes
> 
>
> Key: NETBEANS-906
> URL: https://issues.apache.org/jira/browse/NETBEANS-906
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - Compiler
>Affects Versions: 9.0
> Environment: OpenJDK 1.8.0_171 on Ubuntu
>Reporter: Jeffrey Morlan
>Priority: Major
>
> NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:
> public class Bug {
>     class A {}
>     static void b(Bug c) \{ c.new A(){}; }
> }
> It throws the following exception:
> java.lang.AssertionError
>   at com.sun.tools.javac.util.Assert.error(Assert.java:155)
>   at com.sun.tools.javac.util.Assert.check(Assert.java:46)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
>   at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
>   at 
> com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
>   at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
>   at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
>   at 
> com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
>   at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
>   at 
> com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
>   at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
>   at 
> com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
>   at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
>   at 
> com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-906) nb-javac throws AssertionError compiling valid Java code involving inner classes

2018-06-01 Thread Jeffrey Morlan (JIRA)
Jeffrey Morlan created NETBEANS-906:
---

 Summary: nb-javac throws AssertionError compiling valid Java code 
involving inner classes
 Key: NETBEANS-906
 URL: https://issues.apache.org/jira/browse/NETBEANS-906
 Project: NetBeans
  Issue Type: Bug
  Components: java - Compiler
Affects Versions: 9.0
 Environment: OpenJDK 1.8.0_171 on Ubuntu
Reporter: Jeffrey Morlan


NetBeans 9.0 RC1 with nb-javac plugin fails to compile code like this:

public class Bug {
    class A {}
    static void b(Bug c) \{ c.new A(){}; }
}

It throws the following exception:

java.lang.AssertionError
at com.sun.tools.javac.util.Assert.error(Assert.java:155)
at com.sun.tools.javac.util.Assert.check(Assert.java:46)
at 
com.sun.tools.javac.comp.TransTypes.translateArgs(TransTypes.java:211)
at 
com.sun.tools.javac.comp.TransTypes.visitNewClass(TransTypes.java:723)
at com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1695)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
at com.sun.tools.javac.comp.TransTypes.visitExec(TransTypes.java:655)
at 
com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1458)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
at 
com.sun.tools.javac.tree.TreeTranslator.visitBlock(TreeTranslator.java:167)
at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
at 
com.sun.tools.javac.comp.TransTypes.visitMethodDef(TransTypes.java:539)
at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:872)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:70)
at 
com.sun.tools.javac.tree.TreeTranslator.visitClassDef(TreeTranslator.java:139)
at 
com.sun.tools.javac.comp.TransTypes.translateClass(TransTypes.java:971)
at 
com.sun.tools.javac.comp.TransTypes.visitClassDef(TransTypes.java:525)
at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:778)
at 
com.sun.tools.javac.tree.TreeTranslator.translate(TreeTranslator.java:58)
at com.sun.tools.javac.comp.TransTypes.translate(TransTypes.java:504)
at 
com.sun.tools.javac.comp.TransTypes.translateTopLevelClass(TransTypes.java:995)
at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1653)
at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1520)
at 
com.sun.tools.javac.api.JavacTaskImpl$2.process(JavacTaskImpl.java:567)
at 
com.sun.tools.javac.api.JavacTaskImpl$Filter.run(JavacTaskImpl.java:644)
at 
com.sun.tools.javac.api.JavacTaskImpl.generate(JavacTaskImpl.java:570)




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists