[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108176#comment-17108176 ] Pier Luigi edited comment on NETBEANS-2082 at 5/15/20, 3:38 PM: My post (and intention) was not a criticism but a simple observation: the code folding of NB behave "strange" since the first Apache version thus I'm expecting that a large part of the users base complains about it. In addition the "jump" could be only a part of the problem. To go forward and in order to "investigate it by myself and/or motivate others" this is a visual comparison of the code folding behavior of NB 11.3 compared side by side to the old 8.2: #1: [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Blocks_Identification.mp4] The first video show that code blocks that are "foldable" are identified differently and often in a wrong way: as you can see with NB11.3 the editor fail to identify as "foldable" even the main class block and many methods. Please note that at 0:22 I cut and re-paste the same block of code (so the source remain the same) and the editor seems to correct its foldable blocks identification criteria (the main class and some methods become marked as foldable), but if I save the file, then close and reopen NB the behavior back to the wrong one. #2 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_1.mp4] The video show the problem highlighted with this thread. Please note that the click a 0:26 fold the code correctly with no jump even if the caret is at the end of the document, but the following clicks that expand and collapse the same block into the same situation exhibit the problematic jump. #3 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_2.mp4] As you can see (0:33), with NB11.3 if you fold a block of code AND the caret is inside it, when you scroll the document using the mouse wheel or the scroll bar, the document scroll position keep returning automatically to the folded code after about a second. I think that the fold and unfold actions should not deal with scroll and should ignore the actual caret position if it is outside the affected block, otherwise set the caret position to the begin of the folded block. EDITED sample source code used in video (remove .txt that was added to avoid file execution): http://download.e-link.it/netbeans/CODE_FOLDING_PROBLEM_SOURCE_SAMPLE.php.txt was (Author: picov): My post (and intention) was not a criticism but a simple observation: the code folding of NB behave "strange" since the first Apache version thus I'm expecting that a large part of the users base complains about it. In addition the "jump" could be only a part of the problem. To go forward and in order to "investigate it by myself and/or motivate others" this is a visual comparison of the code folding behavior of NB 11.3 compared side by side to the old 8.2: #1: [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Blocks_Identification.mp4] The first video show that code blocks that are "foldable" are identified differently and often in a wrong way: as you can see with NB11.3 the editor fail to identify as "foldable" even the main class block and many methods. Please note that at 0:22 I cut and re-paste the same block of code (so the source remain the same) and the editor seems to correct its foldable blocks identification criteria (the main class and some methods become marked as foldable), but if I save the file, then close and reopen NB the behavior back to the wrong one. #2 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_1.mp4] The video show the problem highlighted with this thread. Please note that the click a 0:26 fold the code correctly with no jump even if the caret is at the end of the document, but the following clicks that expand and collapse the same block into the same situation exhibit the problematic jump. #3 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_2.mp4] As you can see (0:33), with NB11.3 if you fold a block of code AND the caret is inside it, when you scroll the document using the mouse wheel or the scroll bar, the document scroll position keep returning automatically to the folded code after about a second. I think that the fold and unfold actions should not deal with scroll and should ignore the actual caret position if it is outside the affected block, otherwise set the caret position to the begin of the folded block. > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components:
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108292#comment-17108292 ] Pier Luigi edited comment on NETBEANS-2082 at 5/15/20, 1:43 PM: Ok [~sdedic] , I've reported it assuming that if I've some troubles about identifying things to handle, there will be a chance that I'll not able to handle them correctly. was (Author: picov): Ok [~sdedic] , I've reported it assuming that if I've some troubles about identifying things to handle, is very hard that I'll handle them correctly. > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components: editor - Code folding >Affects Versions: 10.0, 11.0, 11.1, 11.2 > Environment: Netbeans 11 with OpenJDK 12. > Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 > 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64 > Netbeans 10 with OpenJDK 11. > Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 > 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64 >Reporter: Pier Luigi >Assignee: Svatopluk Dedic >Priority: Critical > Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip, > netbeans-2082.gif > > > Collapsing a block often results in a jump of the editor to an incorrect > editing position (and scrolling the page cause a rejump to that position > after a second of scroll inactivity). > The same sources works perfectly with Netbeans 8.2. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[
https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108202#comment-17108202
]
Svatopluk Dedic edited comment on NETBEANS-2082 at 5/15/20, 11:48 AM:
--
{quote}The first video show that code blocks that are "foldable" are identified
differently and often in a wrong way: as you can see with NB11.3 the editor
fail to identify as "foldable" even the main class block and many methods.
{quote}
Thanks for the investigation! But please keep this defect report focused on one
issue. Ideally please file your other findings as separate issues. Note that
because of modular nature, part of the issues may actually come from PHP
support, that's why it's better to split individual individual defects into
separate reports. It's more paperwork, but allows to distribute the work
better.
was (Author: sdedic):
{quote}The first video show that code blocks that are "foldable" are identified
differently and often in a wrong way: as you can see with NB11.3 the editor
fail to identify as "foldable" even the main class block and many methods.
{quote}
Thanks for the investigation! But please keep this defect report focused on one
issue. Ideally please file your findings as separate issues. Note that because
of modular nature, part of the issues may actually come from PHP support,
that's why it's better to split individual individual defects into separate
reports. It's more paperwork, but allows to distribute the work better.
> Scroll to the caret position when code fold feature is run
> --
>
> Key: NETBEANS-2082
> URL: https://issues.apache.org/jira/browse/NETBEANS-2082
> Project: NetBeans
> Issue Type: Bug
> Components: editor - Code folding
>Affects Versions: 10.0, 11.0, 11.1, 11.2
> Environment: Netbeans 11 with OpenJDK 12.
> Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11
> 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64
> Netbeans 10 with OpenJDK 11.
> Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20
> 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64
>Reporter: Pier Luigi
>Assignee: Svatopluk Dedic
>Priority: Critical
> Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip,
> netbeans-2082.gif
>
>
> Collapsing a block often results in a jump of the editor to an incorrect
> editing position (and scrolling the page cause a rejump to that position
> after a second of scroll inactivity).
> The same sources works perfectly with Netbeans 8.2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108176#comment-17108176 ] Pier Luigi edited comment on NETBEANS-2082 at 5/15/20, 11:17 AM: - My post (and intention) was not a criticism but a simple observation: the code folding of NB behave "strange" since the first Apache version thus I'm expecting that a large part of the users base complains about it. In addition the "jump" could be only a part of the problem. To go forward and in order to "investigate it by myself and/or motivate others" this is a visual comparison of the code folding behavior of NB 11.3 compared side by side to the old 8.2: #1: [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Blocks_Identification.mp4] The first video show that code blocks that are "foldable" are identified differently and often in a wrong way: as you can see with NB11.3 the editor fail to identify as "foldable" even the main class block and many methods. Please note that at 0:22 I cut and re-paste the same block of code (so the source remain the same) and the editor seems to correct its foldable blocks identification criteria (the main class and some methods become marked as foldable), but if I save the file, then close and reopen NB the behavior back to the wrong one. #2 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_1.mp4] The video show the problem highlighted with this thread. Please note that the click a 0:26 fold the code correctly with no jump even if the caret is at the end of the document, but the following clicks that expand and collapse the same block into the same situation exhibit the problematic jump. #3 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_2.mp4] As you can see (0:33), with NB11.3 if you fold a block of code AND the caret is inside it, when you scroll the document using the mouse wheel or the scroll bar, the document scroll position keep returning automatically to the folded code after about a second. I think that the fold and unfold actions should not deal with scroll and should ignore the actual caret position if it is outside the affected block, otherwise set the caret position to the begin of the folded block. was (Author: picov): My post (and intention) was not a criticism but a simple observation: the code folding of NB behave "strange" since the first Apache version thus I'm expecting that a large part of the users base complains about it. In addition the "jump" could be only a part of the problem. To go forward and in order to "investigate it by myself and/or motivate others" this is a visual comparison of the code folding behavior of NB 11.3 compared side by side to the old 8.2: #1: [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Blocks_Identification.mp4] The first video show that code blocks that are "foldable" are identified differently and often in a wrong way: as you can see with NB11.3 the editor fail to identify as "foldable" even the main class block and many methods. Please note that at 0:32 I cut and re-paste the same block of code (so the source remain the same) and the editor seems to correct its foldable blocks identification criteria (the main class and some methods become marked as foldable), but if I save the file, then close and reopen NB the behavior back to the wrong one. #2 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_1.mp4] The video show the problem highlighted with this thread. Please note that the click a 0:26 fold the code correctly with no jump even if the caret is at the end of the document, but the following clicks that expand and collapse the same block into the same situation exhibit the problematic jump. #3 [http://download.e-link.it/netbeans/NB_Code_Folding_comparision-Jump_to_caret_2.mp4] As you can see (0:33), with NB11.3 if you fold a block of code AND the caret is inside it, when you scroll the document using the mouse wheel or the scroll bar, the document scroll position keep returning automatically to the folded code after about a second. I think that the fold and unfold actions should not deal with scroll and should ignore the actual caret position if it is outside the affected block, otherwise set the caret position to the begin of the folded block. > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components: editor - Code folding >Affects Versions: 10.0, 11.0, 11.1, 11.2 > Environment: Netbeans 11 with OpenJDK 12. > Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108121#comment-17108121 ] Svatopluk Dedic edited comment on NETBEANS-2082 at 5/15/20, 9:25 AM: - During playing, when I was "fast enough", I've managed to navigate to a PHP symbol from Navigator, and scroll the caret away before the PHP parsed + created folds; the view scrolled back to show the caret. IMHO user instruction (i.e. scrolling) should always override the NetBeans AI :) so I'd say I should fix the repositioning in the Editor to take original caret visibility into acount. I thik there will be still some "visual effects": if the caret is on screen, and at a certain Y distance from the window top, it might be used as an anchor to position the view after folding so that the caret is +- at the same position. What this issue asks for is that if we don't have such anchor on-screen, the view should "remain consistent and focused where the user looks at the moment". I'll start by attempting to block the caret anchor in case the caret was off the screen initially. But the "complete" fix might be a lot trickier, and as indicated above, should be probably done elsewhere than in Caret impl; but still within the Editor. was (Author: sdedic): During playing, when I was "fast enough", I've managed to navigate to a PHP symbol from Navigator, and scroll the caret away before the PHP parsed + created folds; the view scrolled back to show the caret. IMHO user instruction (i.e. scrolling) should always override the NetBeans AI :) so I'd say I should fix the repositioning in the Editor to take original caret visibility into acount. I thik there will be still some "visual effects": if the caret is on screen, and at a certain Y distance from the window top, it might be used as an anchor to position the view after folding so that the caret is +- at the same position. What this issue asks for is that if we don't have such anchor on-screen, the view should "remain consistent". I'll start by attempting to block the caret anchor in case the caret was off the screen initially. But the "complete" fix might be a lot trickier, and as indicated above, should be probably done elsewhere than in Caret impl; but still within the Editor. > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components: editor - Code folding >Affects Versions: 10.0, 11.0, 11.1, 11.2 > Environment: Netbeans 11 with OpenJDK 12. > Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 > 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64 > Netbeans 10 with OpenJDK 11. > Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 > 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64 >Reporter: Pier Luigi >Assignee: Svatopluk Dedic >Priority: Critical > Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip, > netbeans-2082.gif > > > Collapsing a block often results in a jump of the editor to an incorrect > editing position (and scrolling the page cause a rejump to that position > after a second of scroll inactivity). > The same sources works perfectly with Netbeans 8.2. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107771#comment-17107771 ] Junichi Yamamoto edited comment on NETBEANS-2082 at 5/14/20, 11:54 PM: --- I know that the "guideline" exists. However, I thought we should consider 12.0 is "LTS" a bit (and it's a regression from 8.2, maybe). So, I just left the comment to the release manager instead of changing the priority. was (Author: junichi11): I know that the "guideline" exists. However, I thought we should consider 12.0 is "LTS" a bit (and it's a regression from 9.0 or 10, maybe). So, I just left the comment to the release manager instead of changing the priority. > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components: editor - Code folding >Affects Versions: 10.0, 11.0, 11.1, 11.2 > Environment: Netbeans 11 with OpenJDK 12. > Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 > 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64 > Netbeans 10 with OpenJDK 11. > Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 > 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64 >Reporter: Pier Luigi >Assignee: Svatopluk Dedic >Priority: Critical > Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip, > netbeans-2082.gif > > > Collapsing a block often results in a jump of the editor to an incorrect > editing position (and scrolling the page cause a rejump to that position > after a second of scroll inactivity). > The same sources works perfectly with Netbeans 8.2. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107154#comment-17107154 ] Pier Luigi edited comment on NETBEANS-2082 at 5/14/20, 9:50 AM: The bug is about a critical editor feature, exists starting from the earlier version of Apache NetBeans (were talking about year 2018) and was reported more than an year ago, thus the real question is: does someone is really working on it? ... or if you prefer, is the Apache NB project still alive and healthy ? was (Author: picov): The bug is about a critical editor feature, exists starting from the earlier version of Apache NetBeans (were talking about year 2018) and was reported more than 9 months ago, thus the real question is: does someone is really working on it? ... or if you prefer, is the Apache NB project still alive and healthy ? > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components: editor - Code folding >Affects Versions: 10.0, 11.0, 11.1, 11.2 > Environment: Netbeans 11 with OpenJDK 12. > Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 > 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64 > Netbeans 10 with OpenJDK 11. > Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 > 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64 >Reporter: Pier Luigi >Assignee: Svatopluk Dedic >Priority: Critical > Attachments: DemoPHPCodeFoldingProblem_NB11.php, netbeans-2082.gif > > > Collapsing a block often results in a jump of the editor to an incorrect > editing position (and scrolling the page cause a rejump to that position > after a second of scroll inactivity). > The same sources works perfectly with Netbeans 8.2. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-2082) Scroll to the caret position when code fold feature is run
[ https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107154#comment-17107154 ] Pier Luigi edited comment on NETBEANS-2082 at 5/14/20, 9:49 AM: The bug is about a critical editor feature, exists starting from the earlier version of Apache NetBeans (were talking about year 2018) and was reported more than 9 months ago, thus the real question is: does someone is really working on it? ... or if you prefer, is the Apache NB project still alive and healthy ? was (Author: picov): The bug is about a critical editor feature, exists starting from the earlier version of Apache NetBeans (were talking about year 2018) and was reported more than 9 months ago, thus the real question is: does someone is really working on it? ... or if you prefer, is the Apache NB project alive and healthy ? > Scroll to the caret position when code fold feature is run > -- > > Key: NETBEANS-2082 > URL: https://issues.apache.org/jira/browse/NETBEANS-2082 > Project: NetBeans > Issue Type: Bug > Components: editor - Code folding >Affects Versions: 10.0, 11.0, 11.1, 11.2 > Environment: Netbeans 11 with OpenJDK 12. > Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 > 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64 > Netbeans 10 with OpenJDK 11. > Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 > 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64 >Reporter: Pier Luigi >Assignee: Svatopluk Dedic >Priority: Critical > Attachments: DemoPHPCodeFoldingProblem_NB11.php, netbeans-2082.gif > > > Collapsing a block often results in a jump of the editor to an incorrect > editing position (and scrolling the page cause a rejump to that position > after a second of scroll inactivity). > The same sources works perfectly with Netbeans 8.2. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
