[jira] [Comment Edited] (NETBEANS-238) Invoking code-complete in Maven projects is extremely slow
[ https://issues.apache.org/jira/browse/NETBEANS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329101#comment-16329101 ] Gili edited comment on NETBEANS-238 at 1/17/18 5:59 PM: [~jlahoda] I verified the PR. It is even faster than the original patch (probably because you removed `println()`). Performance is now comparable to non-Maven projects (2x slower but the absolute time is low). Thank you! was (Author: cowwoc): [~jlahoda] I verified the PR. It is even faster than the original patch (probably because you removed `println()`). Performance is now comparable to non-Maven projects. Thank you! > Invoking code-complete in Maven projects is extremely slow > -- > > Key: NETBEANS-238 > URL: https://issues.apache.org/jira/browse/NETBEANS-238 > Project: NetBeans > Issue Type: Bug > Components: java - Editor >Affects Versions: 9.0 > Environment: build 152 >Reporter: Gili >Priority: Critical > Labels: pull-request-available > Attachments: NETBEANS-238-experiment.diff, > SlowCodeCompleteAntAndMaven.zip, code-complete-profiler.npss, > code-complete2.npss, messages.log > > Time Spent: 10m > Remaining Estimate: 0h > > Say I'm in a class that has a field {{singletonScope}} where this class is > defined within the same Maven module. > I type {{singletonScope.}} then wait for auto-complete to suggest possible > methods. Code-complete takes roughly 10 seconds to come back. > This is reproducible 100% of the time. > Expected behavior: Code-complete should complete within 300ms or less. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-238) Invoking code-complete in Maven projects is extremely slow
[ https://issues.apache.org/jira/browse/NETBEANS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323640#comment-16323640 ] Gili edited comment on NETBEANS-238 at 1/12/18 7:19 AM: [~jlahoda] Regarding the diff, I am seeing the same directories getting scanned over and over again (specifically, I am surprised the same entries show up consecutively). Is this expected? I've attached messages.log for your review. (UPDATE: I just noticed tens of thousands of other entries in messages.log.1, messages.log.2. This could definitely be useful to optimize away.) Also, I am not aware of any side-effects of this patch. What kind of problems have you run across? was (Author: cowwoc): [~jlahoda] Regarding the diff, I am seeing the same directories getting scanned over and over again (specifically, I am surprised the same entries show up consecutively). Is this expected? I've attached messages.log for your review. Also, I am not aware of any side-effects of this patch. What kind of problems have you run across? > Invoking code-complete in Maven projects is extremely slow > -- > > Key: NETBEANS-238 > URL: https://issues.apache.org/jira/browse/NETBEANS-238 > Project: NetBeans > Issue Type: Bug > Components: java - Editor >Affects Versions: 9.0 > Environment: build 152 >Reporter: Gili >Priority: Critical > Attachments: NETBEANS-238-experiment.diff, > SlowCodeCompleteAntAndMaven.zip, code-complete-profiler.npss, messages.log > > > Say I'm in a class that has a field {{singletonScope}} where this class is > defined within the same Maven module. > I type {{singletonScope.}} then wait for auto-complete to suggest possible > methods. Code-complete takes roughly 10 seconds to come back. > This is reproducible 100% of the time. > Expected behavior: Code-complete should complete within 300ms or less. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-238) Invoking code-complete in Maven projects is extremely slow
[ https://issues.apache.org/jira/browse/NETBEANS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323640#comment-16323640 ] Gili edited comment on NETBEANS-238 at 1/12/18 7:13 AM: [~jlahoda] Regarding the diff, I am seeing the same directories getting scanned over and over again (specifically, I am surprised the same entries show up consecutively). Is this expected? I've attached messages.log for your review. Also, I am not aware of any side-effects of this patch. What kind of problems have you run across? was (Author: cowwoc): [~jlahoda] Regarding the diff, I am seeing the same directories getting scanned over and over again (specifically, I am surprised the same entries show up consecutively). Is this expected? I've attached messages.log for your review. > Invoking code-complete in Maven projects is extremely slow > -- > > Key: NETBEANS-238 > URL: https://issues.apache.org/jira/browse/NETBEANS-238 > Project: NetBeans > Issue Type: Bug > Components: java - Editor >Affects Versions: 9.0 > Environment: build 152 >Reporter: Gili >Priority: Critical > Attachments: NETBEANS-238-experiment.diff, > SlowCodeCompleteAntAndMaven.zip, code-complete-profiler.npss, messages.log > > > Say I'm in a class that has a field {{singletonScope}} where this class is > defined within the same Maven module. > I type {{singletonScope.}} then wait for auto-complete to suggest possible > methods. Code-complete takes roughly 10 seconds to come back. > This is reproducible 100% of the time. > Expected behavior: Code-complete should complete within 300ms or less. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-238) Invoking code-complete in Maven projects is extremely slow
[ https://issues.apache.org/jira/browse/NETBEANS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315180#comment-16315180 ] Gili edited comment on NETBEANS-238 at 1/7/18 10:52 AM: I figured out the difference. "ant tryme" uses JDK 8. It turns out this bug is only reproducible in JDK 9. I tried taking the Jenkins build I had been using, downgrading to JDK 8 and sure enough the bug is gone. (The splash screen looks different for JDK 8 and JDK 9 as well) Is there a way for me to get "ant tryme" to use JDK 9? I tried setting "nbjdk.home" inside user.build.properties but it keeps on complaining the path I am providing is not a valid JDK installation (which it is). was (Author: cowwoc): I figured out the difference. "ant tryme" uses JDK 8. It turns out this bug is only reproducible in JDK 9. I tried taking the Jenkins build I had been using, downgrading to JDK 8 and sure enough the bug is gone. Is there a way for me to get "ant tryme" to use JDK 9? I tried setting "nbjdk.home" inside user.build.properties but it keeps on complaining the path I am providing is not a valid JDK installation (which it is). > Invoking code-complete in Maven projects is extremely slow > -- > > Key: NETBEANS-238 > URL: https://issues.apache.org/jira/browse/NETBEANS-238 > Project: NetBeans > Issue Type: Bug > Components: java - Editor >Affects Versions: 9.0 > Environment: build 152 >Reporter: Gili >Priority: Critical > Attachments: NETBEANS-238-experiment.diff, > SlowCodeCompleteAntAndMaven.zip, code-complete-profiler.npss > > > Say I'm in a class that has a field {{singletonScope}} where this class is > defined within the same Maven module. > I type {{singletonScope.}} then wait for auto-complete to suggest possible > methods. Code-complete takes roughly 10 seconds to come back. > This is reproducible 100% of the time. > Expected behavior: Code-complete should complete within 300ms or less. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-238) Invoking code-complete in Maven projects is extremely slow
[ https://issues.apache.org/jira/browse/NETBEANS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308580#comment-16308580 ] Gili edited comment on NETBEANS-238 at 1/2/18 7:34 PM: --- Okay. Here is a concrete example with nb-javac enabled. I created two projects. SlowCodeCompleteMaven, and SlowCodeCompleteAnt. They contain identical classes. In SlowCodeCompleteMaven, I place the caret inside {{MyClass}} after {{firstMethod()}} and before the closing brace. I then hit CTRL+SPACE. The IDE takes 7 seconds to respond. I get identical timing with nb-javac disabled. If I perform the same operation for an Ant project, the response is instantaneous. I am attaching these projects to this issue. Please take a moment to confirm whether you can reproduce the problem on your end. Thank you. was (Author: cowwoc): Okay. Here is a concrete example with nb-javac enabled. I created two projects. SlowCodeCompleteMaven, and SlowCodeCompleteAnt. They contain identical classes. In SlowCodeCompleteMaven, I place the caret inside MyClass after `firstMethod()` and before the closing brace. I then hit CTRL+SPACE. The IDE takes 7 seconds to respond. I get identical timing with nb-javac disabled. If I perform the same operation for an Ant project, the response is instantaneous. I am attaching these projects to this issue. Please take a moment to confirm whether you can reproduce the problem on your end. Thank you. > Invoking code-complete in Maven projects is extremely slow > -- > > Key: NETBEANS-238 > URL: https://issues.apache.org/jira/browse/NETBEANS-238 > Project: NetBeans > Issue Type: Bug > Components: java - Editor >Affects Versions: 9.0 > Environment: build 152 >Reporter: Gili >Priority: Critical > Attachments: SlowCodeCompleteAntAndMaven.zip > > > Say I'm in a class that has a field {{singletonScope}} where this class is > defined within the same Maven module. > I type {{singletonScope.}} then wait for auto-complete to suggest possible > methods. Code-complete takes roughly 10 seconds to come back. > This is reproducible 100% of the time. > Expected behavior: Code-complete should complete within 300ms or less. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists