[jira] [Commented] (NETBEANS-1397) NetBeans ignores Automatic-Module-Name when java modules are used

2018-10-11 Thread Pavel_K (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647076#comment-16647076
 ] 

Pavel_K commented on NETBEANS-1397:
---

[~jlahoda] I cleaned NetBeans cache and restarted it. The problem has gone. So 
now it is difficult to say what it was.

> NetBeans ignores Automatic-Module-Name when java modules are used
> -
>
> Key: NETBEANS-1397
> URL: https://issues.apache.org/jira/browse/NETBEANS-1397
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Pavel_K
>Priority: Major
> Attachments: NETBEANS-1397.png, java-11-a.png, java-11-b.png, 
> java-11-c.png, java-11-d.png, mavenproject22.zip
>
>
> According to JPMS specs the name of automatic module can be set via 
> MANIFEST.MF by Automatic-Module-Name entry. However, NetBeans doesn't read 
> this entry and it gives problem. For example, there is a module which file 
> name is `foo-boo-1.0.jar` with Automatic-Module-Name as `super.foo`. In my 
> module I must use automatic module set in manifest otherwise JVM won't find 
> this module. That's why I do
> {code:java}
> module my.module {
> requires super.foo;//LINE X
> }
> {code}
> At line X NetBeans shows me an error as it can't find this module! However, 
> compiler compiles module without problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1397) NetBeans ignores Automatic-Module-Name when java modules are used

2018-10-11 Thread Pavel_K (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647062#comment-16647062
 ] 

Pavel_K commented on NETBEANS-1397:
---

[~jlahoda] I uploaded my screenshots. When I use java-10 GUI is not so 
terrible, but I have the same problem with "Automatic-Module-Name".

> NetBeans ignores Automatic-Module-Name when java modules are used
> -
>
> Key: NETBEANS-1397
> URL: https://issues.apache.org/jira/browse/NETBEANS-1397
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Pavel_K
>Priority: Major
> Attachments: NETBEANS-1397.png, java-11-a.png, java-11-b.png, 
> java-11-c.png, java-11-d.png, mavenproject22.zip
>
>
> According to JPMS specs the name of automatic module can be set via 
> MANIFEST.MF by Automatic-Module-Name entry. However, NetBeans doesn't read 
> this entry and it gives problem. For example, there is a module which file 
> name is `foo-boo-1.0.jar` with Automatic-Module-Name as `super.foo`. In my 
> module I must use automatic module set in manifest otherwise JVM won't find 
> this module. That's why I do
> {code:java}
> module my.module {
> requires super.foo;//LINE X
> }
> {code}
> At line X NetBeans shows me an error as it can't find this module! However, 
> compiler compiles module without problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1397) NetBeans ignores Automatic-Module-Name when java modules are used

2018-10-11 Thread Pavel_K (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647052#comment-16647052
 ] 

Pavel_K commented on NETBEANS-1397:
---

[~jlahoda] Can you look at jetty dependency - manifest (Project -> 
Dependencies) Is there "Automatic-Module-Name"  and is it equal to what is in 
module-info of my project? What java version do you use for running NetBeans?

> NetBeans ignores Automatic-Module-Name when java modules are used
> -
>
> Key: NETBEANS-1397
> URL: https://issues.apache.org/jira/browse/NETBEANS-1397
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Pavel_K
>Priority: Major
> Attachments: NETBEANS-1397.png, mavenproject22.zip
>
>
> According to JPMS specs the name of automatic module can be set via 
> MANIFEST.MF by Automatic-Module-Name entry. However, NetBeans doesn't read 
> this entry and it gives problem. For example, there is a module which file 
> name is `foo-boo-1.0.jar` with Automatic-Module-Name as `super.foo`. In my 
> module I must use automatic module set in manifest otherwise JVM won't find 
> this module. That's why I do
> {code:java}
> module my.module {
> requires super.foo;//LINE X
> }
> {code}
> At line X NetBeans shows me an error as it can't find this module! However, 
> compiler compiles module without problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1397) NetBeans ignores Automatic-Module-Name when java modules are used

2018-10-11 Thread Jan Lahoda (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646986#comment-16646986
 ] 

Jan Lahoda commented on NETBEANS-1397:
--

Sorry, but still no luck in reproducing this. It seems the branch has already 
been merged, so I used branch "jetty-9.4.x".

 

FWIW, the class that determines the module name is:

[https://github.com/apache/incubator-netbeans/blob/accdbada0a9c5105bd3f06e435024230c1618316/java/java.source.base/src/org/netbeans/modules/java/source/ModuleNames.java]

 

And it definitely tries to look for the "Automatic-Module-Name" attribute. So 
if this does not work, there's probably something more tricky going on. I'll 
attach a screenshot of the module-info.java that I see.

> NetBeans ignores Automatic-Module-Name when java modules are used
> -
>
> Key: NETBEANS-1397
> URL: https://issues.apache.org/jira/browse/NETBEANS-1397
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Pavel_K
>Priority: Major
> Attachments: NETBEANS-1397.png, mavenproject22.zip
>
>
> According to JPMS specs the name of automatic module can be set via 
> MANIFEST.MF by Automatic-Module-Name entry. However, NetBeans doesn't read 
> this entry and it gives problem. For example, there is a module which file 
> name is `foo-boo-1.0.jar` with Automatic-Module-Name as `super.foo`. In my 
> module I must use automatic module set in manifest otherwise JVM won't find 
> this module. That's why I do
> {code:java}
> module my.module {
> requires super.foo;//LINE X
> }
> {code}
> At line X NetBeans shows me an error as it can't find this module! However, 
> compiler compiles module without problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1397) NetBeans ignores Automatic-Module-Name when java modules are used

2018-10-10 Thread Pavel_K (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645525#comment-16645525
 ] 

Pavel_K commented on NETBEANS-1397:
---

[~jlahoda] Thank you for your answer. I didn't try with `super` either as I 
wanted to explain the principle. So, this is full example:

I use jetty, that uses automatic-module-name, so it is necessary to do the 
following:
$ git clone https://github.com/eclipse/jetty.project.git
$ cd jetty.project
$ git checkout jetty-9.4.x-2191-jpms_automatic_module_name
$ mvn clean install -DskipTests

Now open in NetBeans 9.0 the project I attached and you will see the errors. 
Try to compile the project. Try to make code completion. 

> NetBeans ignores Automatic-Module-Name when java modules are used
> -
>
> Key: NETBEANS-1397
> URL: https://issues.apache.org/jira/browse/NETBEANS-1397
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Pavel_K
>Priority: Major
> Attachments: mavenproject22.zip
>
>
> According to JPMS specs the name of automatic module can be set via 
> MANIFEST.MF by Automatic-Module-Name entry. However, NetBeans doesn't read 
> this entry and it gives problem. For example, there is a module which file 
> name is `foo-boo-1.0.jar` with Automatic-Module-Name as `super.foo`. In my 
> module I must use automatic module set in manifest otherwise JVM won't find 
> this module. That's why I do
> {code:java}
> module my.module {
> requires super.foo;//LINE X
> }
> {code}
> At line X NetBeans shows me an error as it can't find this module! However, 
> compiler compiles module without problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1397) NetBeans ignores Automatic-Module-Name when java modules are used

2018-10-10 Thread Jan Lahoda (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645483#comment-16645483
 ] 

Jan Lahoda commented on NETBEANS-1397:
--

I tried, but cannot reproduce, sorry. Could you please provide an exact example 
that fails inside NetBeans and is compilable using javac?

When I try with a module with:

Automatic-Module-Name: super.foo

Then I cannot add "requires super.foo;", as "super" is a keyword. (And there's 
an error both in NetBeans and when compiling using javac.)

 

When I try with:

Automatic-Module-Name: foo

 

It works both in NetBeans and with javac for me.

 

What do I need to do to see the problem?

 

Thanks.

 

 

> NetBeans ignores Automatic-Module-Name when java modules are used
> -
>
> Key: NETBEANS-1397
> URL: https://issues.apache.org/jira/browse/NETBEANS-1397
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Pavel_K
>Priority: Major
>
> According to JPMS specs the name of automatic module can be set via 
> MANIFEST.MF by Automatic-Module-Name entry. However, NetBeans doesn't read 
> this entry and it gives problem. For example, there is a module which file 
> name is `foo-boo-1.0.jar` with Automatic-Module-Name as `super.foo`. In my 
> module I must use automatic module set in manifest otherwise JVM won't find 
> this module. That's why I do
> {code:java}
> module my.module {
> requires super.foo;//LINE X
> }
> {code}
> At line X NetBeans shows me an error as it can't find this module! However, 
> compiler compiles module without problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists