[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484195#comment-17484195 ] Christian Lenz commented on NETBEANS-189: - Uhhh, very nice. Awesome [~ebresie] I followed your work and I appreciate it very much. Thank you for your contribution. I will have a look into the feature soon :) > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Fix For: 13 > > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 9.5h > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476237#comment-17476237 ] Eric Bresie commented on NETBEANS-189: -- Testing includes: # Starting netbeans # Ensure No connections are yet established # Create a new SQL FIleFile...New...Other..Sql File (set given filename) # Edit SQL file. Type "SE" + "CTRL+Space" for auto completion of SELECT # Attempt CTRL+Space => No Suggestions [this is as no connection established yet] # Complete basic select statement (i.e. SELECT * from SomD;) # No connection selected yet. # On select line, attempt to run # Shows "No database connection is selected. Please select a connection in the Connection combo box in the editor toolbar." # Create a valid DB Connection in Database services pane to appliable DB. # Select new DB Connection from Connection combo box # Type new line with SELECT then attempt autocompletion. This will show available DB schema based on the given connection to auto complete with. # Once rest of select statement complete, attempt to run expression. Will show resulting query results. > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 8h 40m > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453643#comment-17453643 ] Eric Bresie commented on NETBEANS-189: -- There has been follow up work based on https://github.com/matthiasblaesing/netbeans/tree/pr-3074 which needs to be assess for inclusion. > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 8h 10m > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443138#comment-17443138 ] Eric Bresie commented on NETBEANS-189: -- PR 3074 currently marked for milestone 13 > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 7h 40m > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395244#comment-17395244 ] Eric Bresie commented on NETBEANS-189: -- Closed Pull Request #2820. Continue to include as reference for discussion. Will use #3074 going forward. > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386429#comment-17386429 ] Eric Bresie commented on NETBEANS-189: -- I have a new clean PR request (https://github.com/apache/netbeans/pull/3074) to avoid some of the confusion from https://github.com/apache/netbeans/pull/2820. > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 6h 40m > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373620#comment-17373620 ] Eric Bresie commented on NETBEANS-189: -- I have created "NETBEANS-5831 Create a SQL Standard Quoter for Use with Connectionless Cases" to accomidate items (6) and (7) listed above on SQL Standard Quoter and additional optional identifiers. > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Labels: pull-request-available > Attachments: SQL Notification.png, required-connection.gif > > Time Spent: 5h 10m > Remaining Estimate: 0h > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[
https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369706#comment-17369706
]
Eric Bresie commented on NETBEANS-189:
--
(1) Resolved issues adding logic to account for cases when connection is not
available and allow sql autocomplete to work even without an active connection
(2) This no longer shows the dialog asking for connection at the time which
prevented autocompletion previously, but still shows the dialogue when needed
like when attempting to "execute" a query where a connection is really needed
(similar to how other sql editor type applications may do things [i.e. wait
until such time as absolutely needed])
(3) From the PR I removed any unnecessary changes from the initial work (i.e.
the hint code initially present was remove and better suited as part of new
created ticket “NETBEANS-5474 Add SQL Hints”),
(4) I have squashed [to the best of my abilities] and reduced the changed files
to only applicable 3 files in the Sql Editor project,
(5) I have adjusted the quoter logic to no longer return an empty string and
have a minimum form of quoter/unquoter (as requested in PR review) which still
works in the unit tests for the SQL projects
(6) Potentially larger architectural change may be needed to allow for
Connection or Connectionless cases involving changes (rather than case by case
changes in a number of places), which may involve introducing a new "Standard
SQL Quoter" class for use when connection is not available instead of the
Metadata (from the connection based handling of identifiers) which I suggest
needs a separate ticket to create a Standard SQL Quoter class and retrofit the
code as part of that work.
The Standard SQl Quoter may involve standardized quoting of identifiers
similar to what is discussed here
https://www.w3resource.com/sql/sql-syntax.php#IDENTIF ). For this, would need
to better understand what the expected input/outputs are for this and what kind
of tests would be needed to confirm this does as expected beyond the existing
sql tests.
(7) There may be another SQL improvements ticket to raise to account for
additional possible missing autocomplete tokens like what is listed in the w3
reference above which mentions after "SELECT" there can be optionally
"DISTINCT | ALL" and either a wildcard ("*"). This is different from selection
list of possible connection based identifiers.
> SQL editor, shouldn't ask evertime to set the connection
>
>
> Key: NETBEANS-189
> URL: https://issues.apache.org/jira/browse/NETBEANS-189
> Project: NetBeans
> Issue Type: Improvement
> Components: db - SQL Editor
>Affects Versions: Next
>Reporter: Christian Lenz
>Assignee: Eric Bresie
>Priority: Major
> Labels: pull-request-available
> Attachments: SQL Notification.png, required-connection.gif
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Of course, the SQL editor doesn't make sense, if you don't set a connection
> to see databases, tables and columns, but sometimes or often, you only want
> to scratch a SQL query and you want the code completion for the SQL stuff,
> like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG,
> etc.) So this is not possible, without setting a connection. But when I don't
> have a connection, I can't use the code completion, becauses it will ends up
> in a loop. See my little screen capture for what I mean.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305530#comment-17305530 ] Eric Bresie commented on NETBEANS-189: -- I have checked in changes to allow auto-completion without connection error each time. See https://github.com/apache/netbeans/pull/2820 > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Assignee: Eric Bresie >Priority: Major > Attachments: SQL Notification.png, required-connection.gif > > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-189) SQL editor, shouldn't ask evertime to set the connection
[ https://issues.apache.org/jira/browse/NETBEANS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686489#comment-16686489 ] Christian Lenz commented on NETBEANS-189: - I attached an image, how IntelliJ handles this. So in general you have Code completion for normal/advanced keywords in SQL files, w/o the need of a connection. But there is a notification which shows you, that you should better configure a data source/connection to get advanced code assistance, which is quite good. So I can use IntelliJ for SQL files with Code completion and writing my SQL w/o using a connection, This is not possible with NetBeans. > SQL editor, shouldn't ask evertime to set the connection > > > Key: NETBEANS-189 > URL: https://issues.apache.org/jira/browse/NETBEANS-189 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Priority: Major > Attachments: SQL Notification.png, required-connection.gif > > > Of course, the SQL editor doesn't make sense, if you don't set a connection > to see databases, tables and columns, but sometimes or often, you only want > to scratch a SQL query and you want the code completion for the SQL stuff, > like the keywords (SELECT, FROM, WHERE) or aggregate functions (COUNT, AVG, > etc.) So this is not possible, without setting a connection. But when I don't > have a connection, I can't use the code completion, becauses it will ends up > in a loop. See my little screen capture for what I mean. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
