[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317343#comment-17317343 ] Ernie Rael commented on NETBEANS-3104: -- The openjfx PRs (from a year ago) mentioned in [earlier comment|https://issues.apache.org/jira/browse/NETBEANS-3104?focusedCommentId=17312777&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17312777] : > Add debug execution to the created archetypes > https://github.com/openjfx/javafx-maven-archetypes/pull/10 > comment out module syntax for JDK8 > https://github.com/openjfx/javafx-maven-archetypes/pull/11 have been merged into openjfx; unclear when it might find its way into maven central. So if this issues gets fixed, an nbactions.xml could be provided by NetBeans that uses executions from a stock openjfx archetype. Then the 4th party archetype could be dropped from NetBeans. But note that the openjfx pom.xml do not have profile or jlink execution; so some minor functionality would be lost. [Another earlier comment|https://issues.apache.org/jira/browse/NETBEANS-3104?focusedCommentId=17025192&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17025192] doesn't explicitly say so, but in addition to providing an nbactions.xml if NetBeans provides a mechanism to merge some optional execution into the pom.xml it would be useful when integrating/using 3rd party maven archetypes. > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 12.2 > > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313351#comment-17313351 ] Ernie Rael commented on NETBEANS-3104: -- _Remembering some history..._ Was planning to change the resolution to *Won't Fix*; but, while preparing the comment, that didn't feel like the right thing to do. All I can say is that _fixed_ is not accurate; perhaps some resolution other than "won't fix" is appropriate. This issue is about how 3rd party maven projects can be integrated with NetBeans. The idea with this issue is that to integrate a 3rd party maven based project type into NetBeans you probably need to provide nbactions. NetBeans `New Project` for javafx used to create a project from an example maven artifact from openjfx/gluon. There were a variety of problems with this artifact. One of the problems was that there had to be an nbactions.xml to run/debug the example. This issue is about providing an API so that NetBeans can provide an nbactions with an off the shelf 3rd party artifact. The solution at the time was for a 4th party to modify the 3rd party openjfx example, *and* to include an *nbactions.xml* in the artifact. Including an nbactions in the artifact is not a general 3rd party solution. There were also a variety of changes made by the 4th party, so things would play better in NetBeans, or _any_ IDE, environment; PRs are pending at openjfx. This 4th party solution is taylored to NetBeans, avoiding 3rd party artifact issues. Note that if these PRs are eventually accepted by openjfx, there will still be a need to provide an nbactions. There's https://github.com/apache/netbeans/pull/2036 provides a mechanism for the jfx new project wizards to provide properties to the prototype for the maven project creation; loosely related to this issue. See the previous comment, https://issues.apache.org/jira/browse/NETBEANS-3104?focusedCommentId=17312777&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17312777 for specifics. > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 12.2 > > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312777#comment-17312777 ] Ernie Rael commented on NETBEANS-3104: -- To get this documented somewhere. There are two outstanding PRs at https://github.com/openjfx/javafx-maven-archetypes/pulls Add debug execution to the created archetypes https://github.com/openjfx/javafx-maven-archetypes/pull/10 comment out module syntax for JDK8 https://github.com/openjfx/javafx-maven-archetypes/pull/11 Until these are merged, NB still uses https://github.com/errael/javafx-maven-archetypes-netbeans See the following for more info Default JavaFX archetypes to javafx 1.8 when running on jdk1.8 https://github.com/apache/netbeans/pull/2036 Ignore module-info.java if on jdk1.8 or earlier. https://github.com/apache/netbeans/pull/2037 Update JavaFX archetypes for recent JavaFX/maven PRs https://github.com/apache/netbeans/pull/2057 > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 12.2 > > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025733#comment-17025733 ] Geertjan Wielenga commented on NETBEANS-3104: - https://github.com/openjfx/javafx-maven-archetypes/pull/8 > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025271#comment-17025271 ] Ernie Rael commented on NETBEANS-3104: -- Do you mean a PR against openjfx? I'm just starting to look at openjfx source and have no idea where to find this. > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025217#comment-17025217 ] Geertjan Wielenga commented on NETBEANS-3104: - Then do a PR on the Gluon POMs. > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025215#comment-17025215 ] Ernie Rael commented on NETBEANS-3104: -- You are referring to javafx-archetype-*. I am referring to javafx-maven-plugin. Gluon fixed a bug I ran into (errors from jvm startup). They didn't update the archetype's at the same time. > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[
https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025194#comment-17025194
]
Geertjan Wielenga commented on NETBEANS-3104:
-
Take a look here againL
https://github.com/apache/netbeans/blob/master/java/maven/src/org/netbeans/modules/maven/newproject/MavenWizardIterator.java
Especially here:
return ArchetypeWizards.definedArchetype("org.openjfx",
"javafx-archetype-fxml", "0.0.3", null, LBL_Maven_FXML_Archetype());
You could provide a pull request, right now, to change 0.0.3 to 0.0.4.
> Extend ArchetypeWizards.definedArchetype to include optional nbactions
> --
>
> Key: NETBEANS-3104
> URL: https://issues.apache.org/jira/browse/NETBEANS-3104
> Project: NetBeans
> Issue Type: Improvement
>Reporter: Geertjan Wielenga
>Assignee: Jaroslav Tulach
>Priority: Major
>
> http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025192#comment-17025192 ] Ernie Rael commented on NETBEANS-3104: -- I've recently, over a few days, taken a long look at MavenWizardIterator and it's package, wondering what it would take to get NetBeans' "Simple JavaFX Maven Archetype" to work out of the box. I was looking since I had to manually * update javafx-maven-plugin to version 0.0.4 * change javafx-maven-plugin's configuration, adding ... so that I could both run *and debug* the simple app. See NETBEANS-3730 attachement. * put two actions into nbactions.xml. Only partly covered by this issue since the pom must be changed in concert. So, what I mean by "more" is that 3rd party archetypes might/probably need dynamic adjustment to work cleanly, from the user's point of view, with NetBeans; this issue is not enough. Some options: # provide fixup/cleanup hooks during project creation # provide our own version of the maven artifact, also takes care of nbactions # provide doc on how to fix up a project after creation > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025020#comment-17025020 ] Geertjan Wielenga commented on NETBEANS-3104: - What is the more you mean? The focus of this issue is to update the API so that 'nbactions.xml' can be included as part of the TemplateRegistrations here: https://github.com/apache/netbeans/blob/master/java/maven/src/org/netbeans/modules/maven/newproject/MavenWizardIterator.java > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3104) Extend ArchetypeWizards.definedArchetype to include optional nbactions
[ https://issues.apache.org/jira/browse/NETBEANS-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024599#comment-17024599 ] Ernie Rael commented on NETBEANS-3104: -- Is this issue about getting 3rd party maven artifacts to work out of the box on NetBeans? Example is simpe javafx project. While nbactions.xml is a part of that, there is certainly more. Is there another issue about this? > Extend ArchetypeWizards.definedArchetype to include optional nbactions > -- > > Key: NETBEANS-3104 > URL: https://issues.apache.org/jira/browse/NETBEANS-3104 > Project: NetBeans > Issue Type: Improvement >Reporter: Geertjan Wielenga >Assignee: Jaroslav Tulach >Priority: Major > > http://bits.netbeans.org/dev/javadoc/org-netbeans-api-maven/org/netbeans/api/maven/archetype/ArchetypeWizards.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
