[netbeans] branch master updated: Remove JDK8 as minimum for build of VSNetBeans. (#5587)
This is an automated email from the ASF dual-hosted git repository. mbalin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new c8c7f11d16 Remove JDK8 as minimum for build of VSNetBeans. (#5587) c8c7f11d16 is described below commit c8c7f11d16f915035d7dc301992c6172272b354b Author: Martin BalĂn AuthorDate: Sun Mar 12 18:06:09 2023 +0100 Remove JDK8 as minimum for build of VSNetBeans. (#5587) * Remove JDK8 as minimum for build of VSNetBeans. * Remove mention of JDK8 as lowest --- java/java.lsp.server/vscode/BUILD.md | 5 + java/java.lsp.server/vscode/README.md | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/java/java.lsp.server/vscode/BUILD.md b/java/java.lsp.server/vscode/BUILD.md index fa12538b0c..dcdca1d898 100644 --- a/java/java.lsp.server/vscode/BUILD.md +++ b/java/java.lsp.server/vscode/BUILD.md @@ -23,14 +23,11 @@ ## Prerequisities -- JDK, version 11 +- JDK, version 11 or later - Ant, latest version - Maven, latest version - node.js, latest LTS (to build VSIX) -It is currently possible to use JDK 8 for the build and execution. -However, as the Apache NetBeans project is slowly moving towards JDK 11, -using JDK 11 may be the safest bet. ## Getting the Code diff --git a/java/java.lsp.server/vscode/README.md b/java/java.lsp.server/vscode/README.md index 718caa6d3e..8926dcaae5 100644 --- a/java/java.lsp.server/vscode/README.md +++ b/java/java.lsp.server/vscode/README.md @@ -23,7 +23,7 @@ This is a technology preview of [Apache NetBeans](http://netbeans.org) based extension for VS Code. Use it to get all the _goodies of NetBeans_ -via the VS Code user interface! Runs on __JDK8__[*] and all newer versions. +via the VS Code user interface! Runs on __JDK11__ and all newer versions. Apache NetBeans Language Server brings full featured Java development (edit-compile-debug & test cycle) for Maven and Gradle projects to VSCode. As well as other features. ## Getting Started - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Added CompletionItem.shouldSingleClickInvokeDefaultAction to the Editor Completion API.
This is an automated email from the ASF dual-hosted git repository. ebakke pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 27c9f3ba08 Added CompletionItem.shouldSingleClickInvokeDefaultAction to the Editor Completion API. 27c9f3ba08 is described below commit 27c9f3ba08cdff765b95639f7db815b34468247e Author: Eirik Bakke AuthorDate: Sat Oct 1 10:21:15 2022 -0400 Added CompletionItem.shouldSingleClickInvokeDefaultAction to the Editor Completion API. --- ide/editor.completion/apichanges.xml | 18 .../editor/completion/CompletionLayout.java| 108 ++--- .../spi/editor/completion/CompletionItem.java | 8 ++ 3 files changed, 97 insertions(+), 37 deletions(-) diff --git a/ide/editor.completion/apichanges.xml b/ide/editor.completion/apichanges.xml index 92daa525f7..4fe52d6c7b 100644 --- a/ide/editor.completion/apichanges.xml +++ b/ide/editor.completion/apichanges.xml @@ -84,6 +84,24 @@ is the proper place. + + +Addition of optional CompletionItem.shouldSingleClickInvokeDefaultAction() method + + + + + + + CompletionItem.shouldSingleClickInvokeDefaultAction method was added +to to indicate that a single mouse click on the CompletionItem in the +completion list, rather than only a double-click, will invoke its default action. +A default method is provided in the method which returns false, preserving the old +behavior by default. + + + + Addition of CompletionUtilities.newCompletionItemBuilder() method diff --git a/ide/editor.completion/src/org/netbeans/modules/editor/completion/CompletionLayout.java b/ide/editor.completion/src/org/netbeans/modules/editor/completion/CompletionLayout.java index 43303cae6b..1486334cb7 100644 --- a/ide/editor.completion/src/org/netbeans/modules/editor/completion/CompletionLayout.java +++ b/ide/editor.completion/src/org/netbeans/modules/editor/completion/CompletionLayout.java @@ -367,48 +367,82 @@ public final class CompletionLayout { completionScrollPane = new CompletionScrollPane( editorComponent, listSelectionListener, new MouseAdapter() { +CompletionItem selectedItemOnPress; + +@Override +public void mousePressed(MouseEvent evt) { +if (!SwingUtilities.isLeftMouseButton(evt)) { +return; +} +selectedItemOnPress = completionScrollPane.getSelectedCompletionItem(); +} + +@Override +public void mouseReleased(MouseEvent evt) { +/* Handle single-click via mouseReleased, rather than in mouseClick with +getClickCount() == 1, since the latter kind of event will not be fired if +the mouse pointer ends up being dragged a tiny bit while the button is +clicked (common on touchpads). */ +if (!SwingUtilities.isLeftMouseButton(evt)) { +return; +} +CompletionItem selectedItem = completionScrollPane.getSelectedCompletionItem(); +boolean shouldInvokeDefaultAction = +selectedItem != null && selectedItem == selectedItemOnPress && + selectedItem.shouldSingleClickInvokeDefaultAction(); +selectedItemOnPress = null; +if (shouldInvokeDefaultAction) { +invokeDefaultAction(selectedItem); +} +} + @Override public void mouseClicked(MouseEvent evt) { - JTextComponent c = getEditorComponent(); -if (SwingUtilities.isLeftMouseButton(evt)) { -if (completionScrollPane.getView().getSize().width - CompletionJList.arrowSpan() <= evt.getPoint().x) { -CompletionItem selectedItem = completionScrollPane.getSelectedCompletionItem(); -if (selectedItem instanceof CompositeCompletionItem && !((CompositeCompletionItem)selectedItem).getSubItems().isEmpty()) { - CompletionImpl.get().showCompletionSubItems(); -
[netbeans] branch master updated (c8c7f11d16 -> 4b7776a679)
This is an automated email from the ASF dual-hosted git repository. ebakke pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git from c8c7f11d16 Remove JDK8 as minimum for build of VSNetBeans. (#5587) add 4b7776a679 Four small UI improvements (3 cosmetic + one focus handling adjustment), in various areas. No new revisions were added by this update. Summary of changes: ide/db/src/org/netbeans/modules/db/util/PropertyEditorPanel.form | 1 + ide/db/src/org/netbeans/modules/db/util/PropertyEditorPanel.java | 7 +-- .../src/org/netbeans/modules/navigator/NavigatorTC.java| 7 +-- .../src/org/openide/explorer/propertysheet/MarginViewportUI.java | 3 ++- .../openide.util.ui/src/org/openide/util/actions/SystemAction.java | 2 +- 5 files changed, 14 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists