[jira] [Commented] (MINIFI-419) delete-service.bat fails to delete minifi service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290335#comment-16290335
 ] 

ASF GitHub Bot commented on MINIFI-419:
---

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi/pull/104


> delete-service.bat fails to delete minifi service
> -
>
> Key: MINIFI-419
> URL: https://issues.apache.org/jira/browse/MINIFI-419
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: Agent Configuration/Installation
>Affects Versions: 0.3.0
> Environment: Windows Server 2016 Datacenter, AMD64
>Reporter: Koji Kawamura
> Fix For: 0.3.0
>
>
> After minifi service was installed using install-service.bat, I tried 
> deleting the service by delete-service.bat. The batch command failed with 
> following error:
> {code}
> C:\dev\minifi-0.3.0-vote\minifi-0.3.0\minifi-assembly\target\minifi-0.3.0-bin\minifi-0.3.0\bin>delete-service.bat
> [2017-12-13 13:17:54] [error] [ 5356] Unrecognized cmd option .exe
> [2017-12-13 13:17:54] [error] [ 5356] Invalid command line arguments
> [2017-12-13 13:17:54] [error] [ 5356] Commons Daemon procrun failed with exit 
> value: 1 (Failed to parse command line arguments)
> {code}
> Removing the double quart around the SERVICE_NAME variable made 
> delete-service.bat to work.
> https://github.com/apache/nifi-minifi/blob/master/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/bin/delete-service.bat#L19



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFI-419) delete-service.bat fails to delete minifi service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289269#comment-16289269
 ] 

ASF GitHub Bot commented on MINIFI-419:
---

GitHub user ijokarumawak opened a pull request:

https://github.com/apache/nifi-minifi/pull/104

MINIFI-419: delete-service.bat fails to delete minifi service

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under minifi-assembly?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijokarumawak/nifi-minifi minifi-419

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit 28a4136cd01d9b7fa69ea05d723835d848122663
Author: Koji Kawamura 
Date:   2017-12-13T13:35:10Z

MINIFI-419: delete-service.bat fails to delete minifi service




> delete-service.bat fails to delete minifi service
> -
>
> Key: MINIFI-419
> URL: https://issues.apache.org/jira/browse/MINIFI-419
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: Agent Configuration/Installation
>Affects Versions: 0.3.0
> Environment: Windows Server 2016 Datacenter, AMD64
>Reporter: Koji Kawamura
>
> After minifi service was installed using install-service.bat, I tried 
> deleting the service by delete-service.bat. The batch command failed with 
> following error:
> {code}
> C:\dev\minifi-0.3.0-vote\minifi-0.3.0\minifi-assembly\target\minifi-0.3.0-bin\minifi-0.3.0\bin>delete-service.bat
> [2017-12-13 13:17:54] [error] [ 5356] Unrecognized cmd option .exe
> [2017-12-13 13:17:54] [error] [ 5356] Invalid command line arguments
> [2017-12-13 13:17:54] [error] [ 5356] Commons Daemon procrun failed with exit 
> value: 1 (Failed to parse command line arguments)
> {code}
> Removing the double quart around the SERVICE_NAME variable made 
> delete-service.bat to work.
> https://github.com/apache/nifi-minifi/blob/master/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/bin/delete-service.bat#L19



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)